Re: [U-Boot] [PATCH v1 1/7] Makefile: Don't shadow actual error when compile ASL
On Sun, Jul 23, 2017 at 12:47 AM, Bin Meng wrote:
> Hi Andy,
>
> On Sun, Jul 23, 2017 at 12:38 AM, Andy Shevchenko
> wrote:
>> On Sat, Jul 22, 2017 at 3:59 PM, Bin Meng wrote:
>>> Hi Andy,
>>>
>>> On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko
>>> wrote:
If ASL compiler failed by any reason do not produce output C file.
Otherwise sequential run of make will shadow the actual error in ASL,
i.e.
CC board/intel/edison/dsdt.o
board/intel/edison/dsdt.c:1:1: error: unterminated comment
/*
and user has to remove dsdt.c and run make in order to see the error again.
Signed-off-by: Andy Shevchenko
---
scripts/Makefile.lib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> Reviewed-by: Bin Meng
>>>
>>
>> Thanks!
>>
>>> Although I am not sure how to reproduce "ASL compiler failed by any
>>> reason do not produce output C file"..
>>
>> Add
>>
>> Name (XXX) ({
>
> Ah, I tried some pattern with no success but yours indeed triggers the issue.
>
>>
>> line to dsdt.asl for Minnowboard MAX and you will see
>>
>> ASL board/intel/minnowmax/dsdt.asl
>> Compiler aborting due to parser-detected syntax error(s)
>> board/intel/minnowmax/dsdt.asl.tmp739: Name(XXX) ({
>> Error6126 -^ syntax error,
>> unexpected PARSEOP_CLOSE_PAREN, expecting ','
>>
>> Next run will get you above error (see commit message) which has been
>> quite confusing.
>>
>> P.S. Of course it's artificial, but better to handle iasl (potential)
>> failures.
>>
>
> Thanks for the clarification!
> Tested-by: Bin Meng
applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/7] Makefile: Don't shadow actual error when compile ASL
Hi Andy,
On Sun, Jul 23, 2017 at 12:38 AM, Andy Shevchenko
wrote:
> On Sat, Jul 22, 2017 at 3:59 PM, Bin Meng wrote:
>> Hi Andy,
>>
>> On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko
>> wrote:
>>> If ASL compiler failed by any reason do not produce output C file.
>>> Otherwise sequential run of make will shadow the actual error in ASL,
>>> i.e.
>>>
>>> CC board/intel/edison/dsdt.o
>>> board/intel/edison/dsdt.c:1:1: error: unterminated comment
>>> /*
>>>
>>> and user has to remove dsdt.c and run make in order to see the error again.
>>>
>>> Signed-off-by: Andy Shevchenko
>>> ---
>>> scripts/Makefile.lib | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> Reviewed-by: Bin Meng
>>
>
> Thanks!
>
>> Although I am not sure how to reproduce "ASL compiler failed by any
>> reason do not produce output C file"..
>
> Add
>
> Name (XXX) ({
Ah, I tried some pattern with no success but yours indeed triggers the issue.
>
> line to dsdt.asl for Minnowboard MAX and you will see
>
> ASL board/intel/minnowmax/dsdt.asl
> Compiler aborting due to parser-detected syntax error(s)
> board/intel/minnowmax/dsdt.asl.tmp739: Name(XXX) ({
> Error6126 -^ syntax error,
> unexpected PARSEOP_CLOSE_PAREN, expecting ','
>
> Next run will get you above error (see commit message) which has been
> quite confusing.
>
> P.S. Of course it's artificial, but better to handle iasl (potential)
> failures.
>
Thanks for the clarification!
Tested-by: Bin Meng
Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/7] Makefile: Don't shadow actual error when compile ASL
On Sat, Jul 22, 2017 at 3:59 PM, Bin Meng wrote:
> Hi Andy,
>
> On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko
> wrote:
>> If ASL compiler failed by any reason do not produce output C file.
>> Otherwise sequential run of make will shadow the actual error in ASL,
>> i.e.
>>
>> CC board/intel/edison/dsdt.o
>> board/intel/edison/dsdt.c:1:1: error: unterminated comment
>> /*
>>
>> and user has to remove dsdt.c and run make in order to see the error again.
>>
>> Signed-off-by: Andy Shevchenko
>> ---
>> scripts/Makefile.lib | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng
>
Thanks!
> Although I am not sure how to reproduce "ASL compiler failed by any
> reason do not produce output C file"..
Add
Name (XXX) ({
line to dsdt.asl for Minnowboard MAX and you will see
ASL board/intel/minnowmax/dsdt.asl
Compiler aborting due to parser-detected syntax error(s)
board/intel/minnowmax/dsdt.asl.tmp739: Name(XXX) ({
Error6126 -^ syntax error,
unexpected PARSEOP_CLOSE_PAREN, expecting ','
Next run will get you above error (see commit message) which has been
quite confusing.
P.S. Of course it's artificial, but better to handle iasl (potential) failures.
--
With Best Regards,
Andy Shevchenko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/7] Makefile: Don't shadow actual error when compile ASL
Hi Andy, On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko wrote: > If ASL compiler failed by any reason do not produce output C file. > Otherwise sequential run of make will shadow the actual error in ASL, > i.e. > > CC board/intel/edison/dsdt.o > board/intel/edison/dsdt.c:1:1: error: unterminated comment > /* > > and user has to remove dsdt.c and run make in order to see the error again. > > Signed-off-by: Andy Shevchenko > --- > scripts/Makefile.lib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng Although I am not sure how to reproduce "ASL compiler failed by any reason do not produce output C file".. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
