Re: [U-Boot] [PATCH v11 6/6] arm: faraday: add virtual machine support

2014-03-26 Thread Wolfgang Denk
Dear Kuo-Jung Su,

In message 1395813799-3672-7-git-send-email-dant...@gmail.com you wrote:
 From: Kuo-Jung Su dant...@faraday-tech.com
 
 Faraday Virtual Machine (FVM) is a QEMU based emulator
 which is designed for early stage software development
 (i.e., IPL, SPL development).
...
 +ulong clk_get_rate(const char *id)
 +{
 + ulong ret = 0;
 +
 + if (!strcmp(id, AHB))
 + ret = clk_get_rate_ahb();
 + else if (!strcmp(id, APB))
 + ret = clk_get_rate_apb();
 + else if (!strcmp(id, CPU))
 + ret = clk_get_rate_cpu();
 + else if (!strcmp(id, I2C))
 + ret = clk_get_rate_apb();
 + else if (!strcmp(id, SSP))
 + ret = clk_get_rate_apb();
 + else if (!strcmp(id, SPI))
 + ret = clk_get_rate_ahb();
 + else if (!strcmp(id, MMC) || !strcmp(id, SDC))
 + ret = clk_get_rate_ahb();
 +
 + return ret;
 +}

I have seen basically identical code in  [PATCH v11 4/6] arm: faraday:
add A369 evaluation board; please move this (and other common code)
into a common location so we have only one implementation of common
code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You don't stop doing things because you get old.  You get old because
you stop doing things.- Rosamunde Pilcher
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v11 6/6] arm: faraday: add virtual machine support

2014-03-26 Thread Kuo-Jung Su
2014-03-26 14:52 GMT+08:00 Wolfgang Denk w...@denx.de:
 Dear Kuo-Jung Su,

 In message 1395813799-3672-7-git-send-email-dant...@gmail.com you wrote:
 From: Kuo-Jung Su dant...@faraday-tech.com

 Faraday Virtual Machine (FVM) is a QEMU based emulator
 which is designed for early stage software development
 (i.e., IPL, SPL development).
 ...
 +ulong clk_get_rate(const char *id)
 +{
 + ulong ret = 0;
 +
 + if (!strcmp(id, AHB))
 + ret = clk_get_rate_ahb();
 + else if (!strcmp(id, APB))
 + ret = clk_get_rate_apb();
 + else if (!strcmp(id, CPU))
 + ret = clk_get_rate_cpu();
 + else if (!strcmp(id, I2C))
 + ret = clk_get_rate_apb();
 + else if (!strcmp(id, SSP))
 + ret = clk_get_rate_apb();
 + else if (!strcmp(id, SPI))
 + ret = clk_get_rate_ahb();
 + else if (!strcmp(id, MMC) || !strcmp(id, SDC))
 + ret = clk_get_rate_ahb();
 +
 + return ret;
 +}

 I have seen basically identical code in  [PATCH v11 4/6] arm: faraday:
 add A369 evaluation board; please move this (and other common code)
 into a common location so we have only one implementation of common
 code.


Got it, thanks


-- 
Best wishes,
Kuo-Jung Su
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot