Re: [U-Boot] [PATCH v2] build: imx: Fix 'u-boot.imx' build without full OBJTREE reference
Hi Stefano, On Tuesday, February 12, 2013 6:53:39 PM, Stefano Babic wrote: > On 12/02/2013 18:55, Benoît Thébaudeau wrote: > > Hi Otavio, > > > > Hi Benoît, > > > >> Alright; It did the test Marek has requested and it works fine. I > >> think this should go to imx/master as it fixes a regression. > > > > OK. I include it into my series so that patches apply fine whether Stefano > > applies it alone first or from my series. > > I merged it - you do not need to bother about it. Great, thanks. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] build: imx: Fix 'u-boot.imx' build without full OBJTREE reference
On 12/02/2013 18:55, Benoît Thébaudeau wrote: > Hi Otavio, > Hi Benoît, >> Alright; It did the test Marek has requested and it works fine. I >> think this should go to imx/master as it fixes a regression. > > OK. I include it into my series so that patches apply fine whether Stefano > applies it alone first or from my series. I merged it - you do not need to bother about it. Best regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] build: imx: Fix 'u-boot.imx' build without full OBJTREE reference
Hi Otavio, On Tuesday, February 12, 2013 6:09:43 PM, Otavio Salvador wrote: > On Tue, Feb 12, 2013 at 12:01 PM, Benoît Thébaudeau > wrote: > > Dear Otavio, Marek, > > > > On Monday, February 11, 2013 5:55:17 PM, Marek Vasut wrote: > >> Dear Otavio Salvador, > >> > >> > When calling 'make u-boot.imx' the build were failing as it were > >> > expecting the full path for the file; this regression has been > >> > included by commit 71a988a (imximage.cfg: run files through C > >> > preprocessor). > >> > > >> > The direct references for u-boot.imx were replaced by $(obj) as > >> > config.mk handles the proper setting of it making it set to $(OBJTREE) > >> > when required. > >> > > >> > The build has been test using: > >> > > >> > - ./MAKEALL -s mx5 -s mx6 > >> > - make u-boot.imx > >> > - make O=/tmp/build > >> > >> BUILD_DIR=/tmp/xyz MAKEALL please. > > > > Once you're confident with this patch, do you mind if I integrate it as is > > in my > > MXC NAND + SPL series in order to avoid merge conflicts (unless it is > > applied > > before)? > > Alright; It did the test Marek has requested and it works fine. I > think this should go to imx/master as it fixes a regression. OK. I include it into my series so that patches apply fine whether Stefano applies it alone first or from my series. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] build: imx: Fix 'u-boot.imx' build without full OBJTREE reference
On Tue, Feb 12, 2013 at 12:01 PM, Benoît Thébaudeau wrote: > Dear Otavio, Marek, > > On Monday, February 11, 2013 5:55:17 PM, Marek Vasut wrote: >> Dear Otavio Salvador, >> >> > When calling 'make u-boot.imx' the build were failing as it were >> > expecting the full path for the file; this regression has been >> > included by commit 71a988a (imximage.cfg: run files through C >> > preprocessor). >> > >> > The direct references for u-boot.imx were replaced by $(obj) as >> > config.mk handles the proper setting of it making it set to $(OBJTREE) >> > when required. >> > >> > The build has been test using: >> > >> > - ./MAKEALL -s mx5 -s mx6 >> > - make u-boot.imx >> > - make O=/tmp/build >> >> BUILD_DIR=/tmp/xyz MAKEALL please. > > Once you're confident with this patch, do you mind if I integrate it as is in > my > MXC NAND + SPL series in order to avoid merge conflicts (unless it is applied > before)? Alright; It did the test Marek has requested and it works fine. I think this should go to imx/master as it fixes a regression. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] build: imx: Fix 'u-boot.imx' build without full OBJTREE reference
Dear Otavio, Marek, On Monday, February 11, 2013 5:55:17 PM, Marek Vasut wrote: > Dear Otavio Salvador, > > > When calling 'make u-boot.imx' the build were failing as it were > > expecting the full path for the file; this regression has been > > included by commit 71a988a (imximage.cfg: run files through C > > preprocessor). > > > > The direct references for u-boot.imx were replaced by $(obj) as > > config.mk handles the proper setting of it making it set to $(OBJTREE) > > when required. > > > > The build has been test using: > > > > - ./MAKEALL -s mx5 -s mx6 > > - make u-boot.imx > > - make O=/tmp/build > > BUILD_DIR=/tmp/xyz MAKEALL please. Once you're confident with this patch, do you mind if I integrate it as is in my MXC NAND + SPL series in order to avoid merge conflicts (unless it is applied before)? Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] build: imx: Fix 'u-boot.imx' build without full OBJTREE reference
Dear Otavio Salvador, > When calling 'make u-boot.imx' the build were failing as it were > expecting the full path for the file; this regression has been > included by commit 71a988a (imximage.cfg: run files through C > preprocessor). > > The direct references for u-boot.imx were replaced by $(obj) as > config.mk handles the proper setting of it making it set to $(OBJTREE) > when required. > > The build has been test using: > > - ./MAKEALL -s mx5 -s mx6 > - make u-boot.imx > - make O=/tmp/build BUILD_DIR=/tmp/xyz MAKEALL please. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
