Re: [U-Boot] [PATCH v2] tiny-printf: Correct the snprintf() implementation
On Wed, Jun 08, 2016 at 08:55:15PM -0600, Simon Glass wrote: > This current code passes the variable arguments list to sprintf(). This is > not correct. Fix it by calling _vprintf() directly. > > This makes firefly-rk3288 boot again. > > Fixes: abeb272 ("tiny-printf: Support snprintf()") > Reviewed-by: Stefan Roese> Acked-by: Marek Vasut > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] tiny-printf: Correct the snprintf() implementation
On 06/09/2016 07:14 AM, Stefan Roese wrote: > On 09.06.2016 04:55, Simon Glass wrote: >> This current code passes the variable arguments list to sprintf(). >> This is >> not correct. Fix it by calling _vprintf() directly. >> >> This makes firefly-rk3288 boot again. >> >> Fixes: abeb272 ("tiny-printf: Support snprintf()") >> Signed-off-by: Simon Glass> > Reviewed-by: Stefan Roese Acked-by: Marek Vasut -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] tiny-printf: Correct the snprintf() implementation
On 09.06.2016 04:55, Simon Glass wrote: This current code passes the variable arguments list to sprintf(). This is not correct. Fix it by calling _vprintf() directly. This makes firefly-rk3288 boot again. Fixes: abeb272 ("tiny-printf: Support snprintf()") Signed-off-by: Simon GlassReviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot