Re: [U-Boot] [PATCH v2] x86: Use microcode update from device tree for all processors
Hi Ivan, On Tue, Jun 19, 2018 at 9:19 AM, Bin Meng wrote: > On Mon, Jun 18, 2018 at 8:58 PM, Bin Meng wrote: >> On Sat, Jun 16, 2018 at 2:01 AM, Ivan Gorinov wrote: >>> Built without a ROM image with FSP (u-boot.rom), the U-Boot loader applies >>> the microcode update data block encoded in Device Tree to the bootstrap >>> processor but not passed to the other CPUs when multiprocessing is enabled. >>> >>> If the bootstrap processor successfully performs a microcode update >>> from Device Tree, use the same data block for the other processors. >>> >>> Signed-off-by: Ivan Gorinov >>> --- >>> arch/x86/cpu/i386/cpu.c | 3 ++- >>> arch/x86/cpu/intel_common/car.S | 2 ++ >>> arch/x86/cpu/intel_common/microcode.c | 10 +++--- >>> arch/x86/include/asm/microcode.h | 1 + >>> arch/x86/lib/fsp/fsp_car.S| 4 +++- >>> 5 files changed, 15 insertions(+), 5 deletions(-) >>> >> >> Reviewed-by: Bin Meng > > applied to u-boot-x86, thanks! This unfortunately breaks edison and qemu-x86. Can you please have a look? x86: + edison qemu-x86 +arch/x86/cpu/built-in.o: In function `x86_mp_init': +build/../arch/x86/cpu/i386/cpu.c:589: undefined reference to `ucode_base' Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] x86: Use microcode update from device tree for all processors
On Mon, Jun 18, 2018 at 8:58 PM, Bin Meng wrote: > On Sat, Jun 16, 2018 at 2:01 AM, Ivan Gorinov wrote: >> Built without a ROM image with FSP (u-boot.rom), the U-Boot loader applies >> the microcode update data block encoded in Device Tree to the bootstrap >> processor but not passed to the other CPUs when multiprocessing is enabled. >> >> If the bootstrap processor successfully performs a microcode update >> from Device Tree, use the same data block for the other processors. >> >> Signed-off-by: Ivan Gorinov >> --- >> arch/x86/cpu/i386/cpu.c | 3 ++- >> arch/x86/cpu/intel_common/car.S | 2 ++ >> arch/x86/cpu/intel_common/microcode.c | 10 +++--- >> arch/x86/include/asm/microcode.h | 1 + >> arch/x86/lib/fsp/fsp_car.S| 4 +++- >> 5 files changed, 15 insertions(+), 5 deletions(-) >> > > Reviewed-by: Bin Meng applied to u-boot-x86, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] x86: Use microcode update from device tree for all processors
On Sat, Jun 16, 2018 at 2:01 AM, Ivan Gorinov wrote: > Built without a ROM image with FSP (u-boot.rom), the U-Boot loader applies > the microcode update data block encoded in Device Tree to the bootstrap > processor but not passed to the other CPUs when multiprocessing is enabled. > > If the bootstrap processor successfully performs a microcode update > from Device Tree, use the same data block for the other processors. > > Signed-off-by: Ivan Gorinov > --- > arch/x86/cpu/i386/cpu.c | 3 ++- > arch/x86/cpu/intel_common/car.S | 2 ++ > arch/x86/cpu/intel_common/microcode.c | 10 +++--- > arch/x86/include/asm/microcode.h | 1 + > arch/x86/lib/fsp/fsp_car.S| 4 +++- > 5 files changed, 15 insertions(+), 5 deletions(-) > Reviewed-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
