Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
On 01/27/2013 04:48 PM, Marek Vasut wrote: Dear Stephen Warren, On 01/25/2013 07:26 PM, Marek Vasut wrote: Dear Lucas Stach, This moves out the Tegra EHCI driver from a platform specific directory to the standard driver/usb/host dir. This is a preparation needed to share this driver between Tegra20 and Tegra30. No functional change in here, so Tegra30 is still not working. Patch 6 could be a lot smaller if it were generated with -B, as GIT would detect that most of it is moving stuff over, but last time I did this it prevented git apply to work. So sorry for the big diff. I think I incorporated all changes needed to reflect the review feedback I got on this last time. I expect this series to go in through the Tegra tree. Last two don't apply, I applied first five and pushed. Marek, what about any conflicts this will cause with other patches in the Tegra tree? Especially since Lucas *explicitly* stated that he expected the series to go through the Tegra tree, I expect that some co-ordination is required here Ok, I can drop them from -USB, will you pick them ? I must have missed that part. That's a question for Tom. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
Marek, -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Sunday, January 27, 2013 4:49 PM To: Stephen Warren Cc: Lucas Stach; u-boot@lists.denx.de; Tom Warren; Simon Glass Subject: Re: [PATCH v2 0/7] Move Tegra EHCI drive to correct place Dear Stephen Warren, On 01/25/2013 07:26 PM, Marek Vasut wrote: Dear Lucas Stach, This moves out the Tegra EHCI driver from a platform specific directory to the standard driver/usb/host dir. This is a preparation needed to share this driver between Tegra20 and Tegra30. No functional change in here, so Tegra30 is still not working. Patch 6 could be a lot smaller if it were generated with -B, as GIT would detect that most of it is moving stuff over, but last time I did this it prevented git apply to work. So sorry for the big diff. I think I incorporated all changes needed to reflect the review feedback I got on this last time. I expect this series to go in through the Tegra tree. Last two don't apply, I applied first five and pushed. Marek, what about any conflicts this will cause with other patches in the Tegra tree? Especially since Lucas *explicitly* stated that he expected the series to go through the Tegra tree, I expect that some co-ordination is required here Ok, I can drop them from -USB, will you pick them ? I must have missed that part. These will go thru the Tegra tree when they've gotten some review time (Simon just Acked some of them), and when Lucas fixes the build warning in patch 6. I'm waiting on a V2 patchset from Lucas, which I'd have thought would be clear from even a cursory read of the threads reviews for this series. Tom If nothing else, 01-05 build-test cleanly ;-) Best regards, Marek Vasut -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
On 01/25/2013 07:26 PM, Marek Vasut wrote: Dear Lucas Stach, This moves out the Tegra EHCI driver from a platform specific directory to the standard driver/usb/host dir. This is a preparation needed to share this driver between Tegra20 and Tegra30. No functional change in here, so Tegra30 is still not working. Patch 6 could be a lot smaller if it were generated with -B, as GIT would detect that most of it is moving stuff over, but last time I did this it prevented git apply to work. So sorry for the big diff. I think I incorporated all changes needed to reflect the review feedback I got on this last time. I expect this series to go in through the Tegra tree. Last two don't apply, I applied first five and pushed. Marek, what about any conflicts this will cause with other patches in the Tegra tree? Especially since Lucas *explicitly* stated that he expected the series to go through the Tegra tree, I expect that some co-ordination is required here ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
Dear Stephen Warren, On 01/25/2013 07:26 PM, Marek Vasut wrote: Dear Lucas Stach, This moves out the Tegra EHCI driver from a platform specific directory to the standard driver/usb/host dir. This is a preparation needed to share this driver between Tegra20 and Tegra30. No functional change in here, so Tegra30 is still not working. Patch 6 could be a lot smaller if it were generated with -B, as GIT would detect that most of it is moving stuff over, but last time I did this it prevented git apply to work. So sorry for the big diff. I think I incorporated all changes needed to reflect the review feedback I got on this last time. I expect this series to go in through the Tegra tree. Last two don't apply, I applied first five and pushed. Marek, what about any conflicts this will cause with other patches in the Tegra tree? Especially since Lucas *explicitly* stated that he expected the series to go through the Tegra tree, I expect that some co-ordination is required here Ok, I can drop them from -USB, will you pick them ? I must have missed that part. If nothing else, 01-05 build-test cleanly ;-) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
Lucas,
-Original Message-
From: Lucas Stach [mailto:d...@lynxeye.de]
Sent: Friday, January 25, 2013 7:41 AM
To: u-boot@lists.denx.de
Cc: Tom Warren; Marek Vasut; Simon Glass; Stephen Warren
Subject: [PATCH v2 0/7] Move Tegra EHCI drive to correct place
This moves out the Tegra EHCI driver from a platform specific directory to the
standard driver/usb/host dir.
This is a preparation needed to share this driver between Tegra20 and Tegra30.
No functional change in here, so Tegra30 is still not working.
Patch 6 could be a lot smaller if it were generated with -B, as GIT would
detect that most of it is moving stuff over, but last time I did this it
prevented git apply to work. So sorry for the big diff.
I think I incorporated all changes needed to reflect the review feedback I got
on this last time.
I expect this series to go in through the Tegra tree.
I tried to apply this to u-boot-tegra/next and it needed some massaging to get
it to apply cleanly. Minor stuff, but you'll need to rebase it on top of
current u-boot-tegra/next (I just pushed a new version with my 'Move common
clock code' patch and Allen's fix for the DTS sort patch. Sorry, but the Tegra
repo is going to be fairly dynamic for the next few weeks.
Also, when I did get it applied and tried to ./MAKEALL -s tegra20 -s tegra30, I
got the following warning on all T20 builds:
ehci-tegra.c: In function 'ehci_hcd_init':
ehci-tegra.c:565: warning: assignment makes pointer from integer without a cast
ehci-tegra.c:566: warning: assignment makes pointer from integer without a cast
Also, it appears that arch-tegra20/usb.h is still hanging around (in my edited
patch series, at any rate). Shouldn't the moved arch-tegra/usb.h be used
exclusively? Removing arch-tegra20/usb.h causes fatal errors in
nvidia/common/board.c. If it does need to exist, then it needs to live in
arch-tegra30, also, so it'll be available when T30 gets USB turned on.
Tom
Lucas Stach (7):
tegra: usb: set USB_PORTS_MAX to correct value
tegra: usb: make controller init functions more self contained
tegra: usb: remove unneeded function parameter
tegra: usb: move controller init into start_port
tegra: usb: various small cleanups
tegra: usb: move implementation into right directory
tegra: usb: move [start|stop]_port into ehci_hcd_[init|stop]
arch/arm/cpu/armv7/tegra20/Makefile| 1 -
arch/arm/cpu/armv7/tegra20/usb.c | 567 -
.../include/asm/{arch-tegra20 = arch-tegra}/usb.h | 22 -
arch/arm/include/asm/arch-tegra20/tegra.h | 1 -
arch/arm/include/asm/arch-tegra30/tegra.h | 2 +
board/nvidia/common/board.c| 2 +-
drivers/usb/host/ehci-tegra.c | 546 +++-
7 files changed, 533 insertions(+), 608 deletions(-) delete mode 100644
arch/arm/cpu/armv7/tegra20/usb.c rename arch/arm/include/asm/{arch-tegra20 =
arch-tegra}/usb.h (89%)
--
1.8.0.2
--
nvpublic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
Hello Tom, Am Freitag, den 25.01.2013, 08:07 -0800 schrieb Tom Warren: I tried to apply this to u-boot-tegra/next and it needed some massaging to get it to apply cleanly. Minor stuff, but you'll need to rebase it on top of current u-boot-tegra/next (I just pushed a new version with my 'Move common clock code' patch and Allen's fix for the DTS sort patch. Sorry, but the Tegra repo is going to be fairly dynamic for the next few weeks. Ok, I'll wait for some comments on the actual code, then repost a rebased version. Also, when I did get it applied and tried to ./MAKEALL -s tegra20 -s tegra30, I got the following warning on all T20 builds: ehci-tegra.c: In function 'ehci_hcd_init': ehci-tegra.c:565: warning: assignment makes pointer from integer without a cast ehci-tegra.c:566: warning: assignment makes pointer from integer without a cast Ah damn, forgot to squash the fix in the last patch. Also, it appears that arch-tegra20/usb.h is still hanging around (in my edited patch series, at any rate). Shouldn't the moved arch-tegra/usb.h be used exclusively? Removing arch-tegra20/usb.h causes fatal errors in nvidia/common/board.c. If it does need to exist, then it needs to live in arch-tegra30, also, so it'll be available when T30 gets USB turned on. I don't see why this is happening. The shortlog points at git picking up the rename at the in the wrong dir, I'll look into this when reposting. But the change to nvidia/common/board.c to use the new include dir is definitely included in patch 6. Regards, Lucas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place
Dear Lucas Stach, This moves out the Tegra EHCI driver from a platform specific directory to the standard driver/usb/host dir. This is a preparation needed to share this driver between Tegra20 and Tegra30. No functional change in here, so Tegra30 is still not working. Patch 6 could be a lot smaller if it were generated with -B, as GIT would detect that most of it is moving stuff over, but last time I did this it prevented git apply to work. So sorry for the big diff. I think I incorporated all changes needed to reflect the review feedback I got on this last time. I expect this series to go in through the Tegra tree. Last two don't apply, I applied first five and pushed. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
