Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use
On Thursday, June 23, 2011 14:27:32 Jason Hobbs wrote: > +#ifdef CONFIG_MENU > +int abortboot(int bootdelay) > +#else > static __inline__ int abortboot(int bootdelay) > +#endif more ifdef trickery here than necessary: #ifndef CONFIG_MENU static inline #endif int abortboot(int bootdelay) { -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use
Dear "Jason Hobbs", In message <1308853655-12407-4-git-send-email-jason.ho...@calxeda.com> you wrote: > Signed-off-by: Jason Hobbs > --- > changes in v2: > - expose abortboot externally instead of using a wrapper > - expose abortboot externally when CONFIG_MENU is set > > common/main.c| 12 > include/common.h |3 +++ > 2 files changed, 11 insertions(+), 4 deletions(-) ... > +#ifdef CONFIG_MENU This being a new CONFIG_ variable, it must be documented in the README. But as is this makes little sense, so I suggest you change the order of your patches and add the abortboot support to the menu system in a second step, after adding (and documenting) the menu stuff. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You have the capacity to learn from mistakes. You'll learn a lot today. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use
Mike, On Thu, Jun 23, 2011 at 06:59:40PM -0400, Mike Frysinger wrote: > more ifdef trickery here than necessary: > #ifndef CONFIG_MENU > static inline > #endif > int abortboot(int bootdelay) > { Thanks - I'll change this in the next version of the patch. Jason ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use
Dear Wolfgang, On Fri, Jun 24, 2011 at 07:18:55AM +0200, Wolfgang Denk wrote: > > +#ifdef CONFIG_MENU > > This being a new CONFIG_ variable, it must be documented in the > README. But as is this makes little sense, so I suggest you change > the order of your patches and add the abortboot support to the menu > system in a second step, after adding (and documenting) the menu > stuff. I knew it wasn't right, but I didn't know what else to do. I'll follow your suggestion in the next version of this patch series. Thanks, Jason ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot