Re: [U-Boot] [PATCH v2 7/7] rpi: Force skip_init on serial devices
Hi Alex, On 17 January 2018 at 15:08, Alexander Graf wrote: > > > On 17.01.18 20:40, Simon Glass wrote: >> Hi Alex, >> >> On 17 January 2018 at 00:54, Alexander Graf wrote: >>> The serial devices on the raspberry pi are based on clocks we can't easily >>> read and influence in U-Boot. However, the serial devices are always already >>> properly set up when coming up, so all we need to do is leave them alone. >>> >>> The way to do that is to specify "skip-init" in device tree usually, but >>> if we set CONFIG_OF_BOARD to get the device tree from the RPi firmware, >>> that does not have skip-init properly set. >>> >>> So instead we just force it in board specific code. That way serial devices >>> also work fine when skip-init is not passed explicitly in DT. >>> >>> Signed-off-by: Alexander Graf >>> --- >>> board/raspberrypi/rpi/rpi.c| 7 +++ >>> drivers/serial/serial_bcm283x_mu.c | 2 +- >>> drivers/serial/serial_pl01x.c | 2 +- >>> 3 files changed, 9 insertions(+), 2 deletions(-) >> >> Would you mind converting these drivers to livetree before adding these >> patches? > > Uh, why? I don't quite see how it's related - and I'm not sure I'll make > the rc1 cut-off even with just the pile I have right now :) I'm trying to make sure that people that touch drivers convert them, since otherwise it won't get done. I hope we can accept v2/v3 patches which just miss rc1. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/7] rpi: Force skip_init on serial devices
On 17.01.18 20:40, Simon Glass wrote: > Hi Alex, > > On 17 January 2018 at 00:54, Alexander Graf wrote: >> The serial devices on the raspberry pi are based on clocks we can't easily >> read and influence in U-Boot. However, the serial devices are always already >> properly set up when coming up, so all we need to do is leave them alone. >> >> The way to do that is to specify "skip-init" in device tree usually, but >> if we set CONFIG_OF_BOARD to get the device tree from the RPi firmware, >> that does not have skip-init properly set. >> >> So instead we just force it in board specific code. That way serial devices >> also work fine when skip-init is not passed explicitly in DT. >> >> Signed-off-by: Alexander Graf >> --- >> board/raspberrypi/rpi/rpi.c| 7 +++ >> drivers/serial/serial_bcm283x_mu.c | 2 +- >> drivers/serial/serial_pl01x.c | 2 +- >> 3 files changed, 9 insertions(+), 2 deletions(-) > > Would you mind converting these drivers to livetree before adding these > patches? Uh, why? I don't quite see how it's related - and I'm not sure I'll make the rc1 cut-off even with just the pile I have right now :) Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/7] rpi: Force skip_init on serial devices
Hi Alex, On 17 January 2018 at 00:54, Alexander Graf wrote: > The serial devices on the raspberry pi are based on clocks we can't easily > read and influence in U-Boot. However, the serial devices are always already > properly set up when coming up, so all we need to do is leave them alone. > > The way to do that is to specify "skip-init" in device tree usually, but > if we set CONFIG_OF_BOARD to get the device tree from the RPi firmware, > that does not have skip-init properly set. > > So instead we just force it in board specific code. That way serial devices > also work fine when skip-init is not passed explicitly in DT. > > Signed-off-by: Alexander Graf > --- > board/raspberrypi/rpi/rpi.c| 7 +++ > drivers/serial/serial_bcm283x_mu.c | 2 +- > drivers/serial/serial_pl01x.c | 2 +- > 3 files changed, 9 insertions(+), 2 deletions(-) Would you mind converting these drivers to livetree before adding these patches? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
