Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Dear Alexey Brodkin, In message <1391011745-22239-8-git-send-email-abrod...@synopsys.com> you wrote: > AXS101 is a new generation of devlopment boards from Synopsys that houses > ASIC with ARC700 and lots of DesignWare peripherals: > +#define CONFIG_HOSTNAME axs101 > +#define CONFIG_ETHADDR 4a:56:49:22:3e:43 > +#define CONFIG_IPADDR 10.121.8.200 > +#define CONFIG_SERVERIP 10.121.8.31 > +#define CONFIG_GATEWAYIP10.121.8.1 > +#define CONFIG_NETMASK 255.255.255.0 We do not allow any such fixed network parameters in the board config headers. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Things are not as simple as they seem at first.- Edward Thorp ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Hello Wolfgang, On Wed, 2014-01-29 at 21:09 +0100, Wolfgang Denk wrote: > Dear Alexey Brodkin, > > In message <1391011745-22239-8-git-send-email-abrod...@synopsys.com> you > wrote: > > AXS101 is a new generation of devlopment boards from Synopsys that houses > > ASIC with ARC700 and lots of DesignWare peripherals: > > > > +#defineCONFIG_HOSTNAME axs101 > > +#defineCONFIG_ETHADDR 4a:56:49:22:3e:43 > > +#defineCONFIG_IPADDR 10.121.8.200 > > +#defineCONFIG_SERVERIP 10.121.8.31 > > +#defineCONFIG_GATEWAYIP10.121.8.1 > > +#defineCONFIG_NETMASK 255.255.255.0 > > We do not allow any such fixed network parameters in the board config > headers. I see tons of boards do have these parameters set in "include/configs/xxx". I may indeed remove them in from my board but why keep it in others? So people won't be confused any longer. Regards, Alexey ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Dear Alexey, In message <1391088984.3518.35.ca...@abrodkin-8560l.internal.synopsys.com> you wrote: > > > > +#define CONFIG_HOSTNAME axs101 > > > +#define CONFIG_ETHADDR 4a:56:49:22:3e:43 > > > +#define CONFIG_IPADDR 10.121.8.200 > > > +#define CONFIG_SERVERIP 10.121.8.31 > > > +#define CONFIG_GATEWAYIP10.121.8.1 > > > +#define CONFIG_NETMASK 255.255.255.0 > > > > We do not allow any such fixed network parameters in the board config > > headers. > > I see tons of boards do have these parameters set in > "include/configs/xxx". Pre-historic sins. You happen to have a bit of tough luck when chosing your examples to copy from. > I may indeed remove them in from my board but why keep it in others? > So people won't be confused any longer. Cleanup patches are welcome. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies and the other is to make it so complicated that there are no obvious defi- ciencies. - Charles Anthony Richard Hoare ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Hello Wolfgang, On Fri, 2014-01-31 at 00:13 +0100, Wolfgang Denk wrote: > Dear Alexey, > > In message <1391088984.3518.35.ca...@abrodkin-8560l.internal.synopsys.com> > you wrote: > > > > > > +#defineCONFIG_HOSTNAME axs101 > > > > +#defineCONFIG_ETHADDR 4a:56:49:22:3e:43 > > > > +#defineCONFIG_IPADDR 10.121.8.200 > > > > +#defineCONFIG_SERVERIP 10.121.8.31 > > > > +#defineCONFIG_GATEWAYIP10.121.8.1 > > > > +#defineCONFIG_NETMASK 255.255.255.0 > > > > > > We do not allow any such fixed network parameters in the board config > > > headers. > > > > I see tons of boards do have these parameters set in > > "include/configs/xxx". > > Pre-historic sins. You happen to have a bit of tough luck when > chosing your examples to copy from. > > > I may indeed remove them in from my board but why keep it in others? > > So people won't be confused any longer. > > Cleanup patches are welcome. Understood. I removed all my network parameters and will take a duty of cleaning up other configs. The question then if CONFIG_HOSTNAME could be left? I see people rely on host name for selection (through name) of boot files (uImage, fdt etc.) For example "include/configs/amcc-common.h", "include/configs/manroland/common.h" and others. Regards, Alexey ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Dear Alexey, In message <1391179745.4721.36.camel@abrodkin-8560l> you wrote: > > Understood. > I removed all my network parameters and will take a duty of cleaning up > other configs. thanks in advance. > The question then if CONFIG_HOSTNAME could be left? > I see people rely on host name for selection (through name) of boot > files (uImage, fdt etc.) Yes, hostname is harmless - also in real life: it will not cause any issues on the network, if several hosts set (locally) the same hostname. Several boards with the same IP address or (even worse) the same MAC addresse are much more "interesting" ;-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What the world needs is not dogma but an attitude of scientific inquiry. - Bertrand Russell ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Hello Wolfgang, On Fri, 2014-01-31 at 18:49 +0100, Wolfgang Denk wrote: > Dear Alexey, > > In message <1391179745.4721.36.camel@abrodkin-8560l> you wrote: > > > > Understood. > > I removed all my network parameters and will take a duty of cleaning up > > other configs. > > thanks in advance. > > > The question then if CONFIG_HOSTNAME could be left? > > I see people rely on host name for selection (through name) of boot > > files (uImage, fdt etc.) > > Yes, hostname is harmless - also in real life: it will not cause any > issues on the network, if several hosts set (locally) the same > hostname. Several boards with the same IP address or (even worse) the > same MAC addresse are much more "interesting" ;-) I'm sorry for another continuation away from original patch discussion. If actually not all network properties are really that harmful could you please comment on others as well - this will save a number of iterations on clean-up submission. CONFIG_ETHADDR & CONFIG_IPADDR - it's simple - we don't want to have duplicates of the same MAC or/and IP address within one network. So definitely these ones must go away. But others doesn't affect other devices in the network so why don't we leave them as well? -Alexey ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Dear Alexey, In message <1391193816.4721.100.camel@abrodkin-8560l> you wrote: > > CONFIG_ETHADDR & CONFIG_IPADDR - it's simple - we don't want to have > duplicates of the same MAC or/and IP address within one network. So > definitely these ones must go away. > > But others doesn't affect other devices in the network so why don't we > leave them as well? It seems only consequent to omit all settings specific to the network interface: addresses, netmask, etc. And if you do not set an IP address, it does not make sense to set a netmask, right? Hostname (set to generic board name) is in so far somewhat of an exception as quite a lot of people appear to use this to organize their TFTP download directories. It is difficult to give simple rules for these things. There is a lot of habits and decade old traditions involved, so please don't ask me for some formally defined rule sets. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Hiring experienced unix people is like a built-in filter against idiots. Hiring experienced NT people provides no such guarantee. -- Miguel Cruz in WgL96.349$cc.122...@typhoon2.ba-dsg.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
