Re: [U-Boot] [PATCH v3] imx6: add Bachmann OT1200 board
Hi Christian, On 02/10/2014 13:33, Christian Gmeiner wrote: > This patch adds support for the OT1200 series of devices. > > Following components are used in u-boot: > + ethernet > + i2c > + emmc > + gpio > > For more details see README. > > Changes v1 > v2 > - make use of enable_cspi_clock(..) > - fix usage of OUTPUT_40OHM define > - added README > > Changes v2 > v3 > - improve spelling in README > - added own copy of mx6q_4x_mt41j128.cfg > > Signed-off-by: Christian Gmeiner > --- I think you can send a follow-up patch according to Masahiro's suggestion for removing the "string" tag from Kconfig. I think we agree that it is better mainlining this one first ;-) Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] imx6: add Bachmann OT1200 board
Hi > >> --- /dev/null >> +++ b/board/bachmann/ot1200/Kconfig >> @@ -0,0 +1,23 @@ >> +if TARGET_OT1200 >> + >> +config SYS_CPU >> + string >> + default "armv7" >> + >> +config SYS_BOARD >> + string >> + default "ot1200" >> + >> +config SYS_VENDOR >> + string >> + default "bachmann" >> + >> +config SYS_SOC >> + string >> + default "mx6" >> + >> +config SYS_CONFIG_NAME >> + string >> + default "ot1200" >> + > > > The type "string" is not mandatory since > commit 461be2f96e4b87e5065208c6659a47dd0ad9e9f8. > You can save 5 lines. Nice to know. > Since it is not a big deal, > I don't think you have to resend it just for fixing this. > (I am just pointing out a minor thing I found by chance.) > > If you like or you have a chance to send v4 for another fix, > I recommend you to drop "string". > I am not sure if the current patch set gets accepted or not. Either way I will send a v4 or a followup patch to correct this. I have some more patches in my queue but I need to wait until this patch hits u-boot-imx. greets -- Christian Gmeiner, MSc https://soundcloud.com/christian-gmeiner ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] imx6: add Bachmann OT1200 board
Hi Christian, On Thu, 2 Oct 2014 13:33:46 +0200 Christian Gmeiner wrote: > --- /dev/null > +++ b/board/bachmann/ot1200/Kconfig > @@ -0,0 +1,23 @@ > +if TARGET_OT1200 > + > +config SYS_CPU > + string > + default "armv7" > + > +config SYS_BOARD > + string > + default "ot1200" > + > +config SYS_VENDOR > + string > + default "bachmann" > + > +config SYS_SOC > + string > + default "mx6" > + > +config SYS_CONFIG_NAME > + string > + default "ot1200" > + The type "string" is not mandatory since commit 461be2f96e4b87e5065208c6659a47dd0ad9e9f8. You can save 5 lines. Since it is not a big deal, I don't think you have to resend it just for fixing this. (I am just pointing out a minor thing I found by chance.) If you like or you have a chance to send v4 for another fix, I recommend you to drop "string". Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
