Re: [U-Boot] [PATCH v3 08/10] NET: mvgbe: add support for Dove
-Original Message- From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] Sent: 03 March 2013 17:14 To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Rabeeh Khoury; Albert Aribaud; Andy Fleming; Joe Hershberger; Daniel Stodden; Luka Perkov Subject: Re: [PATCH v3 08/10] NET: mvgbe: add support for Dove On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote: -Original Message- From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] Sent: 17 January 2013 00:55 To: Sebastian Hesselbarth Cc: u-boot@lists.denx.de; Rabeeh Khoury; Albert Aribaud; Prafulla Wadaskar; Andy Fleming; Joe Hershberger; Daniel Stodden; Luka Perkov Subject: [PATCH v3 08/10] NET: mvgbe: add support for Dove Marvell Dove also uses mvgbe as ethernet driver, therefore add support for Dove to reuse the current driver. Signed-off-by: Sebastian Hesselbarthsebastian.hesselba...@gmail.com --- Cc: u-boot@lists.denx.de Cc: Sebastian Hesselbarthsebastian.hesselba...@gmail.com Cc: Rabeeh Khouryrab...@solid-run.com Cc: Albert Aribaudalbert.u.b...@aribaud.net Cc: Prafulla Wadaskarprafu...@marvell.com Cc: Andy Flemingaflem...@gmail.com Cc: Joe Hershbergerjoe.hershber...@gmail.com Cc: Daniel Stoddendaniel.stod...@gmail.com Cc: Luka Perkovl...@openwrt.org --- drivers/net/mvgbe.c |2 ++ drivers/net/mvgbe.h |7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 192c989..590ea0b 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -43,6 +43,8 @@ #includeasm/arch/kirkwood.h #elif defined(CONFIG_ORION5X) #includeasm/arch/orion5x.h +#elif defined(CONFIG_DOVE) +#includeasm/arch/dove.h #endif #include mvgbe.h diff --git a/drivers/net/mvgbe.h b/drivers/net/mvgbe.h index d8a5429..7f5d98f 100644 --- a/drivers/net/mvgbe.h +++ b/drivers/net/mvgbe.h @@ -308,10 +308,17 @@ #define EBAR_TARGET_GUNIT0x0007 /* Window attrib */ +#if defined(CONFIG_DOVE) +#define EBAR_DRAM_CS0 0x +#define EBAR_DRAM_CS1 0x +#define EBAR_DRAM_CS2 0x +#define EBAR_DRAM_CS3 0x What does this means? May you please explain? These are ORed with other BAR values within mvgbe and control access of mvgbe bus master to sdram. In contrast to Kirkwood, Dove has only one sdram target interface with attribute 0x0 while Kirkwood has four different target IDs each for one sdram bank. Dear Sebastian Since dove has only one SDRAM bank You should do #undef EBAR_DRAM_CS1/2/3 instead of defining them zero, and manage the same effectively in the code. To me, defining unavailable banks doesn't sound good. Regards... Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 08/10] NET: mvgbe: add support for Dove
On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote: -Original Message- From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] Sent: 17 January 2013 00:55 To: Sebastian Hesselbarth Cc: u-boot@lists.denx.de; Rabeeh Khoury; Albert Aribaud; Prafulla Wadaskar; Andy Fleming; Joe Hershberger; Daniel Stodden; Luka Perkov Subject: [PATCH v3 08/10] NET: mvgbe: add support for Dove Marvell Dove also uses mvgbe as ethernet driver, therefore add support for Dove to reuse the current driver. Signed-off-by: Sebastian Hesselbarthsebastian.hesselba...@gmail.com --- Cc: u-boot@lists.denx.de Cc: Sebastian Hesselbarthsebastian.hesselba...@gmail.com Cc: Rabeeh Khouryrab...@solid-run.com Cc: Albert Aribaudalbert.u.b...@aribaud.net Cc: Prafulla Wadaskarprafu...@marvell.com Cc: Andy Flemingaflem...@gmail.com Cc: Joe Hershbergerjoe.hershber...@gmail.com Cc: Daniel Stoddendaniel.stod...@gmail.com Cc: Luka Perkovl...@openwrt.org --- drivers/net/mvgbe.c |2 ++ drivers/net/mvgbe.h |7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 192c989..590ea0b 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -43,6 +43,8 @@ #includeasm/arch/kirkwood.h #elif defined(CONFIG_ORION5X) #includeasm/arch/orion5x.h +#elif defined(CONFIG_DOVE) +#includeasm/arch/dove.h #endif #include mvgbe.h diff --git a/drivers/net/mvgbe.h b/drivers/net/mvgbe.h index d8a5429..7f5d98f 100644 --- a/drivers/net/mvgbe.h +++ b/drivers/net/mvgbe.h @@ -308,10 +308,17 @@ #define EBAR_TARGET_GUNIT 0x0007 /* Window attrib */ +#if defined(CONFIG_DOVE) +#define EBAR_DRAM_CS0 0x +#define EBAR_DRAM_CS1 0x +#define EBAR_DRAM_CS2 0x +#define EBAR_DRAM_CS3 0x What does this means? May you please explain? These are ORed with other BAR values within mvgbe and control access of mvgbe bus master to sdram. In contrast to Kirkwood, Dove has only one sdram target interface with attribute 0x0 while Kirkwood has four different target IDs each for one sdram bank. Sebastian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 08/10] NET: mvgbe: add support for Dove
-Original Message- From: Sebastian Hesselbarth [mailto:sebastian.hesselba...@gmail.com] Sent: 17 January 2013 00:55 To: Sebastian Hesselbarth Cc: u-boot@lists.denx.de; Rabeeh Khoury; Albert Aribaud; Prafulla Wadaskar; Andy Fleming; Joe Hershberger; Daniel Stodden; Luka Perkov Subject: [PATCH v3 08/10] NET: mvgbe: add support for Dove Marvell Dove also uses mvgbe as ethernet driver, therefore add support for Dove to reuse the current driver. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: u-boot@lists.denx.de Cc: Sebastian Hesselbarth sebastian.hesselba...@gmail.com Cc: Rabeeh Khoury rab...@solid-run.com Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Prafulla Wadaskar prafu...@marvell.com Cc: Andy Fleming aflem...@gmail.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Daniel Stodden daniel.stod...@gmail.com Cc: Luka Perkov l...@openwrt.org --- drivers/net/mvgbe.c |2 ++ drivers/net/mvgbe.h |7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 192c989..590ea0b 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -43,6 +43,8 @@ #include asm/arch/kirkwood.h #elif defined(CONFIG_ORION5X) #include asm/arch/orion5x.h +#elif defined(CONFIG_DOVE) +#include asm/arch/dove.h #endif #include mvgbe.h diff --git a/drivers/net/mvgbe.h b/drivers/net/mvgbe.h index d8a5429..7f5d98f 100644 --- a/drivers/net/mvgbe.h +++ b/drivers/net/mvgbe.h @@ -308,10 +308,17 @@ #define EBAR_TARGET_GUNIT0x0007 /* Window attrib */ +#if defined(CONFIG_DOVE) +#define EBAR_DRAM_CS00x +#define EBAR_DRAM_CS10x +#define EBAR_DRAM_CS20x +#define EBAR_DRAM_CS30x What does this means? May you please explain? Regards... Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
