Re: [U-Boot] [PATCH v3 2/2] fit: Support compat string property in configuration node

2019-05-14 Thread Simon Glass
Hi Julius,

On Mon, 13 May 2019 at 19:15, Julius Werner  wrote:
>
> > Can you please add a change log, as this is a v3 patch.
>
> I didn't change anything in this one. (Should I have not called it v3
> then? Sorry, I'm not familiar with the submission process here. I
> thought letting the individual patches in the series have different
> version numbers for the same set would be more confusing.)

If there are no changes for a version, the patch should say so.

Do you use patman for submission? It does all of this for you reliably
each time.

For this one, there should be a documentation update too. Also, for
the series I think you should add a new example to the docs, since you
are adding two new features.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v3 2/2] fit: Support compat string property in configuration node

2019-05-13 Thread Julius Werner
> Can you please add a change log, as this is a v3 patch.

I didn't change anything in this one. (Should I have not called it v3
then? Sorry, I'm not familiar with the submission process here. I
thought letting the individual patches in the series have different
version numbers for the same set would be more confusing.)
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v3 2/2] fit: Support compat string property in configuration node

2019-05-13 Thread Simon Glass
Hi,

> This patch adds support for an optional optimization to compatible
> string matching where the compatible string property from the root node
> of the kernel FDT can be copied into the configuration node of the FIT
> image. This is most useful when using compressed FDTs or when using FDT
> overlays, where the traditional extraction of the compatible string from
> the kernel FDT itself is not easily possible.
>
> Signed-off-by: Julius Werner 
> ---
>  common/image-fit.c | 67 +++---
>  1 file changed, 39 insertions(+), 28 deletions(-)

Can you please add a change log, as this is a v3 patch.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot