Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2Cframework
Hello Stephen, Am 07.05.2013 16:55, schrieb Stephen Warren: > On 05/07/2013 02:01 AM, Marc Dietrich wrote: >> Hi, >> >> Am Montag, 6. Mai 2013, 13:08:31 schrieb Stephen Warren: >>> On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. include/configs/beaver.h| 5 ++- include/configs/cardhu.h| 3 +- include/configs/dalmore.h | 3 +- include/configs/seaboard.h | 5 ++- include/configs/trimslice.h | 5 ++- include/configs/whistler.h | 5 ++- >>> >>> There are a lot more Tegra boards than just those. Shouldn't they all be >>> updated? You also didn't Cc the Tegra maintainer - I have done on this mail. >> >> not all boards use I2C up to now, to the patch seems to change only the >> boards >> which do. So this is ok for now. The question is if CONFIG_SYS_I2C could be >> moved to tegra_common or so because the device-tree disables I2C be default. > > Yes, we should do that for all the devices that are now > instantiated/configured using device tree. But, we can do that as a > separate patch series after this. Yes, that makes sense. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2Cframework
Hi, On Tue, May 7, 2013 at 8:55 AM, Stephen Warren wrote: > On 05/07/2013 02:01 AM, Marc Dietrich wrote: >> Hi, >> >> Am Montag, 6. Mai 2013, 13:08:31 schrieb Stephen Warren: >>> On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. include/configs/beaver.h| 5 ++- include/configs/cardhu.h| 3 +- include/configs/dalmore.h | 3 +- include/configs/seaboard.h | 5 ++- include/configs/trimslice.h | 5 ++- include/configs/whistler.h | 5 ++- >>> >>> There are a lot more Tegra boards than just those. Shouldn't they all be >>> updated? You also didn't Cc the Tegra maintainer - I have done on this mail. >> >> not all boards use I2C up to now, to the patch seems to change only the >> boards >> which do. So this is ok for now. The question is if CONFIG_SYS_I2C could be >> moved to tegra_common or so because the device-tree disables I2C be default. > > Yes, we should do that for all the devices that are now > instantiated/configured using device tree. But, we can do that as a > separate patch series after this. I don't have anything to add to this - I did the Tegra patch a long time ago when this was last posted, and it was tested on Seaboard at the time. I'll make time to review and test the series at least on snow. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2Cframework
On 05/07/2013 02:01 AM, Marc Dietrich wrote: > Hi, > > Am Montag, 6. Mai 2013, 13:08:31 schrieb Stephen Warren: >> On 05/04/2013 06:01 AM, Heiko Schocher wrote: >>> From: Simon Glass >>> >>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the >>> Tegra i2c driver to support this. >>> >>> include/configs/beaver.h| 5 ++- >>> include/configs/cardhu.h| 3 +- >>> include/configs/dalmore.h | 3 +- >>> include/configs/seaboard.h | 5 ++- >>> include/configs/trimslice.h | 5 ++- >>> include/configs/whistler.h | 5 ++- >> >> There are a lot more Tegra boards than just those. Shouldn't they all be >> updated? You also didn't Cc the Tegra maintainer - I have done on this mail. > > not all boards use I2C up to now, to the patch seems to change only the > boards > which do. So this is ok for now. The question is if CONFIG_SYS_I2C could be > moved to tegra_common or so because the device-tree disables I2C be default. Yes, we should do that for all the devices that are now instantiated/configured using device tree. But, we can do that as a separate patch series after this. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2Cframework
Hi, Am Montag, 6. Mai 2013, 13:08:31 schrieb Stephen Warren: > On 05/04/2013 06:01 AM, Heiko Schocher wrote: > > From: Simon Glass > > > > This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the > > Tegra i2c driver to support this. > > > > include/configs/beaver.h| 5 ++- > > include/configs/cardhu.h| 3 +- > > include/configs/dalmore.h | 3 +- > > include/configs/seaboard.h | 5 ++- > > include/configs/trimslice.h | 5 ++- > > include/configs/whistler.h | 5 ++- > > There are a lot more Tegra boards than just those. Shouldn't they all be > updated? You also didn't Cc the Tegra maintainer - I have done on this mail. not all boards use I2C up to now, to the patch seems to change only the boards which do. So this is ok for now. The question is if CONFIG_SYS_I2C could be moved to tegra_common or so because the device-tree disables I2C be default. Marc ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
