Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board
Dear Angelo Dureghello,
In message 20130123145107.GA5565@sion.sysam you wrote:
Add support for Sysam AMCORE mcf5307 (coldfire) based board.
Signed-off-by: Angelo Dureghello sysa...@gmail.com
Cc: Jason Jin jason@freescale.com
...
diff --git a/MAINTAINERS b/MAINTAINERS
index 28c052d..1d27cb7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1137,6 +1137,10 @@ Wolfgang Wegner w.weg...@astro-kom.de
astro_mcf5373l MCF5373L
+Angelo Dureghello sysa...@gmail.com
+
+ amcore mcf5307
Please keep the list sorted...
+
+ for (p = pstart; p pend; p++) {
+ if (*p != 0x) {
+ printf(SDRAM test fails at: %08x\n, (uint) p);
+ return 1;
+ }
Incorrect indentation.
+/*
+ * BOOTP options
+ */
+#undef CONFIG_BOOTP_BOOTFILESIZE
+#undef CONFIG_BOOTP_BOOTPATH
+#undef CONFIG_BOOTP_GATEWAY
+#undef CONFIG_BOOTP_HOSTNAME
Please don't undef what is not defined anyway. Please fix globally.
+#define CONFIG_SYS_SDRAM_BASE0x
+#define CONFIG_SYS_SDRAM_SIZE16 /* in MB */
NAK. CONFIG_SYS_SDRAM_SIZE is always and everywhere in bytes...
+/* reserve 128-4KB */
+#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400)
+#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024)
Are you sure this is sufficient?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There's a way out of any cage.
-- Captain Christopher Pike, The Menagerie (The Cage),
stardate unknown.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board
Dear Wolfgang, thanks for the review, will fix all points. +/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE(CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024) Are you sure this is sufficient? For my board/case actually seems to be more than enough. I can still change this in the future. Best Regards, Angelo Dureghello ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board
Dear Angelo Dureghello, In message 20130124161349.GA11311@sion.sysam you wrote: +/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024) Are you sure this is sufficient? For my board/case actually seems to be more than enough. I can still change this in the future. How big is your U-Boot image, then? I think it's a pretty long time since I haven't seen any image smaller than 128 kB... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There's nothing disgusting about it [the Companion]. It's just another life form, that's all. You get used to those things. -- McCoy, Metamorphosis, stardate 3219.8 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board
Dear Wolfgang, On Thu, Jan 24, 2013 at 07:24:11PM +0100, Wolfgang Denk wrote: Dear Angelo Dureghello, In message 20130124161349.GA11311@sion.sysam you wrote: +/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE(CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024) Are you sure this is sufficient? For my board/case actually seems to be more than enough. I can still change this in the future. How big is your U-Boot image, then? I think it's a pretty long time since I haven't seen any image smaller than 128 kB... -rwxr-xr-x 1 angelo angelo 88556 gen 22 22:31 u-boot.bin Best regards, Angelo Dureghello ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] board: add support for amcore board
Dear Angelo Dureghello, In message 20130124200736.GA19171@sion.sysam you wrote: How big is your U-Boot image, then? I think it's a pretty long time since I haven't seen any image smaller than 128 kB... -rwxr-xr-x 1 angelo angelo 88556 gen 22 22:31 u-boot.bin Wow, that's just great :-) Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Living on Earth may be expensive, but it includes an annual free trip around the Sun. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
