Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
-Original Message- From: Luka Perkov [mailto:ub...@lukaperkov.net] Sent: 26 March 2012 22:56 To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; drea...@doukki.net; gmbno...@gmail.com Subject: Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support Hi Prafulla, On Mon, Mar 26, 2012 at 01:03:49AM -0700, Prafulla Wadaskar wrote: This patch looks okay to me. Great! Who is in charge of commiting this? You? Thant's me, I will pick it up :-) Regards.. Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot- boun...@lists.denx.de] On Behalf Of Luka Perkov Sent: 26 March 2012 01:02 To: u-boot@lists.denx.de Cc: drea...@doukki.net; gmbno...@gmail.com Subject: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220. Only difference between boards is number of SATA ports. More information about the boards can be found here: http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036 http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7515 Signed-off-by: Luka Perkov ub...@lukaperkov.net Signed-off-by: Gerald Kerma drea...@doukki.net Signed-off-by: Simon Baatz gmbno...@gmail.com --- Changes from version v1: * use tools/checkpatch.pl to locate patch errors and fix them * add two entries in boards.cfg, one for each board * fixed CONFIG_RESET_PHY_R * don't define values for macros that enable features only * remove static RAM configuration * fix comments * use only CONFIG_ENV_OFFSET and remove CONFIG_ENV_ADDR * clean coding style * add entry in MAINTAINERS file Changes from version v2: * use defined() in macros for board selection for robustness Changes from version v3: * don't use utf8 for Geralds name * don't mix upper/lower case in kwbimage.cfg * fix prompt Changes from version v4: * fix board Makefile (clean and distclean) * use generic way to handle arch number of the board * fix MAINTAINERS file * move code from Marvell to raidsonic folder * use CONFIG_MACH_TYPE * set only necessary GPIOs * use link instead of address for license * add few links about board being supported for quick reference * add previous change logs * multiple updates to kwbimage.cfg, thank you Simon About kwbimage.cfg - first version was taken from sheevaplug with change only regarding memory. Now it's rewriten so it uses settings like manufacturer. MAINTAINERS |5 + board/raidsonic/ib62x0/Makefile | 43 + board/raidsonic/ib62x0/ib62x0.c | 79 board/raidsonic/ib62x0/ib62x0.h | 40 board/raidsonic/ib62x0/kwbimage.cfg | 172 +++ boards.cfg |2 + include/configs/ib62x0.h| 172 +++ 7 files changed, 513 insertions(+) Hi Luka This patch looks okay to me. Just one concern, how you are taking care of machine-id? Just curious to know: Have you already registered for machine-ID for this board? Is Linux kernel support for this board is done, is it being mainlined? Regards.. Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
On Sun, Mar 25, 2012 at 09:31:43PM +0200, Luka Perkov wrote: Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220. Only difference between boards is number of SATA ports. More information about the boards can be found here: http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036 http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7515 Luka, Sorry I didn't see this before now. You may want to have a look at the patch series going into v3.4 here [1]. Basically, All of mine and Andrew Lunn's. If you base your kernel patches off of this, CC: me and I'll pull them in. ... diff --git a/include/configs/ib62x0.h b/include/configs/ib62x0.h new file mode 100644 index 000..2dc698e --- /dev/null +++ b/include/configs/ib62x0.h @@ -0,0 +1,172 @@ +/* + * Copyright (C) 2011-2012 + * Gerald Kerma drea...@doukki.net + * Luka Perkov ub...@lukaperkov.net + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see http://www.gnu.org/licenses/. + */ + +#ifndef _CONFIG_IB62x0_H +#define _CONFIG_IB62x0_H + +/* + * Version number information + */ +#if defined(CONFIG_BOARD_IS_IB_NAS6210) +# define CONFIG_IDENT_STRING RaidSonic ICY BOX IB-NAS6210 +#elif defined(CONFIG_BOARD_IS_IB_NAS6220) +# define CONFIG_IDENT_STRING RaidSonic ICY BOX IB-NAS6220 +#else +# error Unknown RaidSonic ICY BOX board specified +#endif + +/* + * High level configuration options + */ +#define CONFIG_FEROCEON_88FR131 /* CPU Core subversion */ +#define CONFIG_KIRKWOOD /* SOC Family Name */ +#define CONFIG_KW88F6281 /* SOC Name */ +#define CONFIG_SKIP_LOWLEVEL_INIT/* disable board lowlevel_init */ + +/* + * Machine type + */ +#define CONFIG_MACH_TYPE MACH_TYPE_NAS6210 #define CONFIG_OF_LIBFDT If you add this here, the mach-type won't be needed once you add a devicetree file to Linux. It shouldn't be too hard to follow what we have going on for dreamplug and Buffalo DNS-xxx (patches are still wip for Buffalo stuff). hth, Jason. [1] git://git.infradead.org/users/jcooper/linux-kirkwood.git kirkwood_dt_for_3.4_v3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
Hi Prafulla, On Mon, Mar 26, 2012 at 01:03:49AM -0700, Prafulla Wadaskar wrote: This patch looks okay to me. Great! Who is in charge of commiting this? You? Just one concern, how you are taking care of machine-id? In file include/configs/ib62x0.h this line takes care of that: #define CONFIG_MACH_TYPEMACH_TYPE_NAS6210 It was one of your comments for v4. Just curious to know: Have you already registered for machine-ID for this board? MACH_TYPE_NAS6210 is already inside kernel but the board is not added yet. Is Linux kernel support for this board is done, is it being mainlined? Not yet. This is next on my TODO. Here is a patch I submitted to OpenWrt: https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/01.html Simon is the author of the kernel mach file. Regarding u-boot I have other things on my TODO list, one of them is to clean up other kirkwood targets. I'll fix stuff that were pointed for this board. But first I would like this to be commited. Thank you for the review. Regards, Luka ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
Hi Jason,
please keep me in CC because I'm not subscribed to the list... Thanks!
Sorry I didn't see this before now. You may want to have a look at the
patch series going into v3.4 here [1]. Basically, All of mine and
Andrew Lunn's.
Cool! Thanks for pointing this out.
I have looked at this:
http://git.infradead.org/users/jcooper/linux-kirkwood.git/blob/refs/heads/kirkwood_dt_for_3.4_v3:/arch/arm/mach-kirkwood/board-dreamplug.c
40 struct mtd_partition dreamplug_partitions[] = {
41 {
42 .name = u-boot,
43 .size = SZ_512K,
44 .offset = 0,
45 },
46 {
47 .name = u-boot env,
48 .size = SZ_64K,
49 .offset = SZ_512K + SZ_512K,
50 },
51 {
52 .name = dtb,
53 .size = SZ_64K,
54 .offset = SZ_512K + SZ_512K + SZ_512K,
55 },
56 };
Can you explain why line 49 is not:
.offset = MTDPART_OFS_NXTBLK, or .offset = SZ_512K
and line 54:
.offset = MTDPART_OFS_NXTBLK, or .offset = SZ_512K + SZ_64K
Am I missing something here?
If you base your kernel patches off of this, CC: me and I'll pull them
in.
Is there a list where we can talk about this? I dont think we should use
u-boot list for this...
...
+#define CONFIG_MACH_TYPE MACH_TYPE_NAS6210
#define CONFIG_OF_LIBFDT
If you add this here, the mach-type won't be needed once you add a
devicetree file to Linux.
I do not want to add this now because I did not test that. And there is
no support for this in kernel yet. When we have this we can post a patch
to u-boot list to fix this. I think that is the best way.
It shouldn't be too hard to follow what we have going on for dreamplug
and Buffalo DNS-xxx (patches are still wip for Buffalo stuff).
I will test this patch with your kernel branch:
https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/01.html
I'll let you know how it went and bug you if I have problems...
[1] git://git.infradead.org/users/jcooper/linux-kirkwood.git
kirkwood_dt_for_3.4_v3
Thanks again for this.
Regards,
Luka
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
On Mon, Mar 26, 2012 at 07:57:38PM +0200, Luka Perkov wrote:
Hi Jason,
please keep me in CC because I'm not subscribed to the list... Thanks!
Sorry I didn't see this before now. You may want to have a look at the
patch series going into v3.4 here [1]. Basically, All of mine and
Andrew Lunn's.
Cool! Thanks for pointing this out.
I have looked at this:
http://git.infradead.org/users/jcooper/linux-kirkwood.git/blob/refs/heads/kirkwood_dt_for_3.4_v3:/arch/arm/mach-kirkwood/board-dreamplug.c
40 struct mtd_partition dreamplug_partitions[] = {
41 {
42 .name = u-boot,
43 .size = SZ_512K,
44 .offset = 0,
45 },
46 {
47 .name = u-boot env,
48 .size = SZ_64K,
49 .offset = SZ_512K + SZ_512K,
50 },
51 {
52 .name = dtb,
53 .size = SZ_64K,
54 .offset = SZ_512K + SZ_512K + SZ_512K,
55 },
56 };
Can you explain why line 49 is not:
.offset = MTDPART_OFS_NXTBLK, or .offset = SZ_512K
and line 54:
.offset = MTDPART_OFS_NXTBLK, or .offset = SZ_512K + SZ_64K
Am I missing something here?
Nope, I copied the style from arch/arm/mach-kirkwood/t5325-setup.c:37.
Thankfully, that will be going away once spi/flash is converted to
devicetree. If your board uses nand, you can look at Jamie Lentin's
patch series for the Buffalo DNS-32x boards. He's converted orion_nand
to devicetree. Hopefully, I'll be able to pull those soon.
If you base your kernel patches off of this, CC: me and I'll pull them
in.
Is there a list where we can talk about this? I dont think we should use
u-boot list for this...
linux-arm-ker...@vger.kernel.org, CC'd.
...
+#define CONFIG_MACH_TYPE MACH_TYPE_NAS6210
#define CONFIG_OF_LIBFDT
If you add this here, the mach-type won't be needed once you add a
devicetree file to Linux.
I do not want to add this now because I did not test that. And there is
no support for this in kernel yet. When we have this we can post a patch
to u-boot list to fix this. I think that is the best way.
I use this with dreamplug currently. It boots non-fdt and fdt kernels
without problem. It basically has bootm command read an extra argument
(address of dt blob), if provided. So, args would be:
bootm kernel addr [initrd addr] [dtb addr]
If you're not comfortable with it, that's fine. I just remember having
to go back and add it and then wait another release cycle to see it in
mainline. I wish I had it in there the first time around.
It shouldn't be too hard to follow what we have going on for dreamplug
and Buffalo DNS-xxx (patches are still wip for Buffalo stuff).
I will test this patch with your kernel branch:
https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/01.html
I'll let you know how it went and bug you if I have problems...
[1] git://git.infradead.org/users/jcooper/linux-kirkwood.git
kirkwood_dt_for_3.4_v3
Thanks again for this.
No problem.
thx,
Jason.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
On Mon, Mar 26, 2012 at 03:34:37PM -0400, Jason Cooper wrote: On Mon, Mar 26, 2012 at 07:57:38PM +0200, Luka Perkov wrote: ... Is there a list where we can talk about this? I dont think we should use u-boot list for this... linux-arm-ker...@vger.kernel.org, CC'd. oops, that's the old address, current is linux-arm-ker...@lists.infradead.org thx, Jason. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
