Re: [U-Boot] [PATCH v5 4/8] dm: Expand the uclass for Platform Controller Hubs (PCH)
On Tue, Jan 19, 2016 at 11:24 AM, Bin Meng wrote:
> Hi Simon,
>
> On Tue, Jan 19, 2016 at 11:19 AM, Simon Glass wrote:
>> A Platform Controller Hub is an Intel concept - it is like the peripherals
>> on an SoC and is often in a separate chip from the CPU. The chip is typically
>> found on the first PCI bus and integrates multiple devices.
>>
>> We have a very simple uclass to support PCHs. Add a few operations, such as
>> setting up the devices on the PCH and finding the SPI controller base
>> address. Also move it into drivers/pch/ since we will be adding a few PCH
>> drivers.
>>
>> Signed-off-by: Simon Glass
>> Signed-off-by: Bin Meng
>> ---
>>
>
> I guess I don't do anything with this patch, but just a :)
>
> Reviewed-by: Bin Meng
>
Fixed the tag, and
>> Changes in v5: None
>> Changes in v4:
>> - Return -ENOSYS if the version is unknown
>>
>> Changes in v3:
>> - Add a PCH method to enable/disable SPI flash protection
>> - Drop the pch_init() call
>>
>> Changes in v2:
>> - Update the commit message and header file comments
>> - Use an enum for the PCH version
>> - Replace SBASE with SPI base
>> - Add a TODO to check if the init() method can be removed later
>>
>> arch/x86/lib/Makefile | 1 -
>> drivers/Makefile | 1 +
>> drivers/pch/Makefile | 5 ++
>> {arch/x86/lib => drivers/pch}/pch-uclass.c | 32 +
>> include/pch.h | 74
>> ++
>> 5 files changed, 112 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/pch/Makefile
>> rename {arch/x86/lib => drivers/pch}/pch-uclass.c (50%)
>> create mode 100644 include/pch.h
>>
applied to u-boot-x86/master, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 4/8] dm: Expand the uclass for Platform Controller Hubs (PCH)
Hi Simon,
On Tue, Jan 19, 2016 at 11:19 AM, Simon Glass wrote:
> A Platform Controller Hub is an Intel concept - it is like the peripherals
> on an SoC and is often in a separate chip from the CPU. The chip is typically
> found on the first PCI bus and integrates multiple devices.
>
> We have a very simple uclass to support PCHs. Add a few operations, such as
> setting up the devices on the PCH and finding the SPI controller base
> address. Also move it into drivers/pch/ since we will be adding a few PCH
> drivers.
>
> Signed-off-by: Simon Glass
> Signed-off-by: Bin Meng
> ---
>
I guess I don't do anything with this patch, but just a :)
Reviewed-by: Bin Meng
> Changes in v5: None
> Changes in v4:
> - Return -ENOSYS if the version is unknown
>
> Changes in v3:
> - Add a PCH method to enable/disable SPI flash protection
> - Drop the pch_init() call
>
> Changes in v2:
> - Update the commit message and header file comments
> - Use an enum for the PCH version
> - Replace SBASE with SPI base
> - Add a TODO to check if the init() method can be removed later
>
> arch/x86/lib/Makefile | 1 -
> drivers/Makefile | 1 +
> drivers/pch/Makefile | 5 ++
> {arch/x86/lib => drivers/pch}/pch-uclass.c | 32 +
> include/pch.h | 74
> ++
> 5 files changed, 112 insertions(+), 1 deletion(-)
> create mode 100644 drivers/pch/Makefile
> rename {arch/x86/lib => drivers/pch}/pch-uclass.c (50%)
> create mode 100644 include/pch.h
>
[snip]
Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
