Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup
Hello, Jagan Teki wrote on Sun, 27 Oct 2019 15:24:40 +0100: > On Sun, 27 Oct, 2019, 15:06 Tom Rini, wrote: > > > On Sun, Oct 27, 2019 at 05:23:14PM +0530, Jagan Teki wrote: > > > On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal > > > > > wrote: > > > > > > > > Hi Jagan, > > > > > > > > Jagan Teki wrote on Sat, 26 Oct 2019 > > > > 15:50:06 +0530: > > > > > > > > > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > > > > > wrote: > > > > > > > > > > > > As rightfully pointed by Jagan, I should have dropped the > > dependency > > > > > > of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the > > "MTD > > > > > > defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series. > > > > > > > > > > > > Instead of sending the 40 patches again, here are only the last > > three > > > > > > patches with: > > > > > > * patch 1 (24/26) being corrected as per Jagan's comment > > > > > > * patch 2 (25/26) is untouched > > > > > > * patch 3 (26/26) is almost untouched but I had to resolve a > > conflict > > > > > > due to patch 1. > > > > > > > > > > > > Thanks, > > > > > > Miquèl > > > > > > > > > > > > Miquel Raynal (3): > > > > > > cmd: nand/sf: isolate legacy code > > > > > > cmd: make MTD commands depend on MTD > > > > > > mtd: Makefile: deep cleanup > > > > > > > > > > Reviewed-by: Jagan Teki > > > > > > > > Thanks! > > > > > > > > Who is supposed to take the two series? > > > > > > Looks like there are several defconfig changes in master, please > > > rebase on master and send your branch (some where from github or so). > > > > If it's just defconfigs, I'll grab it so I can have the series also be > > the only thing in the tree when I do the before/after size check. > > Thanks! > > > > Thanks Tom. > > > Great! Thanks Tom. Miquèl ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup
On Sun, 27 Oct, 2019, 15:06 Tom Rini, wrote: > On Sun, Oct 27, 2019 at 05:23:14PM +0530, Jagan Teki wrote: > > On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal > wrote: > > > > > > Hi Jagan, > > > > > > Jagan Teki wrote on Sat, 26 Oct 2019 > > > 15:50:06 +0530: > > > > > > > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > > > > wrote: > > > > > > > > > > As rightfully pointed by Jagan, I should have dropped the > dependency > > > > > of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the > "MTD > > > > > defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series. > > > > > > > > > > Instead of sending the 40 patches again, here are only the last > three > > > > > patches with: > > > > > * patch 1 (24/26) being corrected as per Jagan's comment > > > > > * patch 2 (25/26) is untouched > > > > > * patch 3 (26/26) is almost untouched but I had to resolve a > conflict > > > > > due to patch 1. > > > > > > > > > > Thanks, > > > > > Miquèl > > > > > > > > > > Miquel Raynal (3): > > > > > cmd: nand/sf: isolate legacy code > > > > > cmd: make MTD commands depend on MTD > > > > > mtd: Makefile: deep cleanup > > > > > > > > Reviewed-by: Jagan Teki > > > > > > Thanks! > > > > > > Who is supposed to take the two series? > > > > Looks like there are several defconfig changes in master, please > > rebase on master and send your branch (some where from github or so). > > If it's just defconfigs, I'll grab it so I can have the series also be > the only thing in the tree when I do the before/after size check. > Thanks! > Thanks Tom. > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup
On Sun, Oct 27, 2019 at 05:23:14PM +0530, Jagan Teki wrote: > On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal > wrote: > > > > Hi Jagan, > > > > Jagan Teki wrote on Sat, 26 Oct 2019 > > 15:50:06 +0530: > > > > > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > > > wrote: > > > > > > > > As rightfully pointed by Jagan, I should have dropped the dependency > > > > of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD > > > > defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series. > > > > > > > > Instead of sending the 40 patches again, here are only the last three > > > > patches with: > > > > * patch 1 (24/26) being corrected as per Jagan's comment > > > > * patch 2 (25/26) is untouched > > > > * patch 3 (26/26) is almost untouched but I had to resolve a conflict > > > > due to patch 1. > > > > > > > > Thanks, > > > > Miquèl > > > > > > > > Miquel Raynal (3): > > > > cmd: nand/sf: isolate legacy code > > > > cmd: make MTD commands depend on MTD > > > > mtd: Makefile: deep cleanup > > > > > > Reviewed-by: Jagan Teki > > > > Thanks! > > > > Who is supposed to take the two series? > > Looks like there are several defconfig changes in master, please > rebase on master and send your branch (some where from github or so). If it's just defconfigs, I'll grab it so I can have the series also be the only thing in the tree when I do the before/after size check. Thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup
On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal wrote: > > Hi Jagan, > > Jagan Teki wrote on Sat, 26 Oct 2019 > 15:50:06 +0530: > > > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > > wrote: > > > > > > As rightfully pointed by Jagan, I should have dropped the dependency > > > of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD > > > defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series. > > > > > > Instead of sending the 40 patches again, here are only the last three > > > patches with: > > > * patch 1 (24/26) being corrected as per Jagan's comment > > > * patch 2 (25/26) is untouched > > > * patch 3 (26/26) is almost untouched but I had to resolve a conflict > > > due to patch 1. > > > > > > Thanks, > > > Miquèl > > > > > > Miquel Raynal (3): > > > cmd: nand/sf: isolate legacy code > > > cmd: make MTD commands depend on MTD > > > mtd: Makefile: deep cleanup > > > > Reviewed-by: Jagan Teki > > Thanks! > > Who is supposed to take the two series? Looks like there are several defconfig changes in master, please rebase on master and send your branch (some where from github or so). ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup
Hi Jagan, Jagan Teki wrote on Sat, 26 Oct 2019 15:50:06 +0530: > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > wrote: > > > > As rightfully pointed by Jagan, I should have dropped the dependency > > of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD > > defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series. > > > > Instead of sending the 40 patches again, here are only the last three > > patches with: > > * patch 1 (24/26) being corrected as per Jagan's comment > > * patch 2 (25/26) is untouched > > * patch 3 (26/26) is almost untouched but I had to resolve a conflict > > due to patch 1. > > > > Thanks, > > Miquèl > > > > Miquel Raynal (3): > > cmd: nand/sf: isolate legacy code > > cmd: make MTD commands depend on MTD > > mtd: Makefile: deep cleanup > > Reviewed-by: Jagan Teki Thanks! Who is supposed to take the two series? Miquèl ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup
On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal wrote: > > As rightfully pointed by Jagan, I should have dropped the dependency > of cmd/sf.c and cmd/nand.c on mtd_uboot.c in patch 24/26 of the "MTD > defconfigs/Kconfigs/Makefiles heavy cleanup" v5 series. > > Instead of sending the 40 patches again, here are only the last three > patches with: > * patch 1 (24/26) being corrected as per Jagan's comment > * patch 2 (25/26) is untouched > * patch 3 (26/26) is almost untouched but I had to resolve a conflict > due to patch 1. > > Thanks, > Miquèl > > Miquel Raynal (3): > cmd: nand/sf: isolate legacy code > cmd: make MTD commands depend on MTD > mtd: Makefile: deep cleanup Reviewed-by: Jagan Teki ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot