Re: [U-Boot] [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board support

2012-06-05 Thread Joe Hershberger
Hi Prafulla,

On Jun 5, 2012, at 9:10 AM, Prafulla Wadaskar  wrote:

> 
> 
>> -Original Message-
>> From: Michael Walle [mailto:mich...@walle.cc]
>> Sent: 05 June 2012 16:39
>> To: Prafulla Wadaskar
>> Cc: u-boot@lists.denx.de; Joe Hershberger
>> Subject: Re: [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board
>> support
>> 
>> 
>> Hi Prafulla,
>> 
>> do you have any additional comments? With both net patches acked by
>> Joe, i
>> guess its ready to be merged with your tree. Should i post another
>> patch
>> version with the ACK added to the second net patch?
> 
> No, I think those are ready to merge, I will pull them soon
> 
> Hi Joe,
> What do you think?

Looks good. 

> Regards..
> Prafulla . . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board support

2012-06-05 Thread Prafulla Wadaskar


> -Original Message-
> From: Prafulla Wadaskar
> Sent: 05 June 2012 19:41
> To: 'Michael Walle'
> Cc: u-boot@lists.denx.de; Joe Hershberger
> Subject: RE: [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board
> support
> 
> 
> 
> > -Original Message-
> > From: Michael Walle [mailto:mich...@walle.cc]
> > Sent: 05 June 2012 16:39
> > To: Prafulla Wadaskar
> > Cc: u-boot@lists.denx.de; Joe Hershberger
> > Subject: Re: [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board
> > support
> >
> >
> > Hi Prafulla,
> >
> > do you have any additional comments? With both net patches acked by
> > Joe, i
> > guess its ready to be merged with your tree. Should i post another
> > patch
> > version with the ACK added to the second net patch?
> 
> No, I think those are ready to merge, I will pull them soon

Hi Michael

I have pulled Kirkwood spi patch series that breaks the Kirkwood_mpp_conf(),
So your patch series gives me build error.

May you pls pull u-boot-marvell.git master and send your patch series against 
that?

Regards..
Prafulla . . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board support

2012-06-05 Thread Prafulla Wadaskar


> -Original Message-
> From: Michael Walle [mailto:mich...@walle.cc]
> Sent: 05 June 2012 16:39
> To: Prafulla Wadaskar
> Cc: u-boot@lists.denx.de; Joe Hershberger
> Subject: Re: [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board
> support
> 
> 
> Hi Prafulla,
> 
> do you have any additional comments? With both net patches acked by
> Joe, i
> guess its ready to be merged with your tree. Should i post another
> patch
> version with the ACK added to the second net patch?

No, I think those are ready to merge, I will pull them soon

Hi Joe,
What do you think?

Regards..
Prafulla . . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v8 0/4] Kirkwood: add lschlv2 and lsxhl board support

2012-06-05 Thread Michael Walle

Hi Prafulla,

do you have any additional comments? With both net patches acked by Joe, i
guess its ready to be merged with your tree. Should i post another patch
version with the ACK added to the second net patch?

-- 
michael

On Fri, June 1, 2012 22:39, Michael Walle wrote:
> Changes:
> v8:
>  - revert CONFIG_RAND to old CONFIG_RANDOM_MACADDR
>  - the features CONFIG_BOOTP_RANDOM_DELAY and CONFIG_CMD_LINK_LOCAL pulls
>rand.o implicitly now as suggested by Joe Hershberger
>  - remove reset_phy() from board code. Thanks Luka Perkov for pointing
>this out
>  - dont derive the seed from the timer in seed_mac()
>
> v7:
>  - rebase to new master
>  - new function rand_r()
>  - lib/rand.c is now selected by CONFIG_RAND, because it is used by three
>features (CONFIG_BOOTP_RANDOM_DELAY, CONFIG_RANDOM_MACADDR and
>CONFIG_CMD_LINK_LOCAL)
>  - new patch: use the common rand() functions as a replacement for
>net_rand.c. This will fix the confliction function declarations, too.
>
> v6:
>  - remove dead code in Makefile
>  - use eth_{g,s}etenv_enetaddr() instead of
>eth_{g,s}etenv_enetaddr_by_index() since index is always 0
>
> v5:
>  - combine patchset again. the "net: *" patches should be individually
>acked by net custodian
>  - make features configurable at compile time (CONFIG_RANDOM_MACADDR and
>CONFIG_SETENV_ENETADDR_BY_INDEX)
>  - remove unused variable in boards/buffalo/lsxl.c
>  - fix potential compiler warning "too many arguments for format"
>  - new patch which fixes eth_getenv_enetaddr_by_index() and eth_mac_skip()
>  - change initial seed of rand() to 1
>  - enable CONFIG_API and CONFIG_CMD_ELF for lsxl boards
>
> v4:
>  - typo fixes (thanks Mike)
>  - seed all 46bits of the generated ethernet address (suggested by Mike)
>  - split patchset (generic net helpers and lsxl support)
>  - fix typo in bootcmd_hdd
>  - removed board/buffalo/lsxl/config.mk patch from patchset
>
> v3:
>  - add "Kirkwood:" prefix to patch subject
>  - moved board/buffalo/lsxl/config.mk to an own patch, so it can be
>separately acked/naked ;)
>  - removed any hardcoding, that is the mac address is now automatically
>generated (random, locally administered) and the IP settings are
>fetched with DHCP/BOOTP.
>  - add detailed comments to every configuration line in kwbimage.cfg
>  - add comments in MPP configuration about GPIO usage
>  - removed lschlv2 ramboot
>  - use short board ident string
>  - small cleanups
>
> v2:
>  - add to buffalo vendor directory instead of Marvell
>  - add both boards to MAINTAINERS
>  - don't define values for feature macros
>  - use tab for vertical alignment
>  - remove static network configuration, instead introduce a rescue mode
>  - add some convenience scripts
>  - small cleanups
>
> Michael Walle (4):
>   lib: add rand() function
>   net: use common rand()/srand() functions
>   net: add helper to generate random mac address
>   Kirkwood: add lschlv2 and lsxhl board support
>
>  MAINTAINERS   |5 +
>  board/buffalo/lsxl/Makefile   |   44 +
>  board/buffalo/lsxl/kwbimage-lschl.cfg |  229 ++
>  board/buffalo/lsxl/kwbimage-lsxhl.cfg |  229 ++
>  board/buffalo/lsxl/lsxl.c |  283
> +
>  board/buffalo/lsxl/lsxl.h |   75 +
>  boards.cfg|2 +
>  include/common.h  |   10 ++
>  include/configs/lsxl.h|  182 +
>  include/net.h |   17 ++
>  lib/Makefile  |5 +-
>  lib/rand.c|   48 ++
>  net/Makefile  |2 -
>  net/eth.c |   22 +++
>  net/link_local.c  |7 +-
>  net/net_rand.c|   68 
>  net/net_rand.h|   31 +++-
>  17 files changed, 1178 insertions(+), 81 deletions(-)
>  create mode 100644 board/buffalo/lsxl/Makefile
>  create mode 100644 board/buffalo/lsxl/kwbimage-lschl.cfg
>  create mode 100644 board/buffalo/lsxl/kwbimage-lsxhl.cfg
>  create mode 100644 board/buffalo/lsxl/lsxl.c
>  create mode 100644 board/buffalo/lsxl/lsxl.h
>  create mode 100644 include/configs/lsxl.h
>  create mode 100644 lib/rand.c
>  delete mode 100644 net/net_rand.c
>


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot