Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Nov 28, 2019 at 11:17:36AM +0100, Marek Vasut wrote:

> The following changes since commit 9a0cbae22a613dfd55e15565785749b74c19fdf0:
> 
>   Merge tag 'u-boot-rockchip-20191124' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip (2019-11-23
> 20:50:11 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to dbcbdad92caf4b42a6279da6e65180532bc45620:
> 
>   sandbox: enable USB_KEYBOARD_FN_KEYS (2019-11-25 13:28:53 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Nov 22, 2019 at 01:39:05PM +0100, Marek Vasut wrote:

> The following changes since commit d4a31e8ee5592072d8d5208b3e950cba2d89b6bd:
> 
>   Prepare v2020.01-rc3 (2019-11-18 21:31:49 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 7dc0ac6015718f5fb66bb79bf53df19f64fbfeee:
> 
>   usb: dwc2: fix possible alignment issues (2019-11-22 01:25:40 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Nov 08, 2019 at 11:25:42AM +0100, Marek Vasut wrote:

> The following changes since commit 0f282c1876af26cc2c8c018ae6293a691561011e:
> 
>   Makefile: fix dependency for imx targets (2019-11-06 09:22:32 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to e0891bb679200a8cc73c3b3d98ba40c02c31b850:
> 
>   usb: xhci: support 1.1 or later version (2019-11-08 11:09:08 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Nov 06, 2019 at 11:49:05AM +0100, Marek Vasut wrote:

> The following changes since commit 412326d1bc2d346d7b4faad6fa547eaf065681a2:
> 
>   Merge tag 'u-boot-clk-23Oct2019' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-clk (2019-10-30 13:13:46
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 02b0e1a36c5bc20174299312556ec4e266872bd6:
> 
>   usb: ehci-hcd: Keep async schedule running (2019-10-31 12:13:40 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Oct 25, 2019 at 01:19:04PM +0200, Marek Vasut wrote:

> The following changes since commit 680023c5fab6b1777c0c6f2e76e5d2effb7903a0:
> 
>   Merge tag 'u-boot-stm32-2019-10-23' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-10-23 14:04:02
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 235f5e158e336371759f98ffbf265fe078cda251:
> 
>   ehci-mx6: Update EHCI driver to support OTG0 on i.MX7ULP (2019-10-24
> 15:31:13 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Igor Opaniuk]

Hi Tom,

On Thu, Oct 24, 2019 at 2:24 PM Tom Rini  wrote:
>
> On Thu, Oct 24, 2019 at 12:22:25PM +0300, Igor Opaniuk wrote:
> > Hi Tom,
> >
> > On Wed, Oct 23, 2019 at 10:36 PM Marek Vasut  wrote:
> > >
> > > On 10/23/19 9:26 PM, Tom Rini wrote:
> > > > On Sun, Oct 20, 2019 at 05:08:37PM +0200, Marek Vasut wrote:
> > > >
> > > >> The following changes since commit 
> > > >> 6891152a4596d38ac25d2fe1238e3b6a938554b8:
> > > >>
> > > >>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-10-14
> > > >> 21:00:10 -0400)
> > > >>
> > > >> are available in the Git repository at:
> > > >>
> > > >>   git://git.denx.de/u-boot-usb.git master
> > > >>
> > > >> for you to fetch changes up to 
> > > >> 79b03816cb7d17ce717cbeb2d1c69836a0adef1e:
> > > >>
> > > >>   dm: test: usb: rework keyboard test (2019-10-15 13:12:09 +0200)
> > > >>
> > > >
> > > > Two problems.  First (and I was going to fix this myself, it's not too
> > > > hard) is that the DWC3 series is once again out of date with new
> > > > platforms added since posting, this time khadas-vim3 and sei610.
> > >
> > > Lovely, CCing Jean again ...
> > >
> > > > But the second and bigger problem is that (I assume) the mx6 patch makes
> > > > tbs2910 now exceed the binary size limit and fail to link.
> >
> > Could you please provide steps to reproduce (or just point to CI build log).
> > I've tried building both u-boot-usb tree and u-boot with all changes
> > from this PR
> > applied on top. In all cases everything is OK:
> >
> > $ make tbs2910_defconfig
> > $ make
> > #
> > # configuration written to .config
> > #
> > 
> >   OBJCOPY u-boot-nodtb.bin
> >   COPYu-boot.bin
> >   MKIMAGE u-boot.imx
> >   OBJCOPY u-boot.srec
> >   SYM u-boot.sym
> > = WARNING ==
> > This board does not use CONFIG_DM_VIDEO Please update
> > the board to use CONFIG_DM_VIDEO before the v2019.07 release.
> > Failure to update by the deadline may result in board removal.
> > See doc/driver-model/MIGRATION.txt for more info.
> > 
> > = WARNING ==
> > CONFIG_OF_EMBED is enabled. This option should only
> > be used for debugging purposes. Please use
> > CONFIG_OF_SEPARATE for boards in mainline.
> > See doc/README.fdt-control for more info.
> > 
> >   CFGCHK  u-boot.cfg
>
> What toolchain are you using?  Thanks!
It's gcc-arm-8.2-2019.01

>
> --
> Tom

After discussion with Marek in IRC, found out that
this issue is definitely toolchain dependent .

I've managed to reproduce this with buildman (and gcc-7.3.0, which is
fetched by default)

$ ./tools/buildman/buildman --board=tbs2910
boards.cfg is up to date. Nothing to do.
Building current source for 1 boards (1 thread, 8 jobs per thread)
   arm:  +   tbs2910
+u-boot.imx exceeds file size limit:
+/bin/sh: 1: printf: bytes: expected numeric value
+  limit:  00x5fc00 bytes
+  actual: 0x60c00 bytes
+  excess: 0x1000 bytes
+make[1]: *** [u-boot.imx] Error 1
+make[1]: *** Deleting file 'u-boot.imx'
+make: *** [sub-make] Error 2
001 /1  tbs2910

Thanks

-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opan...@gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Oct 24, 2019 at 12:22:25PM +0300, Igor Opaniuk wrote:
> Hi Tom,
> 
> On Wed, Oct 23, 2019 at 10:36 PM Marek Vasut  wrote:
> >
> > On 10/23/19 9:26 PM, Tom Rini wrote:
> > > On Sun, Oct 20, 2019 at 05:08:37PM +0200, Marek Vasut wrote:
> > >
> > >> The following changes since commit 
> > >> 6891152a4596d38ac25d2fe1238e3b6a938554b8:
> > >>
> > >>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-10-14
> > >> 21:00:10 -0400)
> > >>
> > >> are available in the Git repository at:
> > >>
> > >>   git://git.denx.de/u-boot-usb.git master
> > >>
> > >> for you to fetch changes up to 79b03816cb7d17ce717cbeb2d1c69836a0adef1e:
> > >>
> > >>   dm: test: usb: rework keyboard test (2019-10-15 13:12:09 +0200)
> > >>
> > >
> > > Two problems.  First (and I was going to fix this myself, it's not too
> > > hard) is that the DWC3 series is once again out of date with new
> > > platforms added since posting, this time khadas-vim3 and sei610.
> >
> > Lovely, CCing Jean again ...
> >
> > > But the second and bigger problem is that (I assume) the mx6 patch makes
> > > tbs2910 now exceed the binary size limit and fail to link.
> 
> Could you please provide steps to reproduce (or just point to CI build log).
> I've tried building both u-boot-usb tree and u-boot with all changes
> from this PR
> applied on top. In all cases everything is OK:
> 
> $ make tbs2910_defconfig
> $ make
> #
> # configuration written to .config
> #
> 
>   OBJCOPY u-boot-nodtb.bin
>   COPYu-boot.bin
>   MKIMAGE u-boot.imx
>   OBJCOPY u-boot.srec
>   SYM u-boot.sym
> = WARNING ==
> This board does not use CONFIG_DM_VIDEO Please update
> the board to use CONFIG_DM_VIDEO before the v2019.07 release.
> Failure to update by the deadline may result in board removal.
> See doc/driver-model/MIGRATION.txt for more info.
> 
> = WARNING ==
> CONFIG_OF_EMBED is enabled. This option should only
> be used for debugging purposes. Please use
> CONFIG_OF_SEPARATE for boards in mainline.
> See doc/README.fdt-control for more info.
> 
>   CFGCHK  u-boot.cfg

What toolchain are you using?  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Igor Opaniuk]

Hi Tom,

On Wed, Oct 23, 2019 at 10:36 PM Marek Vasut  wrote:
>
> On 10/23/19 9:26 PM, Tom Rini wrote:
> > On Sun, Oct 20, 2019 at 05:08:37PM +0200, Marek Vasut wrote:
> >
> >> The following changes since commit 
> >> 6891152a4596d38ac25d2fe1238e3b6a938554b8:
> >>
> >>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-10-14
> >> 21:00:10 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://git.denx.de/u-boot-usb.git master
> >>
> >> for you to fetch changes up to 79b03816cb7d17ce717cbeb2d1c69836a0adef1e:
> >>
> >>   dm: test: usb: rework keyboard test (2019-10-15 13:12:09 +0200)
> >>
> >
> > Two problems.  First (and I was going to fix this myself, it's not too
> > hard) is that the DWC3 series is once again out of date with new
> > platforms added since posting, this time khadas-vim3 and sei610.
>
> Lovely, CCing Jean again ...
>
> > But the second and bigger problem is that (I assume) the mx6 patch makes
> > tbs2910 now exceed the binary size limit and fail to link.

Could you please provide steps to reproduce (or just point to CI build log).
I've tried building both u-boot-usb tree and u-boot with all changes
from this PR
applied on top. In all cases everything is OK:

$ make tbs2910_defconfig
$ make
#
# configuration written to .config
#

  OBJCOPY u-boot-nodtb.bin
  COPYu-boot.bin
  MKIMAGE u-boot.imx
  OBJCOPY u-boot.srec
  SYM u-boot.sym
= WARNING ==
This board does not use CONFIG_DM_VIDEO Please update
the board to use CONFIG_DM_VIDEO before the v2019.07 release.
Failure to update by the deadline may result in board removal.
See doc/driver-model/MIGRATION.txt for more info.

= WARNING ==
CONFIG_OF_EMBED is enabled. This option should only
be used for debugging purposes. Please use
CONFIG_OF_SEPARATE for boards in mainline.
See doc/README.fdt-control for more info.

  CFGCHK  u-boot.cfg

>
> And Igor ...
>
> --
> Best regards,
> Marek Vasut



-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opan...@gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 10/23/19 9:26 PM, Tom Rini wrote:
> On Sun, Oct 20, 2019 at 05:08:37PM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 6891152a4596d38ac25d2fe1238e3b6a938554b8:
>>
>>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-10-14
>> 21:00:10 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to 79b03816cb7d17ce717cbeb2d1c69836a0adef1e:
>>
>>   dm: test: usb: rework keyboard test (2019-10-15 13:12:09 +0200)
>>
> 
> Two problems.  First (and I was going to fix this myself, it's not too
> hard) is that the DWC3 series is once again out of date with new
> platforms added since posting, this time khadas-vim3 and sei610.

Lovely, CCing Jean again ...

> But the second and bigger problem is that (I assume) the mx6 patch makes
> tbs2910 now exceed the binary size limit and fail to link.

And Igor ...

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Oct 20, 2019 at 05:08:37PM +0200, Marek Vasut wrote:

> The following changes since commit 6891152a4596d38ac25d2fe1238e3b6a938554b8:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-10-14
> 21:00:10 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 79b03816cb7d17ce717cbeb2d1c69836a0adef1e:
> 
>   dm: test: usb: rework keyboard test (2019-10-15 13:12:09 +0200)
> 

Two problems.  First (and I was going to fix this myself, it's not too
hard) is that the DWC3 series is once again out of date with new
platforms added since posting, this time khadas-vim3 and sei610.

But the second and bigger problem is that (I assume) the mx6 patch makes
tbs2910 now exceed the binary size limit and fail to link.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 10/15/19 6:59 PM, Jean-Jacques Hiblot wrote:
> 
> On 15/10/2019 11:36, Jean-Jacques Hiblot wrote:
>> Hi Marek,
>>
>> On 15/10/2019 03:01, Marek Vasut wrote:
>>> On 10/15/19 2:59 AM, Tom Rini wrote:
 On Tue, Oct 15, 2019 at 01:34:57AM +0200, Marek Vasut wrote:

> The following changes since commit
> 44fb0d6c9f5147a41c710032869e5e01b3c9e310:
>
>    Merge tag 'xilinx-for-v2020.01' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze (2019-10-09
> 16:22:03 -0400)
>
> are available in the Git repository at:
>
>    git://git.denx.de/u-boot-usb.git master
>
> for you to fetch changes up to
> 3cf0f7a8d485e4bf969628f5658e075084b2f013:
>
>    usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs (2019-10-12
> 13:07:32
> +0200)
>
 NAK.  From: https://gitlab.denx.de/u-boot/u-boot/-/jobs/19870
 sei510 rock64-rk3328 u200 odroid-n2 fail due to:
 +drivers/usb/gadget/udc/built-in.o: In function
 `usb_gadget_register_driver':
 +drivers/usb/gadget/udc/udc-core.c:325: multiple definition of
 `usb_gadget_register_driver'
 +drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:238: first
 defined here
 +drivers/usb/gadget/udc/built-in.o: In function
 `usb_gadget_unregister_driver':
 +drivers/usb/gadget/udc/udc-core.c:334: multiple definition of
 `usb_gadget_unregister_driver'
 +drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:287: first
 defined here
>>> Sigh, +CC Jean.
>>
>> Looks like v3 has been merged instead of the latest v4 which has the
>> changes in defconfig to prevent this.
>>
>> v4: https://patchwork.ozlabs.org/project/uboot/list/?series=130132
>>
>> v3:
>> https://patchwork.ozlabs.org/project/uboot/list/?series=116460=*
>>
>> Changes in v4:
>> - removed patches already merged (DWC3 fixes)
>> - update more defconfigs (u200, sei510, rock64-rk332 and odroid-n2)
>> - Fix the test of the USB_DWC3_GADGET option. IS_ENABLED() requires the
>>   whole option name including the 'CONFIG_' prefix
>>
>> JJ
> 
> 
> Travis build with v4 rebased on top of u-boot-usb/master (minus the v3
> patches): https://travis-ci.org/jjhiblot/u-boot/jobs/598065745

I loaded the V4 into travis too, thanks.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Jean-Jacques Hiblot]

On 15/10/2019 11:36, Jean-Jacques Hiblot wrote:

Hi Marek,

On 15/10/2019 03:01, Marek Vasut wrote:

On 10/15/19 2:59 AM, Tom Rini wrote:

On Tue, Oct 15, 2019 at 01:34:57AM +0200, Marek Vasut wrote:

The following changes since commit 
44fb0d6c9f5147a41c710032869e5e01b3c9e310:


   Merge tag 'xilinx-for-v2020.01' of
https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze (2019-10-09
16:22:03 -0400)

are available in the Git repository at:

   git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to 
3cf0f7a8d485e4bf969628f5658e075084b2f013:


   usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs (2019-10-12 
13:07:32

+0200)


NAK.  From: https://gitlab.denx.de/u-boot/u-boot/-/jobs/19870
sei510 rock64-rk3328 u200 odroid-n2 fail due to:
+drivers/usb/gadget/udc/built-in.o: In function 
`usb_gadget_register_driver':
+drivers/usb/gadget/udc/udc-core.c:325: multiple definition of 
`usb_gadget_register_driver'
+drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:238: 
first defined here
+drivers/usb/gadget/udc/built-in.o: In function 
`usb_gadget_unregister_driver':
+drivers/usb/gadget/udc/udc-core.c:334: multiple definition of 
`usb_gadget_unregister_driver'
+drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:287: 
first defined here

Sigh, +CC Jean.


Looks like v3 has been merged instead of the latest v4 which has the 
changes in defconfig to prevent this.


v4: https://patchwork.ozlabs.org/project/uboot/list/?series=130132

v3: https://patchwork.ozlabs.org/project/uboot/list/?series=116460=*

Changes in v4:
- removed patches already merged (DWC3 fixes)
- update more defconfigs (u200, sei510, rock64-rk332 and odroid-n2)
- Fix the test of the USB_DWC3_GADGET option. IS_ENABLED() requires the
  whole option name including the 'CONFIG_' prefix

JJ



Travis build with v4 rebased on top of u-boot-usb/master (minus the v3 
patches): https://travis-ci.org/jjhiblot/u-boot/jobs/598065745







___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Jean-Jacques Hiblot]

Hi Marek,

On 15/10/2019 03:01, Marek Vasut wrote:

On 10/15/19 2:59 AM, Tom Rini wrote:

On Tue, Oct 15, 2019 at 01:34:57AM +0200, Marek Vasut wrote:


The following changes since commit 44fb0d6c9f5147a41c710032869e5e01b3c9e310:

   Merge tag 'xilinx-for-v2020.01' of
https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze (2019-10-09
16:22:03 -0400)

are available in the Git repository at:

   git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to 3cf0f7a8d485e4bf969628f5658e075084b2f013:

   usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs (2019-10-12 13:07:32
+0200)


NAK.  From: https://gitlab.denx.de/u-boot/u-boot/-/jobs/19870
sei510 rock64-rk3328 u200 odroid-n2 fail due to:
+drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_register_driver':
+drivers/usb/gadget/udc/udc-core.c:325: multiple definition of 
`usb_gadget_register_driver'
+drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:238: first 
defined here
+drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_unregister_driver':
+drivers/usb/gadget/udc/udc-core.c:334: multiple definition of 
`usb_gadget_unregister_driver'
+drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:287: first 
defined here

Sigh, +CC Jean.


Looks like v3 has been merged instead of the latest v4 which has the 
changes in defconfig to prevent this.


v4: https://patchwork.ozlabs.org/project/uboot/list/?series=130132

v3: https://patchwork.ozlabs.org/project/uboot/list/?series=116460=*

Changes in v4:
- removed patches already merged (DWC3 fixes)
- update more defconfigs (u200, sei510, rock64-rk332 and odroid-n2)
- Fix the test of the USB_DWC3_GADGET option. IS_ENABLED() requires the
  whole option name including the 'CONFIG_' prefix

JJ




___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 10/15/19 2:59 AM, Tom Rini wrote:
> On Tue, Oct 15, 2019 at 01:34:57AM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 44fb0d6c9f5147a41c710032869e5e01b3c9e310:
>>
>>   Merge tag 'xilinx-for-v2020.01' of
>> https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze (2019-10-09
>> 16:22:03 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to 3cf0f7a8d485e4bf969628f5658e075084b2f013:
>>
>>   usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs (2019-10-12 13:07:32
>> +0200)
>>
> 
> NAK.  From: https://gitlab.denx.de/u-boot/u-boot/-/jobs/19870
> sei510 rock64-rk3328 u200 odroid-n2 fail due to:
> +drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_register_driver':
> +drivers/usb/gadget/udc/udc-core.c:325: multiple definition of 
> `usb_gadget_register_driver'
> +drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:238: first 
> defined here
> +drivers/usb/gadget/udc/built-in.o: In function 
> `usb_gadget_unregister_driver':
> +drivers/usb/gadget/udc/udc-core.c:334: multiple definition of 
> `usb_gadget_unregister_driver'
> +drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:287: first 
> defined here

Sigh, +CC Jean.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Oct 15, 2019 at 01:34:57AM +0200, Marek Vasut wrote:

> The following changes since commit 44fb0d6c9f5147a41c710032869e5e01b3c9e310:
> 
>   Merge tag 'xilinx-for-v2020.01' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze (2019-10-09
> 16:22:03 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 3cf0f7a8d485e4bf969628f5658e075084b2f013:
> 
>   usb: ehci-mx6: Fix bus enumeration for iMX7 SoCs (2019-10-12 13:07:32
> +0200)
> 

NAK.  From: https://gitlab.denx.de/u-boot/u-boot/-/jobs/19870
sei510 rock64-rk3328 u200 odroid-n2 fail due to:
+drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_register_driver':
+drivers/usb/gadget/udc/udc-core.c:325: multiple definition of 
`usb_gadget_register_driver'
+drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:238: first 
defined here
+drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_unregister_driver':
+drivers/usb/gadget/udc/udc-core.c:334: multiple definition of 
`usb_gadget_unregister_driver'
+drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:287: first 
defined here

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Sep 14, 2019 at 02:27:05PM +0200, Marek Vasut wrote:

> The following changes since commit 001c8ea94ae710d8340829237a7d788b25ce2ae7:
> 
>   Merge https://gitlab.denx.de/u-boot/custodians/u-boot-x86 (2019-09-10
> 08:52:00 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to e3e5825d0143c2b24583d256ef111ae9344382a2:
> 
>   usb: musb_hcd: fix compilation error (2019-09-11 10:11:39 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 8/31/19 9:40 PM, Tom Rini wrote:
> On Thu, Aug 29, 2019 at 02:08:05PM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 8c56ea5c1e033f16993e5427300399ef848234bb:
>>
>>   Merge branch 'u-boot-stm32_20190827' of
>> https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-08-27 13:19:47
>> -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to fd0637b814cdbc8aa9060f313f6c8e71fb9c5d15:
>>
>>   dwc2: use the nonblock argument in submit_int_msg (2019-08-29 14:07:26
>> +0200)
>>
> 
> NAK, this breaks nokia_rx51 and am3517_crane:
> +(nokia_rx51,am3517_crane) ../drivers/usb/musb/musb_hcd.c:1052:5: error: 
> conflicting types for 'submit_int_msg'
> +(nokia_rx51,am3517_crane)  int submit_int_msg(struct usb_device *dev, 
> unsigned long pipe,
> +(nokia_rx51,am3517_crane)  ^~
> +(nokia_rx51,am3517_crane) In file included from 
> ../drivers/usb/musb/musb_hcd.c:11:0:
> +(nokia_rx51,am3517_crane) ../include/usb.h:186:5: note: previous declaration 
> of 'submit_int_msg' was here
> +(nokia_rx51,am3517_crane)  int submit_int_msg(struct usb_device *dev, 
> unsigned long pipe, void *buffer,
> +(nokia_rx51,am3517_crane) make[2]: *** [../scripts/Makefile.build:279: 
> drivers/usb/musb/musb_hcd.o] Error 1
> +(nokia_rx51,am3517_crane) make[1]: *** [Makefile:1598: drivers/usb/musb] 
> Error 2
> +(nokia_rx51,am3517_crane) make: *** [Makefile:148: sub-make] Error 2

Aaargh! I am CCing the author of the patches ...
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Aug 29, 2019 at 02:08:05PM +0200, Marek Vasut wrote:

> The following changes since commit 8c56ea5c1e033f16993e5427300399ef848234bb:
> 
>   Merge branch 'u-boot-stm32_20190827' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-08-27 13:19:47
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to fd0637b814cdbc8aa9060f313f6c8e71fb9c5d15:
> 
>   dwc2: use the nonblock argument in submit_int_msg (2019-08-29 14:07:26
> +0200)
> 

NAK, this breaks nokia_rx51 and am3517_crane:
+(nokia_rx51,am3517_crane) ../drivers/usb/musb/musb_hcd.c:1052:5: error: 
conflicting types for 'submit_int_msg'
+(nokia_rx51,am3517_crane)  int submit_int_msg(struct usb_device *dev, unsigned 
long pipe,
+(nokia_rx51,am3517_crane)  ^~
+(nokia_rx51,am3517_crane) In file included from 
../drivers/usb/musb/musb_hcd.c:11:0:
+(nokia_rx51,am3517_crane) ../include/usb.h:186:5: note: previous declaration 
of 'submit_int_msg' was here
+(nokia_rx51,am3517_crane)  int submit_int_msg(struct usb_device *dev, unsigned 
long pipe, void *buffer,
+(nokia_rx51,am3517_crane) make[2]: *** [../scripts/Makefile.build:279: 
drivers/usb/musb/musb_hcd.o] Error 1
+(nokia_rx51,am3517_crane) make[1]: *** [Makefile:1598: drivers/usb/musb] Error 
2
+(nokia_rx51,am3517_crane) make: *** [Makefile:148: sub-make] Error 2

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Aug 10, 2019 at 03:33:44PM +0200, Marek Vasut wrote:

> The following changes since commit 2e8fef747bf773691d174b2b8120d7aa6c637bcf:
> 
>   test/py: avb: Move AVB test to android dir (2019-08-07 23:15:13 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 29a81142be960a07761f50ccae6cde766e3696d9:
> 
>   fastboot: Remove "bootloader-version" variable (2019-08-08 11:35:02 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Jul 06, 2019 at 08:27:30PM +0200, Marek Vasut wrote:

> The following changes since commit 1f83431f0053f6fb20c511c391ffc687433848cf:
> 
>   board: amlogic: add mailing-list to MAINTAINERS (2019-07-04 11:36:52
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 3b83829ed63fabe460592395571c1d8fd9b861c8:
> 
>   usb: dwc3: Use UCLASS_NOP instead of UCLASS_MISC for the DWC3 generic
> glue (2019-07-05 14:19:41 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Jun 14, 2019 at 12:45:47PM +0200, Marek Vasut wrote:

> Assorted gadget fixes.
> 
> The following changes since commit c2ea87883ef309570c8903e6de4b8b78685d73d0:
> 
>   Merge tag 'efi-2019-07-rc5' of git://git.denx.de/u-boot-efi
> (2019-06-12 07:15:38 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 220f655176de8e6aa4aaea91bb2182260d26c4a4:
> 
>   fastboot: Check if partition really exist in getvar_has_slot()
> (2019-06-14 12:39:54 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 6/18/19 1:42 PM, Sam Protsenko wrote:
> Hi Marek,
> 
> On Sat, Jun 15, 2019 at 6:16 PM Marek Vasut  wrote:
>>
>> On 6/15/19 4:24 PM, Eugeniu Rosca wrote:
>>> Hi Marek,
>>>
>>> On Sat, Jun 15, 2019 at 02:35:12PM +0200, Marek Vasut wrote:
 On 6/15/19 11:46 AM, Eugeniu Rosca wrote:
> Hello Marek, Lukasz cc: Sam
>
> On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
> [..]
>> Sam Protsenko (3):
>>   fastboot: Fix slot names reported by getvar
>
> Commit [1] from this PR got replaced by series [2].

 Replaced where ? [1] seems like a fix to me, [2] seems like feature
 addition ,
>>>
>>> Your instincts are correct (i.e. features must be rejected at this late
>>> stage) and they deserve credits. However and what seems extremely
>>> interesting is:
>>>  - it is very easy to masquerade a fix as a feature (and viceversa),
>>>just by slightly adjusting the title [1-2] and it's very easy to
>>>play with your perception this way
>>
>> Likely because free software development is built on trust. If there are
>> malicious actors who decide to not play nice, and even try to manipulate
>> others by elaborately crafting commit messages or otherwise, this might
>> work out to worm patches in. But at the end of the day, this helps no
>> one, so please refrain from such underhanded practices.
>>
> 
> I believe it's for maintainer to decide, which patches are ok to go to
> -rc, and which are not. We can always discuss that here in mailing
> list, if something is not clear.
> 
>>>  - it seems like there isn't a process (and this is a OSS-wide issue) of
>>>marking a patch as fix/feature (the latter would help the maintainer
>>>enormously)
>>
>> Maybe you can start a separate thread and help figure out such a
>> process? Complaining about unrelated stuff under random patches/PRs
>> won't make that happen, it will only happen if someone takes the
>> initiative. Scratching your own itch and all that.
>>
>>>  - it also appears that sometimes there is a fine line in our minds
>>>between what's a fix and what's a feature
>>>
>>> So, in a nutshell, series [2] is the v2 of commit [1].
>>> IMHO there is no feature added.
>>> The two commits from series [2] are:
>>>  - https://patchwork.ozlabs.org/patch/1116099/
>>>  - https://patchwork.ozlabs.org/patch/1116101/
>>
>> Seems this was not clearly marked as so.
>> I would suggest Sam sends a V3 on top of this PR and be done with it.
>>
> 
> Agreed. From my point of view, both V2 and V3 are simultaneously
> harmless *and* not required in this release. Just because there are no
> users for A/B slotted partitions in upstream U-Boot right now.
> 
> The only important fix to be included in release, is this patch-series:
> 
> [PATCH v3 0/3] fastboot: Fix getvar "has-slot" and cleanup
> 
> which actually fixes fastboot on non-slotted partitions (like on
> BeagleBoard X15), where right now we are unable to flash images.
> 
>>> What's interesting is that, depending on which version of fastboot
>>> utility users use/assume, they might see a "regression" introduced
>>> by [1-2]. Both [1-2] do changes to align U-Boot with latest fastboot
>>> utility from AOSP. What [2] is doing _in addition_ to [1] is:
>>>  - remove some dead code in U-Boot which will never be exercised
>>>assuming users run the latest fastboot
>>>  - place a bold warning in commit description that users are assumed to
>>>be using the latest fastboot utility
>>
>> If this can be fixed better, patches welcome.
>>
 so merging [1] this late in the release cycle seems like the
 right thing to do.
>>>
>>> My assumption is that Sam would like to see [1] being dropped in favor
>>> of [2], as commented in https://patchwork.ozlabs.org/patch/1114850/#2194140
>>
>> I will leave that up to Sam and Lukasz to figure this out.
>> However, I would prefer a V3 on top of this PR, that's easiest IMO.
>>
> 
> Let's make it so. I can send V3 later. Discussed patch ("fastboot: Fix
> slot names reported by getvar") is not crucial anyway, I guess.

Please do, the USB PR is now in.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Sam Protsenko]

Hi Marek,

On Sat, Jun 15, 2019 at 6:16 PM Marek Vasut  wrote:
>
> On 6/15/19 4:24 PM, Eugeniu Rosca wrote:
> > Hi Marek,
> >
> > On Sat, Jun 15, 2019 at 02:35:12PM +0200, Marek Vasut wrote:
> >> On 6/15/19 11:46 AM, Eugeniu Rosca wrote:
> >>> Hello Marek, Lukasz cc: Sam
> >>>
> >>> On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
> >>> [..]
>  Sam Protsenko (3):
>    fastboot: Fix slot names reported by getvar
> >>>
> >>> Commit [1] from this PR got replaced by series [2].
> >>
> >> Replaced where ? [1] seems like a fix to me, [2] seems like feature
> >> addition ,
> >
> > Your instincts are correct (i.e. features must be rejected at this late
> > stage) and they deserve credits. However and what seems extremely
> > interesting is:
> >  - it is very easy to masquerade a fix as a feature (and viceversa),
> >just by slightly adjusting the title [1-2] and it's very easy to
> >play with your perception this way
>
> Likely because free software development is built on trust. If there are
> malicious actors who decide to not play nice, and even try to manipulate
> others by elaborately crafting commit messages or otherwise, this might
> work out to worm patches in. But at the end of the day, this helps no
> one, so please refrain from such underhanded practices.
>

I believe it's for maintainer to decide, which patches are ok to go to
-rc, and which are not. We can always discuss that here in mailing
list, if something is not clear.

> >  - it seems like there isn't a process (and this is a OSS-wide issue) of
> >marking a patch as fix/feature (the latter would help the maintainer
> >enormously)
>
> Maybe you can start a separate thread and help figure out such a
> process? Complaining about unrelated stuff under random patches/PRs
> won't make that happen, it will only happen if someone takes the
> initiative. Scratching your own itch and all that.
>
> >  - it also appears that sometimes there is a fine line in our minds
> >between what's a fix and what's a feature
> >
> > So, in a nutshell, series [2] is the v2 of commit [1].
> > IMHO there is no feature added.
> > The two commits from series [2] are:
> >  - https://patchwork.ozlabs.org/patch/1116099/
> >  - https://patchwork.ozlabs.org/patch/1116101/
>
> Seems this was not clearly marked as so.
> I would suggest Sam sends a V3 on top of this PR and be done with it.
>

Agreed. From my point of view, both V2 and V3 are simultaneously
harmless *and* not required in this release. Just because there are no
users for A/B slotted partitions in upstream U-Boot right now.

The only important fix to be included in release, is this patch-series:

[PATCH v3 0/3] fastboot: Fix getvar "has-slot" and cleanup

which actually fixes fastboot on non-slotted partitions (like on
BeagleBoard X15), where right now we are unable to flash images.

> > What's interesting is that, depending on which version of fastboot
> > utility users use/assume, they might see a "regression" introduced
> > by [1-2]. Both [1-2] do changes to align U-Boot with latest fastboot
> > utility from AOSP. What [2] is doing _in addition_ to [1] is:
> >  - remove some dead code in U-Boot which will never be exercised
> >assuming users run the latest fastboot
> >  - place a bold warning in commit description that users are assumed to
> >be using the latest fastboot utility
>
> If this can be fixed better, patches welcome.
>
> >> so merging [1] this late in the release cycle seems like the
> >> right thing to do.
> >
> > My assumption is that Sam would like to see [1] being dropped in favor
> > of [2], as commented in https://patchwork.ozlabs.org/patch/1114850/#2194140
>
> I will leave that up to Sam and Lukasz to figure this out.
> However, I would prefer a V3 on top of this PR, that's easiest IMO.
>

Let's make it so. I can send V3 later. Discussed patch ("fastboot: Fix
slot names reported by getvar") is not crucial anyway, I guess.

Thanks!

> >>> [1] 
> >>> https://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=97a0c6ff577d57f162abc696c4efc962981229b1
> >>> [2] https://patchwork.ozlabs.org/cover/1116097/ ("fastboot: Support
> >>> new A/B slot format")
> >>>
> >
>
>
> --
> Best regards,
> Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Jun 15, 2019 at 04:43:38PM +0200, Marek Vasut wrote:
> On 6/15/19 4:24 PM, Eugeniu Rosca wrote:
> > Hi Marek,
> > 
> > On Sat, Jun 15, 2019 at 02:35:12PM +0200, Marek Vasut wrote:
> >> On 6/15/19 11:46 AM, Eugeniu Rosca wrote:
> >>> Hello Marek, Lukasz cc: Sam
> >>>
> >>> On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
> >>> [..]
>  Sam Protsenko (3):
>    fastboot: Fix slot names reported by getvar
> >>>
> >>> Commit [1] from this PR got replaced by series [2].
> >>
> >> Replaced where ? [1] seems like a fix to me, [2] seems like feature
> >> addition ,
> > 
> > Your instincts are correct (i.e. features must be rejected at this late
> > stage) and they deserve credits. However and what seems extremely
> > interesting is:
> >  - it is very easy to masquerade a fix as a feature (and viceversa),
> >just by slightly adjusting the title [1-2] and it's very easy to
> >play with your perception this way
> 
> Likely because free software development is built on trust. If there are
> malicious actors who decide to not play nice, and even try to manipulate
> others by elaborately crafting commit messages or otherwise, this might
> work out to worm patches in. But at the end of the day, this helps no
> one, so please refrain from such underhanded practices.

Yes, as a community we expect people to be clear and, well, plainly
spoken, perhaps is the best way to say it.  A bug fix is a bug fix and a
new feature is a new feature.

> >  - it seems like there isn't a process (and this is a OSS-wide issue) of
> >marking a patch as fix/feature (the latter would help the maintainer
> >enormously)
> 
> Maybe you can start a separate thread and help figure out such a
> process? Complaining about unrelated stuff under random patches/PRs
> won't make that happen, it will only happen if someone takes the
> initiative. Scratching your own itch and all that.
> 
> >  - it also appears that sometimes there is a fine line in our minds
> >between what's a fix and what's a feature
> > 
> > So, in a nutshell, series [2] is the v2 of commit [1].
> > IMHO there is no feature added.
> > The two commits from series [2] are:
> >  - https://patchwork.ozlabs.org/patch/1116099/
> >  - https://patchwork.ozlabs.org/patch/1116101/
> 
> Seems this was not clearly marked as so.
> I would suggest Sam sends a V3 on top of this PR and be done with it.

Agreed.

> > What's interesting is that, depending on which version of fastboot
> > utility users use/assume, they might see a "regression" introduced
> > by [1-2]. Both [1-2] do changes to align U-Boot with latest fastboot
> > utility from AOSP. What [2] is doing _in addition_ to [1] is:
> >  - remove some dead code in U-Boot which will never be exercised
> >assuming users run the latest fastboot
> >  - place a bold warning in commit description that users are assumed to
> >be using the latest fastboot utility
> 
> If this can be fixed better, patches welcome.
> 
> >> so merging [1] this late in the release cycle seems like the
> >> right thing to do.
> > 
> > My assumption is that Sam would like to see [1] being dropped in favor
> > of [2], as commented in https://patchwork.ozlabs.org/patch/1114850/#2194140
> 
> I will leave that up to Sam and Lukasz to figure this out.
> However, I would prefer a V3 on top of this PR, that's easiest IMO.

Agreed.  Thanks all!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 6/15/19 4:24 PM, Eugeniu Rosca wrote:
> Hi Marek,
> 
> On Sat, Jun 15, 2019 at 02:35:12PM +0200, Marek Vasut wrote:
>> On 6/15/19 11:46 AM, Eugeniu Rosca wrote:
>>> Hello Marek, Lukasz cc: Sam
>>>
>>> On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
>>> [..]
 Sam Protsenko (3):
   fastboot: Fix slot names reported by getvar
>>>
>>> Commit [1] from this PR got replaced by series [2].
>>
>> Replaced where ? [1] seems like a fix to me, [2] seems like feature
>> addition ,
> 
> Your instincts are correct (i.e. features must be rejected at this late
> stage) and they deserve credits. However and what seems extremely
> interesting is:
>  - it is very easy to masquerade a fix as a feature (and viceversa),
>just by slightly adjusting the title [1-2] and it's very easy to
>play with your perception this way

Likely because free software development is built on trust. If there are
malicious actors who decide to not play nice, and even try to manipulate
others by elaborately crafting commit messages or otherwise, this might
work out to worm patches in. But at the end of the day, this helps no
one, so please refrain from such underhanded practices.

>  - it seems like there isn't a process (and this is a OSS-wide issue) of
>marking a patch as fix/feature (the latter would help the maintainer
>enormously)

Maybe you can start a separate thread and help figure out such a
process? Complaining about unrelated stuff under random patches/PRs
won't make that happen, it will only happen if someone takes the
initiative. Scratching your own itch and all that.

>  - it also appears that sometimes there is a fine line in our minds
>between what's a fix and what's a feature
> 
> So, in a nutshell, series [2] is the v2 of commit [1].
> IMHO there is no feature added.
> The two commits from series [2] are:
>  - https://patchwork.ozlabs.org/patch/1116099/
>  - https://patchwork.ozlabs.org/patch/1116101/

Seems this was not clearly marked as so.
I would suggest Sam sends a V3 on top of this PR and be done with it.

> What's interesting is that, depending on which version of fastboot
> utility users use/assume, they might see a "regression" introduced
> by [1-2]. Both [1-2] do changes to align U-Boot with latest fastboot
> utility from AOSP. What [2] is doing _in addition_ to [1] is:
>  - remove some dead code in U-Boot which will never be exercised
>assuming users run the latest fastboot
>  - place a bold warning in commit description that users are assumed to
>be using the latest fastboot utility

If this can be fixed better, patches welcome.

>> so merging [1] this late in the release cycle seems like the
>> right thing to do.
> 
> My assumption is that Sam would like to see [1] being dropped in favor
> of [2], as commented in https://patchwork.ozlabs.org/patch/1114850/#2194140

I will leave that up to Sam and Lukasz to figure this out.
However, I would prefer a V3 on top of this PR, that's easiest IMO.

>>> [1] 
>>> https://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=97a0c6ff577d57f162abc696c4efc962981229b1
>>> [2] https://patchwork.ozlabs.org/cover/1116097/ ("fastboot: Support
>>> new A/B slot format")
>>>
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Eugeniu Rosca]

Hi Marek,

On Sat, Jun 15, 2019 at 02:35:12PM +0200, Marek Vasut wrote:
> On 6/15/19 11:46 AM, Eugeniu Rosca wrote:
> > Hello Marek, Lukasz cc: Sam
> > 
> > On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
> > [..]
> >> Sam Protsenko (3):
> >>   fastboot: Fix slot names reported by getvar
> > 
> > Commit [1] from this PR got replaced by series [2].
> 
> Replaced where ? [1] seems like a fix to me, [2] seems like feature
> addition ,

Your instincts are correct (i.e. features must be rejected at this late
stage) and they deserve credits. However and what seems extremely
interesting is:
 - it is very easy to masquerade a fix as a feature (and viceversa),
   just by slightly adjusting the title [1-2] and it's very easy to
   play with your perception this way
 - it seems like there isn't a process (and this is a OSS-wide issue) of
   marking a patch as fix/feature (the latter would help the maintainer
   enormously)
 - it also appears that sometimes there is a fine line in our minds
   between what's a fix and what's a feature

So, in a nutshell, series [2] is the v2 of commit [1].
IMHO there is no feature added.
The two commits from series [2] are:
 - https://patchwork.ozlabs.org/patch/1116099/
 - https://patchwork.ozlabs.org/patch/1116101/

What's interesting is that, depending on which version of fastboot
utility users use/assume, they might see a "regression" introduced
by [1-2]. Both [1-2] do changes to align U-Boot with latest fastboot
utility from AOSP. What [2] is doing _in addition_ to [1] is:
 - remove some dead code in U-Boot which will never be exercised
   assuming users run the latest fastboot
 - place a bold warning in commit description that users are assumed to
   be using the latest fastboot utility

> so merging [1] this late in the release cycle seems like the
> right thing to do.

My assumption is that Sam would like to see [1] being dropped in favor
of [2], as commented in https://patchwork.ozlabs.org/patch/1114850/#2194140

> > 
> > [1] 
> > https://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=97a0c6ff577d57f162abc696c4efc962981229b1
> > [2] https://patchwork.ozlabs.org/cover/1116097/ ("fastboot: Support
> > new A/B slot format")
> >

-- 
Best regards,
Eugeniu
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 6/15/19 11:46 AM, Eugeniu Rosca wrote:
> Hello Marek, Lukasz cc: Sam
> 
> On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
> [..]
>> Sam Protsenko (3):
>>   fastboot: Fix slot names reported by getvar
> 
> Commit [1] from this PR got replaced by series [2].

Replaced where ? [1] seems like a fix to me, [2] seems like feature
addition , so merging [1] this late in the release cycle seems like the
right thing to do.

> If this PR is merged as-is, the benefit of the new series will be lost
> and the series will need rework (since it overlaps with [1]).
> Ideally [2] should replace commit [1]. Is this feasible and do you
> have any suggestions how to achieve this? TIA.
> 
> [1] 
> https://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=97a0c6ff577d57f162abc696c4efc962981229b1
> [2] https://patchwork.ozlabs.org/cover/1116097/ ("fastboot: Support
> new A/B slot format")
> 
> Thanks,
> Eugeniu,
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Eugeniu Rosca]

Hello Marek, Lukasz cc: Sam

On Sat, Jun 15, 2019 at 5:23 AM Marek Vasut  wrote:
[..]
> Sam Protsenko (3):
>   fastboot: Fix slot names reported by getvar

Commit [1] from this PR got replaced by series [2].
If this PR is merged as-is, the benefit of the new series will be lost
and the series will need rework (since it overlaps with [1]).
Ideally [2] should replace commit [1]. Is this feasible and do you
have any suggestions how to achieve this? TIA.

[1] 
https://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=97a0c6ff577d57f162abc696c4efc962981229b1
[2] https://patchwork.ozlabs.org/cover/1116097/ ("fastboot: Support
new A/B slot format")

Thanks,
Eugeniu,
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, May 03, 2019 at 05:15:30PM +0200, Marek Vasut wrote:

> The following changes since commit b4ee6daad7a2604ca9466b2ba48de86cc27d381f:
> 
>   Merge tag 'u-boot-imx-20190426' of git://git.denx.de/u-boot-imx
> (2019-05-01 07:25:51 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to ff83e4c368f0155617e813d275d88192f05131e1:
> 
>   ARM: davinci: Remove unused functions from header (2019-05-03 17:14:49
> +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Apr 21, 2019 at 09:39:25PM +0200, Marek Vasut wrote:

> The following changes since commit 1f4ae66eaab29bfb5d1eb44996f7826c9cd01ed1:
> 
>   Merge tag 'arc-for-2019.07' of git://git.denx.de/u-boot-arc
> (2019-04-18 12:12:16 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 7fd9f31c6bd13609da61b985cf8f5f65ebebd913:
> 
>   usb: dwc2: fix gadget disconnect (2019-04-21 10:26:52 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Apr 10, 2019 at 04:45:43PM +0200, Marek Vasut wrote:

> The following changes since commit 3c99166441bf3ea325af2da83cfe65430b49c066:
> 
>   Prepare v2019.04 (2019-04-08 21:40:40 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 69535b33bc1fce43dcc10b646cf44db81cffa131:
> 
>   usb: ehci-mx6: Use common code to extract dr_mode (2019-04-09 13:11:45
> +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Apr 03, 2019 at 01:48:46PM +0200, Marek Vasut wrote:

> The following changes since commit bcd40c347d2c983625065ec70e9e9e1f98b42baf:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-04-01
> 12:31:22 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 2a766db11a7e3129db0c893a43661ed7ee944c55:
> 
>   doc: Fix outdated ohci board hook documentation (2019-04-02 12:52:54
> +0200)
> 

Applied (a while ago, but I don't see my own email) to u-boot/master,
thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Mon, Mar 18, 2019 at 04:08:18AM +0100, Marek Vasut wrote:

> The following changes since commit 9659eb46af6249b6e4b3712e60a1eb2e87fc48a1:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-samsung (2019-03-14
> 11:37:11 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to f402d268e8e17e9d6d1d9bf8a8b1f6e0b07718ef:
> 
>   fastboot: common: fix default fastboot_boot on 64-bit (2019-03-16
> 13:29:43 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Jan 11, 2019 at 03:51:17PM +0100, Marek Vasut wrote:

> UDC fixes below, this is for coming 2019.01 release.
> There's a lot of churn, however most are just renames.
> 
> The following changes since commit 54707a942009fae083dd78b58ff057127ba0e900:
> 
>   Prepare v2019.01-rc3 (2019-01-07 22:58:17 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to b3c518a88278619b1e109de114c450237d03e032:
> 
>   dm: usb: gadget: Fix boot breakage on sunxi platforms (2019-01-10
> 18:53:03 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Dec 15, 2018 at 07:31:44PM +0100, Marek Vasut wrote:

> As much as I hate sending so many patches after RC, apparently this is
> second half of USB gadget DM conversion, so be it.
> 
> The following changes since commit d117d8f19b0625f88309e47a8a32c2faa384dddc:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-i2c (2018-12-13
> 09:36:55 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 46a3f276549f3e5720b6e80278cda354c7fa859f:
> 
>   usb: musb-new: sunxi: Fix null pointer access (2018-12-14 17:59:10 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Mon, Dec 10, 2018 at 05:51:36AM +0100, Marek Vasut wrote:

> DWC3 and UDC cleanup
> 
> The following changes since commit 57dbc151437b36cc1105857d222df28b095236d7:
> 
>   rockchip: rk3399: Add MAINTAINERS entry (2018-12-06 10:24:12 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 532ededd5cbff3d55e8c8e5b6377cec9e90f2152:
> 
>   board: ti: am57xx: remove USB platform code (2018-12-07 16:31:46 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Nov 28, 2018 at 01:21:53PM +0100, Marek Vasut wrote:
> On 11/28/2018 01:20 PM, Tom Rini wrote:
> > On Wed, Nov 28, 2018 at 11:54:26AM +0100, Marek Vasut wrote:
> >> On 11/28/2018 04:09 AM, Tom Rini wrote:
> >>> On Tue, Nov 27, 2018 at 06:40:30PM +0100, Marek Vasut wrote:
> >>>
>  The following changes since commit 
>  6b21502229035779059493b2193fd790448fe85e:
> 
>    Merge branch '2018-11-25-master-imports' (2018-11-26 12:40:22 -0500)
> >>>
> >>> In the future, can you please include a short summary here if not using
> >>> a signed tag?  Thanks!
> >>
> >> Summary of what ?
> > 
> > The contents of your pull request.  Like in this case I did:
> > 
> > - Introduce CONFIG_SPL_DM_USB
> 
> Isn't that what the patch listing is for ?

No, it's not always as clear to me what's in every PR as it is for the
person assembling the PR.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 11/28/2018 01:20 PM, Tom Rini wrote:
> On Wed, Nov 28, 2018 at 11:54:26AM +0100, Marek Vasut wrote:
>> On 11/28/2018 04:09 AM, Tom Rini wrote:
>>> On Tue, Nov 27, 2018 at 06:40:30PM +0100, Marek Vasut wrote:
>>>
 The following changes since commit 
 6b21502229035779059493b2193fd790448fe85e:

   Merge branch '2018-11-25-master-imports' (2018-11-26 12:40:22 -0500)
>>>
>>> In the future, can you please include a short summary here if not using
>>> a signed tag?  Thanks!
>>
>> Summary of what ?
> 
> The contents of your pull request.  Like in this case I did:
> 
> - Introduce CONFIG_SPL_DM_USB

Isn't that what the patch listing is for ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Nov 28, 2018 at 11:54:26AM +0100, Marek Vasut wrote:
> On 11/28/2018 04:09 AM, Tom Rini wrote:
> > On Tue, Nov 27, 2018 at 06:40:30PM +0100, Marek Vasut wrote:
> > 
> >> The following changes since commit 
> >> 6b21502229035779059493b2193fd790448fe85e:
> >>
> >>   Merge branch '2018-11-25-master-imports' (2018-11-26 12:40:22 -0500)
> > 
> > In the future, can you please include a short summary here if not using
> > a signed tag?  Thanks!
> 
> Summary of what ?

The contents of your pull request.  Like in this case I did:

- Introduce CONFIG_SPL_DM_USB

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 11/28/2018 04:09 AM, Tom Rini wrote:
> On Tue, Nov 27, 2018 at 06:40:30PM +0100, Marek Vasut wrote:
> 
>> The following changes since commit 6b21502229035779059493b2193fd790448fe85e:
>>
>>   Merge branch '2018-11-25-master-imports' (2018-11-26 12:40:22 -0500)
> 
> In the future, can you please include a short summary here if not using
> a signed tag?  Thanks!

Summary of what ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Nov 27, 2018 at 06:40:30PM +0100, Marek Vasut wrote:

> The following changes since commit 6b21502229035779059493b2193fd790448fe85e:
> 
>   Merge branch '2018-11-25-master-imports' (2018-11-26 12:40:22 -0500)

In the future, can you please include a short summary here if not using
a signed tag?  Thanks!

> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 1af9bfd334a5c92cb3123be7c8da3ba0f522cf4a:
> 
>   usb: storage: s/CONFIG_BLK/CONFIG_IS_ENABLED(BLK)/ (2018-11-26
> 21:19:04 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Sep 15, 2018 at 9:13 PM, Marek Vasut  wrote:

> The following changes since commit ecb10a41c9adf2c499c3d19fff96a0
> 8bb9ad2aef:
>
>   Revert "ARM: da850evm_direct_nor_defconfig: Enable DM_SERIAL"
> (2018-09-14 13:52:15 -0400)
>
> are available in the Git repository at:
>
>   git://git.denx.de/u-boot-usb.git master
>
> for you to fetch changes up to 5c349e179db794eff99dd5d3bbac6845d173709e:
>
>   usb: ehci-generic: Add vbus-supply regulator support (2018-09-15
> 03:17:43 +0200)
>
> 
> Patrice Chotard (1):
>   usb: ehci-generic: Add vbus-supply regulator support
>
>  drivers/usb/host/ehci-generic.c | 62
> +-
>  1 file changed, 61 insertions(+), 1 deletion(-)
>

Applied to u-boot/master, thanks!

-- 
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Aug 30, 2018 at 03:35:19PM +0200, Marek Vasut wrote:

> The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437:
> 
>   configs: am57xx: change default board name to beagle_x15 (2018-08-26
> 12:26:16 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 88c34b8da62cfb4188ff9a59acb32f88ce9ed1b0:
> 
>   usb: dwc2: Add reset ctrl to driver (2018-08-29 03:10:30 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Aug 24, 2018 at 08:21:46PM +0200, Marek Vasut wrote:

> The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931:
> 
>   Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 49c752c93a785b9bad9d3fbbd52a76bec003eac5:
> 
>   cmd: Add bind/unbind commands to bind a device to a driver from the
> command line (2018-08-21 16:21:37 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Aug 09, 2018 at 09:29:58AM +0200, Marek Vasut wrote:

> The following changes since commit b1aad8dbe28415695b290726199681ced969c118:
> 
>   zynqmp: Add avnet_ultra96_rev1_defconfig to the lits of boards
> (2018-08-07 11:36:39 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 28a5c88043c80a38040abde957fbe1755b796912:
> 
>   dfu: Provide more verbose error message (2018-08-08 22:22:08 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 07/27/2018 01:39 PM, Tom Rini wrote:
> On Fri, Jul 27, 2018 at 11:59:32AM +0200, Lukasz Majewski wrote:
>> On Thu, 26 Jul 2018 23:14:01 +0200
>> Marek Vasut  wrote:
>>
>>> On 07/26/2018 11:08 PM, Lukasz Majewski wrote:
 On Thu, 26 Jul 2018 21:25:02 +0200
 Marek Vasut  wrote:
   
> On 07/26/2018 05:14 PM, Tom Rini wrote:  
>> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
>> 
>>> The following changes since commit
>>> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
>>>
>>>   mtd: nand: add new enum for storing ECC algorithm (2018-07-23
>>> 14:33:21 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.denx.de/u-boot-usb.git master
>>>
>>> for you to fetch changes up to
>>> 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
>>>
>>>   usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
>>>
>>
>> NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart
>> brppt1_spi brppt1_mmc am335x_evm brppt1_nand and stih410-b2260
>
> CCing the authors, I expect a patch.
>  

 Could you share how and where it breaks?

 I did standard Travis-CI build test on DFU PR.   
>>>
>>> I agree it'd be helpful if Tom shared more information than just
>>> "NAK", yes. Then again, did you try building one of those targets ?
>>>
>>
>> I did the Travis-CI run during the night of Marek's u-boot-usb branch.
> 
> When I pull -usb right now I see:
> Testing /tmp/am335x_hs_evm_uart
> Fri Jul 27 07:38:02 EDT 2018
> WARNING: no status info for 'pico-pi-imx7d'
> WARNING: no maintainers for 'pico-pi-imx7d'
> Building current source for 1 boards (1 thread, 16 jobs per thread)
>arm:  +   am335x_hs_evm_uart
> +(am335x_hs_evm_uart) drivers/usb/musb-new/ti-musb.c: In function 
> 'ti_musb_wrapper_bind':
> +(am335x_hs_evm_uart) drivers/usb/musb-new/ti-musb.c:221:29: error: 
> incompatible type for argument 1 of 'usb_get_dr_mode'
> +(am335x_hs_evm_uart)dr_mode = usb_get_dr_mode(node);
> +(am335x_hs_evm_uart)  ^~~~
> +(am335x_hs_evm_uart) In file included from 
> drivers/usb/musb-new/ti-musb.c:12:0:
> +(am335x_hs_evm_uart) include/linux/usb/otg.h:28:18: note: expected 'ofnode 
> {aka union ofnode_union}' but argument is of type 'int'
> +(am335x_hs_evm_uart)  enum usb_dr_mode usb_get_dr_mode(ofnode node);
> +(am335x_hs_evm_uart)   ^~~
> +(am335x_hs_evm_uart) make[2]: *** [drivers/usb/musb-new/ti-musb.o] Error 1
> +(am335x_hs_evm_uart) make[1]: *** [drivers/usb/musb-new] Error 2
> +(am335x_hs_evm_uart) make: *** [sub-make] Error 2
> 001 /1  am335x_hs_evm_uart
> 

Seems this is broken because of the patch from Vipul , and while we all
scramble to get this fixed, there is zero activity from Xilinx. So I'll
just drop that patch and resubmit the PR. It's a real disappointment...

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Patrice CHOTARD]

Hi

On 07/26/2018 05:14 PM, Tom Rini wrote:
> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
>>
>>mtd: nand: add new enum for storing ECC algorithm (2018-07-23 14:33:21
>> -0400)
>>
>> are available in the Git repository at:
>>
>>git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
>>
>>usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
>>
> 
> NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart brppt1_spi
> brppt1_mmc am335x_evm brppt1_nand and stih410-b2260

I can provide the fix for stih410-b2260.

Patrice

> 
> 
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Jul 27, 2018 at 11:59:32AM +0200, Lukasz Majewski wrote:
> On Thu, 26 Jul 2018 23:14:01 +0200
> Marek Vasut  wrote:
> 
> > On 07/26/2018 11:08 PM, Lukasz Majewski wrote:
> > > On Thu, 26 Jul 2018 21:25:02 +0200
> > > Marek Vasut  wrote:
> > >   
> > >> On 07/26/2018 05:14 PM, Tom Rini wrote:  
> > >>> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
> > >>> 
> >  The following changes since commit
> >  323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
> > 
> >    mtd: nand: add new enum for storing ECC algorithm (2018-07-23
> >  14:33:21 -0400)
> > 
> >  are available in the Git repository at:
> > 
> >    git://git.denx.de/u-boot-usb.git master
> > 
> >  for you to fetch changes up to
> >  67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
> > 
> >    usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
> > 
> > >>>
> > >>> NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart
> > >>> brppt1_spi brppt1_mmc am335x_evm brppt1_nand and stih410-b2260
> > >>
> > >> CCing the authors, I expect a patch.
> > >>  
> > > 
> > > Could you share how and where it breaks?
> > > 
> > > I did standard Travis-CI build test on DFU PR.   
> > 
> > I agree it'd be helpful if Tom shared more information than just
> > "NAK", yes. Then again, did you try building one of those targets ?
> > 
> 
> I did the Travis-CI run during the night of Marek's u-boot-usb branch.

When I pull -usb right now I see:
Testing /tmp/am335x_hs_evm_uart
Fri Jul 27 07:38:02 EDT 2018
WARNING: no status info for 'pico-pi-imx7d'
WARNING: no maintainers for 'pico-pi-imx7d'
Building current source for 1 boards (1 thread, 16 jobs per thread)
   arm:  +   am335x_hs_evm_uart
+(am335x_hs_evm_uart) drivers/usb/musb-new/ti-musb.c: In function 
'ti_musb_wrapper_bind':
+(am335x_hs_evm_uart) drivers/usb/musb-new/ti-musb.c:221:29: error: 
incompatible type for argument 1 of 'usb_get_dr_mode'
+(am335x_hs_evm_uart)dr_mode = usb_get_dr_mode(node);
+(am335x_hs_evm_uart)  ^~~~
+(am335x_hs_evm_uart) In file included from drivers/usb/musb-new/ti-musb.c:12:0:
+(am335x_hs_evm_uart) include/linux/usb/otg.h:28:18: note: expected 'ofnode 
{aka union ofnode_union}' but argument is of type 'int'
+(am335x_hs_evm_uart)  enum usb_dr_mode usb_get_dr_mode(ofnode node);
+(am335x_hs_evm_uart)   ^~~
+(am335x_hs_evm_uart) make[2]: *** [drivers/usb/musb-new/ti-musb.o] Error 1
+(am335x_hs_evm_uart) make[1]: *** [drivers/usb/musb-new] Error 2
+(am335x_hs_evm_uart) make: *** [sub-make] Error 2
001 /1  am335x_hs_evm_uart

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Lukasz Majewski]

On Thu, 26 Jul 2018 23:14:01 +0200
Marek Vasut  wrote:

> On 07/26/2018 11:08 PM, Lukasz Majewski wrote:
> > On Thu, 26 Jul 2018 21:25:02 +0200
> > Marek Vasut  wrote:
> >   
> >> On 07/26/2018 05:14 PM, Tom Rini wrote:  
> >>> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
> >>> 
>  The following changes since commit
>  323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
> 
>    mtd: nand: add new enum for storing ECC algorithm (2018-07-23
>  14:33:21 -0400)
> 
>  are available in the Git repository at:
> 
>    git://git.denx.de/u-boot-usb.git master
> 
>  for you to fetch changes up to
>  67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
> 
>    usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
> 
> >>>
> >>> NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart
> >>> brppt1_spi brppt1_mmc am335x_evm brppt1_nand and stih410-b2260
> >>
> >> CCing the authors, I expect a patch.
> >>  
> > 
> > Could you share how and where it breaks?
> > 
> > I did standard Travis-CI build test on DFU PR.   
> 
> I agree it'd be helpful if Tom shared more information than just
> "NAK", yes. Then again, did you try building one of those targets ?
> 

I did the Travis-CI run during the night of Marek's u-boot-usb branch.

https://travis-ci.org/lmajewski/u-boot-dfu/jobs/408692849

The problem seems now to be with x86 sandbox. However it seems not to
be related to USB:

Building current source for 29 boards (2 threads, 1 job per thread)
   x86:  +   theadorable-x86-conga-qa3-e3845
+Could not delete: No such file or directory
+mv: cannot stat ?board/congatec/conga-qeval20-qa3-e3845/dsdt.hex?: No
such file or directory +make[2]: ***
[board/congatec/conga-qeval20-qa3-e3845/dsdt.c] Error 1 +make[1]: ***
[board/congatec/conga-qeval20-qa3-e3845] Error 2


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de


pgpY1T2mie6Fq.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 07/26/2018 11:08 PM, Lukasz Majewski wrote:
> On Thu, 26 Jul 2018 21:25:02 +0200
> Marek Vasut  wrote:
> 
>> On 07/26/2018 05:14 PM, Tom Rini wrote:
>>> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
>>>   
 The following changes since commit
 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:

   mtd: nand: add new enum for storing ECC algorithm (2018-07-23
 14:33:21 -0400)

 are available in the Git repository at:

   git://git.denx.de/u-boot-usb.git master

 for you to fetch changes up to
 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:

   usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
  
>>>
>>> NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart
>>> brppt1_spi brppt1_mmc am335x_evm brppt1_nand and stih410-b2260  
>>
>> CCing the authors, I expect a patch.
>>
> 
> Could you share how and where it breaks?
> 
> I did standard Travis-CI build test on DFU PR. 

I agree it'd be helpful if Tom shared more information than just "NAK",
yes. Then again, did you try building one of those targets ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Lukasz Majewski]

On Thu, 26 Jul 2018 21:25:02 +0200
Marek Vasut  wrote:

> On 07/26/2018 05:14 PM, Tom Rini wrote:
> > On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
> >   
> >> The following changes since commit
> >> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
> >>
> >>   mtd: nand: add new enum for storing ECC algorithm (2018-07-23
> >> 14:33:21 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://git.denx.de/u-boot-usb.git master
> >>
> >> for you to fetch changes up to
> >> 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
> >>
> >>   usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
> >>  
> > 
> > NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart
> > brppt1_spi brppt1_mmc am335x_evm brppt1_nand and stih410-b2260  
> 
> CCing the authors, I expect a patch.
> 

Could you share how and where it breaks?

I did standard Travis-CI build test on DFU PR. 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de


pgplsr2cpYViT.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 07/26/2018 05:14 PM, Tom Rini wrote:
> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
>>
>>   mtd: nand: add new enum for storing ECC algorithm (2018-07-23 14:33:21
>> -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
>>
>>   usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
>>
> 
> NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart brppt1_spi
> brppt1_mmc am335x_evm brppt1_nand and stih410-b2260

CCing the authors, I expect a patch.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote:

> The following changes since commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
> 
>   mtd: nand: add new enum for storing ECC algorithm (2018-07-23 14:33:21
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7:
> 
>   usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200)
> 

NAK.  This breaks at least: am335x_hs_evm am335x_hs_evm_uart brppt1_spi
brppt1_mmc am335x_evm brppt1_nand and stih410-b2260

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Jul 06, 2018 at 02:41:54PM +0200, Marek Vasut wrote:

> The following changes since commit 4ac5df4b41ba46d7e635bdd8d500721c642b0a0d:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-07-03
> 23:09:34 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 0bc846a769d43810af9e4622473b85ffaead3dea:
> 
>   sunxi: A64: OHCI: prevent turning off shared USB clock (2018-07-05
> 11:25:50 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Jun 30, 2018 at 08:51:09AM +0200, Marek Vasut wrote:

> The following changes since commit fb77a9e3537039664ad42992bef6688869eda7c1:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-spi (2018-06-28
> 09:04:41 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 9c22aec4102de0f0dc35e21772d9f21d4616c3d2:
> 
>   usb: sunxi: Use proper reg_mask for clock gate, reset (2018-06-29
> 10:52:18 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Jun 16, 2018 at 02:12:30AM +0200, Marek Vasut wrote:

> The following changes since commit 7868909ed53ed41a945f7ed95ebb88aa252142ce:
> 
>   Merge git://git.denx.de/u-boot-fsl-qoriq (2018-06-12 13:25:24 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to b9f34757db5dcde9ccfa6ce35705b025bc4843fc:
> 
>   usb: sunxi: access ahb_reset0_cfg in CCM using its offset (2018-06-14
> 12:57:19 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, May 31, 2018 at 08:06:20PM +0200, Marek Vasut wrote:

> The following changes since commit c3c863880479edeb5b08226e622d13c91326e4a7:
> 
>   add FIT data-position & data-offset property support (2018-05-26
> 18:19:19 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 277b1333b780acd8ddb761c9160c06ffdf1c3901:
> 
>   fastboot: Update fastboot documentation (2018-05-30 11:59:21 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, May 20, 2018 at 12:06:00PM +0200, Marek Vasut wrote:

> The following changes since commit 233719cc40b5a00f37949d4173c190edcb4491a1:
> 
>   Merge git://www.denx.de/git/u-boot-marvell (2018-05-17 12:38:30 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 0ad3f771b69c0db837f40f6ffd5d41915fc07095:
> 
>   drivers: usb: dwc3: remove devm_zalloc from linux_compact (2018-05-18
> 13:37:02 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, May 03, 2018 at 01:50:23AM +0200, Marek Vasut wrote:

> The following changes since commit b25f8e2112b1582ce6386e846800a31bab688e50:
> 
>   Merge git://git.denx.de/u-boot-imx (2018-04-30 07:14:05 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 48cdfa2f8177dbdfc77c365c0f3f918ceadbe484:
> 
>   usb: f_mass_storage: simplify logical expression (2018-04-30 19:38:09
> +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Apr 27, 2018 at 01:12:14AM +0200, Marek Vasut wrote:

> The following changes since commit a61f9d1fbbca3c5e59b907ad3071db70ef174872:
> 
>   Merge git://git.denx.de/u-boot-spi (2018-04-25 20:50:28 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to d57ed4d9f2cb6abc9438104f321b4fe3bc829d57:
> 
>   usb: gadget: composite: fix NULL pointer when a non standard request
> is received (2018-04-26 15:15:07 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Apr 22, 2018 at 05:29:46AM +0200, Marek Vasut wrote:

> The following changes since commit a35747b5e1261adfb27ab87575dea4b17e247da2:
> 
>   Merge git://git.denx.de/u-boot-uniphier (2018-04-18 16:24:26 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 38276090ee7fda6b31cac638d8c5f4fb61f57b0b:
> 
>   usb: dwc3-of-simple: fix error check of clk_get_bulk when disabled
> (2018-04-21 18:38:56 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Apr 12, 2018 at 05:30:06AM +0200, Marek Vasut wrote:

> The following changes since commit c4446b1d6c96de406972690083e2884bf69bce5c:
> 
>   Merge git://git.denx.de/u-boot-ubi (2018-04-11 10:05:41 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 2960e27e3834ef2e6d506b21a582bd97ac18bbb0:
> 
>   phy: Add Amlogic Meson USB2 & USB3 Generic PHY drivers (2018-04-11
> 17:22:07 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Mon, Mar 19, 2018 at 06:13:55PM +0100, Marek Vasut wrote:

> The following changes since commit 6f6b7cfa89e5aa3b643196a4ccc8b1ba5d6fa7a4:
> 
>   Convert all of CONFIG_CONS_INDEX to Kconfig (2018-03-16 10:28:52 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to ac6c796c3f5c7b7594cf4ecede8cd8fb8d2611ba:
> 
>   usb: dwc2: Replace printf, pr_err by dev_info, dev_err (2018-03-17
> 03:23:09 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Feb 23, 2018 at 12:06:59AM +0100, Marek Vasut wrote:

> The following changes since commit f0f6917188ad660cf002c10095f46ecf748b8f58:
> 
>   Prepare v2018.03-rc3 (2018-02-20 16:51:56 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to b0cce3f90f546da0c1e0dda5abcaf05d81078b0d:
> 
>   cmd: fastboot: Kconfig: solve config issue (2018-02-21 20:28:15 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Fri, Feb 16, 2018 at 04:59:08PM +0100, Marek Vasut wrote:

> The following changes since commit 0c502b6c176281a096a23803e517b19e964485f1:
> 
>   configs: Resync with savedefconfig (2018-02-14 21:34:50 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to b16c129c2290d26e7b16b4309713c78f6146bc8a:
> 
>   usb: host: xhci-omap: Remove redundant board_usb_init and
> board_usb_cleanup functions (2018-02-15 13:44:30 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Jan 28, 2018 at 01:38:11PM +0100, Marek Vasut wrote:

> The following changes since commit
> 1a7f6d4597646662022f3e67ceaaeff7a23459e5:
>
>   Merge git://git.denx.de/u-boot-uniphier (2018-01-27 21:55:04 -0500)
>
> are available in the Git repository at:
>
>   git://git.denx.de/u-boot-usb.git master
>
> for you to fetch changes up to 40b61180c1b0fcfceb82e80fb03ce0e88b31e7ab:
>
>   usb: host: Drop unused hcd_name from r8a66597-hcd.c (2018-01-28
> 04:00:59 +0100)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Jan 27, 2018 at 08:38:19PM +0100, Marek Vasut wrote:

> The following changes since commit fb4413295c765aa8c013650984dc2d908964c81d:
> 
>   Merge git://git.denx.de/u-boot-mmc (2018-01-24 11:28:44 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 6f7c92db4c7d1e45503fb10e60caa1ec2bb18d10:
> 
>   usb: ehci: mxs: fix swapped argument in ehci_writel() (2018-01-25
> 20:59:20 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Jan 11, 2018 at 02:57:50AM +0100, Marek Vasut wrote:

> The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
> 
>   Prepare v2018.01 (2018-01-08 20:25:29 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to c3d098e762d3b064ad86e72babfbcaf188180d90:
> 
>   rockchip: rk3288: enable rockusb support on rk3288 based device
> (2018-01-10 11:11:06 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Dec 13, 2017 at 08:46:18AM +0100, Marek Vasut wrote:

> The following changes since commit 335f7b1290ce24a729a9689a1db834c743226ca8:
> 
>   Merge git://git.denx.de/u-boot-mpc85xx (2017-12-08 12:02:01 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 243fd6420d2275275b8267ead971a7dbd69b369f:
> 
>   usb: r8a66597: convert wait loop to readw_poll_timeout (2017-12-09
> 13:39:27 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Nov 28, 2017 at 08:32:53AM +0100, Marek Vasut wrote:

> The following changes since commit 93a51d301ad051ec6f8c6016862c7719b8b434d3:
> 
>   Merge git://git.denx.de/u-boot-arc (2017-11-24 11:45:15 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 11f4678962960636f1a07cea8d040f468463f8c3:
> 
>   usb: r8a66597: Add support for RZ/A series (2017-11-28 04:06:40 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Oct 01, 2017 at 08:41:36PM +0200, Marek Vasut wrote:

> The following changes since commit 6e9b109aa9bcdd094e77da9fb03de8b44da8eb9d:
> 
>   Merge git://git.denx.de/u-boot-usb (2017-09-27 09:39:48 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to dc04b35ef2c8c04cb362758ec46348ef3f15:
> 
>   usb: dwc3: add UniPhier specific glue layer (2017-10-01 16:32:55 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Sep 27, 2017 at 03:35:26PM +0200, Marek Vasut wrote:

> The following changes since commit 9241265f29f3670e380a9859a343ddc14873c46f:
> 
>   Merge git://www.denx.de/git/u-boot-cfi-flash (2017-09-26 19:38:04 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to a939af0c748e2ea1eeb8cf47fa9771a95786de70:
> 
>   usb: dwc2: Align size of invalidating dcache before starting DMA
> (2017-09-27 12:12:23 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

The following changes since commit 9241265f29f3670e380a9859a343ddc14873c46f:

  Merge git://www.denx.de/git/u-boot-cfi-flash (2017-09-26 19:38:04 -0400)

are available in the git repository at:

  git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to a939af0c748e2ea1eeb8cf47fa9771a95786de70:

  usb: dwc2: Align size of invalidating dcache before starting DMA
(2017-09-27 12:12:23 +0200)


Bin Meng (6):
  dm: usb: Add a new USB controller operation 'get_max_xfer_size'
  dm: usb: xhci: Implement get_max_xfer_size() operation
  dm: usb: ehci: Implement get_max_xfer_size() operation
  usb: storage: Refactor to use max_xfer_blk from struct us_data
  dm: usb: storage: Fix broken read/write when both EHCD and xHCD
are enabled
  usb: kbd: Set a default polling mechanism for USB keyboard



Marek Vasut (1):

  usb: xhci: Set number of event segments and entries to 1



Philipp Tomsich (3):
  rockchip: xhci: Convert to livetree
  usb: dwc2: convert to livetree
  usb: host: ehci-generic: convert to livetree

Seung-Woo Kim (1):
  usb: dwc2: Align size of invalidating dcache before starting DMA

 common/usb_storage.c   | 64
+---
 configs/Cyrus_P5020_defconfig  |  1 -
 configs/Cyrus_P5040_defconfig  |  1 -
 configs/MPC8610HPCD_defconfig  |  1 -
 configs/MPC8641HPCN_36BIT_defconfig|  1 -
 configs/MPC8641HPCN_defconfig  |  1 -
 configs/apalis_imx6_defconfig  |  1 -
 configs/apalis_imx6_nospl_com_defconfig|  1 -
 configs/apalis_imx6_nospl_it_defconfig |  1 -
 configs/colibri_imx6_defconfig |  1 -
 configs/colibri_imx6_nospl_defconfig   |  1 -
 configs/firefly-rk3288_defconfig   |  1 -
 configs/mx6cuboxi_defconfig|  1 -
 configs/rpi_2_defconfig|  1 -
 configs/rpi_3_32b_defconfig|  1 -
 configs/rpi_3_defconfig|  1 -
 configs/rpi_defconfig  |  1 -
 configs/sandbox_defconfig  |  1 -
 configs/sandbox_flattree_defconfig |  1 -
 configs/sandbox_noblk_defconfig|  1 -
 configs/sandbox_spl_defconfig  |  1 -
 configs/seaboard_defconfig |  1 -
 configs/ventana_defconfig  |  1 -
 drivers/usb/Kconfig|  2 +-
 drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |  3 ++-
 drivers/usb/host/dwc2.c|  2 +-
 drivers/usb/host/ehci-generic.c|  2 +-
 drivers/usb/host/ehci-hcd.c| 12 
 drivers/usb/host/usb-uclass.c  | 11 +++
 drivers/usb/host/xhci-rockchip.c   |  4 +---
 drivers/usb/host/xhci.c| 15 +++
 drivers/usb/host/xhci.h|  4 ++--
 include/usb.h  | 22 +-
 33 files changed, 112 insertions(+), 51 deletions(-)
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Mon, Sep 25, 2017 at 06:41:58PM +0200, Marek Vasut wrote:

> The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
> 
>   tools/mkimage: Make the path to the dtc binary that mkimage calls
> configurable (2017-09-24 07:33:03 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
> 
>   usb: dwc2: Align size of invalidating dcache before starting DMA
> (2017-09-24 18:45:56 +0200)
> 

This breaks building of vyasa-rk3288 and introduces a bunch of warnings
over stuff that's in Kconfig being re-added to config.h files.  And I
guess the rockusb stuff was applied oddly, all of the comments below the
'---' are in the commit message rather than discarded as usual.  Sorry,
thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Sep 26, 2017 at 07:10:21AM +0800, Bin Meng wrote:
> Hi Marek,
> 
> On Tue, Sep 26, 2017 at 12:41 AM, Marek Vasut  wrote:
> > The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
> >
> >   tools/mkimage: Make the path to the dtc binary that mkimage calls
> > configurable (2017-09-24 07:33:03 -0400)
> >
> > are available in the git repository at:
> >
> >   git://git.denx.de/u-boot-usb.git master
> >
> > for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
> >
> >   usb: dwc2: Align size of invalidating dcache before starting DMA
> > (2017-09-24 18:45:56 +0200)
> >
> > 
> > Bin Meng (6):
> >   dm: usb: Add a new USB controller operation 'get_max_xfer_size'
> >   dm: usb: xhci: Implement get_max_xfer_size() operation
> >   dm: usb: ehci: Implement get_max_xfer_size() operation
> >   usb: storage: Refactor to use max_xfer_blk from struct us_data
> >   dm: usb: storage: Fix broken read/write when both EHCD and xHCD
> > are enabled
> >   usb: kbd: Set a default polling mechanism for USB keyboard
> >
> 
> I see this new PR does not contain the xHCI updates while previous one
> had. Any reason to drop that?

Yes, these break some of the tests in test/py/ as seen by 'make tests',
thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Bin Meng]

Hi Marek,

On Tue, Sep 26, 2017 at 12:41 AM, Marek Vasut  wrote:
> The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
>
>   tools/mkimage: Make the path to the dtc binary that mkimage calls
> configurable (2017-09-24 07:33:03 -0400)
>
> are available in the git repository at:
>
>   git://git.denx.de/u-boot-usb.git master
>
> for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:
>
>   usb: dwc2: Align size of invalidating dcache before starting DMA
> (2017-09-24 18:45:56 +0200)
>
> 
> Bin Meng (6):
>   dm: usb: Add a new USB controller operation 'get_max_xfer_size'
>   dm: usb: xhci: Implement get_max_xfer_size() operation
>   dm: usb: ehci: Implement get_max_xfer_size() operation
>   usb: storage: Refactor to use max_xfer_blk from struct us_data
>   dm: usb: storage: Fix broken read/write when both EHCD and xHCD
> are enabled
>   usb: kbd: Set a default polling mechanism for USB keyboard
>

I see this new PR does not contain the xHCI updates while previous one
had. Any reason to drop that?

> Eddie Cai (4):
>   usb: rockchip: add the rockusb gadget
>   usb: rockchip: add rockusb command
>   rockchip:usb: add a simple readme for rockusb
>   rockchip: rk3288: enable rockusb support on rk3288 based device
>
> Marek Vasut (1):
>   usb: xhci: Set number of event segments and entries to 1
>
> Philipp Tomsich (3):
>   rockchip: xhci: Convert to livetree
>   usb: dwc2: convert to livetree
>   usb: host: ehci-generic: convert to livetree
>
> Seung-Woo Kim (1):
>   usb: dwc2: Align size of invalidating dcache before starting DMA
>

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:

  tools/mkimage: Make the path to the dtc binary that mkimage calls
configurable (2017-09-24 07:33:03 -0400)

are available in the git repository at:

  git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to 0184c6fb34b49f0bb1ffc7b0e35a597de339353e:

  usb: dwc2: Align size of invalidating dcache before starting DMA
(2017-09-24 18:45:56 +0200)


Bin Meng (6):
  dm: usb: Add a new USB controller operation 'get_max_xfer_size'
  dm: usb: xhci: Implement get_max_xfer_size() operation
  dm: usb: ehci: Implement get_max_xfer_size() operation
  usb: storage: Refactor to use max_xfer_blk from struct us_data
  dm: usb: storage: Fix broken read/write when both EHCD and xHCD
are enabled
  usb: kbd: Set a default polling mechanism for USB keyboard

Eddie Cai (4):
  usb: rockchip: add the rockusb gadget
  usb: rockchip: add rockusb command
  rockchip:usb: add a simple readme for rockusb
  rockchip: rk3288: enable rockusb support on rk3288 based device

Marek Vasut (1):
  usb: xhci: Set number of event segments and entries to 1

Philipp Tomsich (3):
  rockchip: xhci: Convert to livetree
  usb: dwc2: convert to livetree
  usb: host: ehci-generic: convert to livetree

Seung-Woo Kim (1):
  usb: dwc2: Align size of invalidating dcache before starting DMA

 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +
 arch/arm/mach-rockchip/Kconfig |   2 +
 cmd/Kconfig|   9 ++
 cmd/Makefile   |   1 +
 cmd/rockusb.c  |  74 ++
 common/usb_storage.c   |  64 ++---
 configs/Cyrus_P5020_defconfig  |   1 -
 configs/Cyrus_P5040_defconfig  |   1 -
 configs/MPC8610HPCD_defconfig  |   1 -
 configs/MPC8641HPCN_36BIT_defconfig|   1 -
 configs/MPC8641HPCN_defconfig  |   1 -
 configs/apalis_imx6_defconfig  |   1 -
 configs/apalis_imx6_nospl_com_defconfig|   1 -
 configs/apalis_imx6_nospl_it_defconfig |   1 -
 configs/chromebit_mickey_defconfig |   8 ++
 configs/chromebook_jerry_defconfig |   8 ++
 configs/chromebook_minnie_defconfig|   8 ++
 configs/colibri_imx6_defconfig |   1 -
 configs/colibri_imx6_nospl_defconfig   |   1 -
 configs/evb-rk3288_defconfig   |  10 ++
 configs/fennec-rk3288_defconfig|   6 +
 configs/firefly-rk3288_defconfig   |   7 +-
 configs/miqi-rk3288_defconfig  |   6 +
 configs/mx6cuboxi_defconfig|   1 -
 configs/phycore-rk3288_defconfig   |   7 +
 configs/popmetal-rk3288_defconfig  |   6 +
 configs/rock2_defconfig|   9 ++
 configs/rpi_2_defconfig|   1 -
 configs/rpi_3_32b_defconfig|   1 -
 configs/rpi_3_defconfig|   1 -
 configs/rpi_defconfig  |   1 -
 configs/sandbox_defconfig  |   1 -
 configs/sandbox_flattree_defconfig |   1 -
 configs/sandbox_noblk_defconfig|   1 -
 configs/sandbox_spl_defconfig  |   1 -
 configs/seaboard_defconfig |   1 -
 configs/tinker-rk3288_defconfig|   6 +
 configs/ventana_defconfig  |   1 -
 doc/README.rockusb |  51 +++
 drivers/usb/Kconfig|   2 +-
 drivers/usb/gadget/Kconfig |   8 ++
 drivers/usb/gadget/Makefile|   1 +
 drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |   3 +-
 drivers/usb/gadget/f_rockusb.c | 691
+
 drivers/usb/host/dwc2.c|   2 +-
 drivers/usb/host/ehci-generic.c|   2 +-
 drivers/usb/host/ehci-hcd.c|  12 ++
 drivers/usb/host/usb-uclass.c  |  11 ++
 drivers/usb/host/xhci-rockchip.c   |   4 +-
 drivers/usb/host/xhci.c|  15 ++
 drivers/usb/host/xhci.h|   4 +-
 include/configs/rk3288_common.h|  12 ++
 include/usb.h  |  22 ++-
 53 files changed, 1173 insertions(+), 51 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 cmd/rockusb.c
 create mode 100644 doc/README.rockusb
 create mode 100644 drivers/usb/gadget/f_rockusb.c
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 09/23/2017 07:39 PM, Tom Rini wrote:
> On Sat, Sep 23, 2017 at 07:32:31PM +0200, Marek Vasut wrote:
>> On 09/23/2017 06:11 PM, Tom Rini wrote:
>>> On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
>>>
 The following changes since commit 
 91ebf300934461e450f5ef8f386ea9e55d2636c5:

   Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)

 are available in the git repository at:

   git://git.denx.de/u-boot-usb.git master

 for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:

   usb: xhci: Set 'Average TRB Length' to 8 for control endpoints
 (2017-09-23 15:12:29 +0200)

>>>
>>> git bisect says that:
>>> commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3
>>> Author: Bin Meng 
>>> Date:   Mon Sep 18 06:40:37 2017 -0700
>>>
>>> dm: usb: Fix broken usb_stop()
>>>
>>> breaks 'make tests'.
>>
>> Unfortunately, for me the bisect points to:
>> commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a
>> Author: Tom Rini 
>> Date:   Fri Sep 15 13:15:25 2017 -0400
>>
>> Makefile: Update minimum dtc version to 1.4.3
>>
>> With support for overlays and calling the -@ flag to dtc we need to have
>> at least 1.4.3 available now.
>>
>> Cc: Simon Glass 
>> Reported-by: Stephen Warren 
>> Signed-off-by: Tom Rini 
>>
>> And it is broken on EVERY debian system, since every debian system ships
>> with DTC 1.4.2 or older:
>> https://packages.debian.org/search?keywords=device-tree-compiler
> 
> Please make sure that you submit your pull requests to travis-ci before
> sending them to me.  And I'm not trying to single you out here, we have
> a whole bunch of automated CI and I do get a little cranky when we hit
> problems that the tools catch.
> 
> And yes, sure, don't submit PRs you're absolutely sure won't have
> problems that CI would have caught (like the SoCFPGA one) or when you've
> locally run all of the relevant tests yourself.
> 
Clearly, travis does not catch "u-boot does not build for any debian
system" this time.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Sep 23, 2017 at 07:32:31PM +0200, Marek Vasut wrote:
> On 09/23/2017 06:11 PM, Tom Rini wrote:
> > On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
> > 
> >> The following changes since commit 
> >> 91ebf300934461e450f5ef8f386ea9e55d2636c5:
> >>
> >>   Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-usb.git master
> >>
> >> for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
> >>
> >>   usb: xhci: Set 'Average TRB Length' to 8 for control endpoints
> >> (2017-09-23 15:12:29 +0200)
> >>
> > 
> > git bisect says that:
> > commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3
> > Author: Bin Meng 
> > Date:   Mon Sep 18 06:40:37 2017 -0700
> > 
> > dm: usb: Fix broken usb_stop()
> > 
> > breaks 'make tests'.
> 
> Unfortunately, for me the bisect points to:
> commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a
> Author: Tom Rini 
> Date:   Fri Sep 15 13:15:25 2017 -0400
> 
> Makefile: Update minimum dtc version to 1.4.3
> 
> With support for overlays and calling the -@ flag to dtc we need to have
> at least 1.4.3 available now.
> 
> Cc: Simon Glass 
> Reported-by: Stephen Warren 
> Signed-off-by: Tom Rini 
> 
> And it is broken on EVERY debian system, since every debian system ships
> with DTC 1.4.2 or older:
> https://packages.debian.org/search?keywords=device-tree-compiler

Please make sure that you submit your pull requests to travis-ci before
sending them to me.  And I'm not trying to single you out here, we have
a whole bunch of automated CI and I do get a little cranky when we hit
problems that the tools catch.

And yes, sure, don't submit PRs you're absolutely sure won't have
problems that CI would have caught (like the SoCFPGA one) or when you've
locally run all of the relevant tests yourself.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 09/23/2017 06:11 PM, Tom Rini wrote:
> On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
>>
>>   Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
>>
>>   usb: xhci: Set 'Average TRB Length' to 8 for control endpoints
>> (2017-09-23 15:12:29 +0200)
>>
> 
> git bisect says that:
> commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3
> Author: Bin Meng 
> Date:   Mon Sep 18 06:40:37 2017 -0700
> 
> dm: usb: Fix broken usb_stop()
> 
> breaks 'make tests'.

Unfortunately, for me the bisect points to:
commit 2fa73e784da105419b7d9d07d8f9d4a79afe531a
Author: Tom Rini 
Date:   Fri Sep 15 13:15:25 2017 -0400

Makefile: Update minimum dtc version to 1.4.3

With support for overlays and calling the -@ flag to dtc we need to have
at least 1.4.3 available now.

Cc: Simon Glass 
Reported-by: Stephen Warren 
Signed-off-by: Tom Rini 

And it is broken on EVERY debian system, since every debian system ships
with DTC 1.4.2 or older:
https://packages.debian.org/search?keywords=device-tree-compiler

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Sep 23, 2017 at 03:14:20PM +0200, Marek Vasut wrote:

> The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5:
> 
>   Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 78787e28bbefad9d647fc9f7467893b8d2627481:
> 
>   usb: xhci: Set 'Average TRB Length' to 8 for control endpoints
> (2017-09-23 15:12:29 +0200)
> 

git bisect says that:
commit 5c45fbd38ecd6388f6d3ee1e07126b17d7e0c6b3
Author: Bin Meng 
Date:   Mon Sep 18 06:40:37 2017 -0700

dm: usb: Fix broken usb_stop()

breaks 'make tests'.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Mon, Aug 21, 2017 at 11:32:42AM +0200, Marek Vasut wrote:

> The following changes since commit 2d7cb5b426e7e0cdf684d7f8029ad132d7a8d383:
> 
>   env: Replace all open-coded gd->env_valid values with ENV_ flags
> (2017-08-20 19:27:44 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 5bf4475f1d7726541edec0060c6461fbb37db02d:
> 
>   doc: license: Add license header to the README.dfutftp file
> (2017-08-21 11:31:11 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Jul 29, 2017 at 05:26:45PM +0200, Marek Vasut wrote:

> The following changes since commit 26722335253a9fa384ceb423419254cb00d0def1:
> 
>   rockchip: puma-rk3399: remove duplicate code (merge artifact)
> (2017-07-27 14:59:04 +0200)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to b108d8a0de3ddc6fe8aae55bc54e3edc69b4778b:
> 
>   clk: fix compilation errors for poplar platform (2017-07-28 23:34:46
> +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Jun 18, 2017 at 09:46:39PM +0200, Marek Vasut wrote:

> The following changes since commit b9f7d8817424bb328d5eac9b16196a1189b8b6f5:
> 
>   powerpc, 5xx: remove some "5xx" remains (2017-06-16 10:14:56 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to b9203429a04402bd03c48fa87670686ef7e7891d:
> 
>   cmd: usb_mass_storage: Staticize do_usb_mass_storage() (2017-06-18
> 21:11:10 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Mon, May 22, 2017 at 11:49:04AM +0200, Marek Vasut wrote:

> The following changes since commit a375ff8e14bea0a5cbfff99d6456aa8d9a3320ab:
> 
>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2017-05-18
> 17:17:45 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 3426b2038cfb831d74ac0407fc7a04e990b44540:
> 
>   usb: ehci: Add Renesas RCar M3/H3 EHCI support (2017-05-22 11:47:27 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, May 18, 2017 at 11:32:47AM +0200, Marek Vasut wrote:

> The following changes since commit fa8967cfbaed5582ba987756fa9f0470a9affbf4:
> 
>   Merge git://git.denx.de/u-boot-uniphier (2017-05-17 14:13:58 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 9ad69f0ba45b1e1a95be04fcc2d7e143fa24627c:
> 
> 
>   usb: lpc32xx: add i2c DM support (2017-05-18 11:31:56 +0200)
> 
> 
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Apr 25, 2017 at 12:51:10PM +0200, Marek Vasut wrote:

> The following changes since commit 3c476d841daa491f87c8f07851038afbdf4d90a8:
> 
>   Merge git://git.denx.de/u-boot-fsl-qoriq (2017-04-18 11:36:06 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 83cb46c286beb5406aaed2e0d5895719717804b3:
> 
>   ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
> (2017-04-25 12:50:13 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Feb 26, 2017 at 05:51:19PM +0100, Marek Vasut wrote:

> Hi,
> 
> mostly DFU fixes for current release .
> 
> The following changes since commit b24cf8540a85a9bf97975aadd6a7542f166c78a3:
> 
>   video: mxsfb: Fix reset hang when videomode variable is not present
> (2017-02-22 21:47:59 +0100)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 9bf9e813584c23b677e92d8dca742ae9ef27fc94:
> 
>   usb: gadget: f_dfu: set serial number if serial# is valid (2017-02-26
> 13:24:30 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Jan 17, 2017 at 04:19:19PM +0100, Marek Vasut wrote:

> The following changes since commit 035ebf85b09cf11c820ae9eec414097420741abd:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-spi (2017-01-15
> 13:33:30 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 65c389d27902f6376bd057609b66b7339b219cf1:
> 
>   drivers: usb: gadget: ether: Fix compiler warning (2017-01-17 10:26:46
> +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Tue, Dec 06, 2016 at 05:54:19AM +0100, Marek Vasut wrote:

> The following changes since commit 3cfb67d0419c645998b440592d8c2ce010134b8e:
> 
>   Prepare v2017.01-rc1 (2016-12-05 18:36:23 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 555a347209000f8655ca637a5a04f7275a2fb999:
> 
>   usb: xhci-pci: Add DM support (2016-12-06 01:54:26 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Nov 03, 2016 at 11:57:12AM +0100, Marek Vasut wrote:

> The following changes since commit d8bdfc80da39211d95f10d24e79f2e867305f71b:
> 
>   Prepare v2016.11-rc3 (2016-10-31 16:36:10 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to dd93a8e9e688f4c448092a275bf7db3e16d21c6f:
> 
>   dfu: align array in dfu_get_dev_type with enum dfu_device_type
> (2016-11-03 11:55:25 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sat, Oct 29, 2016 at 08:00:57PM +0200, Marek Vasut wrote:

> The following changes since commit 5ac5861c4ba851b473e6a24940b412b397627d8d:
> 
>   travis-ci: Add test.py for various qemu platforms (2016-10-24 08:06:29
> -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 57faca19a82fc9b43a227824c30aeb76a43d1957:
> 
>   drivers: USB: OHCI: allow compilation for 64-bit targets (2016-10-29
> 19:45:40 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Wed, Sep 28, 2016 at 07:53:52PM +0200, Marek Vasut wrote:

> The following changes since commit cbe7706ab8aab06c18edaa9b120371f9c8012728:
> 
>   Merge git://git.denx.de/u-boot-fsl-qoriq (2016-09-26 17:10:56 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 4c043712e9910ef1d612aedbd8304a1f7348ef5f:
> 
>   drivers: usb: xhci-fsl: Implement Erratum A-010151 for FSL USB3
> controller (2016-09-27 23:30:49 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Aug 11, 2016 at 11:27:25AM +0200, Marek Vasut wrote:

> The following changes since commit 2863a9bfc29092be37f8beee230883367b057065:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2016-08-06 11:38:14 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 76b2fad775ee3cb58788b11454655ba5a244ac56:
> 
>   eth: asix88179: Add support for the driver model (2016-08-09 12:52:05
> +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

The following changes since commit 2863a9bfc29092be37f8beee230883367b057065:

  Merge git://git.denx.de/u-boot-rockchip (2016-08-06 11:38:14 -0400)

are available in the git repository at:

  git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to 76b2fad775ee3cb58788b11454655ba5a244ac56:

  eth: asix88179: Add support for the driver model (2016-08-09 12:52:05
+0200)


Alban Bedel (4):
  eth: asix88179: Add VID:DID for Cypress GX3 USB Ethernet Adapter
  eth: asix88179: Fix receiving on big endian system
  eth: asix88179: Prepare supporting the driver model
  eth: asix88179: Add support for the driver model

Masahiro Yamada (3):
  usb: add CONFIG_USB_OHCI_HCD in Kconfig
  usb: add CONFIG_USB_UHCI_HCD in Kconfig
  usb: add (move) CONFIG_USB_HOST to Kconfig

Peng Fan (1):
  dm: ehci-mx6: support driver model

Rajesh Bhagat (5):
  drivers: usb: fsl: Make function for initialization to use in
CONFIG_DM_USB
  usb: ehci: fsl: Add code to use CONFIG_DM_USB
  usb: xhci: fsl: Add code to use CONFIG_DM_USB
  dm: ls1021a: dts: Update USB 3.0 node to support DM USB
  arm: ls1021a: Enable CONFIG_DM_USB in defconfigs

Stefan Roese (1):
  net: usb: r8152: Add DM support

 arch/arm/dts/ls1021a.dtsi|   2 +-

 configs/axs103_defconfig |   1 +

 configs/ls1021aqds_ddr4_nor_defconfig|   1 +

 configs/ls1021aqds_ddr4_nor_lpuart_defconfig |   1 +

 configs/ls1021aqds_nor_defconfig |   1 +

 configs/ls1021aqds_nor_lpuart_defconfig  |   1 +

 drivers/usb/eth/asix88179.c  | 263
+---
 drivers/usb/eth/r8152.c  | 237
+++
 drivers/usb/eth/r8152.h  |   4 ++
 drivers/usb/eth/r8152_fw.c   |   2 +
 drivers/usb/host/Kconfig |  59 +
 drivers/usb/host/ehci-fsl.c  | 194
+---
 drivers/usb/host/ehci-mx6.c  | 144
+-
 drivers/usb/host/xhci-fsl.c  |  83
-
 include/configs/am43xx_evm.h |   1 -
 include/configs/am57xx_evm.h |   1 -
 include/configs/cm_t43.h |   1 -
 include/configs/cm_t54.h |   1 -
 include/configs/dra7xx_evm.h |   1 -
 include/configs/duovero.h|   1 -
 include/configs/omap4_panda.h|   1 -
 include/configs/omap5_uevm.h |   1 -
 22 files changed, 885 insertions(+), 116 deletions(-)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Masahiro Yamada]

2016-08-09 1:45 GMT+09:00 Marek Vasut :
> On 08/08/2016 06:42 PM, Tom Rini wrote:
>> On Sun, Aug 07, 2016 at 09:57:44PM +0200, Marek Vasut wrote:
>>
>>> The following changes since commit 2863a9bfc29092be37f8beee230883367b057065:
>>>
>>>   Merge git://git.denx.de/u-boot-rockchip (2016-08-06 11:38:14 -0400)
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.denx.de/u-boot-usb.git master
>>>
>>> for you to fetch changes up to 606120f99ec2baf3635b1c2545803348b6f550ab:
>>>
>>>   dm: atmel: Add driver model support for the ehci driver (2016-08-07
>>> 21:56:56 +0200)
>>>
>>
>> NAK:
>
> Dang, CCing the authors, I expect fixed patches. Both dropped for now.
>


Then, please send a new pull-req.




-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

On 08/08/2016 06:42 PM, Tom Rini wrote:
> On Sun, Aug 07, 2016 at 09:57:44PM +0200, Marek Vasut wrote:
> 
>> The following changes since commit 2863a9bfc29092be37f8beee230883367b057065:
>>
>>   Merge git://git.denx.de/u-boot-rockchip (2016-08-06 11:38:14 -0400)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-usb.git master
>>
>> for you to fetch changes up to 606120f99ec2baf3635b1c2545803348b6f550ab:
>>
>>   dm: atmel: Add driver model support for the ehci driver (2016-08-07
>> 21:56:56 +0200)
>>
> 
> NAK:

Dang, CCing the authors, I expect fixed patches. Both dropped for now.

> Adding in:
> commit eb769ac6556f230e30b196445556ba88890ccfd7
> Author: Alban Bedel 
> Date:   Wed Aug 3 08:14:42 2016 +0200
> 
> eth: asix88179: Prepare supporting the driver model
> 
> gives:
> +(snow) drivers/usb/eth/asix88179.c: In function 'ax88179_eth_get_info':
> +(snow) drivers/usb/eth/asix88179.c:725:6: error: too few arguments to 
> function 'asix_basic_reset'
> +(snow)   if (asix_basic_reset(ss))
> +(snow)   ^
> +(snow) drivers/usb/eth/asix88179.c:285:12: note: declared here
> +(snow)  static int asix_basic_reset(struct ueth_data *dev,
> +(snow) ^
> +(snow) make[2]: *** [drivers/usb/eth/asix88179.o] Error 1
> +(snow) make[1]: *** [drivers/usb/eth] Error 2
> +(snow) make: *** [sub-make] Error 2
> And adding in:
> commit 606120f99ec2baf3635b1c2545803348b6f550ab
> Author: Wenyou Yang 
> Date:   Fri Aug 5 08:57:35 2016 +0800
> 
> dm: atmel: Add driver model support for the ehci driver
> gives:
> +(sama5d2_xplained_mmc)  static int clk_get_by_name(struct udevice *dev, 
> const char *name,
> +(sama5d2_xplained_mmc) ^
> w+(sama5d2_xplained_mmc) In file included from 
> drivers/usb/host/ehci-atmel.c:10:0:
> w+(sama5d2_xplained_mmc) include/clk.h:107:12: warning: 'clk_get_by_name' 
> defined but not used [-Wunused-function]
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Sun, Aug 07, 2016 at 09:57:44PM +0200, Marek Vasut wrote:

> The following changes since commit 2863a9bfc29092be37f8beee230883367b057065:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2016-08-06 11:38:14 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 606120f99ec2baf3635b1c2545803348b6f550ab:
> 
>   dm: atmel: Add driver model support for the ehci driver (2016-08-07
> 21:56:56 +0200)
> 

NAK:
Adding in:
commit eb769ac6556f230e30b196445556ba88890ccfd7
Author: Alban Bedel 
Date:   Wed Aug 3 08:14:42 2016 +0200

eth: asix88179: Prepare supporting the driver model

gives:
+(snow) drivers/usb/eth/asix88179.c: In function 'ax88179_eth_get_info':
+(snow) drivers/usb/eth/asix88179.c:725:6: error: too few arguments to function 
'asix_basic_reset'
+(snow)   if (asix_basic_reset(ss))
+(snow)   ^
+(snow) drivers/usb/eth/asix88179.c:285:12: note: declared here
+(snow)  static int asix_basic_reset(struct ueth_data *dev,
+(snow) ^
+(snow) make[2]: *** [drivers/usb/eth/asix88179.o] Error 1
+(snow) make[1]: *** [drivers/usb/eth] Error 2
+(snow) make: *** [sub-make] Error 2
And adding in:
commit 606120f99ec2baf3635b1c2545803348b6f550ab
Author: Wenyou Yang 
Date:   Fri Aug 5 08:57:35 2016 +0800

dm: atmel: Add driver model support for the ehci driver
gives:
+(sama5d2_xplained_mmc)  static int clk_get_by_name(struct udevice *dev, const 
char *name,
+(sama5d2_xplained_mmc) ^
w+(sama5d2_xplained_mmc) In file included from 
drivers/usb/host/ehci-atmel.c:10:0:
w+(sama5d2_xplained_mmc) include/clk.h:107:12: warning: 'clk_get_by_name' 
defined but not used [-Wunused-function]

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Tom Rini]

On Thu, Jul 07, 2016 at 03:55:43PM +0200, Marek Vasut wrote:

> Hi Tom,
> 
> I added one more patch by York to fix the powerpc mess. Updated PR
> below, please pull for 2016.07 .
> 
> Thanks!
> 
> The following changes since commit e8009beff6d5c55c1bf1ae8184791f167e6378b0:
> 
>Merge git://git.denx.de/u-boot-arc (2016-07-04 11:46:21 -0400)
> 
> are available in the git repository at:
> 
>git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to eb364c3dc28d59d33e823470d07746b22a8e6fee:
> 
>powerpc: mpc85xx: kmp204x: Fix compiling error for usb errata
> (2016-07-07 13:34:10 +0200)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PULL] u-boot-usb/master

[Marek Vasut]

Hi Tom,

I added one more patch by York to fix the powerpc mess. Updated PR 
below, please pull for 2016.07 .


Thanks!

The following changes since commit e8009beff6d5c55c1bf1ae8184791f167e6378b0:

   Merge git://git.denx.de/u-boot-arc (2016-07-04 11:46:21 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to eb364c3dc28d59d33e823470d07746b22a8e6fee:

   powerpc: mpc85xx: kmp204x: Fix compiling error for usb errata 
(2016-07-07 13:34:10 +0200)



Hans de Goede (2):
   usb: dm: Add a usb_for_each_root_dev() helper function
   usb: dm: Make "usb info" use usb_for_each_root_dev()

Marek Vasut (1):
   powerpc: mpc85xx: Do not build errata command in SPL

York Sun (1):
   powerpc: mpc85xx: kmp204x: Fix compiling error for usb errata

  arch/powerpc/cpu/mpc85xx/Makefile   |  2 ++
  cmd/usb.c   | 46 
++

  include/configs/km/kmp204x-common.h |  1 +
  3 files changed, 21 insertions(+), 28 deletions(-)

--
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot