Re: [U-Boot] [Patch V3 4/4] [MIPS] Disable standalone while building MIPS64
2012/8/26 Zhi-zhou Zhang :
>
>
> On Fri, Aug 24, 2012 at 8:23 AM, Daniel Schwierzeck
> wrote:
>>
>> 2012/8/20 Zhizhou Zhang :
>> > I think copy mips.lds to mips64.lds with only one line changed is not
>> > good. So I disable it in top Makefile.
>> > Signed-off-by: Zhizhou Zhang
>> > ---
>> > Makefile |2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> > diff --git a/Makefile b/Makefile
>> > index 5ce5cc3..626d888 100644
>> > --- a/Makefile
>> > +++ b/Makefile
>> > @@ -155,8 +155,10 @@ sinclude $(obj)include/autoconf.mk.dep
>> > sinclude $(obj)include/autoconf.mk
>> >
>> > ifndef CONFIG_SANDBOX
>> > +ifndef CONFIG_MIPS64
>> > SUBDIRS += $(SUBDIR_EXAMPLES)
>> > endif
>> > +endif
>> >
>> > # load ARCH, BOARD, and CPU configuration
>> > include $(obj)include/config.mk
>> > --
>> > 1.7.9.5
>> >
>>
>> NAK.
>>
>> Please do what you have done in v1 of your patch series. This is possible
>> now
>> if you use current master of git://git.denx.de/u-boot-mips.git.
>>
>> --
>> Best regards,
>> Daniel
>
>
> when I add below in examples/standalone/mips.lds,
> #ifdef CONFIG_64BIT
> OUTPUT_FORMAT("elf64-tradbigmips", "elf64-tradbigmips",
> "elf64-tradlittlemips")
> #else
> OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips",
> "elf32-tradlittlemips")
> #endif
> I will get a error:
> /home/zhangzz/work/clfs/sys_root/cross-tools/bin/mips64el-unknown-linux-gnu-ld:mips.lds:27:
> ignoring invalid character `#' in expression
> /home/zhangzz/work/clfs/sys_root/cross-tools/bin/mips64el-unknown-linux-gnu-ld:mips.lds:27:
> syntax error
>
> So I find these in top Makefile:
> $(obj)u-boot.lds: $(LDSCRIPT)
> $(CPP) $(CPPFLAGS) $(LDPPFLAGS) -ansi -D__ASSEMBLY__ -P -
> <$^ >$@
> It seems that I can't make mips.lds configurable without a lot modifications
> in example/standalone/Makefile.
> So could you give a tip?
yes, in my previous comment I thought that mips.lds is also
preprocessed like u-boot.lds.
But sadly that is not the case. You have added a mips64.lds in your
first patch series.
I guess that was already the correct solution without changing
standalone/Makefile.
--
Best regards,
Daniel
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch V3 4/4] [MIPS] Disable standalone while building MIPS64
On Fri, Aug 24, 2012 at 8:23 AM, Daniel Schwierzeck <
daniel.schwierz...@gmail.com> wrote:
> 2012/8/20 Zhizhou Zhang :
> > I think copy mips.lds to mips64.lds with only one line changed is not
> > good. So I disable it in top Makefile.
> > Signed-off-by: Zhizhou Zhang
> > ---
> > Makefile |2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 5ce5cc3..626d888 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -155,8 +155,10 @@ sinclude $(obj)include/autoconf.mk.dep
> > sinclude $(obj)include/autoconf.mk
> >
> > ifndef CONFIG_SANDBOX
> > +ifndef CONFIG_MIPS64
> > SUBDIRS += $(SUBDIR_EXAMPLES)
> > endif
> > +endif
> >
> > # load ARCH, BOARD, and CPU configuration
> > include $(obj)include/config.mk
> > --
> > 1.7.9.5
> >
>
> NAK.
>
> Please do what you have done in v1 of your patch series. This is possible
> now
> if you use current master of git://git.denx.de/u-boot-mips.git.
>
> --
> Best regards,
> Daniel
>
when I add below in examples/standalone/mips.lds,
#ifdef CONFIG_64BIT
OUTPUT_FORMAT("elf64-tradbigmips", "elf64-tradbigmips",
"elf64-tradlittlemips")
#else
OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips",
"elf32-tradlittlemips")
#endif
I will get a error:
/home/zhangzz/work/clfs/sys_root/cross-tools/bin/mips64el-unknown-linux-gnu-ld:mips.lds:27:
ignoring invalid character `#' in expression
/home/zhangzz/work/clfs/sys_root/cross-tools/bin/mips64el-unknown-linux-gnu-ld:mips.lds:27:
syntax error
So I find these in top Makefile:
$(obj)u-boot.lds: $(LDSCRIPT)
$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -ansi -D__ASSEMBLY__ -P -
<$^ >$@
It seems that I can't make mips.lds configurable without a lot
modifications in example/standalone/Makefile.
So could you give a tip?
--
Regards,
Zhizhou Zhang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch V3 4/4] [MIPS] Disable standalone while building MIPS64
2012/8/20 Zhizhou Zhang : > I think copy mips.lds to mips64.lds with only one line changed is not > good. So I disable it in top Makefile. > Signed-off-by: Zhizhou Zhang > --- > Makefile |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 5ce5cc3..626d888 100644 > --- a/Makefile > +++ b/Makefile > @@ -155,8 +155,10 @@ sinclude $(obj)include/autoconf.mk.dep > sinclude $(obj)include/autoconf.mk > > ifndef CONFIG_SANDBOX > +ifndef CONFIG_MIPS64 > SUBDIRS += $(SUBDIR_EXAMPLES) > endif > +endif > > # load ARCH, BOARD, and CPU configuration > include $(obj)include/config.mk > -- > 1.7.9.5 > NAK. Please do what you have done in v1 of your patch series. This is possible now if you use current master of git://git.denx.de/u-boot-mips.git. -- Best regards, Daniel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
