Re: [U-Boot] [RFC PATCH] SPL: FIT: Enable SPL_FIT_LOAD in RAM based boot mode

[Simon Glass]

Hi Michal,

On 28 April 2016 at 02:43, Michal Simek  wrote:
> Support loading FIT in SPL for RAM bootmode.
> CONFIG_SPL_LOAD_FIT_ADRESS points to address where FIT image is stored
> in memory.
>
> Signed-off-by: Michal Simek 
> ---
>
> Not sure if solution with CONFIG_SPL_LOAD_FIT_ADDRESS is accepted.
> But it should be out of TEXT_BASE.
>
> ---
>  common/spl/spl.c | 44 +++-
>  1 file changed, 35 insertions(+), 9 deletions(-)
>

Reviewed-by: Simon Glass 

I suggest moving this all into a new spl_ram.c file.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH] SPL: FIT: Enable SPL_FIT_LOAD in RAM based boot mode

[Nicolae Rosia]

Hello Michal,

I have a minor comment.

On Thu, Apr 28, 2016 at 11:43 AM, Michal Simek  wrote:
> Support loading FIT in SPL for RAM bootmode.
> CONFIG_SPL_LOAD_FIT_ADRESS points to address where FIT image is stored
> in memory.
>
> Signed-off-by: Michal Simek 
> ---
>
[...]
> +   debug("%s: sector %lx, count %lx, buf %lx\n",
> + __func__, sector, count, (ulong)buf);
> +   memcpy(buf, (void *)(CONFIG_SPL_LOAD_FIT_ADRESS + sector), count);
s/CONFIG_SPL_LOAD_FIT_ADRESS/CONFIG_SPL_LOAD_FIT_ADDRESS

[...]
> -*/
> -   header = (struct image_header *)
> -   (CONFIG_SYS_TEXT_BASE - sizeof(struct image_header));
> +   header = (struct image_header *)CONFIG_SPL_LOAD_FIT_ADRESS;
s/CONFIG_SPL_LOAD_FIT_ADRESS/CONFIG_SPL_LOAD_FIT_ADDRESS

[...]

Regards,
Nicolae
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot