Re: [U-Boot] [RFC PATCH 1/4] ARM: enable Thumb build

2012-02-06 Thread Tom Rini
On Mon, Feb 6, 2012 at 4:37 AM, Aneesh V  wrote:
> Enable Thumb build and ARM-Thumb interworking based on the new
> config flag CONFIG_SYS_THUMB_BUILD
>
> Signed-off-by: Aneesh V 
[snip]
> -# Explicitly specifiy 32-bit ARM ISA since toolchain default can be -mthumb:
> -PF_CPPFLAGS_ARM := $(call cc-option,-marm,)
> +# Choose between ARM/Thumb instruction sets
> +ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
> +PF_CPPFLAGS_ARM += $(call cc-option, -mthumb -mthumb-interwork, \
> +               -marm -mno-thumb-interwork)
> +else
> +PF_CPPFLAGS_ARM += $(call cc-option, -marm -mno-thumb-interwork)
> +endif

We need the ':=' syntax to evaluate this once rather than for every
file we build.  Same with the rest of the changes here.

-- 
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [RFC PATCH 1/4] ARM: enable Thumb build

2012-02-06 Thread Aneesh V

On Tuesday 07 February 2012 12:15 AM, Tom Rini wrote:

On Mon, Feb 6, 2012 at 4:37 AM, Aneesh V  wrote:

Enable Thumb build and ARM-Thumb interworking based on the new
config flag CONFIG_SYS_THUMB_BUILD

Signed-off-by: Aneesh V

[snip]

-# Explicitly specifiy 32-bit ARM ISA since toolchain default can be -mthumb:
-PF_CPPFLAGS_ARM := $(call cc-option,-marm,)
+# Choose between ARM/Thumb instruction sets
+ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
+PF_CPPFLAGS_ARM += $(call cc-option, -mthumb -mthumb-interwork, \
+   -marm -mno-thumb-interwork)
+else
+PF_CPPFLAGS_ARM += $(call cc-option, -marm -mno-thumb-interwork)
+endif


We need the ':=' syntax to evaluate this once rather than for every
file we build.  Same with the rest of the changes here.



Oops! In my initial patch it was affecting PLATFORM_CPPFLAGS. When I
rebased it I didn't notice that PF_CPPFLAGS_ARM was defined for the
first time here. I will fix it.

Thanks,
Aneesh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot