Re: [U-Boot] [U-Boot, 1/1] scripts/get_maintainer.pl: update to current version

[waltfeasel]

On Sat, 2017-10-28 at 07:26 +0200, Heinrich Schuchardt wrote:
> On 10/28/2017 05:44 AM, waltfea...@gmail.com wrote:
> > Heinrich,
> > 
> > I ran across a problem with not getting a maintainer for a
> > correction I
> > was putting together. I tracked it down to the line:
> > 
> > "+my $find_maintainer_files = 0;"
> > 
> > When I changed the "0" to a "1" I was able to get the maintainer as
> > intended.
> > 
> > My error was as follows:
> > 
> > $ perl scripts/get_maintainer.pl -m -r -l -f
> > board/Marvell/dreamplug/
> > Bad divisor in main::vcs_assign: 0
> > "GitAuthor: Walt Feasel"  (authored:2/1=100%)
> > u-boot@lists.denx.de (open list)
> 
> Hello Walt,
> 
Heinrich,

> I am not able to reproduce your problem with perl v5.4.21 on Debian
> Stretch:
> 
I have perl 5.24.1-3+deb9u2 on Debian Stretch.

> $ scripts/get_maintainer.pl -f board/Marvell/dreamplug/
> u-boot@lists.denx.de (open list)
> $ perl scripts/get_maintainer.pl -m -r -l -f board/Marvell/dreamplug/
> u-boot@lists.denx.de (open list)
> $
> 
These are missing Jason Cooper whom is the maintainer so neither is
correct but not sure why I have the bad divisor if you also have the
"+my $find_maintainer_files = 0;" setting.

> I wonder why you are calling perl with -m -r -l.
> 
From my uneducated understanding:

-m = maintainer
-r = reviewers
-l = mailing list

to get the email listings for each.

> The get_maintainer.pl script is maintained in the Linux kernel source
> tree. So if you find any problem, please, send a mail
> 
Sorry, I thought you had made the modifications.

> TO: Joe Perches  (maintainer:GET_MAINTAINER SCRIPT)
> CC: linux-ker...@vger.kernel.org (open list)
> 
> As we have many MAINTAINERS files in subdirectories you are right in
> that we should enable finding these. I will submit a patch.
> 
Thank you very much!

> Best regards
> 
> Heinrich
> 
Walt
> > 
> > When I changed from the "0" to the "1" as stated above I get:
> > 
> > $ perl scripts/get_maintainer.pl -m -r -l -f
> > board/Marvell/dreamplug/
> > Jason Cooper  (maintainer:DREAMPLUG BOARD)
> > u-boot@lists.denx.de (open list)
> > 
> > As I would expect and believe is intended.
> > 
> > 
> > I have included below the text of your e-mail to the u-boot list as
> > a
> > reference.
> > 
> > I do not know if this is the proper fix for it or if it may cause
> > issues with your intentions so I will leave it to you and or Tom to
> > decide what to do.
> > 
> > Also, I am currently not subscribed to the mailing list so unable
> > to
> > post there.
> > 
> > Sincerely,
> > 
> > Walt Feasel
> > 
> > 
> > ORIGINAL POST ON MAILING LIST BELOW
> > 
> > 
> > Update the script to version 0.26 (as of Linux v4.14-rc1)
> > Keep our "penguin_chief".
> > Keep our top_of_kernel_tree.
> > 
> > The negative forms of the command line parameters are described
> > when using --help.
> > 
> > New options are
> > 
> >  --git-blame-signatures => when used with --git-blame,
> >    also include all commit signers
> >  --r => include reviewer(s) if any
> >  --letters => print all matching 'letter' types
> >   from all matching sections
> > 
> > File .get_maintainer.ignore can be used to specify
> > email addressees that shall be ignored.
> > 
> > Signed-off-by: Heinrich Schuchardt 
> > ---
> >  scripts/get_maintainer.pl | 202
> > +++---
> > 
> >  1 file changed, 156 insertions(+), 46 deletions(-)
> > 
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > index 83a4e5bad2..8b6037b73f 100755
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl -w
> > +#!/usr/bin/env perl
> >  # (c) 2007, Joe Perches 
> >  #   created from checkpatch.pl
> >  #
> > @@ -10,18 +10,22 @@
> >  #
> >  # Licensed under the terms of the GNU GPL License version 2
> >  
> > +use warnings;
> >  use strict;
> >  
> >  my $P = $0;
> >  my $V = '0.26';
> >  
> >  use Getopt::Long qw(:config no_auto_abbrev);
> > +use Cwd;
> >  use File::Find;
> >  
> > +my $cur_path = fastgetcwd() . '/';
> >  my $lk_path = "./";
> >  my $email = 1;
> >  my $email_usename = 1;
> >  my $email_maintainer = 1;
> > +my $email_reviewer = 1;
> >  my $email_list = 1;
> >  my $email_subscriber_list = 0;
> >  my $email_git_penguin_chiefs = 0;
> > @@ -42,10 +46,12 @@ my $output_multiline = 1;
> >  my $output_separator = ", ";
> >  my $output_roles = 0;
> >  my $output_rolestats = 1;
> > +my $output_section_maxlen = 50;
> >  my $scm = 0;
> >  my $web = 0;
> >  my $subsystem = 0;
> >  my $status = 0;
> > +my $letters = "";
> >  my $keywords = 1;
> >  my $sections = 0;
> >  my $file_emails = 0;
> > @@ -53,6 +59,7 @@ my $from_filename = 0;
> >  my $pattern_depth = 0;
> >  my $version = 0;
> >  my $help = 0;
> > +my $find_maintainer_files = 0;
> >  
> >  my $vcs_used = 0;
> >  
> > @@ -128,6 +135,7 @@ my %VCS_cmds_git = (
> >  "author_pattern" 

Re: [U-Boot] [U-Boot, 1/1] scripts/get_maintainer.pl: update to current version

[Heinrich Schuchardt]

On 10/28/2017 05:44 AM, waltfea...@gmail.com wrote:
> Heinrich,
> 
> I ran across a problem with not getting a maintainer for a correction I
> was putting together. I tracked it down to the line:
> 
> "+my $find_maintainer_files = 0;"
> 
> When I changed the "0" to a "1" I was able to get the maintainer as
> intended.
> 
> My error was as follows:
> 
> $ perl scripts/get_maintainer.pl -m -r -l -f board/Marvell/dreamplug/
> Bad divisor in main::vcs_assign: 0
> "GitAuthor: Walt Feasel"  (authored:2/1=100%)
> u-boot@lists.denx.de (open list)

Hello Walt,

I am not able to reproduce your problem with perl v5.4.21 on Debian Stretch:

$ scripts/get_maintainer.pl -f board/Marvell/dreamplug/
u-boot@lists.denx.de (open list)
$ perl scripts/get_maintainer.pl -m -r -l -f board/Marvell/dreamplug/
u-boot@lists.denx.de (open list)
$

I wonder why you are calling perl with -m -r -l.

The get_maintainer.pl script is maintained in the Linux kernel source
tree. So if you find any problem, please, send a mail

TO: Joe Perches  (maintainer:GET_MAINTAINER SCRIPT)
CC: linux-ker...@vger.kernel.org (open list)

As we have many MAINTAINERS files in subdirectories you are right in
that we should enable finding these. I will submit a patch.

Best regards

Heinrich

> 
> When I changed from the "0" to the "1" as stated above I get:
> 
> $ perl scripts/get_maintainer.pl -m -r -l -f board/Marvell/dreamplug/
> Jason Cooper  (maintainer:DREAMPLUG BOARD)
> u-boot@lists.denx.de (open list)
> 
> As I would expect and believe is intended.
> 
> 
> I have included below the text of your e-mail to the u-boot list as a
> reference.
> 
> I do not know if this is the proper fix for it or if it may cause
> issues with your intentions so I will leave it to you and or Tom to
> decide what to do.
> 
> Also, I am currently not subscribed to the mailing list so unable to
> post there.
> 
> Sincerely,
> 
> Walt Feasel
> 
> 
> ORIGINAL POST ON MAILING LIST BELOW
> 
> 
> Update the script to version 0.26 (as of Linux v4.14-rc1)
> Keep our "penguin_chief".
> Keep our top_of_kernel_tree.
> 
> The negative forms of the command line parameters are described
> when using --help.
> 
> New options are
> 
>  --git-blame-signatures => when used with --git-blame,
>    also include all commit signers
>  --r => include reviewer(s) if any
>  --letters => print all matching 'letter' types
>   from all matching sections
> 
> File .get_maintainer.ignore can be used to specify
> email addressees that shall be ignored.
> 
> Signed-off-by: Heinrich Schuchardt 
> ---
>  scripts/get_maintainer.pl | 202 +++---
> 
>  1 file changed, 156 insertions(+), 46 deletions(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 83a4e5bad2..8b6037b73f 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1,4 +1,4 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl
>  # (c) 2007, Joe Perches 
>  #   created from checkpatch.pl
>  #
> @@ -10,18 +10,22 @@
>  #
>  # Licensed under the terms of the GNU GPL License version 2
>  
> +use warnings;
>  use strict;
>  
>  my $P = $0;
>  my $V = '0.26';
>  
>  use Getopt::Long qw(:config no_auto_abbrev);
> +use Cwd;
>  use File::Find;
>  
> +my $cur_path = fastgetcwd() . '/';
>  my $lk_path = "./";
>  my $email = 1;
>  my $email_usename = 1;
>  my $email_maintainer = 1;
> +my $email_reviewer = 1;
>  my $email_list = 1;
>  my $email_subscriber_list = 0;
>  my $email_git_penguin_chiefs = 0;
> @@ -42,10 +46,12 @@ my $output_multiline = 1;
>  my $output_separator = ", ";
>  my $output_roles = 0;
>  my $output_rolestats = 1;
> +my $output_section_maxlen = 50;
>  my $scm = 0;
>  my $web = 0;
>  my $subsystem = 0;
>  my $status = 0;
> +my $letters = "";
>  my $keywords = 1;
>  my $sections = 0;
>  my $file_emails = 0;
> @@ -53,6 +59,7 @@ my $from_filename = 0;
>  my $pattern_depth = 0;
>  my $version = 0;
>  my $help = 0;
> +my $find_maintainer_files = 0;
>  
>  my $vcs_used = 0;
>  
> @@ -128,6 +135,7 @@ my %VCS_cmds_git = (
>  "author_pattern" => "^GitAuthor: (.*)",
>  "subject_pattern" => "^GitSubject: (.*)",
>  "stat_pattern" => "^(\\d+)\\t(\\d+)\\t\$file\$",
> +"file_exists_cmd" => "git ls-files \$file",
>  );
>  
>  my %VCS_cmds_hg = (
> @@ -156,6 +164,7 @@ my %VCS_cmds_hg = (
>  "author_pattern" => "^HgAuthor: (.*)",
>  "subject_pattern" => "^HgSubject: (.*)",
>  "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
> +"file_exists_cmd" => "hg files \$file",
>  );
>  
>  my $conf = which_conf(".get_maintainer.conf");
> @@ -184,6 +193,27 @@ if (-f $conf) {
>  unshift(@ARGV, @conf_args) if @conf_args;
>  }
>  
> +my @ignore_emails = ();
> +my $ignore_file = which_conf(".get_maintainer.ignore");
> +if (-f $ignore_file) {
> +open(my $ignore, '<', "$ignore_file")
> + or warn "$P: Can't find a readable .get_maintainer.ignore 

Re: [U-Boot] [U-Boot, 1/1] scripts/get_maintainer.pl: update to current version

[Tom Rini]

On Fri, Oct 13, 2017 at 07:31:20PM +0200, Heinrich Schuchardt wrote:

> Update the script to version 0.26 (as of Linux v4.14-rc1)
> Keep our "penguin_chief".
> Keep our top_of_kernel_tree.
> 
> The negative forms of the command line parameters are described
> when using --help.
> 
> New options are
> 
>  --git-blame-signatures => when used with --git-blame,
>also include all commit signers
>  --r => include reviewer(s) if any
>  --letters => print all matching 'letter' types
>   from all matching sections
> 
> File .get_maintainer.ignore can be used to specify
> email addressees that shall be ignored.
> 
> Signed-off-by: Heinrich Schuchardt 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot