Re: [U-Boot] [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot support

2013-01-17 Thread Xie Shaohui-B21989
 -Original Message-
 From: Tabi Timur-B04825
 Sent: Wednesday, January 16, 2013 10:42 PM
 To: Xie Shaohui-B21989
 Cc: u-boot@lists.denx.de
 Subject: Re: [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot
 support
 
 Shaohui Xie wrote:
  Signed-off-by: Shaohui Xie shaohui@freescale.com
  ---
 
 These patches only add one line each, and each depends on the previous
 anyway.  They should be merged into one patch.
 
[S.H] I thought one patch doing one thing even it's simple. 
I'm fine with the merge if you insist.


Best Regards, 
Shaohui Xie

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot support

2013-01-17 Thread Tabi Timur-B04825
Xie Shaohui-B21989 wrote:
 [S.H] I thought one patch doing one thing even it's simple.
 I'm fine with the merge if you insist.

Well, it is a matter of opinion.  I don't insist, but I think it would be 
easier for everyone if you did merge these patches.  Each one is very 
short, and they are all very similar.

-- 
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot support

2013-01-17 Thread Xie Shaohui-B21989
 -Original Message-
 From: Tabi Timur-B04825
 Sent: Friday, January 18, 2013 10:27 AM
 To: Xie Shaohui-B21989
 Cc: u-boot@lists.denx.de
 Subject: Re: [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot
 support
 
 Xie Shaohui-B21989 wrote:
  [S.H] I thought one patch doing one thing even it's simple.
  I'm fine with the merge if you insist.
 
 Well, it is a matter of opinion.  I don't insist, but I think it would be
 easier for everyone if you did merge these patches.  Each one is very
 short, and they are all very similar.
[S.H] it's also easier for me. :)
I had to separate the three lines to three patches when sending them, I thought
Someone may NAC the merged patch because it added three features.


Best Regards, 
Shaohui Xie

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot support

2013-01-16 Thread Timur Tabi
Shaohui Xie wrote:
 Signed-off-by: Shaohui Xie shaohui@freescale.com
 ---

These patches only add one line each, and each depends on the previous
anyway.  They should be merged into one patch.

  boards.cfg |1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
 
 diff --git a/boards.cfg b/boards.cfg
 index e4b0d44..8cf4936 100644
 --- a/boards.cfg
 +++ b/boards.cfg
 @@ -855,6 +855,7 @@ P5020DS_SECURE_BOOT  powerpc mpc85xx 
 corenet_ds  freesca
  P5020DS_SPIFLASH  powerpc mpc85xx corenet_ds  
 freescale  -   
 P5020DS:RAMBOOT_PBL,SPIFLASH,SYS_TEXT_BASE=0xFFF8
  P5020DS_SRIO_PCIE_BOOT  powerpc mpc85xx corenet_ds  
 freescale  -   
 P5020DS:SRIO_PCIE_BOOT_SLAVE,SYS_TEXT_BASE=0xFFF8
  P5040DS  powerpc mpc85xx corenet_ds  
 freescale
 +P5040DS_NAND  powerpc mpc85xx corenet_ds  
 freescale  -   P5040DS:RAMBOOT_PBL,NAND,SYS_TEXT_BASE=0xFFF8
  BSC9131RDB_SPIFLASH  powerpc mpc85xx bsc9131rdb  
 freescale  -   BSC9131RDB:BSC9131RDB,SPIFLASH
  stxgp3   powerpc mpc85xx stxgp3  stx
  stxssa   powerpc mpc85xx stxssa  stx 
-   stxssa
 


-- 
Timur Tabi
Linux kernel developer at Freescale

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot