Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-13 Thread Tom Rini
On Tue, Jan 14, 2014 at 12:05:32AM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> PR have quad and dual_flash change set also includes few fixes.
> Tested these changes on spansion, stmicro and sst flash devices.
> 
> --
> Thanks,
> Jagan.
> 
> The following changes since commit 7f673c99c2d8d1aa21996c5b914f06d784b080ca:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-arm (2014-01-10 10:56:00 
> -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 35a55fb57fffb615e6b20980fb317e162076adb4:
> 
>   sf: params: Removed flag SECT_4K for Micron N25Q128 (2014-01-12 21:40:23 
> +0530)
> 
> 
> Axel Lin (1):
>   spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
> 
> Jagannadha Sutradharudu Teki (17):
>   sf: Add extended read commands support
>   sf: Add quad read/write commands support
>   sf: ops: Add configuration register writing support
>   sf: Set quad enable bit support
>   sf: probe: Enable RD_FULL and WR_QPP
>   sf: Separate the flash params table
>   sf: Add QUAD_IO_FAST read support
>   sf: Discover read dummy_byte
>   sf: Add macronix set QEB support
>   sf: probe: Enable macronix quad read/write cmds support
>   sf: Divide flash register ops from QEB code
>   sf: Code cleanups
>   sf: ops: Unify read_ops bank configuration
>   sf: Add dual memories support - DUAL_STACKED
>   sf: Add dual memories support - DUAL_PARALLEL
>   sf: Add CONFIG_SF_DUAL_FLASH
>   doc: SPI: Update status.txt
> 
> Kuo-Jung Su (1):
>   spi: Add Faraday SPI controller support
> 
> Simon Glass (1):
>   sandbox: spi: Adjust 'sf test' to work on sandbox
> 
> Siva Durga Prasad Paladugu (1):
>   sf: params: Removed flag SECT_4K for Micron N25Q128
> 
>  README   |   6 +
>  common/cmd_sf.c  |  14 +-
>  doc/SPI/README.dual-flash|  92 +++
>  doc/SPI/README.ftssp010_spi_test |  41 
>  doc/SPI/status.txt   |  11 +-
>  drivers/mtd/spi/Makefile |   4 +-
>  drivers/mtd/spi/sf.c |   4 +
>  drivers/mtd/spi/sf_internal.h|  34 ++-
>  drivers/mtd/spi/sf_ops.c | 157 +---
>  drivers/mtd/spi/sf_params.c  | 130 ++
>  drivers/mtd/spi/sf_probe.c   | 274 +++--
>  drivers/spi/Makefile |   1 +
>  drivers/spi/ftssp010_spi.c   | 508 
> +++
>  drivers/spi/sh_spi.c |  10 +-
>  include/spi.h|  26 ++
>  include/spi_flash.h  |  57 +
>  16 files changed, 1171 insertions(+), 198 deletions(-)
>  create mode 100644 doc/SPI/README.dual-flash
>  create mode 100644 doc/SPI/README.ftssp010_spi_test
>  create mode 100644 drivers/mtd/spi/sf_params.c
>  create mode 100644 drivers/spi/ftssp010_spi.c

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-15 Thread Marek Vasut
On Monday, January 13, 2014 at 08:42:18 PM, Tom Rini wrote:
> On Tue, Jan 14, 2014 at 12:05:32AM +0530, Jagannadha Sutradharudu Teki wrote:
> > Hi Tom,
> > 
> > PR have quad and dual_flash change set also includes few fixes.
> > Tested these changes on spansion, stmicro and sst flash devices.
> > 
> > --
> > Thanks,
> > Jagan.
> > 
> > The following changes since commit 7f673c99c2d8d1aa21996c5b914f06d784b080ca:
> >   Merge branch 'master' of git://git.denx.de/u-boot-arm (2014-01-10
> >   10:56:00 -0500)
> > 
> > are available in the git repository at:
> >   git://git.denx.de/u-boot-spi.git master
> > 
> > for you to fetch changes up to 35a55fb57fffb615e6b20980fb317e162076adb4:
> >   sf: params: Removed flag SECT_4K for Micron N25Q128 (2014-01-12
> >   21:40:23 +0530)
> > 
> > 
> > 
> > Axel Lin (1):
> >   spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
> > 
> > Jagannadha Sutradharudu Teki (17):
> >   sf: Add extended read commands support
> >   sf: Add quad read/write commands support
> >   sf: ops: Add configuration register writing support
> >   sf: Set quad enable bit support
> >   sf: probe: Enable RD_FULL and WR_QPP
> >   sf: Separate the flash params table
> >   sf: Add QUAD_IO_FAST read support
> >   sf: Discover read dummy_byte
> >   sf: Add macronix set QEB support
> >   sf: probe: Enable macronix quad read/write cmds support
> >   sf: Divide flash register ops from QEB code
> >   sf: Code cleanups
> >   sf: ops: Unify read_ops bank configuration
> >   sf: Add dual memories support - DUAL_STACKED
> >   sf: Add dual memories support - DUAL_PARALLEL
> >   sf: Add CONFIG_SF_DUAL_FLASH
> >   doc: SPI: Update status.txt

I looked into this patchset and this seems completely misdesigned, sorry.

It seems this patchset aims to accomodate an SPI-NOR controllers within the SPI 
API. The SPI-NOR controllers are a completely separate class of hardware 
though, 
so I disagree with the attempt to integrate them into the SPI framework. I 
cannot use most of the SPI-NOR controllers to drive regular SPI bus (there are 
exceptions), but they are now presented as regular SPI controllers 
indiscriminately.

Instead of going down this path, there should be a completely separate class of 
drivers for the SPI-NOR controllers, same as in Linux [1]. That way, there 
would 
still be an SF command talking to SF core, but the SF core would be delegating 
the calls to either a layer talking to a SPI flash via regular SPI interface or 
a layer talking the SPI-NOR controller.

I also see some flaws in these patches. For example the struct spi_slave {} now 
contains all kinds of new entries used only by the SPI flash driver. The slave 
can now export for example SPI_OPM_RX_QOF and SPI_OPM_RX_QIOF (see 
include/spi.h) flags, which -- if you inspect drivers/mtd/spi/sf_probe.c and 
include/spi_flash.h -- should match up with enum spi_read_cmds . So we now have 
two sets of flags, which needs to be kept in sync, which is wrong. Besides, 
these flags define the capabilities of the SPI-NOR host controller, so why are 
they even in struct spi_slave {} ?

I also observe a big lack of documentation for all those flags, so it's really 
hard to make heads or tails of how it's supposed to work.

Also, I don't see any of these new flags used yet, so we're still at a good 
point to avoid going down the wrong path. I would love to see this patchset 
postponed for next if possible, since my feeling of this is it needs severe 
redesign.

[1] http://www.spinics.net/lists/arm-kernel/msg291891.html

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-15 Thread Jagan Teki
Hi Marek,

On Thu, Jan 16, 2014 at 1:08 AM, Marek Vasut  wrote:
> On Monday, January 13, 2014 at 08:42:18 PM, Tom Rini wrote:
>> On Tue, Jan 14, 2014 at 12:05:32AM +0530, Jagannadha Sutradharudu Teki wrote:
>> > Hi Tom,
>> >
>> > PR have quad and dual_flash change set also includes few fixes.
>> > Tested these changes on spansion, stmicro and sst flash devices.
>> >
>> > --
>> > Thanks,
>> > Jagan.
>> >
>> > The following changes since commit 
>> > 7f673c99c2d8d1aa21996c5b914f06d784b080ca:
>> >   Merge branch 'master' of git://git.denx.de/u-boot-arm (2014-01-10
>> >   10:56:00 -0500)
>> >
>> > are available in the git repository at:
>> >   git://git.denx.de/u-boot-spi.git master
>> >
>> > for you to fetch changes up to 35a55fb57fffb615e6b20980fb317e162076adb4:
>> >   sf: params: Removed flag SECT_4K for Micron N25Q128 (2014-01-12
>> >   21:40:23 +0530)
>> >
>> > 
>> >
>> > Axel Lin (1):
>> >   spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
>> >
>> > Jagannadha Sutradharudu Teki (17):
>> >   sf: Add extended read commands support
>> >   sf: Add quad read/write commands support
>> >   sf: ops: Add configuration register writing support
>> >   sf: Set quad enable bit support
>> >   sf: probe: Enable RD_FULL and WR_QPP
>> >   sf: Separate the flash params table
>> >   sf: Add QUAD_IO_FAST read support
>> >   sf: Discover read dummy_byte
>> >   sf: Add macronix set QEB support
>> >   sf: probe: Enable macronix quad read/write cmds support
>> >   sf: Divide flash register ops from QEB code
>> >   sf: Code cleanups
>> >   sf: ops: Unify read_ops bank configuration
>> >   sf: Add dual memories support - DUAL_STACKED
>> >   sf: Add dual memories support - DUAL_PARALLEL
>> >   sf: Add CONFIG_SF_DUAL_FLASH
>> >   doc: SPI: Update status.txt
>
> I looked into this patchset and this seems completely misdesigned, sorry.
No issues - OK.

Let me explain the journey with (spi_flash)sf since last 8 months. [1]
- We have a individual class of vendor drivers and removed all vendor specific
  stuff and added a common probe.
- Added Bank addr reg stuff
- Tunned sf almost seems like mtd/nand style where sf.c, sf_probe.c,
sf_params.c and sf_ops.c
- Added memory_mapped and quad commands supports
- Done many of cleanups
- maintained doc/SPI which we're trying to update.

Keeping these enhancements on current sf we are in a good shape than before.
>
> It seems this patchset aims to accomodate an SPI-NOR controllers within the 
> SPI
> API. The SPI-NOR controllers are a completely separate class of hardware 
> though,
> so I disagree with the attempt to integrate them into the SPI framework. I
> cannot use most of the SPI-NOR controllers to drive regular SPI bus (there are
> exceptions), but they are now presented as regular SPI controllers
> indiscriminately.
>
> Instead of going down this path, there should be a completely separate class 
> of
> drivers for the SPI-NOR controllers, same as in Linux [1]. That way, there 
> would
> still be an SF command talking to SF core, but the SF core would be delegating
> the calls to either a layer talking to a SPI flash via regular SPI interface 
> or
> a layer talking the SPI-NOR controller.
>
> I also see some flaws in these patches. For example the struct spi_slave {} 
> now
> contains all kinds of new entries used only by the SPI flash driver. The slave
> can now export for example SPI_OPM_RX_QOF and SPI_OPM_RX_QIOF (see
> include/spi.h) flags, which -- if you inspect drivers/mtd/spi/sf_probe.c and
> include/spi_flash.h -- should match up with enum spi_read_cmds . So we now 
> have
> two sets of flags, which needs to be kept in sync, which is wrong. Besides,
> these flags define the capabilities of the SPI-NOR host controller, so why are
> they even in struct spi_slave {} ?

The spi_slave grown with flash stuff with spi driver terminologies,
and the reason
for taking one extra flag for reads in params is like we have couple
of  commands
for 1, 2 and 4-lines I have given a spi driver has a provision to
verify these one by one.
The reason for going this implementation for improving sf performance.
>
> I also observe a big lack of documentation for all those flags, so it's really
> hard to make heads or tails of how it's supposed to work.

Some how disagree this, because we have started doc/SPI [2] these days
which don't have
before and I'm stressing patch contributors to add as many as doc and
test-cases logs.

and Yes- for this quad I'm planning to add test-case logs once our
zynq qspi is ML.
>
> Also, I don't see any of these new flags used yet, so we're still at a good
> point to avoid going down the wrong path. I would love to see this patchset
> postponed for next if possible, since my feeling of this is it needs severe
> redesign.
>
> [1] http://www.spinics.net/lists/arm-kernel/msg291891.html

And finally - I do understand your comments and

Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-16 Thread Marek Vasut
On Thursday, January 16, 2014 at 07:06:20 AM, Jagan Teki wrote:
> Hi Marek,
> 
> On Thu, Jan 16, 2014 at 1:08 AM, Marek Vasut  wrote:
> > On Monday, January 13, 2014 at 08:42:18 PM, Tom Rini wrote:
> >> On Tue, Jan 14, 2014 at 12:05:32AM +0530, Jagannadha Sutradharudu Teki 
wrote:
> >> > Hi Tom,
> >> > 
> >> > PR have quad and dual_flash change set also includes few fixes.
> >> > Tested these changes on spansion, stmicro and sst flash devices.
> >> > 
> >> > --
> >> > Thanks,
> >> > Jagan.
> >> > 
> >> > The following changes since commit 
7f673c99c2d8d1aa21996c5b914f06d784b080ca:
> >> >   Merge branch 'master' of git://git.denx.de/u-boot-arm (2014-01-10
> >> >   10:56:00 -0500)
> >> > 
> >> > are available in the git repository at:
> >> >   git://git.denx.de/u-boot-spi.git master
> >> > 
> >> > for you to fetch changes up to 35a55fb57fffb615e6b20980fb317e162076adb4:
> >> >   sf: params: Removed flag SECT_4K for Micron N25Q128 (2014-01-12
> >> >   21:40:23 +0530)
> >> > 
> >> > 
> >> > 
> >> > Axel Lin (1):
> >> >   spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
> >> > 
> >> > Jagannadha Sutradharudu Teki (17):
> >> >   sf: Add extended read commands support
> >> >   sf: Add quad read/write commands support
> >> >   sf: ops: Add configuration register writing support
> >> >   sf: Set quad enable bit support
> >> >   sf: probe: Enable RD_FULL and WR_QPP
> >> >   sf: Separate the flash params table
> >> >   sf: Add QUAD_IO_FAST read support
> >> >   sf: Discover read dummy_byte
> >> >   sf: Add macronix set QEB support
> >> >   sf: probe: Enable macronix quad read/write cmds support
> >> >   sf: Divide flash register ops from QEB code
> >> >   sf: Code cleanups
> >> >   sf: ops: Unify read_ops bank configuration
> >> >   sf: Add dual memories support - DUAL_STACKED
> >> >   sf: Add dual memories support - DUAL_PARALLEL
> >> >   sf: Add CONFIG_SF_DUAL_FLASH
> >> >   doc: SPI: Update status.txt
> > 
> > I looked into this patchset and this seems completely misdesigned, sorry.
> 
> No issues - OK.
> 
> Let me explain the journey with (spi_flash)sf since last 8 months. [1]
> - We have a individual class of vendor drivers and removed all vendor
> specific stuff and added a common probe.
> - Added Bank addr reg stuff
> - Tunned sf almost seems like mtd/nand style where sf.c, sf_probe.c,
> sf_params.c and sf_ops.c
> - Added memory_mapped and quad commands supports
> - Done many of cleanups
> - maintained doc/SPI which we're trying to update.
> 
> Keeping these enhancements on current sf we are in a good shape than
> before.

This patchset does not do this cleanup you describe here. This patchset adds 
(dead) code to support SPI-NOR controllers via regular SPI API .

> > It seems this patchset aims to accomodate an SPI-NOR controllers within
> > the SPI API. The SPI-NOR controllers are a completely separate class of
> > hardware though, so I disagree with the attempt to integrate them into
> > the SPI framework. I cannot use most of the SPI-NOR controllers to drive
> > regular SPI bus (there are exceptions), but they are now presented as
> > regular SPI controllers indiscriminately.
> > 
> > Instead of going down this path, there should be a completely separate
> > class of drivers for the SPI-NOR controllers, same as in Linux [1]. That
> > way, there would still be an SF command talking to SF core, but the SF
> > core would be delegating the calls to either a layer talking to a SPI
> > flash via regular SPI interface or a layer talking the SPI-NOR
> > controller.
> > 
> > I also see some flaws in these patches. For example the struct spi_slave
> > {} now contains all kinds of new entries used only by the SPI flash
> > driver. The slave can now export for example SPI_OPM_RX_QOF and
> > SPI_OPM_RX_QIOF (see include/spi.h) flags, which -- if you inspect
> > drivers/mtd/spi/sf_probe.c and include/spi_flash.h -- should match up
> > with enum spi_read_cmds . So we now have two sets of flags, which needs
> > to be kept in sync, which is wrong. Besides, these flags define the
> > capabilities of the SPI-NOR host controller, so why are they even in
> > struct spi_slave {} ?
> 
> The spi_slave grown with flash stuff with spi driver terminologies,
> and the reason
> for taking one extra flag for reads in params is like we have couple
> of  commands
> for 1, 2 and 4-lines I have given a spi driver has a provision to
> verify these one by one.
> The reason for going this implementation for improving sf performance.

Sorry, I don't understand what you're telling me here.

btw. the struct spi_slave {} has grown quite significantly , it contains:

u8 op_mode_rx
u8 op_mode_tx
 -> SPI-NOR controllers' bus caps (like, can it do 4-bit transfer etc.), but 
this is SPI-NOR _controller_ specific, what is this stuff doing in struct 
spi_slave {} ? btw. /wrt placement of these new entries, you m

Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-16 Thread Jagan Teki
Hi Marek,

On Fri, Jan 17, 2014 at 12:34 AM, Marek Vasut  wrote:
> On Thursday, January 16, 2014 at 07:06:20 AM, Jagan Teki wrote:
>> Hi Marek,
>>
>> On Thu, Jan 16, 2014 at 1:08 AM, Marek Vasut  wrote:
>> > On Monday, January 13, 2014 at 08:42:18 PM, Tom Rini wrote:
>> >> On Tue, Jan 14, 2014 at 12:05:32AM +0530, Jagannadha Sutradharudu Teki
> wrote:
>> >> > Hi Tom,
>> >> >
>> >> > PR have quad and dual_flash change set also includes few fixes.
>> >> > Tested these changes on spansion, stmicro and sst flash devices.
>> >> >
>> >> > --
>> >> > Thanks,
>> >> > Jagan.
>> >> >
>> >> > The following changes since commit
> 7f673c99c2d8d1aa21996c5b914f06d784b080ca:
>> >> >   Merge branch 'master' of git://git.denx.de/u-boot-arm (2014-01-10
>> >> >   10:56:00 -0500)
>> >> >
>> >> > are available in the git repository at:
>> >> >   git://git.denx.de/u-boot-spi.git master
>> >> >
>> >> > for you to fetch changes up to 35a55fb57fffb615e6b20980fb317e162076adb4:
>> >> >   sf: params: Removed flag SECT_4K for Micron N25Q128 (2014-01-12
>> >> >   21:40:23 +0530)
>> >> >
>> >> > 
>> >> >
>> >> > Axel Lin (1):
>> >> >   spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
>> >> >
>> >> > Jagannadha Sutradharudu Teki (17):
>> >> >   sf: Add extended read commands support
>> >> >   sf: Add quad read/write commands support
>> >> >   sf: ops: Add configuration register writing support
>> >> >   sf: Set quad enable bit support
>> >> >   sf: probe: Enable RD_FULL and WR_QPP
>> >> >   sf: Separate the flash params table
>> >> >   sf: Add QUAD_IO_FAST read support
>> >> >   sf: Discover read dummy_byte
>> >> >   sf: Add macronix set QEB support
>> >> >   sf: probe: Enable macronix quad read/write cmds support
>> >> >   sf: Divide flash register ops from QEB code
>> >> >   sf: Code cleanups
>> >> >   sf: ops: Unify read_ops bank configuration
>> >> >   sf: Add dual memories support - DUAL_STACKED
>> >> >   sf: Add dual memories support - DUAL_PARALLEL
>> >> >   sf: Add CONFIG_SF_DUAL_FLASH
>> >> >   doc: SPI: Update status.txt
>> >
>> > I looked into this patchset and this seems completely misdesigned, sorry.
>>
>> No issues - OK.
>>
>> Let me explain the journey with (spi_flash)sf since last 8 months. [1]
>> - We have a individual class of vendor drivers and removed all vendor
>> specific stuff and added a common probe.
>> - Added Bank addr reg stuff
>> - Tunned sf almost seems like mtd/nand style where sf.c, sf_probe.c,
>> sf_params.c and sf_ops.c
>> - Added memory_mapped and quad commands supports
>> - Done many of cleanups
>> - maintained doc/SPI which we're trying to update.
>>
>> Keeping these enhancements on current sf we are in a good shape than
>> before.
>
> This patchset does not do this cleanup you describe here. This patchset adds
> (dead) code to support SPI-NOR controllers via regular SPI API .

I don't know what you mean by dead code here, I agreed that the
current sf code is
touching spi api because we followed the same approach since so-far.
we're using this since so far and honestly if you compare this with newly added
SPI-NOR framework in Linux - ends defiantly have a side effects.

The reason why I am not agree with this not a dead-code is like even
if we have a new
SPI-NOR framework these should be part of spi-nor code i guess.

I totally agree that if we follow the new SPI-NOR will answer all
these side effects.
And also SPI-NOR is not yet ML'ed I am currently understanding this.

My plan is to do this new framework addition for next release and wrap this code
once all gets set.

>
>> > It seems this patchset aims to accomodate an SPI-NOR controllers within
>> > the SPI API. The SPI-NOR controllers are a completely separate class of
>> > hardware though, so I disagree with the attempt to integrate them into
>> > the SPI framework. I cannot use most of the SPI-NOR controllers to drive
>> > regular SPI bus (there are exceptions), but they are now presented as
>> > regular SPI controllers indiscriminately.
>> >
>> > Instead of going down this path, there should be a completely separate
>> > class of drivers for the SPI-NOR controllers, same as in Linux [1]. That
>> > way, there would still be an SF command talking to SF core, but the SF
>> > core would be delegating the calls to either a layer talking to a SPI
>> > flash via regular SPI interface or a layer talking the SPI-NOR
>> > controller.
>> >
>> > I also see some flaws in these patches. For example the struct spi_slave
>> > {} now contains all kinds of new entries used only by the SPI flash
>> > driver. The slave can now export for example SPI_OPM_RX_QOF and
>> > SPI_OPM_RX_QIOF (see include/spi.h) flags, which -- if you inspect
>> > drivers/mtd/spi/sf_probe.c and include/spi_flash.h -- should match up
>> > with enum spi_read_cmds . So we now have two sets of flags, which needs
>> > to be kept in sync, which is wrong

Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-18 Thread Marek Vasut
On Thursday, January 16, 2014 at 08:44:55 PM, Jagan Teki wrote:
> Hi Marek,
[...]
> >> 
> >> Let me explain the journey with (spi_flash)sf since last 8 months. [1]
> >> - We have a individual class of vendor drivers and removed all vendor
> >> specific stuff and added a common probe.
> >> - Added Bank addr reg stuff
> >> - Tunned sf almost seems like mtd/nand style where sf.c, sf_probe.c,
> >> sf_params.c and sf_ops.c
> >> - Added memory_mapped and quad commands supports
> >> - Done many of cleanups
> >> - maintained doc/SPI which we're trying to update.
> >> 
> >> Keeping these enhancements on current sf we are in a good shape than
> >> before.
> > 
> > This patchset does not do this cleanup you describe here. This patchset
> > adds (dead) code to support SPI-NOR controllers via regular SPI API .
> 
> I don't know what you mean by dead code here

I mean all those new flags added to struct spi_slave {} for example. They have 
no user in mainline U-Boot. CONFIG_SF_DUAL_FLASH is not used by anyone in u-
boot/master either.

> I agreed that the current sf code is
> touching spi api because we followed the same approach since so-far.

What does that mean ? The SF code must not ever touch the SPI API, the SPI 
already provides everything the SPI flash can hope for (that is, means to 
send/receive data on/from the bus AND position of the SPI devices (bus # and 
chipselect # )). The approach to extend SPI API for one particular type of SPI 
device is wrong.

> we're using this since so far and honestly if you compare this with newly
> added SPI-NOR framework in Linux - ends defiantly have a side effects.

What kind of side-effects ? The SPI API is different from SPI-NOR controller 
API 
and we _must_ keep that in mind. The later is in no set relationship to the 
former ; they're neither subset nor a superset, they barely even intersect.

> The reason why I am not agree with this not a dead-code is like even
> if we have a new
> SPI-NOR framework these should be part of spi-nor code i guess.

The actual device-model idea here is as such:

I) The 'sf' command talks to the SF layer and informs it about:
   1) operation to be performed (read/write/erase)
   2) device credentials (bus number and chipselect number)

II) The SF layer figures out the correct struct spi_slave {} based on the 
information passed from the SF command above.

III) The SF layer talks using SPI API to make the SPI controller send/receive 
data to/from device identified by struct spi_slave {}.


To incorporate the new SPI-NOR controllers, the SF layer would need to be 
adjusted.

Step II) would need to be changed such, that an appropriate conversion to 
either 
struct spi_slave {} or struct spi_nor_device {} would happen depending on which 
kind of connection and API would the SPI flash device use -- whether it is 
generic SPI or specific SPI-NOR.

Step III) would then need to be adjusted such that depending on the controller 
type retrieved in step II), one of the APIs (generic SPI or SPI-NOR) would be 
used.

The adjustment really isn't hard at all ;-)

> I totally agree that if we follow the new SPI-NOR will answer all
> these side effects.
> And also SPI-NOR is not yet ML'ed I am currently understanding this.

Ok, so that's why it's a lot of dead code ;-)

> My plan is to do this new framework addition for next release and wrap this
> code once all gets set.

I would suggest we start heading for the SPI NOR split. Seriously, hit the 
brakes here, otherwise we're going for an unpleasant ride through a sh**storm 
;-)

> >> > It seems this patchset aims to accomodate an SPI-NOR controllers
> >> > within the SPI API. The SPI-NOR controllers are a completely separate
> >> > class of hardware though, so I disagree with the attempt to integrate
> >> > them into the SPI framework. I cannot use most of the SPI-NOR
> >> > controllers to drive regular SPI bus (there are exceptions), but they
> >> > are now presented as regular SPI controllers indiscriminately.
> >> > 
> >> > Instead of going down this path, there should be a completely separate
> >> > class of drivers for the SPI-NOR controllers, same as in Linux [1].
> >> > That way, there would still be an SF command talking to SF core, but
> >> > the SF core would be delegating the calls to either a layer talking
> >> > to a SPI flash via regular SPI interface or a layer talking the
> >> > SPI-NOR controller.
> >> > 
> >> > I also see some flaws in these patches. For example the struct
> >> > spi_slave {} now contains all kinds of new entries used only by the
> >> > SPI flash driver. The slave can now export for example SPI_OPM_RX_QOF
> >> > and SPI_OPM_RX_QIOF (see include/spi.h) flags, which -- if you
> >> > inspect drivers/mtd/spi/sf_probe.c and include/spi_flash.h -- should
> >> > match up with enum spi_read_cmds . So we now have two sets of flags,
> >> > which needs to be kept in sync, which is wrong. Besides, these flags
> >> > define the capabilities of the SPI-NOR host controller, so why are

Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-20 Thread Marek Vasut
On Monday, January 20, 2014 at 06:53:58 PM, Jagannadha Sutradharudu Teki wrote:
> Hi Tom,
> 
> SF code optimized stuff and few fixes.
> 
> --
> Thanks,
> Jagan.
> 
> The following changes since commit
> 5c9038b6af1a93410af966999638eabb81efcd0f:
> 
>   omap3_beagle: use omap3-beagle.dtb for the C4 revision (2014-01-17
> 11:03:04 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 83ba605953162443b054d5ad60535468b46558bd:
> 
>   sf: Update bank configuration (2014-01-20 22:30:35 +0530)
> 
> 
> Jagannadha Sutradharudu Teki (5):
>   sf: ops: Squash the malloc+memset combo
>   sf: Optimize flash features code
>   sf: Use mode_bits for dual_flash connection
>   doc: SPI: Update the dual_flash info
>   sf: Update bank configuration

This is for -next.

> Marek Vasut (3):
>   sf: Squash the malloc+memset combo

This is definitelly for -next.

>   sf: Fix entries for S25FL256S_256K and S25FL512S_256K

This is the only one I would let into current , since it's an actual bugfix . 
The rest are just adjustments.

>   sf: Add S25FL128S_256K IDs

This is an adjustment, can wait for -next.

> 
>  doc/SPI/README.dual-flash |   5 +-
>  doc/SPI/README.sf-features| 125 ++
>  drivers/mtd/spi/sf.c  |   4 +-
>  drivers/mtd/spi/sf_internal.h |   1 -
>  drivers/mtd/spi/sf_ops.c  |  16 ++--
>  drivers/mtd/spi/sf_params.c   | 171
> +- drivers/mtd/spi/sf_probe.c|
> 104 -
>  include/spi.h |  42 ---
>  include/spi_flash.h   |  24 +++---
>  9 files changed, 301 insertions(+), 191 deletions(-)
>  create mode 100644 doc/SPI/README.sf-features

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-20 Thread Jagan Teki
Hi Marek,

Waited your response since last couple of hours.!

On Tue, Jan 21, 2014 at 1:07 AM, Marek Vasut  wrote:
> On Monday, January 20, 2014 at 06:53:58 PM, Jagannadha Sutradharudu Teki 
> wrote:
>> Hi Tom,
>>
>> SF code optimized stuff and few fixes.
>>
>> --
>> Thanks,
>> Jagan.
>>
>> The following changes since commit
>> 5c9038b6af1a93410af966999638eabb81efcd0f:
>>
>>   omap3_beagle: use omap3-beagle.dtb for the C4 revision (2014-01-17
>> 11:03:04 -0500)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 83ba605953162443b054d5ad60535468b46558bd:
>>
>>   sf: Update bank configuration (2014-01-20 22:30:35 +0530)
>>
>> 
>> Jagannadha Sutradharudu Teki (5):
>>   sf: ops: Squash the malloc+memset combo
Agree this for -next

>>   sf: Optimize flash features code
>>   sf: Use mode_bits for dual_flash connection
>>   doc: SPI: Update the dual_flash info
>>   sf: Update bank configuration
>
> This is for -next.

Better to keep this in release - as code optimized at-least for
current framework, I'm OK with this.

>
>> Marek Vasut (3):
>>   sf: Squash the malloc+memset combo
>
> This is definitelly for -next.
>
>>   sf: Fix entries for S25FL256S_256K and S25FL512S_256K
>
> This is the only one I would let into current , since it's an actual bugfix .
> The rest are just adjustments.
>
>>   sf: Add S25FL128S_256K IDs
>
> This is an adjustment, can wait for -next.
>
>>
>>  doc/SPI/README.dual-flash |   5 +-
>>  doc/SPI/README.sf-features| 125 ++
>>  drivers/mtd/spi/sf.c  |   4 +-
>>  drivers/mtd/spi/sf_internal.h |   1 -
>>  drivers/mtd/spi/sf_ops.c  |  16 ++--
>>  drivers/mtd/spi/sf_params.c   | 171
>> +- drivers/mtd/spi/sf_probe.c|
>> 104 -
>>  include/spi.h |  42 ---
>>  include/spi_flash.h   |  24 +++---
>>  9 files changed, 301 insertions(+), 191 deletions(-)
>>  create mode 100644 doc/SPI/README.sf-features

thanks!
-- 
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-24 Thread Marek Vasut
On Wednesday, January 22, 2014 at 05:26:36 PM, Jagannadha Sutradharudu Teki 
wrote:
> Hi Tom,
> 
> SF code optimized stuff and few fixes.
> 
> --
> Thanks!
> Jagan.
> 
> The following changes since commit
> b44bd2c73c4cfb6e3b9e7f8cf987e8e39aa74a0b:
> 
>   Prepare v2014.01 (2014-01-20 17:52:59 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b53c0ea9adb7b72f4e3074d382598b6b3d9c5037:
> 
>   sf: Update bank configuration (2014-01-21 23:08:28 +0530)
> 
> 
> Jagannadha Sutradharudu Teki (5):
>   sf: ops: Squash the malloc+memset combo
>   sf: Optimize flash features code

756802dd776e5687060c50cabb64b775e64830d7 in your u-boot-spi/master still uses
#define FOO n << m
please fix

[...]

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-01-27 Thread Marek Vasut
On Monday, January 27, 2014 at 06:26:21 PM, Jagannadha Sutradharudu Teki wrote:
> Hi Tom,
> 
> SF code optimized stuff and few fixes.

Hi, I see PR, but I don't see the fixed patches reposted to the ML. Did you 
repost the new ones please ?

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-02-21 Thread Tom Rini
On Tue, Feb 18, 2014 at 10:54:30PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please take this PR, few fixes and pending patches on qspi am43xx.
> 
> thanks!
> --
> Jagan.
> 
> The following changes since commit 22a240c32c1340183fce12867ae5f8736b92a638:
> 
>   serial/serial_arc - add driver for ARC UART (2014-02-07 12:55:07 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 9ea09e20376abbca21760ed4ba87d6b5c4df465c:
> 
>   doc: SPI: Add qspi test details on AM43xx (2014-02-18 22:41:09 +0530)
> 
> 
> Markus Niebel (3):
>   spi: spi-mxc: add defines for clk inactive state for ECSPI
>   spi: spi-mxc: implement clk control for ECSPI to fix SPI_MODE_3
>   spi: mxc_spi: i.MX6 DL/S have only 4 eCSPI controller
> 
> Michal Simek (1):
>   spi: xilinx: Move timeout calculation out of the loop
> 
> Sourav Poddar (5):
>   am43xx: Add qspi support
>   am437x_epos_evm: add SPL API, QSPI, and serial flash support
>   spi: ti_qspi: Add AM43xx specifics changes
>   spi: ti_qspi: Add delay before xfer for am43xx
>   doc: SPI: Add qspi test details on AM43xx
> 
>  arch/arm/cpu/armv7/am33xx/clock_am43xx.c |  1 +
>  arch/arm/include/asm/arch-am33xx/cpu.h   |  4 +-
>  arch/arm/include/asm/arch-am33xx/omap.h  |  1 +
>  arch/arm/include/asm/arch-mx5/imx-regs.h |  7 +--
>  arch/arm/include/asm/arch-mx6/imx-regs.h |  9 ++--
>  board/ti/am43xx/mux.c| 11 +
>  doc/SPI/README.ti_qspi_am43x_test| 76 
> 
>  drivers/spi/mxc_spi.c|  9 +++-
>  drivers/spi/ti_qspi.c| 33 --
>  drivers/spi/xilinx_spi.c |  8 ++--
>  include/configs/am43xx_evm.h | 20 +
>  11 files changed, 163 insertions(+), 16 deletions(-)
>  create mode 100644 doc/SPI/README.ti_qspi_am43x_test

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-12-19 Thread Tom Rini
On Thu, Dec 19, 2013 at 11:52:00PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Small PR - addons on one spi driver, others and few fixes.
> 
> Thanks,
> Jagan.
> 
> The following changes since commit f3bf212abc4139f12b472e97c1992ab32671b609:
> 
>   serial_sh: add support for SH7753 (2013-12-18 16:50:00 +0900)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ac5cce38de8f97a120b8c98f34be0d5eec50a6fb:
> 
>   driver: mtd: sf_ops: claim bus while doing memcpy (2013-12-19 12:23:22 
> +0530)
> 
> 
> Luka Perkov (2):
>   sf: probe: Hex values are in lower case
>   sf: probe: add support for MX25L2006E
> 
> Nobuhiro Iwamatsu (1):
>   spi: Add support SH Quad SPI driver
> 
> Poddar, Sourav (2):
>   config: dra7_evm: Add Bank Address Register(BAR) config
>   driver: mtd: sf_ops: claim bus while doing memcpy
> 
> Yen Lin (1):
>   spi: tegra: clear RDY bit prior to every transfer
> 
>  doc/SPI/README.sh_qspi_test  |  38 ++
>  drivers/mtd/spi/sf_ops.c |   6 +
>  drivers/mtd/spi/sf_probe.c   |   3 +-
>  drivers/spi/Makefile |   1 +
>  drivers/spi/sh_qspi.c| 277 
> +++
>  drivers/spi/tegra114_spi.c   |  21 ++--
>  include/configs/dra7xx_evm.h |   1 +
>  7 files changed, 333 insertions(+), 14 deletions(-)
>  create mode 100644 doc/SPI/README.sh_qspi_test
>  create mode 100644 drivers/spi/sh_qspi.c

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-06-11 Thread Tom Rini
On Sun, Jun 08, 2014 at 11:27:57PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 3e1fa221f94b7ae3389d166882b77f1da5895f22:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-mpc85xx (2014-06-05 
> 17:38:30 -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 1f436a6ddf7eb7f2da1c8df6c13100429baf844a:
> 
>   sf: probe: Fix quad bit set path (2014-06-08 23:12:27 +0530)
> 
> 
> Andrew Ruder (1):
>   spi: soft_spi: Support NULL din/dout buffers
> 
> Poddar, Sourav (1):
>   sf: probe: Fix quad bit set path
> 
> Siva Durga Prasad Paladugu (1):
>   sf: params: Added support for Spansion S25FL512S_512K
> 
>  drivers/mtd/spi/sf_params.c |  1 +
>  drivers/mtd/spi/sf_probe.c  | 20 ++--
>  drivers/spi/soft_spi.c  | 18 --
>  3 files changed, 23 insertions(+), 16 deletions(-)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-14 Thread Tom Rini
On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote:

> The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320:
> 
>   powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 
> -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8:
> 
>   sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 
> +0530)
> 
> 
> Axel Lin (3):
>   spi: armada100_spi: Remove unnecessary NULL test for dout and din
>   spi: tegra114_spi: Convert to use spi_alloc_slave()
>   spi: tegra20_sflash: Remove redundant code to set bus and cs of struct 
> spi_slave
> 
> Jagannadha Sutradharudu Teki (7):
>   sf: winbond: Add support for W25Q256
>   sf: Fix sf read for memory-mapped SPI flashes
>   cmd_sf: Add print mesg for 'sf erase' command
>   cmd_sf: Add print mesgs on sf read/write commands
>   sf: spansion: Update the name for S25FL256S flash
>   sf: winbond: Add support for W25Q80BW
>   sf: winbond: Correct the nr_blocks used for W25Q32DW
> 
> Kuo-Jung Su (1):
>   sf: winbond: Add support for W25PXX SPI flash
> 
> Marek Vasut (1):
>   sf: spansion: Add Spansion S25FL064P IDs
> 
> Rajeshwari Shinde (2):
>   spi: Add support for preamble bytes
>   spi: exynos: Support SPI_PREAMBLE mode
> 
>  common/cmd_sf.c  | 34 --
>  drivers/mtd/spi/spansion.c   |  9 +-
>  drivers/mtd/spi/spi_flash.c  | 14 -
>  drivers/mtd/spi/winbond.c| 28 +++---
>  drivers/spi/armada100_spi.c  | 11 ++-
>  drivers/spi/exynos_spi.c | 69 
> +---
>  drivers/spi/tegra114_spi.c   |  4 +--
>  drivers/spi/tegra20_sflash.c |  2 --
>  include/spi.h|  5 
>  9 files changed, 122 insertions(+), 54 deletions(-)

Trying this on am335x_evm, booting from SPI:
SF: Detected W25Q64 with page size 4 KiB, total 8 MiB

U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52)
SPI error: malloc of SPI structure failed
SF: Failed to set up slave
SPI probe failed.
### ERROR ### Please RESET the board ###

malloc should have been initalized already, digging further.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-14 Thread Jagan Teki

On 14-06-2013 20:06, Tom Rini wrote:

On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote:


The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320:

   powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 
-0500)

are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8:

   sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 
+0530)


Axel Lin (3):
   spi: armada100_spi: Remove unnecessary NULL test for dout and din
   spi: tegra114_spi: Convert to use spi_alloc_slave()
   spi: tegra20_sflash: Remove redundant code to set bus and cs of struct 
spi_slave

Jagannadha Sutradharudu Teki (7):
   sf: winbond: Add support for W25Q256
   sf: Fix sf read for memory-mapped SPI flashes
   cmd_sf: Add print mesg for 'sf erase' command
   cmd_sf: Add print mesgs on sf read/write commands
   sf: spansion: Update the name for S25FL256S flash
   sf: winbond: Add support for W25Q80BW
   sf: winbond: Correct the nr_blocks used for W25Q32DW

Kuo-Jung Su (1):
   sf: winbond: Add support for W25PXX SPI flash

Marek Vasut (1):
   sf: spansion: Add Spansion S25FL064P IDs

Rajeshwari Shinde (2):
   spi: Add support for preamble bytes
   spi: exynos: Support SPI_PREAMBLE mode

  common/cmd_sf.c  | 34 --
  drivers/mtd/spi/spansion.c   |  9 +-
  drivers/mtd/spi/spi_flash.c  | 14 -
  drivers/mtd/spi/winbond.c| 28 +++---
  drivers/spi/armada100_spi.c  | 11 ++-
  drivers/spi/exynos_spi.c | 69 +---
  drivers/spi/tegra114_spi.c   |  4 +--
  drivers/spi/tegra20_sflash.c |  2 --
  include/spi.h|  5 
  9 files changed, 122 insertions(+), 54 deletions(-)


Trying this on am335x_evm, booting from SPI:
SF: Detected W25Q64 with page size 4 KiB, total 8 MiB

It's passed here?



U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52)
SPI error: malloc of SPI structure failed
SF: Failed to set up slave
SPI probe failed.
### ERROR ### Please RESET the board ###

malloc should have been initalized already, digging further.

Was this working earlier releases?
No changes w.r.t sf framework on current tree as of now.

Need to dig further and let you know.

--
Thanks,
Jagan.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-14 Thread Tom Rini
On Fri, Jun 14, 2013 at 08:15:04PM +0530, Jagan Teki wrote:
> On 14-06-2013 20:06, Tom Rini wrote:
> >On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote:
> >
> >>The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320:
> >>
> >>   powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 
> >> -0500)
> >>
> >>are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >>for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8:
> >>
> >>   sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 
> >> 23:42:46 +0530)
> >>
> >>
> >>Axel Lin (3):
> >>   spi: armada100_spi: Remove unnecessary NULL test for dout and din
> >>   spi: tegra114_spi: Convert to use spi_alloc_slave()
> >>   spi: tegra20_sflash: Remove redundant code to set bus and cs of 
> >> struct spi_slave
> >>
> >>Jagannadha Sutradharudu Teki (7):
> >>   sf: winbond: Add support for W25Q256
> >>   sf: Fix sf read for memory-mapped SPI flashes
> >>   cmd_sf: Add print mesg for 'sf erase' command
> >>   cmd_sf: Add print mesgs on sf read/write commands
> >>   sf: spansion: Update the name for S25FL256S flash
> >>   sf: winbond: Add support for W25Q80BW
> >>   sf: winbond: Correct the nr_blocks used for W25Q32DW
> >>
> >>Kuo-Jung Su (1):
> >>   sf: winbond: Add support for W25PXX SPI flash
> >>
> >>Marek Vasut (1):
> >>   sf: spansion: Add Spansion S25FL064P IDs
> >>
> >>Rajeshwari Shinde (2):
> >>   spi: Add support for preamble bytes
> >>   spi: exynos: Support SPI_PREAMBLE mode
> >>
> >>  common/cmd_sf.c  | 34 --
> >>  drivers/mtd/spi/spansion.c   |  9 +-
> >>  drivers/mtd/spi/spi_flash.c  | 14 -
> >>  drivers/mtd/spi/winbond.c| 28 +++---
> >>  drivers/spi/armada100_spi.c  | 11 ++-
> >>  drivers/spi/exynos_spi.c | 69 
> >> +---
> >>  drivers/spi/tegra114_spi.c   |  4 +--
> >>  drivers/spi/tegra20_sflash.c |  2 --
> >>  include/spi.h|  5 
> >>  9 files changed, 122 insertions(+), 54 deletions(-)
> >
> >Trying this on am335x_evm, booting from SPI:
> >SF: Detected W25Q64 with page size 4 KiB, total 8 MiB
> It's passed here?
> 
> >
> >U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52)
> >SPI error: malloc of SPI structure failed
> >SF: Failed to set up slave
> >SPI probe failed.
> >### ERROR ### Please RESET the board ###
> >
> >malloc should have been initalized already, digging further.
> Was this working earlier releases?
> No changes w.r.t sf framework on current tree as of now.
> 
> Need to dig further and let you know.

OK, I'm digging into making sure this isn't a local problem, which it
might just be :(

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-14 Thread Tom Rini
On Fri, Jun 14, 2013 at 10:51:05AM -0400, Tom Rini wrote:
> On Fri, Jun 14, 2013 at 08:15:04PM +0530, Jagan Teki wrote:
> > On 14-06-2013 20:06, Tom Rini wrote:
> > >On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki 
> > >wrote:
> > >
> > >>The following changes since commit 
> > >>48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320:
> > >>
> > >>   powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 
> > >> 18:18:16 -0500)
> > >>
> > >>are available in the git repository at:
> > >>
> > >>   git://git.denx.de/u-boot-spi.git master
> > >>
> > >>for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8:
> > >>
> > >>   sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 
> > >> 23:42:46 +0530)
> > >>
> > >>
> > >>Axel Lin (3):
> > >>   spi: armada100_spi: Remove unnecessary NULL test for dout and din
> > >>   spi: tegra114_spi: Convert to use spi_alloc_slave()
> > >>   spi: tegra20_sflash: Remove redundant code to set bus and cs of 
> > >> struct spi_slave
> > >>
> > >>Jagannadha Sutradharudu Teki (7):
> > >>   sf: winbond: Add support for W25Q256
> > >>   sf: Fix sf read for memory-mapped SPI flashes
> > >>   cmd_sf: Add print mesg for 'sf erase' command
> > >>   cmd_sf: Add print mesgs on sf read/write commands
> > >>   sf: spansion: Update the name for S25FL256S flash
> > >>   sf: winbond: Add support for W25Q80BW
> > >>   sf: winbond: Correct the nr_blocks used for W25Q32DW
> > >>
> > >>Kuo-Jung Su (1):
> > >>   sf: winbond: Add support for W25PXX SPI flash
> > >>
> > >>Marek Vasut (1):
> > >>   sf: spansion: Add Spansion S25FL064P IDs
> > >>
> > >>Rajeshwari Shinde (2):
> > >>   spi: Add support for preamble bytes
> > >>   spi: exynos: Support SPI_PREAMBLE mode
> > >>
> > >>  common/cmd_sf.c  | 34 --
> > >>  drivers/mtd/spi/spansion.c   |  9 +-
> > >>  drivers/mtd/spi/spi_flash.c  | 14 -
> > >>  drivers/mtd/spi/winbond.c| 28 +++---
> > >>  drivers/spi/armada100_spi.c  | 11 ++-
> > >>  drivers/spi/exynos_spi.c | 69 
> > >> +---
> > >>  drivers/spi/tegra114_spi.c   |  4 +--
> > >>  drivers/spi/tegra20_sflash.c |  2 --
> > >>  include/spi.h|  5 
> > >>  9 files changed, 122 insertions(+), 54 deletions(-)
> > >
> > >Trying this on am335x_evm, booting from SPI:
> > >SF: Detected W25Q64 with page size 4 KiB, total 8 MiB
> > It's passed here?
> > 
> > >
> > >U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52)
> > >SPI error: malloc of SPI structure failed
> > >SF: Failed to set up slave
> > >SPI probe failed.
> > >### ERROR ### Please RESET the board ###
> > >
> > >malloc should have been initalized already, digging further.
> > Was this working earlier releases?
> > No changes w.r.t sf framework on current tree as of now.
> > 
> > Need to dig further and let you know.
> 
> OK, I'm digging into making sure this isn't a local problem, which it
> might just be :(

Local problem, please disregard.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-14 Thread Jagan Teki
On Fri, Jun 14, 2013 at 8:23 PM, Tom Rini  wrote:
> On Fri, Jun 14, 2013 at 10:51:05AM -0400, Tom Rini wrote:
>> On Fri, Jun 14, 2013 at 08:15:04PM +0530, Jagan Teki wrote:
>> > On 14-06-2013 20:06, Tom Rini wrote:
>> > >On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki 
>> > >wrote:
>> > >
>> > >>The following changes since commit 
>> > >>48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320:
>> > >>
>> > >>   powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 
>> > >> 18:18:16 -0500)
>> > >>
>> > >>are available in the git repository at:
>> > >>
>> > >>   git://git.denx.de/u-boot-spi.git master
>> > >>
>> > >>for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8:
>> > >>
>> > >>   sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 
>> > >> 23:42:46 +0530)
>> > >>
>> > >>
>> > >>Axel Lin (3):
>> > >>   spi: armada100_spi: Remove unnecessary NULL test for dout and din
>> > >>   spi: tegra114_spi: Convert to use spi_alloc_slave()
>> > >>   spi: tegra20_sflash: Remove redundant code to set bus and cs of 
>> > >> struct spi_slave
>> > >>
>> > >>Jagannadha Sutradharudu Teki (7):
>> > >>   sf: winbond: Add support for W25Q256
>> > >>   sf: Fix sf read for memory-mapped SPI flashes
>> > >>   cmd_sf: Add print mesg for 'sf erase' command
>> > >>   cmd_sf: Add print mesgs on sf read/write commands
>> > >>   sf: spansion: Update the name for S25FL256S flash
>> > >>   sf: winbond: Add support for W25Q80BW
>> > >>   sf: winbond: Correct the nr_blocks used for W25Q32DW
>> > >>
>> > >>Kuo-Jung Su (1):
>> > >>   sf: winbond: Add support for W25PXX SPI flash
>> > >>
>> > >>Marek Vasut (1):
>> > >>   sf: spansion: Add Spansion S25FL064P IDs
>> > >>
>> > >>Rajeshwari Shinde (2):
>> > >>   spi: Add support for preamble bytes
>> > >>   spi: exynos: Support SPI_PREAMBLE mode
>> > >>
>> > >>  common/cmd_sf.c  | 34 --
>> > >>  drivers/mtd/spi/spansion.c   |  9 +-
>> > >>  drivers/mtd/spi/spi_flash.c  | 14 -
>> > >>  drivers/mtd/spi/winbond.c| 28 +++---
>> > >>  drivers/spi/armada100_spi.c  | 11 ++-
>> > >>  drivers/spi/exynos_spi.c | 69 
>> > >> +---
>> > >>  drivers/spi/tegra114_spi.c   |  4 +--
>> > >>  drivers/spi/tegra20_sflash.c |  2 --
>> > >>  include/spi.h|  5 
>> > >>  9 files changed, 122 insertions(+), 54 deletions(-)
>> > >
>> > >Trying this on am335x_evm, booting from SPI:
>> > >SF: Detected W25Q64 with page size 4 KiB, total 8 MiB
>> > It's passed here?
>> >
>> > >
>> > >U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52)
>> > >SPI error: malloc of SPI structure failed
>> > >SF: Failed to set up slave
>> > >SPI probe failed.
>> > >### ERROR ### Please RESET the board ###
>> > >
>> > >malloc should have been initalized already, digging further.
>> > Was this working earlier releases?
>> > No changes w.r.t sf framework on current tree as of now.
>> >
>> > Need to dig further and let you know.
>>
>> OK, I'm digging into making sure this isn't a local problem, which it
>> might just be :(
>
> Local problem, please disregard.

I can say there is no issue w.r.t recent change from Simon. [moving
malloc with global function spi_alloc_slave()]
http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=d3504fee73ec626117427afa08116d1dde21ba9d

--
Thanks,
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-14 Thread Tom Rini
On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote:

> The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320:
> 
>   powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 
> -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8:
> 
>   sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 
> +0530)
> 
> 
> Axel Lin (3):
>   spi: armada100_spi: Remove unnecessary NULL test for dout and din
>   spi: tegra114_spi: Convert to use spi_alloc_slave()
>   spi: tegra20_sflash: Remove redundant code to set bus and cs of struct 
> spi_slave
> 
> Jagannadha Sutradharudu Teki (7):
>   sf: winbond: Add support for W25Q256
>   sf: Fix sf read for memory-mapped SPI flashes
>   cmd_sf: Add print mesg for 'sf erase' command
>   cmd_sf: Add print mesgs on sf read/write commands
>   sf: spansion: Update the name for S25FL256S flash
>   sf: winbond: Add support for W25Q80BW
>   sf: winbond: Correct the nr_blocks used for W25Q32DW
> 
> Kuo-Jung Su (1):
>   sf: winbond: Add support for W25PXX SPI flash
> 
> Marek Vasut (1):
>   sf: spansion: Add Spansion S25FL064P IDs
> 
> Rajeshwari Shinde (2):
>   spi: Add support for preamble bytes
>   spi: exynos: Support SPI_PREAMBLE mode
> 
>  common/cmd_sf.c  | 34 --
>  drivers/mtd/spi/spansion.c   |  9 +-
>  drivers/mtd/spi/spi_flash.c  | 14 -
>  drivers/mtd/spi/winbond.c| 28 +++---
>  drivers/spi/armada100_spi.c  | 11 ++-
>  drivers/spi/exynos_spi.c | 69 
> +---
>  drivers/spi/tegra114_spi.c   |  4 +--
>  drivers/spi/tegra20_sflash.c |  2 --
>  include/spi.h|  5 
>  9 files changed, 122 insertions(+), 54 deletions(-)

Booted on am335x_evm via SPI and applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-06-25 Thread Tom Rini
On Sun, Jun 23, 2013 at 11:29:11PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> These are the major updates on current spi_flash framework to support
> all sizes of flashes in 3-byte addressing mode.
> 
> Tested these changes on stmicro, winbond and spansion flashes.
> 
> Thanks,
> Jagan.
> 
> The following changes since commit 7315cfd9e1922ee1c3c5f016e5a3b16199122172:
> 
>   NET: Fix system hanging if NET device is not installed (2013-06-19 08:32:44 
> -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b9e31be0f8adc1a55179ae3b45c9e274f4650007:
> 
>   sf: Warn to use BAR for > 16MiB flashes (2013-06-23 22:10:36 +0530)
> 
> 
> Axel Lin (2):
>   spi: cf_qspi: Use DIV_ROUND_UP at appropriate place
>   spi: mxc_spi: Use DIV_ROUND_UP at appropriate places
> 
> Jagannadha Sutradharudu Teki (23):
>   sf: spansion: Correct name of S25FL128S 64K Sector part
>   sf: winbond: Update the names for W25Q 0x40XX ID's flash parts
>   sf: winbond: Add support for W25Q128FW
>   sf: winbond: Add support for W25Q16DW
>   sf: winbond: Add support for W25QXXXFV
>   sf: Add bank address register writing support
>   sf: Discover the bank addr commands
>   sf: Read flash bank addr register at probe time
>   sf: Update sf to support all sizes of flashes
>   sf: Update sf read to support all sizes of flashes
>   sf: Add bank addr code in CONFIG_SPI_FLASH_BAR
>   sf: Use spi_flash_addr() in write call
>   sf: stmicro: Add support for N25Q512
>   sf: stmicro: Add support for N25Q512A
>   sf: stmicro: Add support for N25Q1024
>   sf: stmicro: Add support for N25Q1024A
>   sf: spansion: Add support for S25FL512S_64K
>   sf: Remove spi_flash_cmd_poll_bit()
>   sf: Add flag status register polling support
>   sf: Unify spi_flash write code
>   sf: Place the sf calls in proper order
>   sf: Add debug messages on spi_flash_read_common
>   sf: Warn to use BAR for > 16MiB flashes
> 
>  README   |   5 +
>  drivers/mtd/spi/spansion.c   |   9 +-
>  drivers/mtd/spi/spi_flash.c  | 376 
> +++
>  drivers/mtd/spi/spi_flash_internal.h |  39 +++-
>  drivers/mtd/spi/stmicro.c|  28 +++
>  drivers/mtd/spi/winbond.c|  24 ++-
>  drivers/spi/cf_qspi.c|   2 +-
>  drivers/spi/mxc_spi.c|   6 +-
>  include/spi_flash.h  |  10 +
>  9 files changed, 360 insertions(+), 139 deletions(-)

Applied to u-boot/master and tested on am335x_evm, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-08-12 Thread Tom Rini
On Sat, Aug 10, 2013 at 05:56:13PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Pull request has more likely a cleanup and one bug fixe.
> Please let me know for any issues/concerns.
> 
> Thanks,
> Jagan.
> 
> The following changes since commit d05bfd0586ccebe96e31976459c8ef45ec65e109:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-i2c (2013-08-06 09:49:06 
> -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 07a16f2a9cb6cbb0fbce72e649c7be214d7f801a:
> 
>   microblaze: Call spi_init function (2013-08-08 18:58:11 +0530)
> 
> 
> Axel Lin (2):
>   spi: fsl_espi: Use DIV_ROUND_UP instead of open-coded
>   spi: mpc8xxx_spi: Use DIV_ROUND_UP instead of open-coded
> 
> Gerlando Falauto (1):
>   cmd_sf: let "sf update" erase last sector as a whole
> 
> Jagannadha Sutradharudu Teki (9):
>   sf: eon|spansion|ramtron: Fix code cleanup
>   sf: sst: Fix code cleanup
>   sf: stmicro: Fix code cleanup
>   sf: Fix code cleanup
>   cmd_sf|env_sf: Fix code cleanup
>   sf: Fix code cleanups
>   spi: Add zynq spi controller driver
>   sf: sst: Add support for SST25WF080
>   zynq: Enable CONFIG_ZYNQ_SPI
> 
> Michal Simek (1):
>   microblaze: Call spi_init function
> 
>  arch/arm/include/asm/arch-zynq/hardware.h |   2 +
>  arch/microblaze/lib/board.c   |   5 +
>  common/cmd_sf.c   |  30 ++--
>  common/env_sf.c   |   2 +-
>  drivers/mtd/spi/atmel.c   |  10 +-
>  drivers/mtd/spi/eon.c |   3 +-
>  drivers/mtd/spi/gigadevice.c  |   2 +-
>  drivers/mtd/spi/ramtron.c |   8 +-
>  drivers/mtd/spi/spansion.c|   5 +-
>  drivers/mtd/spi/spi_flash.c   |  11 +-
>  drivers/mtd/spi/spi_spl_load.c|   2 +-
>  drivers/mtd/spi/sst.c |  40 +++--
>  drivers/mtd/spi/stmicro.c |  12 +-
>  drivers/mtd/spi/winbond.c |   2 +-
>  drivers/spi/Makefile  |   1 +
>  drivers/spi/fsl_espi.c|   6 +-
>  drivers/spi/mpc8xxx_spi.c |   2 +-
>  drivers/spi/zynq_spi.c| 280 
> ++
>  include/configs/zynq.h|   9 +
>  19 files changed, 373 insertions(+), 59 deletions(-)
>  create mode 100644 drivers/spi/zynq_spi.c

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-09-16 Thread Tom Rini
On Sun, Sep 15, 2013 at 10:49:06PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Small pull request, planning to send next bunch of request for
> next pull.
> 
> Thanks,
> Jagan.
> 
> The following changes since commit 2b26201a2aef0b310b7c04702b0dba5dea493f77:
> 
>   env_nand.c: support falling back to redundant env when writing (2013-08-22 
> 17:49:47 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b95f958d7d06b3cd117647b29b288cf168aa2ee9:
> 
>   cmd_sf: let "sf update" preserve the final part of the last sector 
> (2013-08-27 19:39:39 +0530)
> 
> 
> Gerlando Falauto (1):
>   cmd_sf: let "sf update" preserve the final part of the last sector
> 
> Marek Vasut (1):
>   spi: mxs_spi: Configure chipselect after block reset
> 
>  common/cmd_sf.c   | 13 -
>  drivers/spi/mxs_spi.c | 12 +++-
>  2 files changed, 15 insertions(+), 10 deletions(-)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2013-10-08 Thread Tom Rini
On Mon, Oct 07, 2013 at 07:52:24PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Just released pull request with new sf probe support.
> Tested these changes on stmicro, winbond, spansion and sst.
> 
> --
> Thanks,
> Jagan.
> 
> The following changes since commit f835c77fb7e57508ffe8d8ca3a092ee28add77b2:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-arm (2013-10-04 13:17:48 
> -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 3cfcf774c270ecf6289203d88f859d1f91cb318e:
> 
>   doc: SPI: Update SPI status track (2013-10-07 19:35:10 +0530)
> 
> 
> Jagannadha Sutradharudu Teki (35):
>   sf: Divide spi_flash into multiple parts
>   sf: probe: Add new spi_flash_probe support
>   sf: probe: Add support for M25P* flash parts
>   sf: probe: Add support for EN25Q* flash parts
>   sf: probe: Add support for GD25* flash parts
>   sf: probe: Add support for MX25L* flash parts
>   sf: probe: Add support for W25* flash parts
>   sf: probe: Add support for S25FL* flash parts
>   sf: probe: Add support for SST25* flash parts
>   sf: probe: Add support for AT45DB* flash parts
>   sf: probe: Give proper spacing on flash table params
>   sf: probe: Add support for SST_WP
>   sf: probe: Add support to clear flash BP# bits
>   sf: probe: Add support for erase sector selection flag
>   sf: probe: Add support for flag status polling
>   sf: probe: Simply the BAR configuration logic
>   sf: Add proper comment style on spi_flash structure
>   sf: ramtron: Add support for separate flash driver
>   sf: Remove unneeded flash drivers files
>   sf: probe: Add support for EN25Q64
>   sf: probe: Add support for S25FL256S_256K
>   sf: probe: Add support for S25FL512S_256K
>   sf: probe: Use print_size arg as page_size
>   sf: probe: Print erase_size while printing flash details
>   sf: ops: Add static qualifier to spi_flash_cmd_bankaddr_write
>   sf: probe: Add support for MX25L25635F
>   sf: probe: Add support for MX25L51235F
>   sf: Remove spi_flash_do_alloc references
>   sf: spi_flash cleanups
>   spi: spi cleanups
>   sf: Rename spi_flash files
>   doc: SPI: Add status.txt for tracking SPI subsys status
>   sf: Minor cleanups
>   sf: ramtron: Remove page_size print
>   doc: SPI: Update SPI status track
> 
> Matt Porter (3):
>   omap5: add qspi support
>   spi: add TI QSPI driver
>   dra7xx_evm: add SPL API, QSPI, and serial flash support
> 
> Poddar, Sourav (3):
>   armv7: hw_data: change clock divider setting.
>   sf: Add memory mapped read support
>   README: qspi usecase and testing documentation.
> 
> Priyanka Jain (1):
>   sf: probe: Add support for EN25S64
> 
>  arch/arm/cpu/armv7/omap5/hw_data.c |  10 +-
>  arch/arm/cpu/armv7/omap5/prcm-regs.c   |   1 +
>  arch/arm/include/asm/arch-omap5/omap.h |   3 +
>  arch/arm/include/asm/arch-omap5/spl.h  |   1 +
>  arch/arm/include/asm/omap_common.h |   1 +
>  board/ti/dra7xx/mux_data.h |  10 +
>  doc/SPI/README.ti_qspi_dra_test|  48 ++
>  doc/SPI/README.ti_qspi_flash   |  47 ++
>  doc/SPI/status.txt |  31 ++
>  drivers/mtd/spi/Makefile   |  15 +-
>  drivers/mtd/spi/atmel.c| 544 --
>  drivers/mtd/spi/eon.c  |  60 --
>  drivers/mtd/spi/gigadevice.c   |  65 ---
>  drivers/mtd/spi/macronix.c |  98 
>  drivers/mtd/spi/ramtron.c  | 122 +++-
>  drivers/mtd/spi/sf.c   |  54 ++
>  .../spi/{spi_flash_internal.h => sf_internal.h}| 140 ++---
>  drivers/mtd/spi/sf_ops.c   | 405 ++
>  drivers/mtd/spi/sf_probe.c | 363 
>  drivers/mtd/spi/spansion.c | 141 -
>  drivers/mtd/spi/spi_flash.c| 615 
> -
>  drivers/mtd/spi/sst.c  | 238 
>  drivers/mtd/spi/stmicro.c  | 202 ---
>  drivers/mtd/spi/winbond.c  | 141 -
>  drivers/spi/Makefile   |   1 +
>  drivers/spi/ti_qspi.c  | 311 +++
>  include/configs/dra7xx_evm.h   |  19 +
>  include/configs/top9000.h  |   1 -
>  include/spi.h  | 100 ++--
>  include/spi_flash.h| 103 ++--
>  30 files changed, 1592 insertions(+), 2298 deletions(-)
>  create mode 100644 doc/SPI/READM

Re: [U-Boot] Pull request: u-boot-spi/master

2013-10-15 Thread Tom Rini
On Wed, Oct 16, 2013 at 12:28:10AM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Simple PR - cleanup + some misc changes.
> 
> Thanks,
> Jagan.
> 
> The following changes since commit a707b3db562c4c3ae580e2eabb05b59adcc31846:
> 
>   buildman: Use env to pick the python from $PATH (2013-10-15 08:44:28 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 6d5ce1bd0048617d48c05de1a84fae8696081127:
> 
>   spi: mxc_spi: Fix double incrementing read pointer for unaligned buffers 
> (2013-10-16 00:14:30 +0530)
> 
> 
> Bo Shen (1):
>   sf: probe: Add missing Atmel at25df321 flash
> 
> Jagannadha Sutradharudu Teki (4):
>   sf_ops: Unify bank_sel calculation code
>   sf: Minor cleanups.
>   sf: Add GPL-2.0+ SPDX-License-Identifier for missing ones
>   spi: Add GPL-2.0+ SPDX-License-Identifier for missing files
> 
> Timo Herbrecher (1):
>   spi: mxc_spi: Fix double incrementing read pointer for unaligned buffers
> 
>  common/cmd_sf.c   |  3 ++-
>  drivers/mtd/spi/sf.c  |  2 +-
>  drivers/mtd/spi/sf_internal.h |  8 
>  drivers/mtd/spi/sf_ops.c  | 40 ++--
>  drivers/mtd/spi/sf_probe.c|  8 +---
>  drivers/spi/altera_spi.c  |  2 +-
>  drivers/spi/bfin_spi.c|  2 +-
>  drivers/spi/mxc_spi.c |  2 +-
>  drivers/spi/oc_tiny_spi.c |  2 +-
>  drivers/spi/xilinx_spi.c  |  2 +-
>  drivers/spi/xilinx_spi.h  |  2 +-
>  include/spi.h | 14 +++---
>  12 files changed, 47 insertions(+), 40 deletions(-)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-03-17 Thread Tom Rini
On Mon, Mar 17, 2014 at 10:12:24PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please take this PR, few fixes.
> 
> thanks!
> --
> Jagan.
> 
> The following changes since commit 194ba5d4ecb2ad1195333cc7453f291e5b316479:
> 
>   sh: ecovec: correct romImage address in comment (2014-03-14 14:50:28 +0900)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to bf64035a159f114d0fb93391acb7f5e73eb020e6:
> 
>   mtd: spi: Fix page size for S25FL032P,S25FL064P (2014-03-17 21:54:57 +0530)
> 
> 
> Axel Lin (1):
>   spi: atmel_dataflash: Simplify AT91F_SpiEnable implementation
> 
> Jagannadha Sutradharudu Teki (1):
>   sf: ops: Squash the malloc+memset combo
> 
> Marek Vasut (4):
>   sf: Fix entries for S25FL256S_256K and S25FL512S_256K
>   sf: Add S25FL128S_256K IDs
>   sf: Squash the malloc+memset combo
>   mtd: spi: Fix page size for S25FL032P,S25FL064P
> 
>  drivers/mtd/spi/sf_ops.c  |  8 ++--
>  drivers/mtd/spi/sf_params.c   |  5 +++--
>  drivers/mtd/spi/sf_probe.c| 19 ---
>  drivers/spi/atmel_dataflash_spi.c | 31 ---
>  4 files changed, 37 insertions(+), 26 deletions(-)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-08-06 Thread Tom Rini
On Wed, Aug 06, 2014 at 12:22:15AM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 25b4adbba018633b943a99322bfb2fb819c0bafb:
> 
>   include: remove CONFIG_SPL/CONFIG_TPL definition in config headers 
> (2014-07-30 14:42:03 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to f659b57361c4a351ef2a5fc23b9197428e2e67f0:
> 
>   spi, spi_mxc: do not hang in spi_xchg_single (2014-08-06 00:18:01 +0530)
> 
> 
> Heiko Schocher (1):
>   spi, spi_mxc: do not hang in spi_xchg_single
> 
> Marek Vasut (1):
>   sf: sf_ops: Stop leaking memory
> 
> Simon Glass (3):
>   cros_ec: Fix two bugs in the SPI implementation
>   exynos: spi: Fix calculation of SPI transaction start time
>   spi: Support half-duplex mode in FDT decode
> 
>  README   |  4 
>  doc/device-tree-bindings/spi/spi-bus.txt |  2 ++
>  drivers/misc/cros_ec_spi.c   |  4 ++--
>  drivers/mtd/spi/sf_ops.c |  1 +
>  drivers/spi/exynos_spi.c |  9 +
>  drivers/spi/mxc_spi.c| 17 +++--
>  drivers/spi/spi.c|  2 ++
>  7 files changed, 31 insertions(+), 8 deletions(-)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-04-28 Thread Tom Rini
On Tue, Apr 28, 2015 at 01:47:35PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pick this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit d77447fdb122dab290fb1ad184a62456011e6e06:
> 
>   serial: pl01x: fix PL010 regression (2015-04-21 10:05:42 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to c650ca7b4c160193791dc7a52381c71c6a29e871:
> 
>   sf: Fix to compute proper sector_size (2015-04-28 13:31:36 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-04-07 Thread Tom Rini
On Tue, Mar 31, 2015 at 12:44:46PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 662e2acb46250881ec26bc8366fc9eb1856cb7c2:
> 
>   sunxi: UTOO_P66: Add missing MAINTAINERS entry (2015-03-29 14:56:48 +0200)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 52091ad146d766cdc5ccd65430b2a4e5cb7aec32:
> 
>   spi: designware_spi: revisit FIFO size detection again (2015-03-30 01:42:49 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-09-25 Thread Tom Rini
On Wed, Sep 24, 2014 at 06:15:43PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 47d3debe1ab8315dc9ade22279e02f60eceda25b:
> 
>   Merge git://git.denx.de/u-boot-dm (2014-09-23 15:21:43 -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to bf9b86dc47988a404964c97c74e541a129719f9c:
> 
>   spi: kirkwood_spi.c: cosmetic: Fix minor coding style issues (2014-09-24 
> 17:48:56 +0530)
> 
> 
> Nikita Kiryanov (3):
>   mtd: spi: add support for M25PE16 and M25PX16
>   spi: mxc: fix sf probe when using mxc_spi
>   spl: replace CONFIG_SPL_SPI_* with CONFIG_SF_DEFAULT_*
> 
> Stefan Roese (5):
>   sf: Add M25PX64 SPI NOR flash ID
>   arm: kirkwood: spi.h: Add some missing parenthesis
>   spi: kirkwood_spi.c: Some fixes and cleanup
>   spi: kirkwood_spi.c: Make global variable static
>   spi: kirkwood_spi.c: cosmetic: Fix minor coding style issues
> 
>  arch/arm/include/asm/arch-kirkwood/spi.h  |  8 ++---
>  board/boundary/nitrogen6x/nitrogen6x.c|  5 +++
>  board/embest/mx6boards/mx6boards.c|  5 +++
>  board/freescale/mx6qsabreauto/mx6qsabreauto.c |  7 
>  board/freescale/mx6sabresd/mx6sabresd.c   |  7 
>  board/freescale/mx6slevk/mx6slevk.c   |  5 +++
>  board/gateworks/gw_ventana/gw_ventana.c   |  7 +++-
>  board/genesi/mx51_efikamx/efikamx.c   |  5 +++
>  board/ttcontrol/vision2/vision2.c |  5 +++
>  common/cmd_sf.c   | 13 
>  drivers/mtd/spi/sf_params.c   |  3 ++
>  drivers/mtd/spi/spi_spl_load.c|  6 ++--
>  drivers/spi/kirkwood_spi.c| 27 +++
>  drivers/spi/mxc_spi.c | 48 
> ++-
>  include/configs/am335x_evm.h  |  2 --
>  include/configs/da850evm.h|  4 ---
>  include/configs/dra7xx_evm.h  |  2 --
>  include/configs/embestmx6boards.h |  2 +-
>  include/configs/gw_ventana.h  |  2 +-
>  include/configs/ks2_evm.h |  2 --
>  include/configs/mx51_efikamx.h|  4 +--
>  include/configs/mx6sabre_common.h |  2 +-
>  include/configs/mx6slevk.h|  2 +-
>  include/configs/nitrogen6x.h  |  2 +-
>  include/configs/pcm051.h  |  2 --
>  include/configs/sama5d3xek.h  |  2 --
>  include/configs/siemens-am33x-common.h|  2 --
>  include/configs/tseries.h |  2 --
>  include/configs/vision2.h |  4 +--
>  include/configs/zynq-common.h |  2 --
>  include/spi_flash.h   | 13 
>  31 files changed, 115 insertions(+), 87 deletions(-)

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2014-11-03 Thread Tom Rini
On Tue, Oct 28, 2014 at 12:13:58AM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> --
> Jagan.
> 
> The following changes since commit 0ce4af99c07acebf4fce9a91f1099d2460629293:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-imx (2014-10-27 09:08:42 
> -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 027a9a002455a1175b0f5b7c7c5350afab2b4421:
> 
>   SPI: mxc_spi: delay initialisation until claim bus (2014-10-27 22:37:03 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-01-05 Thread Tom Rini
On Fri, Jan 02, 2015 at 02:15:21AM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit babe6994ca28e5a354ee32b33b7a54b0276d9df1:
> 
>   sf: sf_params: Add S25FL164K flash identifier info (2014-12-18 18:48:30 
> +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to be2fde60b0de7723d29035ba952a970d9e1ca94d:
> 
>   imx:mx6slevk add spi nor boot support (2014-12-31 14:54:01 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-01-05 Thread Tom Rini
On Mon, Dec 29, 2014 at 10:37:52PM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit e3bf81b1e841ecabe7c8b3d48621256db8b8623e:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-mpc85xx (2014-12-16 
> 15:20:02 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to babe6994ca28e5a354ee32b33b7a54b0276d9df1:
> 
>   sf: sf_params: Add S25FL164K flash identifier info (2014-12-18 18:48:30 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-01-09 Thread Tom Rini
On Fri, Jan 09, 2015 at 12:10:35AM +0530, Jagannadha Sutradharudu Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit d622ac39274a949b6445f1bfd92dc1644014388b:
> 
>   powerpc: mpc824x: remove MPC824X cpu support (2015-01-05 12:08:55 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to adc0fabfd9662fa690e866332cd4277351f991c4:
> 
>   imx:mx6sxsabresd support qspi AHB read (2015-01-09 00:03:28 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-29 Thread Jagan Teki
On 21 September 2015 at 23:56, Jagan Teki  wrote:
> Hi Michal,
>
> On 19 September 2015 at 06:38, Michal Simek  wrote:
>> On 09/19/2015 02:55 AM, Michal Simek wrote:
>>> On 09/16/2015 09:20 AM, Jagan Teki wrote:
 Hi Michal,

 On 15 September 2015 at 18:58, Simon Glass  wrote:
> Hi Jagan,
>
> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>> Hi Tom,
>>
>> Zynq patches has SPL build dependency with Simon changes [1].
>>
>> Simon, Any plan to send a PR for your changes.
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>
> These are for the zynq maintainer I think. They are not assigned to me
> in patchwork.

 Seems like this patch[1] resolves the SPL build issue, any plan on
 pushing this? of-course I will test this and let you know.


 [1] 
 http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
>>>
>>> Simon: Are you going to push it? Or do you want me to collect all of
>>> these zynq/zynqmp patches?
>>
>> Sorry I have read Simon's reaction after. I will try to collect all
>> these zynq patches and will send pull request.
>
> Please send your PR on top of these changes, and let me know for any inputs.

Seems like Michal is busy with something, Shall I go with build fix
(not sure whether it's working SPI-SPL or not)

-- Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-29 Thread Michal Simek
On 09/29/2015 11:13 PM, Jagan Teki wrote:
> On 21 September 2015 at 23:56, Jagan Teki  wrote:
>> Hi Michal,
>>
>> On 19 September 2015 at 06:38, Michal Simek  wrote:
>>> On 09/19/2015 02:55 AM, Michal Simek wrote:
 On 09/16/2015 09:20 AM, Jagan Teki wrote:
> Hi Michal,
>
> On 15 September 2015 at 18:58, Simon Glass  wrote:
>> Hi Jagan,
>>
>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>>> Hi Tom,
>>>
>>> Zynq patches has SPL build dependency with Simon changes [1].
>>>
>>> Simon, Any plan to send a PR for your changes.
>>>
>>> [1] 
>>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>
>> These are for the zynq maintainer I think. They are not assigned to me
>> in patchwork.
>
> Seems like this patch[1] resolves the SPL build issue, any plan on
> pushing this? of-course I will test this and let you know.
>
>
> [1] 
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2

 Simon: Are you going to push it? Or do you want me to collect all of
 these zynq/zynqmp patches?
>>>
>>> Sorry I have read Simon's reaction after. I will try to collect all
>>> these zynq patches and will send pull request.
>>
>> Please send your PR on top of these changes, and let me know for any inputs.
> 
> Seems like Michal is busy with something, Shall I go with build fix
> (not sure whether it's working SPI-SPL or not)

Next week I will look at it.

Thanks,
Michal

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-10-09 Thread Michal Simek
Hi Jagan,

On 09/30/2015 12:23 AM, Michal Simek wrote:
> On 09/29/2015 11:13 PM, Jagan Teki wrote:
>> On 21 September 2015 at 23:56, Jagan Teki  wrote:
>>> Hi Michal,
>>>
>>> On 19 September 2015 at 06:38, Michal Simek  wrote:
 On 09/19/2015 02:55 AM, Michal Simek wrote:
> On 09/16/2015 09:20 AM, Jagan Teki wrote:
>> Hi Michal,
>>
>> On 15 September 2015 at 18:58, Simon Glass  wrote:
>>> Hi Jagan,
>>>
>>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
 Hi Tom,

 Zynq patches has SPL build dependency with Simon changes [1].

 Simon, Any plan to send a PR for your changes.

 [1] 
 http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>>
>>> These are for the zynq maintainer I think. They are not assigned to me
>>> in patchwork.
>>
>> Seems like this patch[1] resolves the SPL build issue, any plan on
>> pushing this? of-course I will test this and let you know.
>>
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
>
> Simon: Are you going to push it? Or do you want me to collect all of
> these zynq/zynqmp patches?

 Sorry I have read Simon's reaction after. I will try to collect all
 these zynq patches and will send pull request.
>>>
>>> Please send your PR on top of these changes, and let me know for any inputs.
>>
>> Seems like Michal is busy with something, Shall I go with build fix
>> (not sure whether it's working SPI-SPL or not)
> 
> Next week I will look at it.

All your patches will go on the top of zynq/zynqmp patches and the merge
will happen after 2015.10.
Is there any particular reason to push these changes before 2015.10?

Thanks,
Michal


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-10-09 Thread Tom Rini
On Fri, Oct 09, 2015 at 03:47:59PM +0200, Michal Simek wrote:
> Hi Jagan,
> 
> On 09/30/2015 12:23 AM, Michal Simek wrote:
> > On 09/29/2015 11:13 PM, Jagan Teki wrote:
> >> On 21 September 2015 at 23:56, Jagan Teki  wrote:
> >>> Hi Michal,
> >>>
> >>> On 19 September 2015 at 06:38, Michal Simek  
> >>> wrote:
>  On 09/19/2015 02:55 AM, Michal Simek wrote:
> > On 09/16/2015 09:20 AM, Jagan Teki wrote:
> >> Hi Michal,
> >>
> >> On 15 September 2015 at 18:58, Simon Glass  wrote:
> >>> Hi Jagan,
> >>>
> >>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>  Hi Tom,
> 
>  Zynq patches has SPL build dependency with Simon changes [1].
> 
>  Simon, Any plan to send a PR for your changes.
> 
>  [1] 
>  http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
> >>>
> >>> These are for the zynq maintainer I think. They are not assigned to me
> >>> in patchwork.
> >>
> >> Seems like this patch[1] resolves the SPL build issue, any plan on
> >> pushing this? of-course I will test this and let you know.
> >>
> >>
> >> [1] 
> >> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
> >
> > Simon: Are you going to push it? Or do you want me to collect all of
> > these zynq/zynqmp patches?
> 
>  Sorry I have read Simon's reaction after. I will try to collect all
>  these zynq patches and will send pull request.
> >>>
> >>> Please send your PR on top of these changes, and let me know for any 
> >>> inputs.
> >>
> >> Seems like Michal is busy with something, Shall I go with build fix
> >> (not sure whether it's working SPI-SPL or not)
> > 
> > Next week I will look at it.
> 
> All your patches will go on the top of zynq/zynqmp patches and the merge
> will happen after 2015.10.
> Is there any particular reason to push these changes before 2015.10?

I had/have been holding this for after the merge window.  If there are
any release-critical fixes in the SPI tree they need to be put into a
separate pull request asap.  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-10-09 Thread Michal Simek
Hi Tom,

On 10/09/2015 03:54 PM, Tom Rini wrote:
> On Fri, Oct 09, 2015 at 03:47:59PM +0200, Michal Simek wrote:
>> Hi Jagan,
>>
>> On 09/30/2015 12:23 AM, Michal Simek wrote:
>>> On 09/29/2015 11:13 PM, Jagan Teki wrote:
 On 21 September 2015 at 23:56, Jagan Teki  wrote:
> Hi Michal,
>
> On 19 September 2015 at 06:38, Michal Simek  
> wrote:
>> On 09/19/2015 02:55 AM, Michal Simek wrote:
>>> On 09/16/2015 09:20 AM, Jagan Teki wrote:
 Hi Michal,

 On 15 September 2015 at 18:58, Simon Glass  wrote:
> Hi Jagan,
>
> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>> Hi Tom,
>>
>> Zynq patches has SPL build dependency with Simon changes [1].
>>
>> Simon, Any plan to send a PR for your changes.
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>
> These are for the zynq maintainer I think. They are not assigned to me
> in patchwork.

 Seems like this patch[1] resolves the SPL build issue, any plan on
 pushing this? of-course I will test this and let you know.


 [1] 
 http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
>>>
>>> Simon: Are you going to push it? Or do you want me to collect all of
>>> these zynq/zynqmp patches?
>>
>> Sorry I have read Simon's reaction after. I will try to collect all
>> these zynq patches and will send pull request.
>
> Please send your PR on top of these changes, and let me know for any 
> inputs.

 Seems like Michal is busy with something, Shall I go with build fix
 (not sure whether it's working SPI-SPL or not)
>>>
>>> Next week I will look at it.
>>
>> All your patches will go on the top of zynq/zynqmp patches and the merge
>> will happen after 2015.10.
>> Is there any particular reason to push these changes before 2015.10?
> 
> I had/have been holding this for after the merge window.  If there are
> any release-critical fixes in the SPI tree they need to be put into a
> separate pull request asap.  Thanks!

Good. I was talking to Simon yesterday and retest zynq and zynqmp SPL DM
changes which should go first to your tree and then these spi changes
should go on the top.

Thanks,
Michal



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-10-11 Thread Jagan Teki
On 9 October 2015 at 19:25, Michal Simek  wrote:
> Hi Tom,
>
> On 10/09/2015 03:54 PM, Tom Rini wrote:
>> On Fri, Oct 09, 2015 at 03:47:59PM +0200, Michal Simek wrote:
>>> Hi Jagan,
>>>
>>> On 09/30/2015 12:23 AM, Michal Simek wrote:
 On 09/29/2015 11:13 PM, Jagan Teki wrote:
> On 21 September 2015 at 23:56, Jagan Teki  wrote:
>> Hi Michal,
>>
>> On 19 September 2015 at 06:38, Michal Simek  
>> wrote:
>>> On 09/19/2015 02:55 AM, Michal Simek wrote:
 On 09/16/2015 09:20 AM, Jagan Teki wrote:
> Hi Michal,
>
> On 15 September 2015 at 18:58, Simon Glass  wrote:
>> Hi Jagan,
>>
>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>>> Hi Tom,
>>>
>>> Zynq patches has SPL build dependency with Simon changes [1].
>>>
>>> Simon, Any plan to send a PR for your changes.
>>>
>>> [1] 
>>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>
>> These are for the zynq maintainer I think. They are not assigned to 
>> me
>> in patchwork.
>
> Seems like this patch[1] resolves the SPL build issue, any plan on
> pushing this? of-course I will test this and let you know.
>
>
> [1] 
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2

 Simon: Are you going to push it? Or do you want me to collect all of
 these zynq/zynqmp patches?
>>>
>>> Sorry I have read Simon's reaction after. I will try to collect all
>>> these zynq patches and will send pull request.
>>
>> Please send your PR on top of these changes, and let me know for any 
>> inputs.
>
> Seems like Michal is busy with something, Shall I go with build fix
> (not sure whether it's working SPI-SPL or not)

 Next week I will look at it.
>>>
>>> All your patches will go on the top of zynq/zynqmp patches and the merge
>>> will happen after 2015.10.
>>> Is there any particular reason to push these changes before 2015.10?
>>
>> I had/have been holding this for after the merge window.  If there are
>> any release-critical fixes in the SPI tree they need to be put into a
>> separate pull request asap.  Thanks!
>
> Good. I was talking to Simon yesterday and retest zynq and zynqmp SPL DM
> changes which should go first to your tree and then these spi changes
> should go on the top.

No hurry with the zynq qspi patches for this release, will send the PR
again after release.
Meanwhile, I sent one more for this release [1], pls- pull the same.

[1] https://patchwork.ozlabs.org/patch/528729/

--  Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-10-12 Thread Tom Rini
On Sun, Oct 11, 2015 at 04:52:08PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 9a4c6e9abf5261f565cfbf1e80c6e17d26ad0b1e:
> 
>   sunxi: Fix USB regulators in Linksprite_pcDuino_defconfig (2015-10-10 
> 11:54:16 +0200)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 03d1d568a04b3d67e0f09b598554c2b74e31224f:
> 
>   configs: ls1021atwr: Enable DSPI for LS1021ATWR (2015-10-11 16:43:06 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-10-28 Thread Otavio Salvador
On Wed, Oct 28, 2015 at 4:22 PM, Jagan Teki  wrote:
> Please pull this PR, and skip the previous one [1]
>
> [1] https://patchwork.ozlabs.org/patch/535548/

What about Fabio's serie? it is required for the Congatec support to
go in as well.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-10-28 Thread Jagan Teki
On 28 October 2015 at 23:55, Otavio Salvador
 wrote:
> On Wed, Oct 28, 2015 at 4:22 PM, Jagan Teki  wrote:
>> Please pull this PR, and skip the previous one [1]
>>
>> [1] https://patchwork.ozlabs.org/patch/535548/
>
> What about Fabio's serie? it is required for the Congatec support to
> go in as well.

Next TODO!

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-10-28 Thread Tom Rini
On Wed, Oct 28, 2015 at 11:52:15PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR, and skip the previous one [1]
> 
> [1] https://patchwork.ozlabs.org/patch/535548/
> 
> thanks!
> Jagan.
> 
> The following changes since commit 677f970bc62a661690b3431543d5a5d5e682ba70:
> 
>   common/board_f.c: modify the macro to use get_clocks() more common 
> (2015-10-24 13:50:38 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to bef87adf95e7ca923f866e27bbcccb2dad85df9f:
> 
>   spi: altera_spi: Minor cleanup (2015-10-28 13:54:09 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-08-18 Thread Tom Rini
On Tue, Aug 18, 2015 at 12:08:17PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 632093b566569329bc6e5b0893bdca01de905314:
> 
>   Merge git://git.denx.de/u-boot-x86 (2015-08-14 16:27:16 -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to fc5e22008a668a75d108ebf8edc93849c6f9dcb4:
> 
>   ARM: dra7xx_evm: Enable EDMA3 in SPL to support DMA on qspi (2015-08-17 
> 23:29:15 +0530)
> 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-11-19 Thread Tom Rini
On Thu, Nov 19, 2015 at 11:16:40PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 3d4825446e4258192e1f2302d691a8c0c82a0975:
> 
>   Prepare v2016.01-rc1 (2015-11-16 20:29:51 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 3e56ecec435d30e25fcffb971f8c9627e85ac1df:
> 
>   sf: Correct flash->flags for SST flash (2015-11-18 12:52:05 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-12-11 Thread Tom Rini
On Fri, Dec 11, 2015 at 10:23:06PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 789fa275b3750e60c60cb3d18eabc9467892c257:
> 
>   x86: Remove HAVE_ACPI_RESUME (2015-12-09 17:44:56 +0800)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 76de51a6da0411e1f3e80e1c9a2ef5bfa8e35571:
> 
>   spi: xilinx: Add new compatible strings (2015-12-11 22:12:24 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-01-07 Thread Tom Rini
On Thu, Jan 07, 2016 at 10:32:08PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:
> 
>   Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 
> 09:15:57 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 8770413f380d07439bc9ad60c6b4d108d5a9adf0:
> 
>   spi: fsl_qspi: fix an error of using GENMASK (2016-01-07 20:29:33 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-01-13 Thread Tom Rini
On Wed, Jan 13, 2016 at 08:16:41PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR - this sent intially before the release.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 077678eb0c226e52a1f90edabd3369ab26065b32:
> 
>   Merge git://git.denx.de/u-boot-dm (2016-01-12 18:12:42 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 69b41388ba45b853b3538f5b8cac8ab2154d36d8:
> 
>   dm: core: Add a new api to get indexed device address (2016-01-13 18:54:22 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-06-24 Thread Tom Rini
On Tue, Jun 23, 2015 at 08:47:25PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this request, few importent feature list on spi-flash front
> like data flash and spi flash MTD supports.
> 
> thanks!
> Jagan.
> 
> The following changes since commit c6265f7f3410b5e5763181cdd123a3f6fcd9fd58:
> 
>   CPCI4052: Remove CONFIG_SYS_LONGHELP (2015-06-18 16:19:00 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 1070bf38a5c92c8d1a77b26380988957890ba6de:
> 
>   mtd, spi: Check if flash pointer is used (2015-06-23 01:13:23 +0530)
> 

This introduces build problems on ls1021atwr_qspi and ls1021aqds_qspi.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-06-24 Thread Heiko Schocher denx

Hello Tom,

Am 25.06.2015 um 01:31 schrieb Tom Rini:

On Tue, Jun 23, 2015 at 08:47:25PM +0530, Jagan Teki wrote:


Hi Tom,

Please pull this request, few importent feature list on spi-flash front
like data flash and spi flash MTD supports.

thanks!
Jagan.

The following changes since commit c6265f7f3410b5e5763181cdd123a3f6fcd9fd58:

   CPCI4052: Remove CONFIG_SYS_LONGHELP (2015-06-18 16:19:00 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 1070bf38a5c92c8d1a77b26380988957890ba6de:

   mtd, spi: Check if flash pointer is used (2015-06-23 01:13:23 +0530)



This introduces build problems on ls1021atwr_qspi and ls1021aqds_qspi.


Could you provide a log?

I see, based on current mainline:
commit 325849ff3d4adeebb8f8f9bc5db950724df9bc21
Merge: 8c65a2f de45149
Author: Tom Rini 
Date:   Fri Jun 19 14:21:32 2015 -0400

Merge git://git.denx.de/u-boot-usb

pollux:u-boot hs [20150527] $ make mrproper
  CLEAN   examples/standalone
  CLEAN   tools
  CLEAN   tools/lib tools/common
  CLEAN   include/bmp_logo.h include/bmp_logo_data.h u-boot.lds u-boot.bin u-boot.srec u-boot.map 
u-boot.cfg u-boot System.map

  CLEAN   scripts/basic
  CLEAN   scripts/kconfig
  CLEAN   include/config include/generated
  CLEAN   .config include/autoconf.mk.dep include/autoconf.mk include/config.h
pollux:u-boot hs [20150527] $ make ls1021atwr_qspi_defconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
pollux:u-boot hs [20150527] $ make -s all
pollux:u-boot hs [20150527] $ make mrproper
m  CLEAN   examples/standalone
a  CLEAN   tools
k  CLEAN   tools/lib tools/common
  CLEAN   include/bmp_logo.h include/bmp_logo_data.h u-boot.lds u-boot.bin u-boot.srec u-boot.map 
u-boot.cfg u-boot System.map

e ls1021aqds_qspi_  CLEAN   scripts/basic
  CLEAN   scripts/kconfig
  CLEAN   include/config include/generated
d  CLEAN   .config include/autoconf.mk.dep include/autoconf.mk include/config.h
pollux:u-boot hs [20150527] $ make ls1021aqds_qspi_defconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
pollux:u-boot hs [20150527] $ make -s all
pollux:u-boot hs [20150527] $

Thanks!

bye,
Heiko





___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot



--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-06-24 Thread Jagan Teki
On 25 June 2015 at 05:01, Tom Rini  wrote:
> On Tue, Jun 23, 2015 at 08:47:25PM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this request, few importent feature list on spi-flash front
>> like data flash and spi flash MTD supports.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit c6265f7f3410b5e5763181cdd123a3f6fcd9fd58:
>>
>>   CPCI4052: Remove CONFIG_SYS_LONGHELP (2015-06-18 16:19:00 -0400)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 1070bf38a5c92c8d1a77b26380988957890ba6de:
>>
>>   mtd, spi: Check if flash pointer is used (2015-06-23 01:13:23 +0530)
>>
>
> This introduces build problems on ls1021atwr_qspi and ls1021aqds_qspi.

Don't know what it causes, I applied manually all 8 patches on master
and I couldn't
see any issues.

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-06-25 Thread Tom Rini
On Thu, Jun 25, 2015 at 11:01:44AM +0530, Jagan Teki wrote:
> On 25 June 2015 at 05:01, Tom Rini  wrote:
> > On Tue, Jun 23, 2015 at 08:47:25PM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this request, few importent feature list on spi-flash front
> >> like data flash and spi flash MTD supports.
> >>
> >> thanks!
> >> Jagan.
> >>
> >> The following changes since commit 
> >> c6265f7f3410b5e5763181cdd123a3f6fcd9fd58:
> >>
> >>   CPCI4052: Remove CONFIG_SYS_LONGHELP (2015-06-18 16:19:00 -0400)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to 1070bf38a5c92c8d1a77b26380988957890ba6de:
> >>
> >>   mtd, spi: Check if flash pointer is used (2015-06-23 01:13:23 +0530)
> >>
> >
> > This introduces build problems on ls1021atwr_qspi and ls1021aqds_qspi.
> 
> Don't know what it causes, I applied manually all 8 patches on master
> and I couldn't
> see any issues.

Same for both:
   arm:  +   ls1021atwr_qspi
+(ls1021atwr_qspi) drivers/mtd/spi/sf_probe.c: In function 
'spi_flash_std_probe':
+(ls1021atwr_qspi) drivers/mtd/spi/sf_probe.c:480:54: error: dereferencing 
pointer to i
ncomplete type
+(ls1021atwr_qspi)   debug("%s: slave=%p, cs=%d\n", __func__, slave, plat->cs);
+(ls1021atwr_qspi)   ^
+(ls1021atwr_qspi) include/common.h:109:26: note: in definition of macro 
'debug_cond'
+(ls1021atwr_qspi) printf(pr_fmt(fmt), ##args); \
+(ls1021atwr_qspi)   ^
+(ls1021atwr_qspi) drivers/mtd/spi/sf_probe.c:480:2: note: in expansion of 
macro 'debug
'
+(ls1021atwr_qspi)   ^
+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c: In function 'spi_flash_free':
+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c:47:29: error: 'struct spi_slave' 
has no member named 'dev'
+(ls1021atwr_qspi)   spi_flash_remove(flash->spi->dev);
+(ls1021atwr_qspi)  ^
+(ls1021atwr_qspi)   ret = spi_get_bus_and_cs(busnum, cs, max_hz, spi_mode,
+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c:66:15: error: 'struct spi_slave' 
has no member named 'dev'
+(ls1021atwr_qspi)   *devp = slave->dev;
+(ls1021atwr_qspi)^
+(ls1021atwr_qspi) make[2]: *** [drivers/mtd/spi/sf_probe.o] Error 1
+(ls1021atwr_qspi) make[2]: *** [drivers/mtd/spi/sf-uclass.o] Error 1
+(ls1021atwr_qspi) make[1]: *** [drivers/mtd/spi] Error 2
+(ls1021atwr_qspi)   ret = spi_find_bus_and_cs(bus, cs, &bus_dev, &new);
+(ls1021atwr_qspi) make: *** [sub-make] Error 2
w+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c: In function 
'spi_flash_probe_bus_cs':
w+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c:61:2: warning: implicit 
declaration of function 'spi_get_bus_and_cs' [-Wimplicit-function-declaration]
w+(ls1021atwr_qspi) common/cmd_sf.c: In function 'do_spi_flash_probe':
w+(ls1021atwr_qspi) common/cmd_sf.c:123:2: warning: implicit declaration of 
function 'spi_find_bus_and_cs' [-Wimplicit-function-declaration]

Because CONFIG_DM is not set, and before the SPI patches this is fine but
now it's causing this failure.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-06-25 Thread Jagan Teki
On 25 June 2015 at 17:06, Tom Rini  wrote:
> On Thu, Jun 25, 2015 at 11:01:44AM +0530, Jagan Teki wrote:
>> On 25 June 2015 at 05:01, Tom Rini  wrote:
>> > On Tue, Jun 23, 2015 at 08:47:25PM +0530, Jagan Teki wrote:
>> >
>> >> Hi Tom,
>> >>
>> >> Please pull this request, few importent feature list on spi-flash front
>> >> like data flash and spi flash MTD supports.
>> >>
>> >> thanks!
>> >> Jagan.
>> >>
>> >> The following changes since commit 
>> >> c6265f7f3410b5e5763181cdd123a3f6fcd9fd58:
>> >>
>> >>   CPCI4052: Remove CONFIG_SYS_LONGHELP (2015-06-18 16:19:00 -0400)
>> >>
>> >> are available in the git repository at:
>> >>
>> >>   git://git.denx.de/u-boot-spi.git master
>> >>
>> >> for you to fetch changes up to 1070bf38a5c92c8d1a77b26380988957890ba6de:
>> >>
>> >>   mtd, spi: Check if flash pointer is used (2015-06-23 01:13:23 +0530)
>> >>
>> >
>> > This introduces build problems on ls1021atwr_qspi and ls1021aqds_qspi.
>>
>> Don't know what it causes, I applied manually all 8 patches on master
>> and I couldn't
>> see any issues.
>
> Same for both:
>arm:  +   ls1021atwr_qspi
> +(ls1021atwr_qspi) drivers/mtd/spi/sf_probe.c: In function 
> 'spi_flash_std_probe':
> +(ls1021atwr_qspi) drivers/mtd/spi/sf_probe.c:480:54: error: dereferencing 
> pointer to i
> ncomplete type
> +(ls1021atwr_qspi)   debug("%s: slave=%p, cs=%d\n", __func__, slave, 
> plat->cs);
> +(ls1021atwr_qspi)   ^
> +(ls1021atwr_qspi) include/common.h:109:26: note: in definition of macro 
> 'debug_cond'
> +(ls1021atwr_qspi) printf(pr_fmt(fmt), ##args); \
> +(ls1021atwr_qspi)   ^
> +(ls1021atwr_qspi) drivers/mtd/spi/sf_probe.c:480:2: note: in expansion of 
> macro 'debug
> '
> +(ls1021atwr_qspi)   ^
> +(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c: In function 'spi_flash_free':
> +(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c:47:29: error: 'struct 
> spi_slave' has no member named 'dev'
> +(ls1021atwr_qspi)   spi_flash_remove(flash->spi->dev);
> +(ls1021atwr_qspi)  ^
> +(ls1021atwr_qspi)   ret = spi_get_bus_and_cs(busnum, cs, max_hz, spi_mode,
> +(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c:66:15: error: 'struct 
> spi_slave' has no member named 'dev'
> +(ls1021atwr_qspi)   *devp = slave->dev;
> +(ls1021atwr_qspi)^
> +(ls1021atwr_qspi) make[2]: *** [drivers/mtd/spi/sf_probe.o] Error 1
> +(ls1021atwr_qspi) make[2]: *** [drivers/mtd/spi/sf-uclass.o] Error 1
> +(ls1021atwr_qspi) make[1]: *** [drivers/mtd/spi] Error 2
> +(ls1021atwr_qspi)   ret = spi_find_bus_and_cs(bus, cs, &bus_dev, &new);
> +(ls1021atwr_qspi) make: *** [sub-make] Error 2
> w+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c: In function 
> 'spi_flash_probe_bus_cs':
> w+(ls1021atwr_qspi) drivers/mtd/spi/sf-uclass.c:61:2: warning: implicit 
> declaration of function 'spi_get_bus_and_cs' [-Wimplicit-function-declaration]
> w+(ls1021atwr_qspi) common/cmd_sf.c: In function 'do_spi_flash_probe':
> w+(ls1021atwr_qspi) common/cmd_sf.c:123:2: warning: implicit declaration of 
> function 'spi_find_bus_and_cs' [-Wimplicit-function-declaration]
>
> Because CONFIG_DM is not set, and before the SPI patches this is fine but
> now it's causing this failure.

Looks like some other dependencies about CONFIG_DM, let me look at it.
and will come back.

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-06-29 Thread Tom Rini
On Tue, Jun 30, 2015 at 12:54:52AM +0530, Jagan Teki wrote:

> Please pull this request, few importent feature list on spi-flash front
> like data flash and spi flash MTD supports.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 7853d76b0bdab9b1a4da0bba8da6d12b5b8a303f:
> 
>   Merge git://git.denx.de/u-boot-marvell (2015-06-28 16:31:32 -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 8ee81b7f9b675cb675119a998b04ca843d24ddcd:
> 
>   mtd, spi: Check if flash pointer is used (2015-06-30 00:40:11 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-07-01 Thread Tom Rini
On Wed, Jul 01, 2015 at 11:03:26PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull these series for Kconfig/defconfig updates
> for spi/sf subsystems.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 8ee81b7f9b675cb675119a998b04ca843d24ddcd:
> 
>   mtd, spi: Check if flash pointer is used (2015-06-30 00:40:11 +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 8aa5f1d971df0f668144759991e19b5195606a32:
> 
>   spi: cf_qspi: fix clamp macro type check compilation warnings (2015-07-01 
> 22:58:50 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-07-04 Thread Tom Rini
On Sat, Jul 04, 2015 at 02:11:35PM +0530, Jagan Teki wrote:
> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 891b487098ee2169a16b1bbb354aaef28aa90630:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-07-01 15:38:12 
> -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 8097cba809d8c40d8fe72f792c7dc0644c845a32:
> 
>   spi: cadence_qspi: add device tree binding doc (2015-07-03 13:50:53 +0530)
> 
> 
> Vikas Manocha (10):
>   stv0991: enable saving enrironment in spi flash
>   stv0991: move OF_CONTROL config to defconfig
>   stv0991: remove define CONFIG_OF_SEPARATE from board file
>   stv0991: configure clock & pad muxing for qspi
>   stv0991: enable cadence qspi controller & spi flash
>   stv0991: configure device tree for cadence qspi & flash
>   spi: cadence_qspi: move the sram partition in init
>   spi: cadence_qspi: get sram size from device tree
>   spi: cadence_qspi: support FIFO width other than 4 bytes
>   spi: cadence_qspi: add device tree binding doc

Given the planned release on the 13th, is any of this stuff that can't
wait?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-02-23 Thread Tom Rini
On Tue, Feb 23, 2016 at 04:19:01PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this series.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 595af9db2422fa5ae734cfe615415b17a5098f34:
> 
>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-02-21 
> 07:56:16 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 674f3609aad39f099a5c3605643a6be124504b96:
> 
>   spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN (2016-02-23 
> 16:14:46 +0530)
> 

Applied to u-boot/master, thanks!

Mugunthan, can you please test QSPI boot on J6 or J6Eco?  My board isn't
behaving well and I couldn't walk Nishanth through doing it on his (or,
there's a problem..).  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-02-25 Thread Mugunthan V N
On Wednesday 24 February 2016 02:05 AM, Tom Rini wrote:
> On Tue, Feb 23, 2016 at 04:19:01PM +0530, Jagan Teki wrote:
> 
>> Hi Tom,
>>
>> Please pull this series.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 595af9db2422fa5ae734cfe615415b17a5098f34:
>>
>>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-02-21 
>> 07:56:16 -0500)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 674f3609aad39f099a5c3605643a6be124504b96:
>>
>>   spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN (2016-02-23 
>> 16:14:46 +0530)
>>
> 
> Applied to u-boot/master, thanks!
> 
> Mugunthan, can you please test QSPI boot on J6 or J6Eco?  My board isn't
> behaving well and I couldn't walk Nishanth through doing it on his (or,
> there's a problem..).  Thanks!
> 

Tom, I will do a qspi boot test tomorrow and update here.

Regards
Mugunthan V N
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-02-29 Thread Mugunthan V N
On Wednesday 24 February 2016 02:05 AM, Tom Rini wrote:
> On Tue, Feb 23, 2016 at 04:19:01PM +0530, Jagan Teki wrote:
> 
>> Hi Tom,
>>
>> Please pull this series.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 595af9db2422fa5ae734cfe615415b17a5098f34:
>>
>>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-02-21 
>> 07:56:16 -0500)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 674f3609aad39f099a5c3605643a6be124504b96:
>>
>>   spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN (2016-02-23 
>> 16:14:46 +0530)
>>
> 
> Applied to u-boot/master, thanks!
> 
> Mugunthan, can you please test QSPI boot on J6 or J6Eco?  My board isn't
> behaving well and I couldn't walk Nishanth through doing it on his (or,
> there's a problem..).  Thanks!
> 

Tom, I am able to boot DRA74x EVM in QSPI boot Logs [1].

[1] - http://pastebin.ubuntu.com/15249899/

Regards
Mugunthan V N
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-03-13 Thread Tom Rini
On Sat, Mar 12, 2016 at 08:14:47PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take these two fixes for this release.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 76aab9eb8b4618891914e41fa1ea84441f8c53fd:
> 
>   exynos5: common: Enable CONFIG_USB_ETHER_RTL8152 ethernet support 
> (2016-03-11 10:59:51 +0900)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ea9619aed6908e83b0679bd9c9aa4ae97714ef97:
> 
>   sf: Correct data types in stm_is_locked_sr() (2016-03-12 19:55:42 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-03-15 Thread Tom Rini
On Tue, Mar 15, 2016 at 12:41:20PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:
> 
>   Prepare v2016.03 (2016-03-14 10:20:21 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:
> 
>   spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-03-15 Thread Tom Rini
On Tue, Mar 15, 2016 at 08:01:14AM -0400, Tom Rini wrote:
> On Tue, Mar 15, 2016 at 12:41:20PM +0530, Jagan Teki wrote:
> 
> > Hi Tom,
> > 
> > Please pull this PR.
> > 
> > thanks!
> > Jagan.
> > 
> > The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:
> > 
> >   Prepare v2016.03 (2016-03-14 10:20:21 -0400)
> > 
> > are available in the git repository at:
> > 
> >   git://git.denx.de/u-boot-spi.git master
> > 
> > for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:
> > 
> >   spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)
> > 
> 
> Applied to u-boot/master, thanks!

But, bah!

+(cm_t3517,cm_t35) drivers/spi/built-in.o:(.bss.priv+0x0): multiple definition 
of `priv'
+(cm_t3517,cm_t35) drivers/built-in.o:(.bss.priv+0x0): first defined here
+(cm_t3517,cm_t35) arm-linux-gnueabi-ld.bfd: Warning: size of symbol `priv' 
changed from 20 in drivers/built-in.o to 4 in drivers/spi/built-in.o
+(cm_t3517,cm_t35) make[1]: *** [u-boot] Error 1
+(cm_t3517,cm_t35) make: *** [sub-make] Error 2

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-07-07 Thread Jagan Teki
On 4 July 2015 at 17:12, Tom Rini  wrote:
> On Sat, Jul 04, 2015 at 02:11:35PM +0530, Jagan Teki wrote:
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 891b487098ee2169a16b1bbb354aaef28aa90630:
>>
>>   Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-07-01 15:38:12 
>> -0400)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 8097cba809d8c40d8fe72f792c7dc0644c845a32:
>>
>>   spi: cadence_qspi: add device tree binding doc (2015-07-03 13:50:53 +0530)
>>
>> 
>> Vikas Manocha (10):
>>   stv0991: enable saving enrironment in spi flash
>>   stv0991: move OF_CONTROL config to defconfig
>>   stv0991: remove define CONFIG_OF_SEPARATE from board file
>>   stv0991: configure clock & pad muxing for qspi
>>   stv0991: enable cadence qspi controller & spi flash
>>   stv0991: configure device tree for cadence qspi & flash
>>   spi: cadence_qspi: move the sram partition in init
>>   spi: cadence_qspi: get sram size from device tree
>>   spi: cadence_qspi: support FIFO width other than 4 bytes
>>   spi: cadence_qspi: add device tree binding doc
>
> Given the planned release on the 13th, is any of this stuff that can't
> wait?  Thanks!

No issues, May be you can apply once tag done.

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2015-07-14 Thread Tom Rini
On Sat, Jul 04, 2015 at 02:11:35PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 891b487098ee2169a16b1bbb354aaef28aa90630:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-spi (2015-07-01 15:38:12 
> -0400)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 8097cba809d8c40d8fe72f792c7dc0644c845a32:
> 
>   spi: cadence_qspi: add device tree binding doc (2015-07-03 13:50:53 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-15 Thread Simon Glass
Hi Jagan,

On 15 September 2015 at 02:13, Jagan Teki  wrote:
> Hi Tom,
>
> Zynq patches has SPL build dependency with Simon changes [1].
>
> Simon, Any plan to send a PR for your changes.
>
> [1] 
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working

These are for the zynq maintainer I think. They are not assigned to me
in patchwork.

>
> thanks!
> Jagan.
>
> The following changes since commit 850f788709cef8f7d53d571aec3bfb73b14c5531:
>
>   Merge branch 'rmobile' of git://git.denx.de/u-boot-sh (2015-09-13 17:25:16 
> -0400)
>
> are available in the git repository at:
>
>
>   git://git.denx.de/u-boot-spi.git master
>
> for you to fetch changes up to a63981e1727139c51f05d3fa1cb1b299d2c00a7d:
>
>   zynq-common: Add SPL SPI offset, size configs (2015-09-15 13:31:44 +0530)
>
> 
> Jagan Teki (23):
>   spi: Add zynq qspi controller driver
>   dts: zynq: Add zynq qspi controller nodes
>   doc: device-tree-bindings: spi: Add zynq qspi info
>   dts: microzed: Enable zynq qspi controller node
>   dts: zc702: Enable zynq qspi controller node
>   dts: zc706: Enable zynq qspi controller node
>   dts: zc770-xm010: Enable zynq qspi controller node
>   dts: zed: Enable zynq qspi controller node
>   configs: Enable legacy SPI flash interface support
>   zynq-common: Enable zynq qspi controller support
>   zynq-common: Enable Bank/Extended address register support
>   configs: zynq: Enable zynq qspi controller
>   spi: Kconfig: Add Zynq QSPI controller entry
>   spi: zynq_spi: Add config reg shift named macros
>   spi: zynq_spi: Rename baudrate divisor mask name
>   spi: zynq_spi: Store cs value into private data
>   sf: params: Add IS25LP032 part support
>   sf: params: Add IS25LP064 part support
>   sf: params: Add IS25LP128 part support
>   zynq-common: Enable ISSI SPI-NOR flash support
>   spi: xilinx_spi: Fix to configure CPOL, CPHA mask
>   spi: zynq_spi: Fix to configure CPOL, CPHA mask
>   spi: zynq_qspi: Fix to configure CPOL, CPHA mask
>
> Mirza Krak (1):
>   spi: tegra20: Add support for mode selection
>
> Siva Durga Prasad Paladugu (1):
>   zynq-common: Add SPL SPI offset, size configs
>
>  arch/arm/dts/zynq-7000.dtsi|  12 +
>  arch/arm/dts/zynq-microzed.dts |   5 +
>  arch/arm/dts/zynq-zc702.dts|   5 +
>  arch/arm/dts/zynq-zc706.dts|   5 +
>  arch/arm/dts/zynq-zc770-xm010.dts  |   7 +-
>  arch/arm/dts/zynq-zed.dts  |   5 +
>  configs/zynq_microzed_defconfig|   2 +
>  configs/zynq_zc702_defconfig   |   2 +
>  configs/zynq_zc706_defconfig   |   2 +
>  configs/zynq_zc70x_defconfig   |   2 +
>  configs/zynq_zc770_xm010_defconfig |   1 +
>  configs/zynq_zed_defconfig |   2 +
>  doc/device-tree-bindings/spi/spi-zynq-qspi.txt |  26 ++
>  drivers/mtd/spi/sf_params.c|   5 +
>  drivers/spi/Kconfig|   9 +
>  drivers/spi/Makefile   |   1 +
>  drivers/spi/tegra20_slink.c|  21 +
>  drivers/spi/xilinx_spi.c   |  10 +-
>  drivers/spi/zynq_qspi.c| 623 
> +
>  drivers/spi/zynq_spi.c |  27 +-
>  include/configs/zynq-common.h  |  15 +
>  21 files changed, 771 insertions(+), 16 deletions(-)
>  create mode 100644 doc/device-tree-bindings/spi/spi-zynq-qspi.txt
>  create mode 100644 drivers/spi/zynq_qspi.c

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-16 Thread Jagan Teki
Hi Michal,

On 15 September 2015 at 18:58, Simon Glass  wrote:
> Hi Jagan,
>
> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>> Hi Tom,
>>
>> Zynq patches has SPL build dependency with Simon changes [1].
>>
>> Simon, Any plan to send a PR for your changes.
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>
> These are for the zynq maintainer I think. They are not assigned to me
> in patchwork.

Seems like this patch[1] resolves the SPL build issue, any plan on
pushing this? of-course I will test this and let you know.


[1] 
http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2

>>
>> The following changes since commit 850f788709cef8f7d53d571aec3bfb73b14c5531:
>>
>>   Merge branch 'rmobile' of git://git.denx.de/u-boot-sh (2015-09-13 17:25:16 
>> -0400)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to a63981e1727139c51f05d3fa1cb1b299d2c00a7d:
>>
>>   zynq-common: Add SPL SPI offset, size configs (2015-09-15 13:31:44 +0530)
>>
>> 
>> Jagan Teki (23):
>>   spi: Add zynq qspi controller driver
>>   dts: zynq: Add zynq qspi controller nodes
>>   doc: device-tree-bindings: spi: Add zynq qspi info
>>   dts: microzed: Enable zynq qspi controller node
>>   dts: zc702: Enable zynq qspi controller node
>>   dts: zc706: Enable zynq qspi controller node
>>   dts: zc770-xm010: Enable zynq qspi controller node
>>   dts: zed: Enable zynq qspi controller node
>>   configs: Enable legacy SPI flash interface support
>>   zynq-common: Enable zynq qspi controller support
>>   zynq-common: Enable Bank/Extended address register support
>>   configs: zynq: Enable zynq qspi controller
>>   spi: Kconfig: Add Zynq QSPI controller entry
>>   spi: zynq_spi: Add config reg shift named macros
>>   spi: zynq_spi: Rename baudrate divisor mask name
>>   spi: zynq_spi: Store cs value into private data
>>   sf: params: Add IS25LP032 part support
>>   sf: params: Add IS25LP064 part support
>>   sf: params: Add IS25LP128 part support
>>   zynq-common: Enable ISSI SPI-NOR flash support
>>   spi: xilinx_spi: Fix to configure CPOL, CPHA mask
>>   spi: zynq_spi: Fix to configure CPOL, CPHA mask
>>   spi: zynq_qspi: Fix to configure CPOL, CPHA mask
>>
>> Mirza Krak (1):
>>   spi: tegra20: Add support for mode selection
>>
>> Siva Durga Prasad Paladugu (1):
>>   zynq-common: Add SPL SPI offset, size configs
>>
>>  arch/arm/dts/zynq-7000.dtsi|  12 +
>>  arch/arm/dts/zynq-microzed.dts |   5 +
>>  arch/arm/dts/zynq-zc702.dts|   5 +
>>  arch/arm/dts/zynq-zc706.dts|   5 +
>>  arch/arm/dts/zynq-zc770-xm010.dts  |   7 +-
>>  arch/arm/dts/zynq-zed.dts  |   5 +
>>  configs/zynq_microzed_defconfig|   2 +
>>  configs/zynq_zc702_defconfig   |   2 +
>>  configs/zynq_zc706_defconfig   |   2 +
>>  configs/zynq_zc70x_defconfig   |   2 +
>>  configs/zynq_zc770_xm010_defconfig |   1 +
>>  configs/zynq_zed_defconfig |   2 +
>>  doc/device-tree-bindings/spi/spi-zynq-qspi.txt |  26 ++
>>  drivers/mtd/spi/sf_params.c|   5 +
>>  drivers/spi/Kconfig|   9 +
>>  drivers/spi/Makefile   |   1 +
>>  drivers/spi/tegra20_slink.c|  21 +
>>  drivers/spi/xilinx_spi.c   |  10 +-
>>  drivers/spi/zynq_qspi.c| 623 
>> +
>>  drivers/spi/zynq_spi.c |  27 +-
>>  include/configs/zynq-common.h  |  15 +
>>  21 files changed, 771 insertions(+), 16 deletions(-)
>>  create mode 100644 doc/device-tree-bindings/spi/spi-zynq-qspi.txt
>>  create mode 100644 drivers/spi/zynq_qspi.c

thanks!
-- 
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-18 Thread Michal Simek
On 09/16/2015 09:20 AM, Jagan Teki wrote:
> Hi Michal,
> 
> On 15 September 2015 at 18:58, Simon Glass  wrote:
>> Hi Jagan,
>>
>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>>> Hi Tom,
>>>
>>> Zynq patches has SPL build dependency with Simon changes [1].
>>>
>>> Simon, Any plan to send a PR for your changes.
>>>
>>> [1] 
>>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>
>> These are for the zynq maintainer I think. They are not assigned to me
>> in patchwork.
> 
> Seems like this patch[1] resolves the SPL build issue, any plan on
> pushing this? of-course I will test this and let you know.
> 
> 
> [1] 
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2

Simon: Are you going to push it? Or do you want me to collect all of
these zynq/zynqmp patches?

Thanks,
Michal
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-19 Thread Michal Simek
On 09/19/2015 02:55 AM, Michal Simek wrote:
> On 09/16/2015 09:20 AM, Jagan Teki wrote:
>> Hi Michal,
>>
>> On 15 September 2015 at 18:58, Simon Glass  wrote:
>>> Hi Jagan,
>>>
>>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
 Hi Tom,

 Zynq patches has SPL build dependency with Simon changes [1].

 Simon, Any plan to send a PR for your changes.

 [1] 
 http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>>
>>> These are for the zynq maintainer I think. They are not assigned to me
>>> in patchwork.
>>
>> Seems like this patch[1] resolves the SPL build issue, any plan on
>> pushing this? of-course I will test this and let you know.
>>
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
> 
> Simon: Are you going to push it? Or do you want me to collect all of
> these zynq/zynqmp patches?

Sorry I have read Simon's reaction after. I will try to collect all
these zynq patches and will send pull request.

Thanks,
Michal

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull-request: u-boot-spi/master

2015-09-21 Thread Jagan Teki
Hi Michal,

On 19 September 2015 at 06:38, Michal Simek  wrote:
> On 09/19/2015 02:55 AM, Michal Simek wrote:
>> On 09/16/2015 09:20 AM, Jagan Teki wrote:
>>> Hi Michal,
>>>
>>> On 15 September 2015 at 18:58, Simon Glass  wrote:
 Hi Jagan,

 On 15 September 2015 at 02:13, Jagan Teki  wrote:
> Hi Tom,
>
> Zynq patches has SPL build dependency with Simon changes [1].
>
> Simon, Any plan to send a PR for your changes.
>
> [1] 
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working

 These are for the zynq maintainer I think. They are not assigned to me
 in patchwork.
>>>
>>> Seems like this patch[1] resolves the SPL build issue, any plan on
>>> pushing this? of-course I will test this and let you know.
>>>
>>>
>>> [1] 
>>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
>>
>> Simon: Are you going to push it? Or do you want me to collect all of
>> these zynq/zynqmp patches?
>
> Sorry I have read Simon's reaction after. I will try to collect all
> these zynq patches and will send pull request.

Please send your PR on top of these changes, and let me know for any inputs.

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-05-06 Thread Tom Rini
On Wed, May 03, 2017 at 05:43:46PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit a63d800196ebee59b0f8ff924f67843cd597a8c1:
> 
>   Prepare v2017.05-rc3 (2017-05-01 19:54:41 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 2f54205829429d82c7591340a106bf68f3916120:
> 
>   drivers: spi: Remove duplicate .probe method (2017-05-03 11:52:16 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-09-25 Thread Łukasz Majewski

Hi Jagan,


Hi Tom,

Please pull this PR.


Would you find some time and look into following patch:

http://patchwork.ozlabs.org/patch/813266/

Thanks in advance,
Łukasz



thanks!
Jagan.

The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:

   tools/mkimage: Make the path to the dtc binary that mkimage calls 
configurable (2017-09-24 07:33:03 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to db10809c17c7cd8960d0c45248bbef6e76251ad7:

   Fix s25fl256s position in spi_flash_ids list (2017-09-25 13:00:34 +0530)


Marek Vasut (1):
   sf: Fix S25FL116K entry

Peng Fan (1):
   spi: mxc_spi: support driver model

Suresh Gupta (1):
   spi: fsl_qspi: Add controller busy check before new spi operation

Vsevolod Gribov (1):
   Fix s25fl256s position in spi_flash_ids list

Yogesh Gaur (1):
   mtd/spi: Add MT35XU512ABA1G12 NOR flash support

  drivers/mtd/spi/spi_flash_ids.c |   5 +-
  drivers/spi/fsl_qspi.c  |  28 ++-
  drivers/spi/fsl_qspi.h  |   4 +
  drivers/spi/mxc_spi.c   | 181 +---
  4 files changed, 183 insertions(+), 35 deletions(-)
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot




--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-09-25 Thread Jagan Teki
On Mon, Sep 25, 2017 at 2:11 PM, Łukasz Majewski  wrote:
> Hi Jagan,
>
>> Hi Tom,
>>
>> Please pull this PR.
>
>
> Would you find some time and look into following patch:
>
> http://patchwork.ozlabs.org/patch/813266/

Of-course, will comment on respective patch itself.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-09-26 Thread Tom Rini
On Mon, Sep 25, 2017 at 01:21:35PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
> 
>   tools/mkimage: Make the path to the dtc binary that mkimage calls 
> configurable (2017-09-24 07:33:03 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to db10809c17c7cd8960d0c45248bbef6e76251ad7:
> 
>   Fix s25fl256s position in spi_flash_ids list (2017-09-25 13:00:34 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-10-18 Thread Tom Rini
On Tue, Oct 17, 2017 at 07:20:04PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 10509987285515b0a969c39ef7374fea3545851b:
> 
>   spi: fsl_qspi: Copy 16 byte aligned data in TX FIFO (2017-09-25 15:45:15 
> +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ca1ac16da097bf0ab176b1a201653553160dc042:
> 
>   sf: bar: Clean BA24 Bank Address Register bit after read/write/erase 
> operation (2017-09-27 13:31:59 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-08-16 Thread Tom Rini
On Wed, Aug 16, 2017 at 06:30:39PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit eaa90e5df2a4a1cb12fb73571978a9379242d0b5:
> 
>   common/env_embedded.c: rename PPCENV/PPCTEXT macros (2017-08-04 20:38:39 
> -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 294f2050c438d1e4ab39fd040d394927772048f2:
> 
>   sf: Preserve QE bit when clearing BP# bits for Macronix flash (2017-08-16 
> 18:21:50 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-07-09 Thread Tom Rini
On Sat, Jul 09, 2016 at 09:00:16PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this series.

We are about 2 days from release.  None of these changes are clearly 
critical for release bug fixes.  I will pick this up after the release,
thanks.

> 
> thanks!
> Jagan.
> 
> The following changes since commit e8009beff6d5c55c1bf1ae8184791f167e6378b0:
> 
>   Merge git://git.denx.de/u-boot-arc (2016-07-04 11:46:21 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 96907c0fe50a856f66f60ade68864a2d7949bf15:
> 
>   dm: spi: Read default speed and mode values from DT (2016-07-09 20:16:34 
> +0530)
> 
> 
> Anatolij Gustschin (1):
>   spi: spi-uclass: fix typo in debug output
> 
> Vignesh R (18):
>   dm: core: implement dev_map_physmem()
>   spi: davinci_spi: Convert to driver to adapt to DM
>   keystone2: spi: do not define DM_SPI and DM_SPI_FLASH for SPL build
>   ARM: dts: keystone2: add SPI aliases for davinci SPI nodes
>   ARM: dts: k2hk: Enable Davinci SPI controller
>   defconfig: k2hk_evm_defconfig: enable SPI driver model
>   ARM: dts: k2e: Enable Davinci SPI controller
>   defconfig: k2e_evm_defconfig: enable SPI driver model
>   ARM: dts: k2l: Enable Davinci SPI controller
>   defconfig: k2l_evm_defconfig: enable SPI driver model
>   ARM: dts: k2g: add support for Davinci SPI controller
>   defconfig: k2g_evm_defconfig: enable SPI driver model
>   spi: cadence_qspi_apb: Support 32 bit AHB address
>   spi: cadence_quadspi: Enable QUAD mode based on DT data
>   ARM: dts: K2G: Add support for QSPI controller
>   defconfig: k2g_evm_defconfig: Enable Cadence QSPI controller
>   ARM: dts: dra7x: Support QSPI MODE-0 operation at 64MHz
>   dm: spi: Read default speed and mode values from DT
> 
>  arch/arm/dts/dra7-evm.dts|   6 +-
>  arch/arm/dts/dra72-evm.dts   |   6 +-
>  arch/arm/dts/k2e-evm.dts |   3 +-
>  arch/arm/dts/k2g-evm.dts |  69 
>  arch/arm/dts/k2g.dtsi|  61 +++
>  arch/arm/dts/k2hk-evm.dts|   3 +-
>  arch/arm/dts/k2l-evm.dts |   3 +-
>  arch/arm/dts/keystone.dtsi   |   3 +
>  cmd/sf.c |   2 +
>  common/env_sf.c  |   8 +-
>  configs/k2e_evm_defconfig|   2 +
>  configs/k2g_evm_defconfig|   4 +
>  configs/k2hk_evm_defconfig   |   2 +
>  configs/k2l_evm_defconfig|   2 +
>  drivers/core/device.c|  11 ++
>  drivers/spi/cadence_qspi.c   |   3 +-
>  drivers/spi/cadence_qspi.h   |   2 +-
>  drivers/spi/cadence_qspi_apb.c   |  15 +-
>  drivers/spi/davinci_spi.c| 329 
> +--
>  drivers/spi/spi-uclass.c |  10 +-
>  include/configs/k2g_evm.h|   6 +
>  include/configs/ti_armv7_keystone2.h |   4 +
>  include/dm/device.h  |  13 ++
>  23 files changed, 450 insertions(+), 117 deletions(-)

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-07-12 Thread Tom Rini
On Sat, Jul 09, 2016 at 09:00:16PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this series.
> 
> thanks!
> Jagan.
> 
> The following changes since commit e8009beff6d5c55c1bf1ae8184791f167e6378b0:
> 
>   Merge git://git.denx.de/u-boot-arc (2016-07-04 11:46:21 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 96907c0fe50a856f66f60ade68864a2d7949bf15:
> 
>   dm: spi: Read default speed and mode values from DT (2016-07-09 20:16:34 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-07-29 Thread Tom Rini
On Sat, Jul 30, 2016 at 12:18:15AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 4711e7f7af839b41a6d78490257a9e7975494dd3:
> 
>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-07-28 
> 08:45:00 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 08887ed4505ec14ee94ab32c482dc4dec5ddc1e4:
> 
>   ARM: am57xx_evm: Enable QSPI support (2016-07-30 00:15:07 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-08-09 Thread Tom Rini
On Tue, Aug 09, 2016 at 05:33:59PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this request.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 08887ed4505ec14ee94ab32c482dc4dec5ddc1e4:
> 
>   ARM: am57xx_evm: Enable QSPI support (2016-07-30 00:15:07 +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 53208741d6c3448b7a7f5260d52c28f912ff6453:
> 
>   dm: at91: Add driver model support for the spi driver (2016-07-31 17:03:33 
> +0530)
> 

NAK.  The atmel DM prep stuff needs to be taken in, all at once perhaps,
by Andreas all at once to avoid warnings like:
+   sama5d4_xplained_spiflash
+(sama5d4_xplained_spiflash)  static int clk_get_by_name(struct udevice *dev, 
const char *name,
+(sama5d4_xplained_spiflash) ^
w+(sama5d4_xplained_spiflash) In file included from drivers/spi/atmel_spi.c:7:0:
w+(sama5d4_xplained_spiflash) include/clk.h:107:12: warning: 'clk_get_by_name' 
defined but not used [-Wunused-function]
that Marek also hit with the USB patch.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-01-15 Thread Tom Rini
On Sun, Jan 15, 2017 at 06:32:14PM +0100, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 70c1e0474a9df2c4493b4e2330cc41d3132b4e90:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2017-01-12 21:20:51 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 68e7999ba9de0a15dd3dc99e078b70f41eb98c82:
> 
>   spi: Zap cf_qspi driver and related code (2017-01-15 18:29:04 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-09-22 Thread Tom Rini
On Thu, Sep 22, 2016 at 08:32:48PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 9b1b6d42256a4c2e59c803afdbf90d39371e61ba:
> 
>   Revert "Increase default of CONFIG_SYS_MALLOC_F_LEN for SPL_OF_CONTROL" 
> (2016-09-19 15:20:09 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to fe4753cbc6c51f712024121aad0d21293d6a85fc:
> 
>   configs: fsl: Move SPI/SPI-FLASH configs to defconfig (2016-09-22 14:17:02 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-03-15 Thread Jagan Teki
On 15 March 2016 at 20:34, Tom Rini  wrote:
> On Tue, Mar 15, 2016 at 08:01:14AM -0400, Tom Rini wrote:
>> On Tue, Mar 15, 2016 at 12:41:20PM +0530, Jagan Teki wrote:
>>
>> > Hi Tom,
>> >
>> > Please pull this PR.
>> >
>> > thanks!
>> > Jagan.
>> >
>> > The following changes since commit 
>> > df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:
>> >
>> >   Prepare v2016.03 (2016-03-14 10:20:21 -0400)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.denx.de/u-boot-spi.git master
>> >
>> > for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:
>> >
>> >   spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)
>> >
>>
>> Applied to u-boot/master, thanks!
>
> But, bah!
>
> +(cm_t3517,cm_t35) drivers/spi/built-in.o:(.bss.priv+0x0): multiple 
> definition of `priv'
> +(cm_t3517,cm_t35) drivers/built-in.o:(.bss.priv+0x0): first defined here
> +(cm_t3517,cm_t35) arm-linux-gnueabi-ld.bfd: Warning: size of symbol `priv' 
> changed from 20 in drivers/built-in.o to 4 in drivers/spi/built-in.o
> +(cm_t3517,cm_t35) make[1]: *** [u-boot] Error 1
> +(cm_t3517,cm_t35) make: *** [sub-make] Error 2
>

Ohh, yes look like an issue with global priv on non-dm stuff, will send the fix.

thanks!
-- 
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-11-13 Thread Tom Rini
On Sat, Nov 12, 2016 at 05:43:08PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take these fixes.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 38cacdab3b5a6d8efd16a4b2620f7ab72144a624:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-tegra (2016-11-08 
> 10:36:57 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 7480b35fd19d18871d09fc0447d978d8d10c05b8:
> 
>   spi: ti_qspi: Fix baudrate divider calculation (2016-11-11 17:22:47 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-11-18 Thread Tom Rini
On Fri, Nov 18, 2016 at 04:46:03PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit c2cbd164ea5b5f564fcf03447c7bf9ec4a9f5699:
> 
>   Merge branch 'master' of http://git.denx.de/u-boot-mmc (2016-11-17 11:46:56 
> -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 84cdc6e27aede7d87322842d262f0414824bb126:
> 
>   sf: Fix s25fs512s id table (2016-11-18 13:04:55 +0530)
> 

NAK, this has a build failure that travis-ci catches:
https://travis-ci.org/trini/u-boot/jobs/177155166

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-11-20 Thread Jagan Teki
Hi Tom,

On Sat, Nov 19, 2016 at 6:27 AM, Tom Rini  wrote:
> On Fri, Nov 18, 2016 at 04:46:03PM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit c2cbd164ea5b5f564fcf03447c7bf9ec4a9f5699:
>>
>>   Merge branch 'master' of http://git.denx.de/u-boot-mmc (2016-11-17 
>> 11:46:56 -0500)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 84cdc6e27aede7d87322842d262f0414824bb126:
>>
>>   sf: Fix s25fs512s id table (2016-11-18 13:04:55 +0530)
>>
>
> NAK, this has a build failure that travis-ci catches:
> https://travis-ci.org/trini/u-boot/jobs/177155166

Fixed the same, please consider the same PR again.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-11-22 Thread Tom Rini
On Sun, Nov 20, 2016 at 05:29:41PM +0530, Jagan Teki wrote:
> Hi Tom,
> 
> On Sat, Nov 19, 2016 at 6:27 AM, Tom Rini  wrote:
> > On Fri, Nov 18, 2016 at 04:46:03PM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> thanks!
> >> Jagan.
> >>
> >> The following changes since commit 
> >> c2cbd164ea5b5f564fcf03447c7bf9ec4a9f5699:
> >>
> >>   Merge branch 'master' of http://git.denx.de/u-boot-mmc (2016-11-17 
> >> 11:46:56 -0500)
> >>
> >> are available in the git repository at:
> >>
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to 84cdc6e27aede7d87322842d262f0414824bb126:
> >>
> >>   sf: Fix s25fs512s id table (2016-11-18 13:04:55 +0530)
> >>
> >
> > NAK, this has a build failure that travis-ci catches:
> > https://travis-ci.org/trini/u-boot/jobs/177155166
> 
> Fixed the same, please consider the same PR again.

Applied, but in the future please send a new PR out, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-12-14 Thread Tom Rini
On Wed, Dec 14, 2016 at 04:36:58PM +0100, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 136179bec19f4bc84227cba138214ea392a723ea:
> 
>   colibri_pxa270: transition to driver model for serial (2016-11-23 13:53:20 
> +0100)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 6c11b3a89fe9cd5ef8070b2a13103f6f466860f1:
> 
>   sf: Do not force the DT memory map size to exactly match the device 
> (2016-12-14 16:30:04 +0100)
> 

NAK:
https://travis-ci.org/trini/u-boot/jobs/184036802

Please fix, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2016-12-23 Thread Tom Rini
On Sat, Dec 24, 2016 at 12:39:22AM +0100, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 4cf5c5f1e60e6541630ae829b5fa2db704c268f0:
> 
>   Prepare v2017.01-rc2 (2016-12-19 16:08:57 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master 
> 
> for you to fetch changes up to b98fa02e8a1480eeab6c7e10eb1a2a9971a11497:
> 
>   spi: Zap armada100_spi.c and env (2016-12-23 11:13:04 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-08-05 Thread Tom Rini
On Sat, Aug 04, 2018 at 09:43:24PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit a839c3641e4de98981695056eeeb2ec17ba1a4ab:
> 
>   ARM: tegra: align carveout size (2018-08-01 20:06:10 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 7f25d8179776226a8ecfbaad3d3a88e9acd89f28:
> 
>   arm: sunxi: Allwinner A10 SPI driver (2018-08-03 11:14:08 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-06-28 Thread Tom Rini
On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
> 13:12:53 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> 
>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-07-02 Thread Tom Rini
On Mon, Jul 02, 2018 at 11:05:35PM +0530, Jagan Teki wrote:

> Hi,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> 
>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 +0530)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 069b746ad9e66ab75973020f992e059c06cf3a7c:
> 
>   sf: Enable FSR polling on N25Q256(A) (2018-06-28 19:58:40 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-07-16 Thread Tom Rini
On Mon, Jul 16, 2018 at 06:31:19PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 5e9a9645816edcc68c09729f257e0c863292bf26:
> 
>   mach-stm32: Rename CONFIG_SPL_RESET_SUPPORT to CONFIG_SPL_DM_RESET 
> (2018-07-13 14:47:29 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 51b2411946e5f247f26fde41a7227a002270d376:
> 
>   sf: add paired dev info for winbond w25q16jv (2018-07-16 14:17:13 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-05-30 Thread Tom Rini
On Wed, May 30, 2018 at 11:38:37PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 31dd8efeb661c8db9175a09cf2bab090906a:
> 
>   usb: composite convert __set_bit to generic_set_bit (2018-05-15 21:44:05 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to a2569f12f0efaad2b1e0754a19f373275562f91e:
> 
>   sf: Add Macronix MX25U25635F ID (2018-05-29 10:05:52 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-06-06 Thread Tom Rini
On Tue, Jun 05, 2018 at 11:58:34PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 809e0e398a91db7bf8b4d6259d9bfc6fbd6bce83:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-06-04 
> 08:55:00 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b1f2b72e39465f2d4582bb4d8c426489ee94e2d9:
> 
>   sf: Add support for gd25q32b gigadevice flash (2018-06-04 23:40:04 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-06-25 Thread Tom Rini
On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
> 13:12:53 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> 
>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 +0530)
> 
> 
> Ashish Kumar (1):
>   mtd: spi: Correct parameters for s25fs512s flash
> 
> Hannes Schmelzer (2):
>   spi: omap3: pre-initialize bus-speed with max. slave-speed
>   spi: omap3: fix set_speed and set_mode dm callbacks
> 
> Michael Trimarchi (2):
>   spi: mxc: Fix compilation problem of DM_SPI class driver
>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
> 
> Vipul Kumar (1):
>   spi: zynq_qspi: Fixed incorrect return value error

I thought we had a change or two from Marek that were bug fixes that
should be brought in?  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-06-26 Thread Jagan Teki
On Tue, Jun 26, 2018 at 3:05 AM, Tom Rini  wrote:
> On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks,
>> Jagan.
>>
>> The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392:
>>
>>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
>> 13:12:53 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
>>
>>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 
>> +0530)
>>
>> 
>> Ashish Kumar (1):
>>   mtd: spi: Correct parameters for s25fs512s flash
>>
>> Hannes Schmelzer (2):
>>   spi: omap3: pre-initialize bus-speed with max. slave-speed
>>   spi: omap3: fix set_speed and set_mode dm callbacks
>>
>> Michael Trimarchi (2):
>>   spi: mxc: Fix compilation problem of DM_SPI class driver
>>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
>>
>> Vipul Kumar (1):
>>   spi: zynq_qspi: Fixed incorrect return value error
>
> I thought we had a change or two from Marek that were bug fixes that
> should be brought in?  Thanks!

One fix from Marek "sf: Set current flash bank to 0 in clean_bar()"
already in master, other one is under discussion [1]. are you
referring any other fixes?

[1] https://patchwork.ozlabs.org/patch/920094/
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-06-27 Thread Tom Rini
On Wed, Jun 27, 2018 at 12:17:56PM +0530, Jagan Teki wrote:
> On Tue, Jun 26, 2018 at 3:05 AM, Tom Rini  wrote:
> > On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> thanks,
> >> Jagan.
> >>
> >> The following changes since commit 
> >> 77b5ba5d2b94c5b028991c82782493f64bd4f392:
> >>
> >>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
> >> 13:12:53 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> >>
> >>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 
> >> +0530)
> >>
> >> 
> >> Ashish Kumar (1):
> >>   mtd: spi: Correct parameters for s25fs512s flash
> >>
> >> Hannes Schmelzer (2):
> >>   spi: omap3: pre-initialize bus-speed with max. slave-speed
> >>   spi: omap3: fix set_speed and set_mode dm callbacks
> >>
> >> Michael Trimarchi (2):
> >>   spi: mxc: Fix compilation problem of DM_SPI class driver
> >>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
> >>
> >> Vipul Kumar (1):
> >>   spi: zynq_qspi: Fixed incorrect return value error
> >
> > I thought we had a change or two from Marek that were bug fixes that
> > should be brought in?  Thanks!
> 
> One fix from Marek "sf: Set current flash bank to 0 in clean_bar()"
> already in master, other one is under discussion [1]. are you
> referring any other fixes?
> 
> [1] https://patchwork.ozlabs.org/patch/920094/

That didn't seem under discussion to me, it seemed like it had been
explained as a correct change given the datasheet.  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-06-27 Thread Jagan Teki
On Wed, Jun 27, 2018 at 8:50 PM, Tom Rini  wrote:
> On Wed, Jun 27, 2018 at 12:17:56PM +0530, Jagan Teki wrote:
>> On Tue, Jun 26, 2018 at 3:05 AM, Tom Rini  wrote:
>> > On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:
>> >
>> >> Hi Tom,
>> >>
>> >> Please pull this PR.
>> >>
>> >> thanks,
>> >> Jagan.
>> >>
>> >> The following changes since commit 
>> >> 77b5ba5d2b94c5b028991c82782493f64bd4f392:
>> >>
>> >>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
>> >> 13:12:53 -0400)
>> >>
>> >> are available in the Git repository at:
>> >>
>> >>   git://git.denx.de/u-boot-spi.git master
>> >>
>> >> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
>> >>
>> >>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 
>> >> +0530)
>> >>
>> >> 
>> >> Ashish Kumar (1):
>> >>   mtd: spi: Correct parameters for s25fs512s flash
>> >>
>> >> Hannes Schmelzer (2):
>> >>   spi: omap3: pre-initialize bus-speed with max. slave-speed
>> >>   spi: omap3: fix set_speed and set_mode dm callbacks
>> >>
>> >> Michael Trimarchi (2):
>> >>   spi: mxc: Fix compilation problem of DM_SPI class driver
>> >>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
>> >>
>> >> Vipul Kumar (1):
>> >>   spi: zynq_qspi: Fixed incorrect return value error
>> >
>> > I thought we had a change or two from Marek that were bug fixes that
>> > should be brought in?  Thanks!
>>
>> One fix from Marek "sf: Set current flash bank to 0 in clean_bar()"
>> already in master, other one is under discussion [1]. are you
>> referring any other fixes?
>>
>> [1] https://patchwork.ozlabs.org/patch/920094/
>
> That didn't seem under discussion to me, it seemed like it had been
> explained as a correct change given the datasheet.  Thanks!

Please see my last comment on that patch, I'm waiting for response for
the same. don't understand why we discuss here, if all fine that patch
anyway go into next PR.

Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2017-12-19 Thread Tom Rini
On Tue, Dec 19, 2017 at 05:54:21PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 16fa2eb95172e63820ee5f3d4052f3362a6de84e:
> 
>   ARM: dra7: Kconfig: Add thermal configs for dra7xx and am57xx (2017-11-21 
> 08:03:39 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 065592b40b41b11ee66d8ff71a55156bf1b35088:
> 
>   mtd/spi: fix block count for is25lq040b (2017-12-19 17:33:48 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Pull request: u-boot-spi/master

2018-01-22 Thread Tom Rini
On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 98691a60abffb44303d7dae6e9e699d0daded930:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
> 
>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
> 10:39:13 +0530)
> 

NAK:

commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
Author: Álvaro Fernández Rojas 
Date:   Sat Jan 20 02:11:34 2018 +0100

wait_bit: add 8/16/32 BE/LE versions of wait_for_bit

Add 8/16/32 bits and BE/LE versions of wait_for_bit.
This is needed for reading registers that are not aligned to 32 bits, and 
for
Big Endian platforms.

Signed-off-by: Álvaro Fernández Rojas 
Reviewed-by: Daniel Schwierzeck 
Reviewed-by: Jagan Teki 

Adds warnings on almost all platforms:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
?wait_for_bit_be16?:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: implicit 
declaration of function ?readw_be? [-Wimplicit-function-declaration]
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
../include/wait_bit.h:78:31: warning: implicit declaration of function 
?readl_be? [-Wimplicit-function-declaration]

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


  1   2   >