Re: [U-Boot] fdt: remove unaligned access in fdt_fixup_ethernet()
Hi Stephen, Sorry for not applying this in a timely manner. Thanks, Tom, for covering for me. gvb On 06/07/2013 02:19 PM, Tom Rini wrote: On Mon, May 27, 2013 at 06:01:19PM -, Stephen Warren wrote: Some ARM compilers may emit code that makes unaligned accesses when faced with constructs such as: char mac[16] = ethaddr; Replace this with a strcpy() call instead to avoid this. strcpy() is used here, rather than replacing all usage of the mac variable with the string itself, since the loop itself sprintf()s to the variable each iteration, so strcpy() is doing basically the same thing. Reported-by: Florian Meier Signed-off-by: Stephen Warren swar...@wwwdotorg.org Applied to u-boot/master, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] fdt: remove unaligned access in fdt_fixup_ethernet()
On Mon, May 27, 2013 at 06:01:19PM -, Stephen Warren wrote: Some ARM compilers may emit code that makes unaligned accesses when faced with constructs such as: char mac[16] = ethaddr; Replace this with a strcpy() call instead to avoid this. strcpy() is used here, rather than replacing all usage of the mac variable with the string itself, since the loop itself sprintf()s to the variable each iteration, so strcpy() is doing basically the same thing. Reported-by: Florian Meier Signed-off-by: Stephen Warren swar...@wwwdotorg.org Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
