Re: [U-Boot] u-boot-mmc fails on almost every Tegra board
Hi Stephen, On 01/23/2018 02:02 AM, Stephen Warren wrote: > Jaehoon, > > The latest commit in u-boot-mmc.git master branch fails on almost every Tegra > board. The MMC device experiences an error during initialization and hence > isn't available: Thanks for reporting this. I'm not sure but it seems that relevant to my fixing patch. commit 9546eb92cb648a8bba0aa9d5930ac751e6e5b9a4 Author: Jaehoon Chung Date: Wed Jan 17 19:36:58 2018 +0900 mmc: fix the wrong disabling clock When power is off, clock is not disabling. Because it's passed to 1, mmc->clock should be set to f_min value. Some drivers can't initialize the eMMC/SD card with current status. This patch is to fix the disabling clock value to 0. Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off") Signed-off-by: Jaehoon Chung Reviewed-by: Jean-Jacques Hiblot Tested-by: Guillaume GARDET Tested-by: Anand Moon Will check on today. And share the result. Thanks! Best Regards, Jaehoon Chung > > U-Boot 2018.01-05974-gb9b4f146c9 (Jan 22 2018 - 09:18:42 -0700), Build: > jenkins-u-boot-denx_uboot_mmc-master-build-U_BOOT_BOARD=p2371-2180-151 > > TEGRA210 > Model: NVIDIA P2371-2180 > Board: NVIDIA P2371-2180 > DRAM: 3.5 GiB > MMC: sdhci@700b: 1, sdhci@700b0600: 0 > tegra_mmc_send_cmd_bounced: waiting for status update > mmc_init: -110, time 1068 > *** Warning - No block device, using default environment > > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] u-boot-mmc fails on almost every Tegra board
Hi Stephen, On 01/23/2018 10:39 AM, Jaehoon Chung wrote: > Hi Stephen, > > On 01/23/2018 02:02 AM, Stephen Warren wrote: >> Jaehoon, >> >> The latest commit in u-boot-mmc.git master branch fails on almost every >> Tegra board. The MMC device experiences an error during initialization and >> hence isn't available: > > Thanks for reporting this. I'm not sure but it seems that relevant to my > fixing patch. > > commit 9546eb92cb648a8bba0aa9d5930ac751e6e5b9a4 > Author: Jaehoon Chung > Date: Wed Jan 17 19:36:58 2018 +0900 > > mmc: fix the wrong disabling clock > > When power is off, clock is not disabling. > Because it's passed to 1, mmc->clock should be set to f_min value. > Some drivers can't initialize the eMMC/SD card with current status. > > This patch is to fix the disabling clock value to 0. > > Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off") > > Signed-off-by: Jaehoon Chung > Reviewed-by: Jean-Jacques Hiblot > Tested-by: Guillaume GARDET > Tested-by: Anand Moon > > Will check on today. And share the result. Thanks! I reproduced this issue. i will send the patch for fixing. Thanks! Best Regards, Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> >> U-Boot 2018.01-05974-gb9b4f146c9 (Jan 22 2018 - 09:18:42 -0700), Build: >> jenkins-u-boot-denx_uboot_mmc-master-build-U_BOOT_BOARD=p2371-2180-151 >> >> TEGRA210 >> Model: NVIDIA P2371-2180 >> Board: NVIDIA P2371-2180 >> DRAM: 3.5 GiB >> MMC: sdhci@700b: 1, sdhci@700b0600: 0 >> tegra_mmc_send_cmd_bounced: waiting for status update >> mmc_init: -110, time 1068 >> *** Warning - No block device, using default environment >> >> >> > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] u-boot-mmc fails on almost every Tegra board
On 01/23/2018 01:24 PM, Jaehoon Chung wrote: > Hi Stephen, > > On 01/23/2018 10:39 AM, Jaehoon Chung wrote: >> Hi Stephen, >> >> On 01/23/2018 02:02 AM, Stephen Warren wrote: >>> Jaehoon, >>> >>> The latest commit in u-boot-mmc.git master branch fails on almost every >>> Tegra board. The MMC device experiences an error during initialization and >>> hence isn't available: >> >> Thanks for reporting this. I'm not sure but it seems that relevant to my >> fixing patch. >> >> commit 9546eb92cb648a8bba0aa9d5930ac751e6e5b9a4 >> Author: Jaehoon Chung >> Date: Wed Jan 17 19:36:58 2018 +0900 >> >> mmc: fix the wrong disabling clock >> >> When power is off, clock is not disabling. >> Because it's passed to 1, mmc->clock should be set to f_min value. >> Some drivers can't initialize the eMMC/SD card with current status. >> >> This patch is to fix the disabling clock value to 0. >> >> Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off") >> >> Signed-off-by: Jaehoon Chung >> Reviewed-by: Jean-Jacques Hiblot >> Tested-by: Guillaume GARDET >> Tested-by: Anand Moon >> >> Will check on today. And share the result. Thanks! > > I reproduced this issue. i will send the patch for fixing. Thanks! I sent the patch..refer to the below URL. If it's ok, let me know. http://patchwork.ozlabs.org/patch/864607/ Best Regards, Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> >> Best Regards, >> Jaehoon Chung >> >>> >>> U-Boot 2018.01-05974-gb9b4f146c9 (Jan 22 2018 - 09:18:42 -0700), Build: >>> jenkins-u-boot-denx_uboot_mmc-master-build-U_BOOT_BOARD=p2371-2180-151 >>> >>> TEGRA210 >>> Model: NVIDIA P2371-2180 >>> Board: NVIDIA P2371-2180 >>> DRAM: 3.5 GiB >>> MMC: sdhci@700b: 1, sdhci@700b0600: 0 >>> tegra_mmc_send_cmd_bounced: waiting for status update >>> mmc_init: -110, time 1068 >>> *** Warning - No block device, using default environment >>> >>> >>> >> >> ___ >> U-Boot mailing list >> U-Boot@lists.denx.de >> https://lists.denx.de/listinfo/u-boot >> > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot