Re: SDL 2.0 in gitlab
Hi Tom, On Sun, 2 Feb 2020 at 09:56, Tom Rini wrote: > > On Sun, Feb 02, 2020 at 09:14:56AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 13 Jan 2020 at 14:27, Tom Rini wrote: > > > > > > On Sun, Jan 12, 2020 at 09:01:18PM +1300, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > I have a series which changes sandbox over to use the newer SDL2. At > > > > present I cannot make it pass on gitlab since it seems to have SDL1.2 > > > > (only). > > > > > > > > Is it possible to change that? > > > > > > Yes, change > > > https://gitlab.denx.de/u-boot/gitlab-ci-runner/blob/master/Dockerfile#L35 > > > and also > > > https://gitlab.denx.de/u-boot/u-boot/blob/master/.travis.yml#L22 > > > at the same time. Testing will be a little hard as you'll need to > > > change your local .gitlab/.azure files to use your docker image to > > > confirm the changes. > > > > OK thanks It's just a case of adding libsdl2-dev to the list. I put > > the travis change in the series already. > > > > I created a commit. But how do I submit a change to the > > gitlib-ci-runner project? I don't seem to be able to fork it or push > > to it, but I see others have made changes. > > Post to the regular ML, prefix it so it's clear that it's for the gitlab > file and I'll pick it up and sync things up. OK thanks, done. Regards, Simon
Re: SDL 2.0 in gitlab
On Sun, Feb 02, 2020 at 09:14:56AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 13 Jan 2020 at 14:27, Tom Rini wrote: > > > > On Sun, Jan 12, 2020 at 09:01:18PM +1300, Simon Glass wrote: > > > > > Hi Tom, > > > > > > I have a series which changes sandbox over to use the newer SDL2. At > > > present I cannot make it pass on gitlab since it seems to have SDL1.2 > > > (only). > > > > > > Is it possible to change that? > > > > Yes, change > > https://gitlab.denx.de/u-boot/gitlab-ci-runner/blob/master/Dockerfile#L35 > > and also > > https://gitlab.denx.de/u-boot/u-boot/blob/master/.travis.yml#L22 > > at the same time. Testing will be a little hard as you'll need to > > change your local .gitlab/.azure files to use your docker image to > > confirm the changes. > > OK thanks It's just a case of adding libsdl2-dev to the list. I put > the travis change in the series already. > > I created a commit. But how do I submit a change to the > gitlib-ci-runner project? I don't seem to be able to fork it or push > to it, but I see others have made changes. Post to the regular ML, prefix it so it's clear that it's for the gitlab file and I'll pick it up and sync things up. -- Tom signature.asc Description: PGP signature
Re: SDL 2.0 in gitlab
Hi Tom, On Mon, 13 Jan 2020 at 14:27, Tom Rini wrote: > > On Sun, Jan 12, 2020 at 09:01:18PM +1300, Simon Glass wrote: > > > Hi Tom, > > > > I have a series which changes sandbox over to use the newer SDL2. At > > present I cannot make it pass on gitlab since it seems to have SDL1.2 > > (only). > > > > Is it possible to change that? > > Yes, change > https://gitlab.denx.de/u-boot/gitlab-ci-runner/blob/master/Dockerfile#L35 > and also > https://gitlab.denx.de/u-boot/u-boot/blob/master/.travis.yml#L22 > at the same time. Testing will be a little hard as you'll need to > change your local .gitlab/.azure files to use your docker image to > confirm the changes. OK thanks It's just a case of adding libsdl2-dev to the list. I put the travis change in the series already. I created a commit. But how do I submit a change to the gitlib-ci-runner project? I don't seem to be able to fork it or push to it, but I see others have made changes. Regards, Simon
Re: SDL 2.0 in gitlab
On Sun, Jan 12, 2020 at 09:01:18PM +1300, Simon Glass wrote: > Hi Tom, > > I have a series which changes sandbox over to use the newer SDL2. At > present I cannot make it pass on gitlab since it seems to have SDL1.2 > (only). > > Is it possible to change that? Yes, change https://gitlab.denx.de/u-boot/gitlab-ci-runner/blob/master/Dockerfile#L35 and also https://gitlab.denx.de/u-boot/u-boot/blob/master/.travis.yml#L22 at the same time. Testing will be a little hard as you'll need to change your local .gitlab/.azure files to use your docker image to confirm the changes. -- Tom signature.asc Description: PGP signature
SDL 2.0 in gitlab
Hi Tom, I have a series which changes sandbox over to use the newer SDL2. At present I cannot make it pass on gitlab since it seems to have SDL1.2 (only). Is it possible to change that? Regards, Simon
