Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Anatolij, On Mon, Jun 29, 2020 at 4:31 AM Anatolij Gustschin wrote: > I've tested on mx6ul-14x14-evk, with current U-Boot master I do not > see this problem any more. Excellent! I saw Ye Li's patches that fixed the problem. Thanks
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Fabio, On Mon, 24 Feb 2020 09:38:04 -0300 Fabio Estevam feste...@gmail.com wrote: > Hi Anatolij, > > On Wed, Feb 5, 2020 at 2:45 PM Fabio Estevam wrote: > > > > Hi Anatolij, > > > > On Wed, Feb 5, 2020 at 2:00 PM Anatolij Gustschin wrote: > > > > > I tried to extend the BMP code to fix this, but my testing with > > > sandbox SDL end of last week has shown incorrect colors in 24bpp > > > mode, and I didn't find the reason for it. I do not see what is > > > wrong in the code, maybe there is some issue with sandbox SDL. > > > So I've submitted some patches [1], [2], [3]. Could you please > > > test them on mx6ul-14x14-evk ? Thanks! > > > > Thanks for the patches. > > > > I can see the logo colors correctly now, but there is some breakage now. > > > > Please see the result at: > > https://ibb.co/0YKwTxJ > > Would you have a fix for this? I've tested on mx6ul-14x14-evk, with current U-Boot master I do not see this problem any more. -- Anatolij
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Fabio, On Mon, 24 Feb 2020 09:38:04 -0300 Fabio Estevam feste...@gmail.com wrote: > Hi Anatolij, > > On Wed, Feb 5, 2020 at 2:45 PM Fabio Estevam wrote: > > > > Hi Anatolij, > > > > On Wed, Feb 5, 2020 at 2:00 PM Anatolij Gustschin wrote: > > > > > I tried to extend the BMP code to fix this, but my testing with > > > sandbox SDL end of last week has shown incorrect colors in 24bpp > > > mode, and I didn't find the reason for it. I do not see what is > > > wrong in the code, maybe there is some issue with sandbox SDL. > > > So I've submitted some patches [1], [2], [3]. Could you please > > > test them on mx6ul-14x14-evk ? Thanks! > > > > Thanks for the patches. > > > > I can see the logo colors correctly now, but there is some breakage now. > > > > Please see the result at: > > https://ibb.co/0YKwTxJ > > Would you have a fix for this? it seems this is not video driver related, I didn't find a solution for this yet. First I guessed that this could be caused by removed lcd pads init in board code, but this is not the case. I tried to bisect but it is pretty difficult since the older released U-Boot versions do not boot on this board. I didn't have enough time to finish this, sorry. I hope we still can address this before release. -- Anatolij
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Anatolij, On Wed, Feb 5, 2020 at 2:45 PM Fabio Estevam wrote: > > Hi Anatolij, > > On Wed, Feb 5, 2020 at 2:00 PM Anatolij Gustschin wrote: > > > I tried to extend the BMP code to fix this, but my testing with > > sandbox SDL end of last week has shown incorrect colors in 24bpp > > mode, and I didn't find the reason for it. I do not see what is > > wrong in the code, maybe there is some issue with sandbox SDL. > > So I've submitted some patches [1], [2], [3]. Could you please > > test them on mx6ul-14x14-evk ? Thanks! > > Thanks for the patches. > > I can see the logo colors correctly now, but there is some breakage now. > > Please see the result at: > https://ibb.co/0YKwTxJ Would you have a fix for this? Thanks
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Anatolij, On Wed, Feb 5, 2020 at 2:00 PM Anatolij Gustschin wrote: > I tried to extend the BMP code to fix this, but my testing with > sandbox SDL end of last week has shown incorrect colors in 24bpp > mode, and I didn't find the reason for it. I do not see what is > wrong in the code, maybe there is some issue with sandbox SDL. > So I've submitted some patches [1], [2], [3]. Could you please > test them on mx6ul-14x14-evk ? Thanks! Thanks for the patches. I can see the logo colors correctly now, but there is some breakage now. Please see the result at: https://ibb.co/0YKwTxJ Thanks!
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Fabio, On Mon, 3 Feb 2020 12:15:09 -0300 Fabio Estevam feste...@gmail.com wrote: > Hi Anatolij, > > On Sat, Jan 25, 2020 at 3:36 PM Anatolij Gustschin wrote: > > > Before DM_VIDEO conversion cfb_console driver was used and > > it supports such rendering. I'm working on a fix for this. > > Thanks for testing! > > Have you been able to fix this? I tried to extend the BMP code to fix this, but my testing with sandbox SDL end of last week has shown incorrect colors in 24bpp mode, and I didn't find the reason for it. I do not see what is wrong in the code, maybe there is some issue with sandbox SDL. So I've submitted some patches [1], [2], [3]. Could you please test them on mx6ul-14x14-evk ? Thanks! [1] http://patchwork.ozlabs.org/patch/1233910 [2] http://patchwork.ozlabs.org/patch/1233911 [3] http://patchwork.ozlabs.org/patch/1233912 -- Anatolij
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Anatolij, On Sat, Jan 25, 2020 at 3:36 PM Anatolij Gustschin wrote: > Before DM_VIDEO conversion cfb_console driver was used and > it supports such rendering. I'm working on a fix for this. > Thanks for testing! Have you been able to fix this? Thanks
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Anatolij, On Sat, Jan 25, 2020 at 3:36 PM Anatolij Gustschin wrote: > Now I see that bitmap rendering code for video-uclass driver > doesn't support displaying 8bpp bitmaps on 24bpp frame buffer. > > Before DM_VIDEO conversion cfb_console driver was used and > it supports such rendering. I'm working on a fix for this. > Thanks for testing! Excellent, I will be glad to test it when you have it ready. I think this is the last remaining issue with mxsfb DM_VIDEO conversion. Thanks!
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Fabio,
On Fri, 24 Jan 2020 16:26:26 -0300
Fabio Estevam feste...@gmail.com wrote:
> > Do you have 'bits-per-pixel' property in your display node in DT?
> > Is suitable CONFIG_VIDEO_BPPxx option enabled in your board_defconfig ?
>
> Yes, I have it, but it has the wrong value. It should be 24bpp instead of
> 16bpp.
>
> I did the following change:
>
> --- a/arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi
> @@ -4,7 +4,6 @@
> */
>
> display0: display@0 {
> - bits-per-pixel = <16>;
> + bits-per-pixel = <24>;
> bus-width = <24>;
>
> display-timings {
>
> And now I see the U-Boot strings showing with a correct white color.
>
> However, the logo does not print and I have the following error:
>
> Error: 32 bit/pixel mode, but BMP has 8 bit/pixel
>
> How can I fix this mismatch?
Now I see that bitmap rendering code for video-uclass driver
doesn't support displaying 8bpp bitmaps on 24bpp frame buffer.
Before DM_VIDEO conversion cfb_console driver was used and
it supports such rendering. I'm working on a fix for this.
Thanks for testing!
--
Anatolij
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Oleksandr, On Thu, Jan 23, 2020 at 12:46 PM Oleksandr Suvorov wrote: > We had a similar issue when mxsfb driver tried to use 18-bit elcdif > bus in 24-bit mode. Is there a patch to fix this problem? Does U-Boot logo appear correctly in colibri_imx7 and colibri_imx6ull? Thanks
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Anatolij,
On Thu, Jan 23, 2020 at 11:36 AM Anatolij Gustschin wrote:
> Do you have 'bits-per-pixel' property in your display node in DT?
> Is suitable CONFIG_VIDEO_BPPxx option enabled in your board_defconfig ?
Yes, I have it, but it has the wrong value. It should be 24bpp instead of 16bpp.
I did the following change:
--- a/arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi
@@ -4,7 +4,6 @@
*/
display0: display@0 {
- bits-per-pixel = <16>;
+ bits-per-pixel = <24>;
bus-width = <24>;
display-timings {
And now I see the U-Boot strings showing with a correct white color.
However, the logo does not print and I have the following error:
Error: 32 bit/pixel mode, but BMP has 8 bit/pixel
How can I fix this mismatch?
Thanks
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Fabio, On Thu, Jan 23, 2020 at 3:19 PM Fabio Estevam wrote: > > Hi, > > We are converting imx7d-sdb and imx6sx-sdb boards to DM_VIDEO, but we > are seeing the Freescale logo with incorrect colors (white area is > being shown blue, for example). > We had a similar issue when mxsfb driver tried to use 18-bit elcdif bus in 24-bit mode. > imx6ul-evk has already been converted to DM_VIDEO and also show the > incorrect colors. > > We haven't started to investigate this issue yet, but just wanted to > report in case this is a known issue. > > Does U-Boot logo appear with the correct color on your boards with > eLCDIF controller? > > Thanks, > > Fabio Estevam -- Best regards Oleksandr Suvorov cryo...@gmail.com
Re: U-Boot Logo showing incorrect colors with eLCDIF
Hi Fabio, On Thu, 23 Jan 2020 10:19:08 -0300 Fabio Estevam feste...@gmail.com wrote: ... > We are converting imx7d-sdb and imx6sx-sdb boards to DM_VIDEO, but we > are seeing the Freescale logo with incorrect colors (white area is > being shown blue, for example). > > imx6ul-evk has already been converted to DM_VIDEO and also show the > incorrect colors. > > We haven't started to investigate this issue yet, but just wanted to > report in case this is a known issue. Do you have 'bits-per-pixel' property in your display node in DT? Is suitable CONFIG_VIDEO_BPPxx option enabled in your board_defconfig ? Maybe the video uclass code doesn't have correct code four your bits-per-pixel configuration. Please also try with this patch [1] applied. > Does U-Boot logo appear with the correct color on your boards with > eLCDIF controller? I do not have a board with eLCDIF, so cannot say for sure. Thanks, Anatolij [1] https://gitlab.denx.de/u-boot/custodians/u-boot-video/commit/9a9cf3198e607497a4a900e13930a836e16611f9
U-Boot Logo showing incorrect colors with eLCDIF
Hi, We are converting imx7d-sdb and imx6sx-sdb boards to DM_VIDEO, but we are seeing the Freescale logo with incorrect colors (white area is being shown blue, for example). imx6ul-evk has already been converted to DM_VIDEO and also show the incorrect colors. We haven't started to investigate this issue yet, but just wanted to report in case this is a known issue. Does U-Boot logo appear with the correct color on your boards with eLCDIF controller? Thanks, Fabio Estevam
