[U-Boot-Users] [PATCH] Add include for config.h in command.h.
Because the cmd_tbl_s structure depends on the configuration file, it must be assured that config.h is included before the structure is evaluated by the compiler. If this is not certain, it could happen that the compiler generates structures of different size, depending on the fact if the source file includes config.h before or after command.h. The effect is that u-boot crashes when tries to relocate the command table (for ppc) or try to access to the command table for other architectures. The problem can happen on board-depending commands.All general commands under /common are unaffected, because they include already config.h before command.h. Signed-off-by: Stefano Babic [EMAIL PROTECTED] --- include/command.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/command.h b/include/command.h index c3ef51d..4a27e97 100644 --- a/include/command.h +++ b/include/command.h @@ -27,6 +27,8 @@ #ifndef __COMMAND_H #define __COMMAND_H +#include config.h + #ifndef NULL #define NULL 0 #endif -- 1.5.4.3 - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] Add include for config.h in command.h.
Because the cmd_tbl_s structure depends on the configuration file, it must be assured that config.h is included before the structure is evaluated by the compiler. If this is not certain, it could happen that the compiler generates structures of different size, depending on the fact if the source file includes config.h before or after command.h. The effect is that u-boot crashes when tries to relocate the command table (for ppc) or try to access to the command table for other architectures. The problem can happen on board-depending commands.All general commands under /common are unaffected, because they include already config.h before command.h. Signed-off-by: Stefano Babic [EMAIL PROTECTED] --- include/command.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/command.h b/include/command.h index c3ef51d..8815937 100644 --- a/include/command.h +++ b/include/command.h @@ -31,6 +31,8 @@ #define NULL 0 #endif +#include config.h + #ifndef__ASSEMBLY__ /* * Monitor Command Table -- 1.5.4.3 - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board
Ben Warren wrote: Applied to net repo. Thanks! Stefano, please test from the net repo if you can on your Trizeps board. Done, it works, thanks. Kind regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] = - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [patch 0/6] DM9000: Several fixes/cleanups for the DM9000A controller
Remy Bohmer wrote: In a few minutes I will post a patch which I hope it will solve this. Can you please try it on your board? I have tried, the old error is gone, but the board hangs probably after getting the first packets: $ tftp 0xa001 u-boot.bin dm9000 i/o: 0x800, id: 0x9a46 DM9000: running in 32 bit mode MAC: 00:50:c2:3b:8f:0a operating at 100M full duplex mode TFTP from server 192.168.2.14; our IP address is 192.168.2.77 Filename 'u-boot.bin'. Load address: 0xa001 Loading:* Enabling the debug I get this output (so the first packet was received): $ tftp 0xa001 u-boot.bin eth_halt phy_write(reg:0x0, value:0x8000) eth_init() resetting DM9000 resetting the DM9000, 1st reset resetting the DM9000, 2nd reset dm9000 i/o: 0x800, id: 0x9a46 DM9000: running in 32 bit mode phy_read(0x3): 0x0 MAC: 00:50:c2:3b:8f:0a 00:50:c2:3b:8f:0a: phy_read(0x1): 0x7809 phy_read(0x1): 0x7809 phy_read(0x1): 0x7809 phy_read(0x1): 0x7809 phy_read(0x1): 0x7809 phy_read(0x1): 0x7809 [snip] phy_read(0x1): 0x780d phy_read(0x1): 0x780d phy_read(0x1): 0x780d phy_read(0x1): 0x780d [snip] phy_read(0x1): 0x780d phy_read(0x1): 0x782d phy_read(0x11): 0x8018 operating at 100M full duplex mode TFTP from server 192.168.2.14; our IP address is 192.168.2.77 Filename 'u-boot.bin'. Load address: 0xa001 Loading: eth_send: length: 42 eth_send: 00: ff ff ff ff ff ff 00 50 eth_send: 08: c2 3b 8f 0a 08 06 00 01 eth_send: 10: 08 00 06 04 00 01 00 50 eth_send: 18: c2 3b 8f 0a c0 a8 02 4d eth_send: 20: 00 00 00 00 00 00 c0 a8 eth_send: 28: 02 0e transmit done receiving packet rx status: 0x0001 rx len: 64 eth_rx: length: 64 eth_rx: 00: 01 00 40 00 00 50 c2 3b eth_rx: 08: 8f 0a 00 0b 2b 12 e3 3c eth_rx: 10: 08 06 00 01 08 00 06 04 eth_rx: 18: 00 02 00 0b 2b 12 e3 3c eth_rx: 20: c0 a8 02 0e 00 50 c2 3b eth_rx: 28: 8f 0a c0 a8 02 4d 00 00 eth_rx: 30: 00 00 00 00 00 00 00 00 eth_rx: 38: 00 00 00 00 00 00 00 00 passing packet to upper layer receiving packet rx status: 0x806d rx len: 24529 ^^^ ^-- wrong Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] = - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [patch 0/6] DM9000: Several fixes/cleanups for the DM9000A controller
Remy Bohmer wrote: I will post a mail in a few minutes solving this... Please apply this new past on top of the 6-patches series I posted yesterday. Great ! It works, I tested now with bigger files and it sounds good ! I have seen that the complete patch (all patch 0-xx) is not so big and smaller as the limit of the mailing list (17k 40k). What about to send only the complete patch ? It is easier to read for the review. There are some issues with the coding style, too (trailing blanks, for example). Kind regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] = - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [patch 0/6] DM9000: Several fixes/cleanups for the DM9000A controller
Ben Warren wrote: Wolfgang, Is the merge window open for the rest of today, or is it closed? If open, I'll look at this patch set later today and act on it. Otherwise this goes into the 'for later' bin. Hi, this patch does not work on the trizeps board. I get the following error: $ tftp 0xa001 u-boot.bin dm9000 i/o: 0x800, id: 0x9a46 DM9000: running in 32 bit mode MAC: 00:50:c2:3b:8f:0a operating at 100M full duplex mode TFTP from server 192.168.2.14; our IP address is 192.168.2.77 Filename 'u-boot.bin'. Load address: 0xa001 Loading: DM9000 error: status check fail: 0x6d I have only applied the patches and tried a quick check...The bus width is correctly recognized but there is no data transfer. However, the ethernet controller works with the current driver: $ tftp 0xa001 u-boot.bin dm9000 i/o: 0x800, id: 0x9a46 MAC: 00:50:c2:3b:8f:0a operating at 100M full duplex mode TFTP from server 192.168.2.14; our IP address is 192.168.2.77 Filename 'u-boot.bin'. Load address: 0xa001 Loading: ### done Bytes transferred = 160180 (271b4 hex) Regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] = - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] very slow netconsole
Antonello Lombardinilo wrote:
I just now:
- switched to Intel IXDPG425 board (to have a standard board reference);
- downloaded and compiled u-Boot 1.3.2 with NetConsole support;
Even in this scenario the communication is slow !
Take a look at your ethernet driver (I think cpu/ixp/npe.c). The
eth_halt and eth_init functions are called before each transfer, even
for single character.
In npe_halt:
debug(%s\n, __FUNCTION__);
/* Delay to give time for recovery of mbufs */
for (i = 0; i 100; i++) {
npe_poll(p_npe-eth_id);
udelay(100);
}
The delay seems strictly correlated to the slowness you report. Check
the npe_init function, too. If the ethernet is reinitialized after each
transfer, the result is a very slow connection.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED]
=
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
