[Bug 1959027]
Thanks all! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and theming issues when running in Plasma Wayland session To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1959027/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1959027]
I see. In that case, I think the remaining issues should be reported to KDE or Canonical (not sure where does the culprit live). Might be worth starting with canonical since it seems snap-specific, but on the other hand this seems specific to snap-on-plasma-on-wayland... Vlad, Olivier, do you have thoughts on where could the root cause here live? Keeping open for tracking for now, but chances are there is little we can do here on Firefox's side. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and theming issues when running in Plasma Wayland session To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1959027/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1959027]
Does that happen with other GTK apps ran via snap? I don't think we have control about the GTK theme in use. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and theming issues when running in Plasma Wayland session To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1959027/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1959027]
Does this work on the nightly? I would expect bug 1734934 to have fixed this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1959027 Title: [snap] Various UI and theming issues when running in Plasma Wayland session To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1959027/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1922047]
Bug 1752862 adds prefs to tweak this more precisely. Bug 1753033 tracks potentially switching the default. *** This bug has been marked as a duplicate of bug 1752862 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1922047 Title: Touchpad scrolling is too fast To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1922047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Bug 1745419 will fix that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1936647]
*** Bug 1721154 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1936647 Title: right-click popups transparent after upgrade to Firefox 90 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1936647/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
(In reply to gschram from comment #47) > I understand that this is an edge case currently (with the patched mutter) > but I foresee this becoming a "problem" when in a year or two all other apps > also have rounded bottom corners and Firefox is the odd one out, I think > fixing this now is a good idea to prevent technical debt. Getting bottom corners rounded on Wayland seems worth a separate bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Oh, great, let me know if I can help. Probably a static atomic integer in nsLookAndFeelGtk is slightly easier to invalidate in practice. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Yeah, so `nsWindow::GetTitlebarRadius` can be called off the main thread which seems unfortunate. We can fix this easily by moving the titlebar radius to a member or such. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
So, querying the individual border-radius properties doesn't work. I get: > (firefox:17330): Gtk-WARNING **: 00:39:54.651: Style property "border- top-left-radius" is not gettable And same for the other corners of course. However, my patch works, because of [this code](https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-20/gtk/gtkcssshorthandpropertyimpl.c#L961-977). Basically, querying `border-radius` on gtk3 returns the `border-top- left-radius`, which happens to work for us, yay :) So given there's no way to access the other border corners, and that this works for our purposes, I think we should probably just roll with it, thoughts? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Well, perhaps, but that seems tangential to this bug, isn't it? We don't use XShapeCombineMask for the titlebar and this patch stack doesn't start doing that. If we do want to do the cleanup described above, we might need a new media query which determines this (but it should definitely not have `csd` in the name, since it is not about csd at all). So I'd rather clean up the existing one since it's confusing at best. Anyways, things I've tested: * KWin (Wayland/X11/XWayland) * GNOME (Wayland/X11/XWayland) with a variety of GTK themes * i3 * bspwm And in all cases this patch stack doesn't regress behavior (and improves it in the obvious cases). So I'd say comment 25 should be a separate bug? If someone has an exotic setup and wants to give this a try before it lands, or wants to provide feedback, builds should be here eventually: https://treeherder.mozilla.org/jobs?repo=try&revision=327533608921f19068d1b8898b094fb3b3cdfc9d -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
I fixed the wayland overdraw and the X11 artifacts, so I think this is ready to go. I've tested this stack on KWin and GNOME, both X11 and Wayland. Will test i3 and such asap. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Created attachment 9246314 Bug 1509931 - Use a more precise toolbar radius. r=stransky This seemed possible/maybe worth doing, but let me know if you'd rather keep the 10 hard-coded. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Ah, I think I know why that might be... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
(In reply to Darkspirit from comment #19) > KDE with disabled compositor, i3, etc. use alpha visual, but it's not > transparent. WDYM, just that the background wouldn't be transparent? > Could -moz-gtk-csd-transparent-background be defined with > gdk_screen_is_composited() > and be used to forbid outer border-radius + outer shadow of main > menu/addon/etc. widgets > to remove any Xshape usage (bug 1730991 comment 6)? > According to the Chromium bugtracker, Xshape also causes performance problems > (bug 1730991 comment 7). I'm not sure about this (not familiar with XShape at all). This patch stack makes Wayland look great, but on X11/XWayland I still see the compositor shadow drawn around the crisp corner when using a lightweight theme... Do you know whether that's avoidable Martin? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Created attachment 9246291 Bug 1509931 - Simplify titlebar buttons CSS. r=stransky There's no need to use the media query to set the default styles of the buttons, we only need to hide them if appropriate. Depends on D128682 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Created attachment 9246289 Bug 1509931 - Use titlebar radius on Linux and make titlebar set-up work for lightweight themes. r=stransky!,dao! Depends on D128680 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Created attachment 9246290 Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky We always use alpha visual for WebRender, and appearance: none is unnecessary (root element has no intrinsic appearance). Depends on D128681 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Created attachment 9246288 Bug 1509931 - Expose titlebar radius as a chrome-only CSS environment variable. r=stransky Mostly plumbing. Depends on D128679 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
Created attachment 9246287 Bug 1509931 - Add support for chrome-only environment variables. r=stransky This bit is taken straight from D73454 (I reviewed it but I guess another pair of eyes is ok, it's really straight-forward). Co-authored-by: Nicklas Boman -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
(In reply to Martin Stránský [:stransky] (ni? me) from comment #11) > Emilio, how is the best way how to do it? We can introduce a new appearance > (-moz-window-titlebar-alpha for instance) which contains only alpha component > from titlebar and paint it over theme color or use existing one > (-moz-window-titlebar) but I'm not very experienced in js/css styling so I'll > appreciate any help here. I don't think that's super-great, I think I have an idea which should be relatively simple, stealing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1871644]
I'm not quite familiar with how this works, I think Martin is the right person to ask about it. I can dig if you want but I'd guess that this kind of stuff (the `:not(:-moz-lwtheme)` bits and such) is related: https://searchfox.org/mozilla- central/rev/9bc5dcea99c59dc18eae0de7064131aa20cfbb66/browser/themes/linux/browser.css#389-399 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1871644 Title: Top corners of Firefox windows have weird black protrusions from the rounded edges To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1871644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
Maybe even tier 2 / running on m-c only, or something? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
(In reply to Mike Hommey [:glandium] (high latency) from comment #24) > That specific comment explicitly says current GCC doesn't implement it. Are > we going to require clang only now? Well GCC just fixed it in fairness: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=279069 I think they would've fixed it much earlier if we would've found this on automation rather than after busting builds shipped by distros to a bunch of users... :) I think supporting clang-only would be sad, IMHO. I use gcc builds from time to time for debugging, as they have better debug info. (In reply to Nathan Froyd [:froydnj] from comment #23) > I'll just note that as somebody who has had multiple patches backed out > because of jobs that *only* run on central and those jobs aren't selectable > by default by `mach try fuzzy` (or non-obviously selectable), I'd really not > like to see us add more of "only run on m-c" jobs. To be clear, I'd be more than happy with them running in all pushes :) But if the automation cost is a concern, Tier2 + central-only shouldn't get anyone backed out, and should be cheaper, if I understand our backout policy correctly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
Someone on #introduction mentioned that https://phabricator.services.mozilla.com/D56873 did fix the problem for them. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
(In reply to Nathan Froyd [:froydnj] from comment #19) > (In reply to Mike Hommey [:glandium] (high latency) from comment #18) > > It's very possible this is the same as bug 1601707. If it is, we don't need > > to exclude clang 6. > > OTOH, I don't want to be rediscovering that people are using a compiler that > doesn't implement some finer point of C++17 (bug 1601707 comment 5) every > couple of weeks or months, wasting time debugging, and rewriting the code to > compensate. I think we should have _some_ gcc build running tests on automation, fwiw. Finding stuff like that or bug 1600735 the hard way is really painful :( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
Ah, thanks for the update Olivier :) I think it'd still be nice to detect this at configure time if possible, but it may be not worth the churn. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
*** Bug 1600467 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
Can we add a configure check for this somehow? It seems ubuntu almost ships a build with this bug, see bug 1600467... :/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
