[Bug 1512120]
I can confirm the crash with drag-drop operations after applying th patch from comment #76. I opened two instances of Thunar, selected two different folders and moved a file from one location to the next using drag-drop. This went ok. However, when moving the file back Thunar crashed. It turned out that the file was moved back before the crash though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug go to: https://bugs.launchpad.net/thunar/+bug/1512120/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1512120]
This bug definitely seems to be related to race conditions as has been suggested before. You can do the test by hitting F2, entering an new name immediately followed by [ENTER]. Thunar is likely to crash. The same happens when you click OK too fast after entering a new name (put the mouse cursor on the button and press immediately after entering the last character). When I leave a pause after entering a new name both the enter key and OK-button are much less likely to cause the crash (I have not experienced it yet). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug go to: https://bugs.launchpad.net/thunar/+bug/1512120/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1512120]
(In reply to Frank from comment #66)
> After renaming a few files Thunar may crash after hitting enter in the
> rename dialog.
>
> In an attempt to resolve this I used this patch:
> -
> --- Thunar-1.6.10/thunar/thunar-file.c 2015-05-22 15:25:36.0 +0200
> +++ Thunar-1.6.10-patched/thunar/thunar-file.c 2016-05-15
> 15:13:21.613406924 +0200
> @@ -3918,7 +3918,9 @@
> gboolean
> thunar_file_reload (ThunarFile *file)
> {
> - _thunar_return_if_fail (THUNAR_IS_FILE (file));
> + /* if the file has already been destroyed, break here */
> + if (!THUNAR_IS_FILE (file))
> + return FALSE;
>
>/* clear file pxmap cache */
>thunar_icon_factory_clear_pixmap_cache (file);
> -
>
> It works but only if I click the OK button in the rename dialog. The crash
> occurs when hitting enter following the new name.
This patch is the same as referred to in comment #30.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1512120
Title:
[SRU] thunar crashes on file renaming
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunar/+bug/1512120/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1512120]
After renaming a few files Thunar may crash after hitting enter in the
rename dialog.
In an attempt to resolve this I used this patch:
-
--- Thunar-1.6.10/thunar/thunar-file.c 2015-05-22 15:25:36.0 +0200
+++ Thunar-1.6.10-patched/thunar/thunar-file.c 2016-05-15 15:13:21.613406924
+0200
@@ -3918,7 +3918,9 @@
gboolean
thunar_file_reload (ThunarFile *file)
{
- _thunar_return_if_fail (THUNAR_IS_FILE (file));
+ /* if the file has already been destroyed, break here */
+ if (!THUNAR_IS_FILE (file))
+ return FALSE;
/* clear file pxmap cache */
thunar_icon_factory_clear_pixmap_cache (file);
-
It works but only if I click the OK button in the rename dialog. The
crash occurs when hitting enter following the new name.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1512120
Title:
[SRU] thunar crashes on file renaming
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunar/+bug/1512120/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
