[Bug 867424]
I have no idea why this wouldn't show up before. I'm not an expert on PR_SetEnv, but all of the callers of SaveToEnv are passing in string constants, so it doesn't look to me that you actually need to do a strdup. The header for SetEnv just says that it has to be a "constant, persistent string", and passing in a string literal should be fine. A few call sites do that already. So maybe just inline SaveToEnv and remove the strdup. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
Comment on attachment 8763602 (2/4) - Annotate deliberate leak in SaveToEnv Review of attachment 8763602: - Be sure to #include "mozilla/MemoryChecking.h" in this file please. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 867424]
LSan treats things reachable from global variables as not being leaks, which is different than Valgrind. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
(In reply to Benjamin Kerensa [:bkerensa] from comment #29) This does not appear to meet the landing criteria for ESR: Security and some major stability fixes when they're landed/merged onto mozilla-beta, or fixes for regressions specific to the ESR. This patch fixes a crash that makes Firefox crash every time you save a file on the armhf architecture, which would to me qualify as a major stability fix. This patch has already landed landed on beta. What part of the landing criteria does it not meet? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
(In reply to Jacobo Pantoja from comment #26) Or this code is fed back to Thunderbird in any way? Yes, this will automatically be included in Thunderbird, once it lands on esr, I believe. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
I'm not sure why 31 was marked wontfix, so I'm going to reset it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
Comment on attachment 8523413
Correct argument passing - backport for ESR31
ESR just needs a separate approval request.
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
Crashes on Debian builds of Firefox.
User impact if declined: see previous
Fix Landed on Version: 36
Risk to taking this patch (and alternatives if risky): none. see comment 21
String or UUID changes made by this patch: none
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1398898
Title:
[armhf] segfaults when trying to save a file
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 286366]
OOM check was added to PL_DHashTableOperate at some point in the past. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/286366 Title: segfault in GCGraphBuilder::AddNode To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/286366/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 286366]
*** Bug 466364 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/286366 Title: segfault in GCGraphBuilder::AddNode To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/286366/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
