[Bug 597825]
The Windows api protion of this is already complete. What needs to be done here is: - update nsTextBoxFrame to only draw accelerators when its window says as much from nsGlobalWindow::GetKeyboardIndicators. - update the label-control binding - handle when the alt key is pressed/released (and any other shortcuts that affect the accesskey display) - update menu handling for when a menu bar is active/visible -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/597825 Title: Menu accelerators in Firefox don't follow the GNOME policy. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/597825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
Comment on attachment 565950 Fixed proof of concept Testing and debugging shows that this seems to work. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
There seems to be some expectation that I respond here but I have nothing else to add. The patch creates an issue as described in comment 26. The same issue occurs with caret browsing enabled or disabled. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
Caret browsing doesn't work with this patch. The page scrolls when I try to move the caret up and down. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 602877]
Comment on attachment 561438 patch4 Not sure what you're asking me to review but the call to MoveFocus looks ok. The FLAG_BYMOVEFOCUS won't flag actually do anything here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/602877 Title: Position is not being updated when atk_text_set_caret_offset is used To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/602877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 779581]
Comment on attachment 553868 stop making the close button focusable Is this reverting back 462289 or is that fixed in some other way? What effect does removing stopPropagation have here? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/779581 Title: “Close” button in tabs not responding with the keyboard To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/779581/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 779581]
Where does the close button get -moz-user-focus set to normal, that we need to set it to 'ignore'? Can we remove the rule for '.tab-close-button:focus' from windows browser.css? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/779581 Title: “Close” button in tabs not responding with the keyboard To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/779581/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
Comment on attachment 548949 Proof of concept I'm not sure if something else is being asked of me here. With this patch: 1. Click in the editable area 2. Press cursor up/down Expected: The caret moves up/down a line Actual: Page scrolls, so keyboard users cannot edit other lines. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
I get the same whether caret browsing is enabled or not. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
Comment on attachment 548949 Proof of concept The focus manager change looks ok, but the editor-base.inc change is not. The former fixes an issue where there is a selection within the editable area, but the editable area is not focusable, then tab is pressed. (The removed code from nsFocusManager is only called when there is nothing focused). The editor-base.inc change though makes scrolling occur in a number of situations where it shouldn't, for example, scrolling should not occur while caret browsing is on, nor while the caret is within the focused editable area. Is the editor attaching it's command controller to the document and not the editable area? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 107247]
Likely caused by the post that uses contenteditable. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other Gecko browsers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 131145]
Comment on attachment 534375 Patch 2 @@ +584,5 @@ + + // We only support dropping files onto a file upload control + PRBool typeSupported; + types-Contains(NS_LITERAL_STRING(Files), typeSupported); + return typeSupported; You can also get the file list and check if it's empty. No, you shouldn't do that during dragover, as it will unnecessarily cause the need to retrieve the data of the drag from the source application which can be slow. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/131145 Title: Dragging icon from Nautilus to HTML File Input box does not work -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 597825]
*** This bug has been marked as a duplicate of bug 25894 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/597825 Title: Menu accelerators in Firefox don't follow the GNOME policy. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
