Re: [Bug 695507] Re: [cppcheck] buffer access out of bounds
Hello, I think that this is still applicable to the latest version: https://qa.debian.org/daca/cppcheck/sid/zsnes_1.510+bz2-1.html Best, -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/695507 Title: [cppcheck] buffer access out of bounds To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/695507/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1269676] Re: zsnes hangs mid-game seemingly randomly
*** This bug is a duplicate of bug 1214241 *** https://bugs.launchpad.net/bugs/1214241 ** This bug has been marked a duplicate of bug 1214241 Freezes in midgame -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1269676 Title: zsnes hangs mid-game seemingly randomly To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/1269676/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1214241] Re: Freezes in midgame
This is presumably the same bug as https://bugs.debian.org/cgi- bin/bugreport.cgi?bug=740860 which was fixed in version -7. ** Bug watch added: Debian Bug tracker #740860 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740860 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1214241 Title: Freezes in midgame To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/1214241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1173090] Re: Buffer overflow in ZSNES since update to raring
* Dmitry Shachnev mity...@gmail.com [130618 11:11]:
Thanks for fixing this, I prefer to give someone who knows assembler a
chance to review this. If we have no such person, I'll sponsor this
later.
Hello,
I had a look as even if it does not affect Debian ATM, I'm interested
in merging these changes. Thanks a lot for investing this issue and
providing a patch!
Here is a quick review.
--- a/src/cpu/regs.inc
+++ b/src/cpu/regs.inc
+NEWSYM oamread
This exports a pointer so that the next 14 ints can be referred to in:
- copy_func(buffer, oamaddr, 14*4);
+ copy_func(buffer, oamread, 14*4);
This reads the following data declared in regs.inc:
- 1 int: oamaddr
- 8 ints: bg[1-4]ptr[xy]
- 8 bytes: Voice[0-7]Disable
- 4 bytes: BG[1-4]16x16t
- 2 ints: SPC700{read, write}
--- a/src/init.asm
+++ b/src/init.asm
+NEWSYM xaread
Same here, this so that the following copy:
- copy_func(buffer, xa, 14*4);
+ copy_func(buffer, xaread, 14*4);
can read the next 14 ints: xa, xdb, xpb, xs, xd, xx, xy, flagnz,
flago, flagc, bankkp, Sflagnz, Sflago and Sflagc.
--- a/src/gblvars.h
+++ b/src/gblvars.h
@@ -27,13 +27,14 @@
-extern unsigned int soundcycleft, spc700read, timer2upd, xa,
PHnum2writesfxreg;
-extern unsigned int opcd, HIRQCycNext, oamaddr, curexecstate, nmiprevaddrl;
+extern unsigned int soundcycleft, timer2upd, xa, PHnum2writesfxreg;
+extern unsigned char spc700read[], xaread[], opcd[], oamread[];
+extern unsigned int HIRQCycNext, oamaddr, curexecstate, nmiprevaddrl;
This is equivalent to :
-extern unsigned int spc700read;
-extern unsigned int opcd;
+extern unsigned char spc700read[];
+extern unsigned char opcd[];
+extern unsigned char xaread[];
+extern unsigned char oamread[];
As the symbols spc700read and opcd are now interpreted by address,
their value is equal to the address of the variable, so the following
hunks work:
- copy_func(buffer, spc700read, 10*4);
+ copy_func(buffer, spc700read, 10*4);
copy_func(buffer, timer2upd, 4);
copy_func(buffer, spcnumread, 1);
- copy_func(buffer, opcd, 6*4);
+ copy_func(buffer, opcd, 6*4);
However, I think that in the case of char[] variables, you can use x
for x, so this is unnecessary to remove the operator (this remark
also applies to oamread and xaread).
-extern unsigned char sndrot[], SPCRAM[65472], DSPMem[256], SA1Status,
*SA1RAMArea;
+extern unsigned char sndrot[], SPCRAM[65472], DSPMem[256], SA1Status,
*SA1RAMArea, *SPCState;
--- a/src/initc.c
+++ b/src/initc.c
+unsigned char *SPCState = SPCRAM;
--- a/src/zstate.c
+++ b/src/zstate.c
- copy_func(buffer, SPCRAM, PHspcsave);
+ copy_func(buffer, SPCState, PHspcsave);
Is a global necessary? If you put this line in copy_spc_data this
should work, unless you have to put it in a different file to trick
the static analysis.
Anyway, something seems off with the size of this variable. Cppcheck
detects an error with it:
http://qa.debian.org/daca/cppcheck/sid/zsnes_1.510+bz2-1.html
My guess is that it's related to the SPC ROM located after SPCRAM.
init65816() accesses 0x40 of those bytes through SPCRAM (I'm not sure
that the 16 ones after have a significance). BTW, I'm surprised that
FORTIFY_SOURCE does not trigger an error on this.
--
Etienne Millon
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1173090
Title:
Buffer overflow in ZSNES since update to raring
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/1173090/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1162846] Re: zsnes: 0xf7fdb430 in __kernel_vsyscall()
* osirisgothra osirisgot...@hotmail.com [130428 16:07]: Also, dont know if this is related, but in the --help items there is this. .. cut here .. 0 = None 1 = Keyboard/Gamepad -ad Select Audio Driver : auto = Automatically select output sdl = Simple DirectMedia Layer output [ RIGHT HERE ] -d Start with debugger enabled .cut here. notice where it says [ RIGHT HERE ] (which i added to mark that spot) ??? Well, normally there is a bit of a list of other sound interfaces to choose from, but now those two are the only ones even though i KNOW i have pulseaudio and alsa installed fully and they do work. I don't know if this is somehow related and I only noticed because I use zsnes mostly from the command line and notice small things like the options changing. Hello, Sorry for your kids! As one of the maintainers of zsnes in Debian, here are a few points that may be interesting for this bug report. In the last version we disabled libao suppport. This library could be optionally used by zsnes to use systems such as pulseaudio and alsa, but it caused a lot of problems in the past. What helped this decision is the introduction of multi-arch in Debian, which is a way of running 32 bit applications (such as zsnes) and their library dependencies on a 64 bit system, ie most modern hardware. Because libao is not multiarch compatible (at least, so far - see http://bugs.debian.org/638741), we chose to disable it and it appears that these changes were merged in Ubuntu. So, I'd say that this issue has to do with how differences of implementation of multiarch in Ubuntu Debian. The best I can do is confirm that it works in Debian. Once someone figures this I'd be interested to merge it. HTH, -- Etienne Millon -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1162846 Title: zsnes: 0xf7fdb430 in __kernel_vsyscall() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/1162846/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1162846] Re: zsnes: 0xf7fdb430 in __kernel_vsyscall()
** Bug watch added: Debian Bug tracker #638741 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638741 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1162846 Title: zsnes: 0xf7fdb430 in __kernel_vsyscall() To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/1162846/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 184255] Re: zsnes fails to build on amd64
Now that Debian has multiarch support, it is possible to use it to package zsnes. I'd like to do that at least for wheezy (S2 2012), but of course I'd happily merge that from Ubuntu if someone wants to do it :) The GBP repository is at git://anonscm.debian.org/pkg-games/zsnes.git. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/184255 Title: zsnes fails to build on amd64 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/app-install-data-ubuntu/+bug/184255/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 819774] Re: Please sync zsnes 1.510+bz2-1 (universe) from Debian unstable (main)
Hello, debian maintainer here. The i386 build works fine on unstable. If you can send me a full i386 build log, I will see what I can do. As for the amd64 build, I believe that it will be easier when multiarch will be available in Debian. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/819774 Title: Please sync zsnes 1.510+bz2-1 (universe) from Debian unstable (main) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/819774/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 695507] Re: [cppcheck] buffer access out of bounds
Hello, The cppcheck run on Debian signaled several other warnings : http://qa.debian.org/daca/cppcheck/sid/zsnes_1.510-2.2.html ** Bug watch added: Debian Bug tracker #610313 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610313 ** Also affects: zsnes (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610313 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/695507 Title: [cppcheck] buffer access out of bounds -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 184255] Re: zsnes fails to build on amd64
(sorry, end of message following) ... version 1.510+bz2-1, which includes amd64 support. Feel free to pull it from sid. If you need to patch it to build it on Ubuntu, patches are welcome (or better, clone the git repository). Have a nice day Etienne -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/184255 Title: zsnes fails to build on amd64 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 184255] Re: zsnes fails to build on amd64
Hello, I'm the maintainer of the Debian package. Now that wheezy is in development I could publish -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/184255 Title: zsnes fails to build on amd64 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
