[Bug 1796979]
I'm closing this as WFM because the bug isn't limited only to firefox. Any application that calls getaddrinfo quickly enough will trigger it. Rex, I didn't find anything strange in any config file you've posted. I tried to reproduce it on Fedora and Valentin tried it on Ubuntu, but we were unable to reproduce it. If you would like to track the bug down to nsswitch level, I would recommend to run the python test with rr (https ://rr-project.org/) and if it's reproducible using rr, then you should be able to debug it after installing appropriate debug packages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Is there any change if you remove wins resolving? I.e. in /etc/nsswitch.conf change line "hosts: files wins dns" to "hosts: files dns" and rerun the test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Created attachment 9042103 test with pauses (In reply to rex from comment #79) > Firefox continues to resolve addresses correctly. > > Do we know of a difference between Firefox and Chromium in how they interact > with wins? This may provide further answers as to why Firefox has difficulty > with wins in my system whereas Chromium does not. A quick test shows that chrome uses getaddrinfo just like firefox. Given that first getaddrinfo in the python test succeeded and also that firefox resolves correctly with hook3.so (which adds some delay by printing result to console), the problem might be when subsequent call to getaddrinfo is called too quickly after previous call and something in wins code doesn't have time to fail and clean up. Could you please do another test? - put wins back to nsswitch.conf - run the old test to make sure it still fails - run this new test which sleeps between getaddrinfo calls Also, would you mind sharing your /etc/samba/smb.conf ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Now, it seems to resolve normally. I guess firefox shouldn't fail anymore. Please, test it for a while without wins resolving. I'm not sure what's exactly wrong, but according to the rule in nsswitch.conf dns request should be sent when the host isn't found using wins and because no request is sent, there is probably some fatal failure in wins nss module. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Created attachment 9041202 test.tgz getaddrinfo fails with EAI_SYSTEM and errno should contain details, but it's 0. Could you please extract the attached archive and run "make" in the extracted directory? It should generate few files in logs directory. I'm curious whether getaddrinfo called from python code fails as well and maybe I'll see something interesting in the strace log. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Give a try to both versions. And if it's not reproducible in this 66.0a1 build but is reproducible in 65.0b8, I'll create a testing build from the same source tree. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Thanks, unfortunately this log doesn't contain useful information. I suggested it mainly to check if removing sync helps with reproducing. Helpful would be the log from my version which logs the error code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Created attachment 9040578 log_getaddrinfo_errors.c You could give this version a try. It only prints error message in case of failure. Use it as the other versions, i.e. compile with: gcc -shared -ldl -fPIC log_getaddrinfo_errors.c -o log_getaddrinfo_errors.so And run it with the official firefox: LD_PRELOAD=/path/to/log_getaddrinfo_errors.so ./firefox --no-remote -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to rex from comment #60) > I am able to reproduce the issue with the plain 66.0a1 alpha from a shell > script or otherwise. > > I am not able to reproduce the issue with the plain 66.0a1 alpha from a shell > script that calls out: > export MOZ_LOG=timestamp,sync,GetAddrInfo:5,nsHostResolver:5 > export MOZ_LOG_FILE=./2019-01-31log.txt Since this is not a crash, sync isn't necessary. Timing won't be changes so much without sync, so please try timestamp,GetAddrInfo:5,nsHostResolver:5 or even just timestamp,GetAddrInfo:5 > I am not able to reproduce the issue with the special build of 66.0a1, with or without the MOZ definitions. Hmm, I would expect the same behavior as in the official 66.0a1. This strange behavior makes finding the problem really hard. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Can you please try a special build where I've added a code to log error returned by GetAddrInfo? The try push is here: https://treeherder.mozilla.org/#/jobs?repo=try=a9fbc1eae0ad3b6989fd2d2e42b449ae371f8ca0=225192845 Linux builds can be downloaded from: 32-bit - https://queue.taskcluster.net/v1/task/YQ59Q_ckRbqFDz7D4oCkrQ/runs/0/artifacts/public/build/target.tar.bz2 64-bit - https://queue.taskcluster.net/v1/task/L8QATV2TSkORJwzXFEI3vg/runs/0/artifacts/public/build/target.tar.bz2 The error is logged in GetAddrInfo module, so it has to be added to MOZ_LOG. Following MOZ_LOG is sufficient: timestamp,sync,GetAddrInfo:5,nsHostResolver:5 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to rex from comment #50) > Gladly! > With only 'nameserver 217.23.2.11' in my /etc/resolv.conf and running sudo > /etc/init.d/dns-clean start, I appear to be completely unable to resolve any > name in any of my internet browsers. The dump.pcap simply shows entries like > 'Standard query 0x3347 A www.yahoo.com'. In comment #13 you wrote that 217.23.2.11 and 8.8.8.8 are DNS servers provided automatically by ISP. It's bad, if they really return non- working DNS server in DHCP response. Check using dig utility that it really doesn't work: dig www.cnn.com @217.23.2.11 If it times out or returns an error, get rid of this DNS server in the system configuration. I.e. manually set DNS servers to 8.8.8.8 and 8.8.4.4. > With only 'nameserver 8.8.8.8' in my /etc/resolv.conf and running sudo > /etc/init.d/dns-clean start, I can resolve names again. I've changed the > tcpdump command to 'sudo tcpdump -w /tmp/dump.pcap -s 0 udp and port 53 and > host 8.8.8.8'. > > I've attached the resulting dump.pcap below. In it it shows that several > hostnames were successfully resolved. At the end, it failed to resolve > cnn.com but is not shown in the dump. > > I then did an extra tcpdump with 'sudo tcpdump -w /tmp/dump.pcap -s 0 udp and > port 53' with google.com failing at the end, but again, it is not shown. I meant to provide both logs, tcpdump and HTTP log from firefox, where we could see that we tried to resolve the address. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Could you please put only "nameserver 217.23.2.11" to /etc/resolv.conf and provide HTTP log (the same as in comment #13) and dump of DNS packets when the failure happens? Use tcpdump to dump the DNS packets: sudo tcpdump -w /tmp/dump.pcap -s 0 udp and port 53 and host 217.23.2.11 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to rex from comment #39) > Hi :michal, using the gcc command for either one now is about instantaneous and produces no stderr output. I meant the output when you run it. You should have output like this in the console: getaddrinfo node=detectportal.firefox.com, service=(null), hints=0x7fcb0b678500, retval=0 hints.ai_family=0 hints.ai_socktype=1 hints.ai_protocol=0 hints.ai_flags=32 IPv4 address: 23.219.91.81 IPv4 address: 23.219.91.27 IPv6 address: 2a02:26f0:40::17db:5b51 IPv6 address: 2a02:26f0:40::17db:5b1b getaddrinfo node=tiles.services.mozilla.com, service=(null), hints=0x7fcb0b678500, retval=0 hints.ai_family=0 hints.ai_socktype=1 hints.ai_protocol=0 hints.ai_flags=32 IPv4 address: 52.25.70.97 IPv4 address: 52.26.103.165 IPv4 address: 52.39.131.77 IPv4 address: 52.41.60.30 IPv4 address: 52.24.236.113 IPv4 address: 35.160.41.125 IPv4 address: 52.41.78.152 IPv4 address: 52.34.107.172 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Could you please also provide you DNS setup? Content of /etc/resolv.conf and line beginning with "hosts" from /etc/nsswitch.conf. If your resolv.conf contains 127.0.0.53 then also an output from "systemd- resolve --status". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
> I couldn't find how to determine what my LD_PRELOAD variable is by
default, but I ran a script with 'echo "LD_PRELOAD IS ${LD_PRELOAD}"'
and starting up firefox which did not return anything after "LD_PRELOAD
IS ". Not sure if that is applicable though. Is there a different way I
should check?
Running echo "${LD_PRELOAD}" would show it. That's really strange. If
you comment out getaddrinfo from hook3.c (or just rename it to some
random name) but keep gethostbyname and gethostbyname_r as they are, can
you reproduce the problem?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1796979
Title:
Intermittently can't connect to the server
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
It should work. Did it compile without any warning? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to rex from comment #23) > Hey Michal, sorry if I completely misunderstand, but does your hook ask the system to resolve the address before firefox makes the attempt? I have a hunch that, where firefox would fail to resolve an address, if another program or service had already resolved the address, firefox would succeed. The utility just intercepts calls to gethostbyname, gethostbyname_r and getaddrinfo. It calls the original function and prints the result to stderr. I have no idea why it's not reproducible with it. It might slightly change the timing but it should be negligible. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to rex from comment #36) > :michal, it took about 5 seconds to compile and did not return anything to the terminal. So, how the output written to stderr by hook3.so (which resolves correctly) looks like? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Functions from glibc should be called in both cases (with the LD_PRELOAD as well as without it). Do you run the same firefox binary with the same environment? I.e. when running firefox without the hook, do you run it from console as well? Also, does LD_PRELOAD variable contain anything by default? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
You could try to put ISP's DNS servers to /etc/resolv.conf to make sure dnsmasq doesn't mess anything up. I still don't understand why nothing is resolved when hook3_test1.so is preloaded. I will try to come with something else later. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to rex from comment #44) > The original hook3 running firefox provides output like yours: > gethostbyname_r=myhostname, retval=0, succeeded > address: 127.0.1.1 > gethostbyname_r=myhostname, retval=0, succeeded > address: 127.0.1.1 > getaddrinfo node=detectportal.firefox.com, service=(null), > hints=0x7f0d6787c940, retval=0 > hints.ai_family=0 > hints.ai_socktype=1 > hints.ai_protocol=0 > hints.ai_flags=32 > IPv4 address: 23.54.163.42 > IPv4 address: 23.54.163.75 > IPv6 address: 2600:1404:27::17d7:6222 > IPv6 address: 2600:1404:27::17d7:6241 > etc. This looks normal. > /etc/resolv.conf > nameserver 127.0.1.1 > > "hosts" from /etc/nsswitch.conf > hosts: files wins dns > > I attempted systemd-resolve --status just in case, but received: > systemd-resolve: unrecognized option '--status' You could try: resolvectl status 127.0.1.1 is a local address so something must be listening and forwarding the requests. You can use following command to find out, what it is: sudo netstat -u -l -p -n | grep -e ":53[[:space:]]" -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
Created attachment 9038810 hook3_test1 Thanks for doing the test. Please, try this new file. It only intercepts the function call but does nothing with the result. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796979]
(In reply to Honza Bambas (:mayhemer) from comment #16) > Thanks. Dragana, Michal, Valentin, any ideas what more to check here? In bug 1439780 there is a simple program (hook3.c) that hooks resolver functions and dumps info to standard error, see https://bugzilla.mozilla.org/show_bug.cgi?id=1439780#c26. You can use it to see if it really fails on the system level. See comment #18 how to compile and run it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796979 Title: Intermittently can't connect to the server To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796979/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 222635]
Comment on attachment 8398993 Part1. FTP client detects UTF-8 if server returns UTF8 on FEAT Review of attachment 8398993: - Sorry for the delay, r+ with fixed indentation ::: netwerk/protocol/ftp/nsFtpConnectionThread.cpp @@ +657,5 @@ + case FTP_S_FEAT: +rv = S_feat(); + +if (NS_FAILED(rv)) + mInternalError = rv; wrong indentation @@ +675,5 @@ + case FTP_S_OPTS: +rv = S_opts(); + +if (NS_FAILED(rv)) + mInternalError = rv; wrong indentation -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/222635 Title: firefox ftp client don't understand links in cyrillic letters To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/222635/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 222635]
Comment on attachment 571265
Part 2. 301: encoding works on nsIndexedToHTML correctly v2
+nsresult
+nsIndexedToHTML::OnHeaderAvailable(nsIRequest* request, nsISupports
*aContext,
+ nsString aBuffer)
I think the name of the method is confusing. A name like WriteHeader
would be IMO more appropriate. You could also move the check of
mWroteHeader inside the method.
+bool mWroteHeader;
This member isn't initialized in the constructor.
+bool failbackCharset = encoding.Equals(ISO-8859-1);
s/failback/fallback/ ?
if (mExpectAbsLoc
-NS_SUCCEEDED(net_ExtractURLScheme(utf8UnEscapeSpec, nsnull, nsnull,
nsnull))) {
+NS_SUCCEEDED(net_ExtractURLScheme(convertedUnEscapeSpec, nsnull,
nsnull, nsnull))) {
// escape as absolute.
-escFlags = esc_Forced | esc_OnlyASCII | esc_AlwaysCopy | esc_Minimal;
+escFlags |= esc_Forced | esc_AlwaysCopy | esc_Minimal;
}
As far as I can see, this can be removed completely. mExpectAbsLoc was
set to true only in case of gopher and support for this protocol was
removed.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/222635
Title:
firefox ftp client don't understand links in cyrillic letters
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/222635/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 222635]
Comment on attachment 570960
Part 3. FTP directory list sets the encoding when current FTP server supports
UTF-8 v2
+ channel-GetContentCharset(mCharset);
+ if (mCharset.EqualsLiteral(UTF-8)) {
+ // For RFC 2640 support, charset is into HTML, not channel.
+ // So we need clear charset on channel.
+ channel-SetContentCharset(NS_LITERAL_CSTRING());
+ }
Could you please make the comment more verbose? Why it is needed to
clear the charset and why only in case of UTF8?
+ if (mCharset.EqualsLiteral(UTF-8) !IsUTF8(mPendingBuffer)) {
+ // RFC 2640 section 3.3 says the following.
+ //
+ // If a client detects that a server is non UTF-8,
+ // it SHOULD change its display appropriately.
+ //
+ // So we need failback encoding.
+ mCharset.AssignLiteral(ISO-8859-1);
+ }
There is still a problem when the directory is empty and its name isn't
a valid UTF8 string. In this case call to
mTextToSubURI-UnEscapeAndConvert() in
nsIndexedToHTML::OnHeaderAvailable() fails.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/222635
Title:
firefox ftp client don't understand links in cyrillic letters
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/222635/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 222635]
Makoto, I've tested your patch and before going any further with the review I'd like to get back to comment #54. With this patch applied I can't browse directories in ftp://ftp.asu.ru/incoming/ The situation is now different in that ftp.asu.ru already supports FEAT command and returns UTF8. Those problematic files are in cp1251 encoding which is IMO allowed (see comment #59) and probably quite common. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/222635 Title: firefox ftp client don't understand links in cyrillic letters To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/222635/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
