[Bug 365881] Re: wubi installer's pyrun.exe says "no disk"
William, The same Microsoft documentation (see post 63) says that SetErrorMode works at the process (not thread) level so it should be OK even if Wubi runs multi-threaded. -- wubi installer's pyrun.exe says "no disk" https://bugs.launchpad.net/bugs/365881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 365881] Re: wubi installer's pyrun.exe says "no disk"
I would normally prefer to turn something like this off for a short a time as possible, but it is worth noting that the Microsoft documentation at http://msdn.microsoft.com/en- us/library/ms680621%28VS.85%29.aspx says "Best practice is that all applications call the process-wide SetErrorMode function with a parameter of SEM_FAILCRITICALERRORS at startup. This is to prevent error mode dialogs from hanging the application." (SEM_FAILCRITICALERRORS is a constant value 0x0001) That might be the simplest solution to implement. -- wubi installer's pyrun.exe says "no disk" https://bugs.launchpad.net/bugs/365881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 365881] Re: wubi installer's pyrun.exe says "no disk"
Hi William, It's interesting that you get the error on get_filesystem as well. That would explain why you get the message 3 times for each drive and I get it 2 times. Maybe itt is dependent on WIndows version? I'm XP Home SP3. I am not familiar with the Windows API, but googling SetErrorMode suggests that this is the recommended way to avoid these messages. I think you would still need to do something to avoid the message on the call to glob. You could wrap SetErrorMode calls round that, but the call in a common routine rather than windows, so I'm not sure of the implications of doing that. Alternatively, you could set type=None if filesystem == "" in Drive -- wubi installer's pyrun.exe says "no disk" https://bugs.launchpad.net/bugs/365881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 365881] Re: wubi installer's pyrun.exe says "no disk"
Sorry I'm new to this and don't know how to build a proper patch. I will make it a normal attachment ** Attachment added: "drive.py" http://launchpadlibrarian.net/51326395/drive.py -- wubi installer's pyrun.exe says "no disk" https://bugs.launchpad.net/bugs/365881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 365881] Re: wubi installer's pyrun.exe says "no disk"
I think that I have isolated where in the wubi code these dialogs pop up. The first set are when GetDiskFreeSpaceExW is called at line 69 in backends/win32/drive.py. The second set are when glob.glob is called at line 650 in backends/common/backend.py If it is a CD or USB card reader from which the media has been removed, you get the "Please insert disk message". If it is a card reader than has not had a card in since it was mounted, you get the Exception Error. The solution might be to check filesystem in the __init__ method of Drive and set type = None if filesystem is blank. I attach a patch that does that (patch at lines 43-50) ** Attachment added: "drive.py" http://launchpadlibrarian.net/51326196/drive.py -- wubi installer's pyrun.exe says "no disk" https://bugs.launchpad.net/bugs/365881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 365881] Re: wubi installer's pyrun.exe says "no disk"
I am also getting the Exception Error dialog with a USB card reader plugged in. Before clicking Continue each time, I waited a minute to leave a gap in the log timestamps to see if that would give any useful information. I've attached the log and you can see that there are gaps before "DEBUG WindowsBackend: drive=Drive(G: removable 0.0 mb free )" and the same for drive K which are the empty card reader slots and again between "CommonBackend: Searching ISOs on USB devices" and "CommonBackend: Searching for local CDs". My configuration is : C: & D: Hard Disk, E: cd with LiveCD mounted F: cdr empty. G: empty card read slot, I: & J: card reader slots with cards mounted, K: empty card reader slot ( Not sure what has happened to H: !) ** Attachment added: "wubi-10.04-rev189#nodisk.log" http://launchpadlibrarian.net/51308475/wubi-10.04-rev189%23nodisk.log -- wubi installer's pyrun.exe says "no disk" https://bugs.launchpad.net/bugs/365881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
