Re: [Bug 1372149] Re: bzr-git does not preserve or ignore unknown extra fields
Hi Jelmer, AFAIK There isn't a parameter for users to disable extra headers when importing code into Github. https://porter.github.com/new Am I correct in understanding that you added the functionality in Dulwich to ignore extra headers so it wouldn't crash when encountering extra headers? http://git.661346.n2.nabble.com/extra-headers-in-commit-objects-td4508608.html Could you add this functionality to bzr-git, so that bzr-git would be compliant with the C git rule to ignore extra headers that aren't recognized, after the encoding header? On Tue, Oct 21, 2014 at 9:21 PM, Jelmer Vernooij <1372...@bugs.launchpad.net > wrote: > Hi Susan, > > See this thread, which sprung up on the Git list after I added support > for extra commit headers in Dulwich: http://git.661346.n2.nabble.com > /extra-headers-in-commit-objects-td4508608.html > > The consensus among Git developers seems to be that defining new header > fields should be left up to the Git developers. What hg-git is doing > goes against that. > > bzr-git doesn't completely adhere to the guidelines in that thread > either since it doesn't just drop unknown fields. There are good reasons > it can't just ignore headers it doesn't know about though. See my > earlier comments for a more thorough explanation: > > Throwing an error when unknown fields are encountered is intended > behaviour. bzr-git can't just drop unknown metadata since that makes it > impossible to reserialize the original Git objects later. Reserializing > is necessary since the original git objects are used as delta bases. > > bzr-git could store all unknown headers in an extra metadata field. We > don't do this since it means we can't change the mapping of any unknown > headers later without breaking all existing bzr-git users. Instead, > since git commit header extensions are so rare, we require explicit > support for them in bzr-git. > > Dulwich is used for parsing and creating Git objects in bzr-git; bzr-git > doesn't use Dulwich to store data, it uses native Bazaar objects. > > Is your project itself maintained in Git or in Mercurial? If it is in > Mercurial, you could disable the setting of extra headers in hg-git or > alternatively run a cronjob somewhere that uses hg-fastexport and bzr- > fastimport to create a bzr branch from a mercurial branch. > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1372149 > > Title: > bzr-git does not preserve or ignore unknown extra fields > > Status in bzr git support plugin: > Confirmed > Status in Valentina. Pattern making program.: > New > Status in “valentina” package in Ubuntu: > New > > Bug description: > I can't import source code from git. Here log: > 2014-09-21 12:57:19 INFOStarting job. > 2014-09-21 12:57:19 INFOGetting exising bzr branch from central > store. > 2014-09-21 12:57:20 INFO[chan bzr SocketAsChannelAdapter] Opened > sftp connection (server version 3) > 2014-09-21 12:57:20 INFO35 bytes transferred > 2014-09-21 12:57:29 INFO[chan bzr SocketAsChannelAdapter] Opened > sftp connection (server version 3) > 2014-09-21 12:57:30 INFOImporting branch. > 2014-09-21 12:57:32 INFOCounting objects: 2724, done. 0 > 2014-09-21 12:57:34 INFOfinding revisions to fetch:generating index > 0/2724 > 2014-09-21 12:57:36 INFOfinding revisions to fetch:generating index > 0/2724 > 2014-09-21 12:57:36 INFOfinding revisions to fetch 1/608 > 2014-09-21 12:57:36 INFO > Traceback (most recent call last): > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/scripts/code-import-worker.py", > line 95, in > sys.exit(script.main()) > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/scripts/code-import-worker.py", > line 90, in main > return import_worker.run() > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/lib/lp/codehosting/codeimport/worker.py", > line 576, in run > return self._doImport() > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/lib/lp/codehosting/codeimport/worker.py", > line 730, in _doImport > inter_branch.fetch(limit=revision_limit) > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/bzrplugins/git/branch.py", > line 722, in fetch > self.fetch_objects(stop_revision, fetch_tags=fetch_tags, limit=limit) > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/bzrplugins/git/branch.py", > line 745, in fetch_objects > determine_wants, self.source.mapping, limit=limit) > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/bzrplugins/git/fetch.py", > line 718, in fetch_objects > limit) > File "/srv/ > importd.launchpad.net/production/launchpad-rev-17196/bzrplugins/git/fetch.py", > line 484, in import_git_objects > mapping.revision_id_foreign_to_bzr) > File "/srv/ > importd.launchpad.net/production/launch
Re: [Bug 1372149] [NEW] bzr-git does not preserve or ignore unknown extra fields
Hi Jelmer, Since no one is supporting bzr tools anymore, that leaves projects like mine (Valentina) permanently broken in Launchpad. The hg-git "issue" is that hg-git is now pulling *all* fields from hg into git, which isn't a bug, this is considered to be an improvement. According to the hg-git team, Dulwich either ignores or preserves additional fields that it doesn't recognize. The expectation is that bzr-git, which uses Dulwich, should also either ignore or preserve these fields, but instead bzr-git just crashes. It's too bad that Canonical has stopped supporting bzr tools. I heard a rumour that there was discussion about adding support for git on Launchpad to remove dependence on the dead bzr tools, but that this effort was not well received. What a shame. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1372149 Title: bzr-git does not preserve or ignore unknown extra fields To manage notifications about this bug go to: https://bugs.launchpad.net/bzr-git/+bug/1372149/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1372149] Re: bzr-git does not preserve or ignore unknown extra fields
** Changed in: bzr-git Assignee: (unassigned) => Jelmer Vernooij (jelmer) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1372149 Title: bzr-git does not preserve or ignore unknown extra fields To manage notifications about this bug go to: https://bugs.launchpad.net/bzr-git/+bug/1372149/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1372149] Fwd: HG:rename tags not removed by hg-git
Here is background info from an hg-git developer about the change made to hg-git which may require a change to bzr-git: -- Forwarded message -- From: Augie Fackler You're probably doing the conversion using a relatively recent hg-git, which just started storing this data in the hidden metadata section of git commits. This is (probably) a bzr-git bug wherein they're choking on metadata fields they don't understand, rather than just preserving or dropping them as appropriate. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1372149 Title: bzr-git does not preserve or ignore unknown extra fields To manage notifications about this bug go to: https://bugs.launchpad.net/bzr-git/+bug/1372149/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1372149] Re: bzr-git does not support HG:rename commit header fields
Could not import probably because of bzr-git bug #963525 or bug #1084403 https://launchpad.net/launchpad/+bug/963525 https://launchpad.net/launchpad/+bug/1084403 Another project is also failing to import code from a previously working git import, returning the same error code when importing source code from a git repo into bzr: https://code.launchpad.net/~gnome-shell-extensions/gnome-shell-extensions/appindicator-support-head ** Summary changed: - bzr-git does not support HG:rename commit header fields + bzr-git does not preserve or ignore unknown extra fields -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1372149 Title: bzr-git does not preserve or ignore unknown extra fields To manage notifications about this bug go to: https://bugs.launchpad.net/bzr-git/+bug/1372149/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 963525] Re: mergetag support: UnknownCommitExtra error
** Bug watch added: Email to dismine@gmail # mailto:dismine@gmail ** Also affects: valentina via mailto:dismine@gmail Importance: Undecided Status: New ** Also affects: valentina (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/963525 Title: mergetag support: UnknownCommitExtra error To manage notifications about this bug go to: https://bugs.launchpad.net/bzr-git/+bug/963525/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1372149] Re: bzr-git does not support HG:rename commit header fields
** Also affects: valentina (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1372149 Title: bzr-git does not support HG:rename commit header fields To manage notifications about this bug go to: https://bugs.launchpad.net/bzr-git/+bug/1372149/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 998416] [NEW] Apache Tomcat configuration requires manager-gui role & apache service stop/restart or system reboot
Public bug reported: The following information should be added to the document at https://help.ubuntu.com/10.04/serverguide/tomcat.html In setting up an Apache server, the /etc/tomcat6/tomcat-users.xml must be updated with a user assigned to the manager-gui role: 1. Open tomcat-users.xml file: sudo gedit /etc/tomcat6/tomcat-users.xml 2. Add manager-gui role and create a user: 3. Restart the apache service for configuration changes to take effect: sudo service apache2 restart ** Affects: ubuntu-docs (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/998416 Title: Apache Tomcat configuration requires manager-gui role & apache service stop/restart or system reboot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-docs/+bug/998416/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 762167] Re: missing dependency on gtk2-engines-pixbuf
Problem appears on Precise Pangolin when calling Inkscape 0.48.2 from the command line. 'sudo apt-get install gtk2-engines-pixbuf' solved it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/762167 Title: missing dependency on gtk2-engines-pixbuf To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/762167/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
