[Bug 1096641] Re: Patch to remove Bashism in /usr/share/acpi-support/power-funcs
** Changed in: acpi-support (Ubuntu) Status: Incomplete = New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1096641 Title: Patch to remove Bashism in /usr/share/acpi-support/power-funcs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/1096641/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1096641] Re: Patch to remove Bashism in /usr/share/acpi-support/power-funcs
Hello and thanks for the fast reply :) I guess an argument for it would be for use as a helper in local scripts. While writing a local workaround for #467825, it happened to suit my needs. I would have written a proper one if it didn't exist though. However, since then I caved in and patched upowerd, meaning I have no use for it anymore. Another issue with it is that if it's used by multiple scripts, it'll only work for the first one that happens to be called by acpid per power state change. So it's up to you in the end. If you decide its functionality is useful indeed, and since I seem to have stirred the waters here :), I could send you an improved version of it (or of the whole file while I'm at it). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1096641 Title: Patch to remove Bashism in /usr/share/acpi-support/power-funcs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/1096641/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1096641] Re: Patch to remove Bashism in /usr/share/acpi-support/power-funcs
this entire checkStateChanged() function appears to be unused by acpi- support. It's also not very well-written, calling 'exit' instead of 'return'. Why should we patch out the bashism, instead of removing the function entirely? ** Changed in: acpi-support (Ubuntu) Importance: Medium = Low ** Changed in: acpi-support (Ubuntu) Status: Triaged = Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1096641 Title: Patch to remove Bashism in /usr/share/acpi-support/power-funcs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/1096641/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1096641] Re: Patch to remove Bashism in /usr/share/acpi-support/power-funcs
** Changed in: acpi-support (Ubuntu) Importance: Undecided = Medium ** Changed in: acpi-support (Ubuntu) Status: New = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1096641 Title: Patch to remove Bashism in /usr/share/acpi-support/power-funcs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/1096641/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1096641] Re: Patch to remove Bashism in /usr/share/acpi-support/power-funcs
The attachment power-funcs_remove-bashism.patch of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report. [This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1096641 Title: Patch to remove Bashism in /usr/share/acpi-support/power-funcs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/1096641/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
