[Bug 1123460] Re: verify-signature crashes on non ascii characters
This bug was fixed in the package bzr - 2.6.0+bzr6593-1ubuntu1.1 --- bzr (2.6.0+bzr6593-1ubuntu1.1) trusty; urgency=medium * Fix verify-signature command crashing: - on non ascii characters (LP: #1123460) - when acceptable_keys configuration option is specified (LP: #1249732) -- Dimitri John LedkovFri, 09 May 2014 03:48:24 +0100 ** Changed in: bzr (Ubuntu Trusty) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
the testcase works fine with the update, setting as verification-done ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
Hello Francois, or anyone else affected, Accepted bzr into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/bzr/2.6.0+bzr6593-1ubuntu1.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: bzr (Ubuntu Trusty) Status: In Progress => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Changed in: bzr (Ubuntu Trusty) Status: New => In Progress ** Changed in: bzr (Ubuntu Trusty) Importance: Undecided => Low ** Changed in: bzr (Ubuntu Trusty) Importance: Low => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
This bug was fixed in the package bzr - 2.6.0+bzr6595-1ubuntu1
---
bzr (2.6.0+bzr6595-1ubuntu1) utopic; urgency=low
* Merge from Debian unstable. Remaining changes:
- Drop non-main build dependencies on python-{meliae,lzma,medusa}
bzr (2.6.0+bzr6595-1) unstable; urgency=medium
[ Jelmer Vernooij ]
* Re-add myself to uploaders.
* Don't pass blob to file.writelines(), but rather to file.write().
Closes: #722091
[ Dimitri John Ledkov ]
* New upstream snapshot:
- verify-signature crashes on non ascii characters (LP: #1123460)
- verify-signature crashes when acceptable_keys is defined (LP:
#1249732)
-- Dimitri John LedkovFri, 02 May 2014 14:18:01 +0100
** Changed in: bzr (Ubuntu Utopic)
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1123460
Title:
verify-signature crashes on non ascii characters
To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Description changed:
+ Impact:
+
+ Bzr crashes when verifying non-ascii characters in signatures, in
+ verbose mode.
+
+ Testcase:
+
+ bzr branch lp:~xnox/+junk/test-signatures
+ cd test-signatures
+ gpg --import key.asc
+ bzr verify-signatures -v
+
+
+ Original report:
+
first : on "bzr verify-signatures -v" i get :
bzr: ERROR: exceptions.TypeError: can only concatenate list (not "str") to
list
Traceback (most recent call last):
- File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 920, in
exception_to_return_code
- return the_callable(*args, **kwargs)
- File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1131, in
run_bzr
- ret = run(*run_argv)
- File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673, in
run_argv_aliases
- return self.run(**all_cmd_args)
- File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 695, in run
- return self._operation.run_simple(*args, **kwargs)
- File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136, in
run_simple
- self.cleanups, self.func, *args, **kwargs)
- File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in
_do_with_cleanups
- result = func(*args, **kwargs)
- File
"/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line
170, in run
- write(gpg_strategy.verbose_valid_message(result))
- File
"/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line
130, in write
- self.outf.write(string + "\n")
+ File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 920, in
exception_to_return_code
+ return the_callable(*args, **kwargs)
+ File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1131, in
run_bzr
+ ret = run(*run_argv)
+ File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673, in
run_argv_aliases
+ return self.run(**all_cmd_args)
+ File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 695, in run
+ return self._operation.run_simple(*args, **kwargs)
+ File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136, in
run_simple
+ self.cleanups, self.func, *args, **kwargs)
+ File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in
_do_with_cleanups
+ result = func(*args, **kwargs)
+ File
"/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line
170, in run
+ write(gpg_strategy.verbose_valid_message(result))
+ File
"/usr/lib/python2.7/dist-packages/bzrlib/commit_signature_commands.py", line
130, in write
+ self.outf.write(string + "\n")
TypeError: can only concatenate list (not "str") to list
-
-
-
- maybe a little more straight-forward; if I do "bzr qlog" then click on a
revision, i get :
+ maybe a little more straight-forward; if I do "bzr qlog" then click on a
+ revision, i get :
bzr: ERROR: exceptions.UnicodeEncodeError: 'ascii' codec can't encode
character u'\xe7' in position 4: ordinal not in range(128)
Traceback (most recent call last):
- File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/util.py",
line 908, in run_in_loading_queue
- f(*args, **kargs)
- File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/uifactory.py", line
32, in decorate
- r = f(*args, **kargs)
- File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py",
line 365, in update_selection
- revids, self.log_list.log_model.graph_viz.get_repo_revids)
- File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py",
line 149, in set_display_revids
- pass_prev_loaded_rev=True)
- File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/lazycachedrevloader.py",
line 53, in load_revisions
- revisions_loaded(return_revisions, False)
- File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py",
line 204, in revisions_loaded
- cached_revisions[revid].repository)
- File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 346, in
format_signature_validity
- return "valid signature from {0}".format(result[1])
+ File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/util.py",
line 908, in run_in_loading_queue
+ f(*args, **kargs)
+ File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/uifactory.py", line
32, in decorate
+ r = f(*args, **kargs)
+ File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py",
line 365, in update_selection
+ revids, self.log_list.log_model.graph_viz.get_repo_revids)
+ File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/revisionmessagebrowser.py",
line 149, in set_display_revids
+ pass_prev_loaded_rev=True)
+ File
"/usr/lib/python2.7/dist-packages/bzrlib/plugins/qbzr/lib/lazycachedrevloader.py",
line 53, in load_revisions
+ revisions_loaded(return_revisions, False)
+ File
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Changed in: bzr (Ubuntu Trusty) Assignee: (unassigned) => Dimitri John Ledkov (xnox) ** Changed in: bzr (Ubuntu Utopic) Assignee: (unassigned) => Dimitri John Ledkov (xnox) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Also affects: bzr (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: bzr (Ubuntu Utopic) Importance: Undecided Status: Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Changed in: bzr Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Changed in: bzr Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Changed in: bzr Status: In Progress => Fix Committed ** Changed in: bzr Milestone: None => 2.7b1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
Hi Reagan, Thanks for suggesting a fix. Please submit the patch as a merge request against bzr's trunk. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
A test branch with an export of the UTF-8-containing public key used to sign it included. The public key needs to be in your keyring for bzr to be able to get the pretty name and thus exercise the UTF-8 code path. Similarly, you also have to be able to verify all the signing keys in order to exercise the failing --verbose code path. ** Attachment added: "sign2.tar.gz" https://bugs.launchpad.net/bzr/+bug/1123460/+attachment/3752393/+files/sign2.tar.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Branch linked: lp:~vexofp/bzr/bzr -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Branch linked: lp:~vexofp/bzr/fix-1123460 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Changed in: bzr Status: New => In Progress ** Changed in: bzr Assignee: (unassigned) => Reagan Sanders (vexofp) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Also affects: bzr Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Branch linked: lp:~vexofp/bzr/bzr -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
The attachment "bzr_verify_signature_verbose_fix.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu- reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
patch fixing the UTF issue. We were trying to stick the UTF strings from the GPG subsystem into plain ASCII format strings. Changed the format strings to be UTF as well. His test branch seems to work fine now. ** Patch added: "bzr_verify_signature_utf_fix.patch" https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+attachment/3751719/+files/bzr_verify_signature_utf_fix.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
patch fixing the issue with verify-signatures --verbose. We were attempting to pass an array of strings to write directly. Changed to loop through the array and write them all. ** Patch added: "bzr_verify_signature_verbose_fix.patch" https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+attachment/3751718/+files/bzr_verify_signature_verbose_fix.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: bzr (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
Update : I created a fake key without the "ç". "verify-signatures -v" still crashes, but qbzr doesn't anymore -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1123460] Re: verify-signature crashes on non ascii characters
** Attachment added: "A very simple branch with my apparently exotic signature." https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+attachment/3525747/+files/sign.tgz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1123460 Title: verify-signature crashes on non ascii characters To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bzr/+bug/1123460/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
