[Bug 1130857] Re: Some images have a blue tint
Launchpad has imported 15 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=817356. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2012-12-02T02:47:58+00:00 Steve-c wrote: Bug 486918 added new image resizers from SKIA. Since this was enabled resized images on my ppc32 machine show up with a blue tint. The convolver code extracts the RGBA bits from each 32 bit pixel but doesn't take the endian order into account. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/0 On 2012-12-02T02:52:10+00:00 Steve-c wrote: Created attachment 687479 proposed fix. Detect that this is a PPC and set the BENDIAN then use that when extracting the bits Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/1 On 2012-12-03T15:50:36+00:00 Joe-drew wrote: Comment on attachment 687479 proposed fix. Detect that this is a PPC and set the BENDIAN then use that when extracting the bits Review of attachment 687479: - ::: gfx/2d/convolver.cpp @@ +206,3 @@ if (has_alpha) +accum[3] += cur_filter * source_data_rows[filter_y][byte_offset + + A_OFFSET_IDX]; Can you just leave these all on the same line? @@ +231,5 @@ // // We only need to do this when generating the final output row (here). + int max_color_channel = NS_MAX(out_row[byte_offset + R_OFFSET_IDX], + NS_MAX(out_row[byte_offset + G_OFFSET_IDX], out_row[byte_offset + + B_OFFSET_IDX])); Same line here too Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/2 On 2012-12-04T04:16:27+00:00 Steve-c wrote: Created attachment 688092 v2 of the patch, all one one line but this exceeds 80 characters Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/3 On 2012-12-04T04:32:56+00:00 Steve-c wrote: Created attachment 688094 v3 has the line break but in a better spot Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/4 On 2012-12-09T20:21:48+00:00 Landry-openbsd wrote: Pushed v3 in https://hg.mozilla.org/integration/mozilla- inbound/rev/69b924c155b0 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/5 On 2012-12-09T20:28:17+00:00 Matt-woodrow wrote: I would strongly recommend that the change to SkPreConfig.h gets a patch file added to gfx/skia/patches, or that this change be upstreamed to google's skia repo (or both!). Otherwise this change is at risk of being overwritten when we next update skia. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/6 On 2012-12-10T02:21:03+00:00 Steve-c wrote: submitted for review upstream https://codereview.appspot.com/6900063/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/7 On 2012-12-10T02:22:35+00:00 Steve-c wrote: Created attachment 690255 adds the changes to SkPreConfig.h as a patch listed in gfx/skia/patches This patch will add a patch file in gfx/skia/patches to alter SkPreConfig.h the next time we import upstream sources Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/8 On 2012-12-10T02:52:07+00:00 Joe-drew wrote: Sorry! I was confusing SkPreConfig.h with SkUserConfig.h, and incorrectly figured it didn't need to have a separate patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/9 On 2012-12-10T19:06:18+00:00 Ryanvm wrote: https://hg.mozilla.org/mozilla-central/rev/69b924c155b0 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/10 On 2013-03-09T16:23:53+00:00 Landry-openbsd wrote: Apparently attachment #690255 never went through review in m-c nor commited, and neither upstream
[Bug 1130857] Re: Some images have a blue tint
** Changed in: firefox Importance: Medium = Unknown ** Changed in: firefox Status: Confirmed = Unknown ** Changed in: firefox Remote watch: Mozilla Bugzilla #844436 = Mozilla Bugzilla #817356 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
Fixed since Firefox 20. ** Changed in: firefox (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
Here is the mozilla bug with workaround https://bugzilla.mozilla.org/show_bug.cgi?id=844436 . ** Bug watch added: Mozilla Bugzilla #844436 https://bugzilla.mozilla.org/show_bug.cgi?id=844436 ** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=844436 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
This bug https://bugzilla.mozilla.org/show_bug.cgi?id=817356 has just popped up on the debina mailing list. It appears to contain a patch for this problem? ** Bug watch added: Mozilla Bugzilla #817356 https://bugzilla.mozilla.org/show_bug.cgi?id=817356 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
Launchpad has imported 13 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=844436.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
On 2013-02-23T11:57:57+00:00 Oibaf wrote:
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux ppc; rv:19.0) Gecko/20100101
Firefox/19.0
Build ID: 20130218104019
Steps to reproduce:
Open a random site with png or jpg images on it (e.g. search on google
images).
Actual results:
Many images (happens on both png and jpg) have a blu tint. It happens
that the image loads fine (colors are OK), but when completely loaded a
blu layer appears on it. Strangely when the same image is shown more
time on the same page not all have the blu tint.
Expected results:
Images have correct colors as it happened on firefox = 18. This
happened after upgrading to ff 19 on a Ubuntu 12.04 (official ubuntu
packages) on a powerpc G4 machine.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/6
On 2013-02-23T12:18:42+00:00 Epinal99-bugzilla wrote:
1) Test with a fresh profile, see https://support.mozilla.org/en-US/kb
/profile-manager-create-and-remove-firefox-profiles
2) If images are normal in FF18-, so there is maybe a regression.
Use the tool mozregression to find a possible regression range, see
http://harthur.github.com/mozregression/
(ex: mozregression --good=2012-08-01)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/7
On 2013-02-23T12:43:10+00:00 Oibaf wrote:
I did a mv .mozilla .mozilla_backup, started ff and confirmed the blu
images. When trying a bisect I get:
$ mozregression --good=2012-08-01
Downloading nightly from 2012-11-12
Installing nightly
Starting nightly
['moznightlyapp/firefox/firefox', '-profile', '/tmp/tmpteutxk.mozrunner']
Traceback (most recent call last):
File /usr/local/bin/mozregression, line 9, in module
load_entry_point('mozregression==0.6.4', 'console_scripts',
'mozregression')()
File /usr/local/lib/python2.7/dist-packages/mozregression/regression.py,
line 187, in cli
bisector.bisect(get_date(options.good_date), get_date(options.bad_date))
File /usr/local/lib/python2.7/dist-packages/mozregression/regression.py,
line 108, in bisect
dest = self.runner.start(midDate)
File /usr/local/lib/python2.7/dist-packages/mozregression/runnightly.py,
line 237, in start
if not self.app.start(self.profile, self.addons, self.cmdargs):
File /usr/local/lib/python2.7/dist-packages/mozregression/runnightly.py,
line 141, in start
self.runner.start()
File /usr/local/lib/python2.7/dist-packages/mozrunner/runner.py, line 183,
in start
self.process_handler.run(timeout, outputTimeout)
File /usr/local/lib/python2.7/dist-packages/mozprocess/processhandler.py,
line 621, in run
self.proc = self.Process(self.cmd, **args)
File /usr/local/lib/python2.7/dist-packages/mozprocess/processhandler.py,
line 76, in __init__
universal_newlines, startupinfo, creationflags)
File /usr/lib/python2.7/subprocess.py, line 679, in __init__
errread, errwrite)
File /usr/lib/python2.7/subprocess.py, line 1249, in _execute_child
raise child_exception
OSError: [Errno 8] Exec format error
Exception AttributeError: 'ProcessHandler' object has no attribute 'proc' in
bound method Runner.cleanup of mozrunner.runner.Runner object at 0x10f71530
ignored
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/8
On 2013-02-23T12:48:33+00:00 Bugzilla-tf wrote:
mozregression will not work because we don't have PPC builds, only x64 and X86.
( ftp://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central/ )
Reporter: Please set image.high_quality_downscaling.enabled to false in
about:config and test again.
gfx.color_management.mode to 0 would be another thing to try.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/9
On 2013-02-23T13:08:17+00:00 Oibaf wrote:
OK, can you tell me how to purge all things installed with sudo pip
install mozregression?
Just setting image.high_quality_downscaling.enabled to false fixes the
problem.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/10
On 2013-02-23T13:23:56+00:00 Bugzilla-tf wrote:
(In reply to Fabio from comment #4)
OK, can you tell me how to purge all things installed with sudo pip install
mozregression?
sudo pip
[Bug 1130857] Re: Some images have a blue tint
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: firefox (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
I am also getting this problem with Firefox 19, Ubuntu 12.04.2, iBook G4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
David, here's the rather poor workaround I used: apt-get remove firefox cd /var/cache/apt/archives dpkg -i *firefox*18.02* Then pin Firefox at this version by pasting the following into /etc/apt/preferences.d/firefox: Package: *firefox* Pin: version n=18.0.2 Pin-Priority: 999 apt-get update and you should be sorted until this bug is fixed - modulo security holes. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1130857] Re: Some images have a blue tint
Oops, I got to Launchpad after I had downgraded, to be extra clear: this bug refers to *the latest Firefox as of 20/2/13.* -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
