[Bug 113207] Re: laptop-mode remount does not work
/usr/share/laptop-mode-tools/modules/laptop-mode in line 383 read saved options if WAS_ACTIVE is not 0 and file with saved options exists, but WAS_ACTIVE is always 0 in ubuntu because WAS_ACTIVE detection was removed in ubuntu package. Copying the detection code from upstream to /usr/sbin/laptop-mode fixes this bug, and I haven't got any regression in other modules. -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
We are closing this bug report because it lacks the information we need to investigate the problem, as described in the previous comments. Please reopen it if you can give us the missing information, and don't hesitate to submit bug reports in the future. To reopen the bug report you can click on the current status, under the Status column, and change the Status back to New. Thanks again! ** Changed in: laptop-mode-tools (Ubuntu) Status: Incomplete = Invalid -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
Is this still an issue in Ubuntu 8.04? ** Changed in: laptop-mode-tools (Ubuntu) Status: Confirmed = Incomplete -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
Does this still apply to Hardy? -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 113207] Re: laptop-mode remount does not work
Il giorno lun, 18/02/2008 alle 11.42 +, Daniel Holbach ha scritto: Does this still apply to Hardy? I don't know: I'm still using Gutsy. Mario -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
I have similar problems: I've enabled the CONTROL_NOATIME option so the script 'laptop-mode start' change the mount options of my root with the addition 'noatime' flag. The logic of the laptop_mode script is buggy: the invocation 'laptop-mode stop' doesn't remove the 'noatime' flag!! The script is broken: just look at the use of the WAS_ACTIVE variable. You sent once the value to 0 and you never change it. The value 0 prevents the script to restore the old flags that are correctly saved in /var/run/laptop-mode-nolm-mountopts. Please fix the script. Thanks. -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
Marc, your patches seem to make sense. A lot of WAS_ACTIVE stuff was taken out of the Ubuntu version, I don't know why these pieces were still in there. ** Changed in: laptop-mode-tools (Ubuntu) Status: New = Confirmed -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
Marc, are you sure that wildcards in PARTITIONS do not work? They should be expanded, at the latest at: # Expand shell wild cards immediately. PARTITIONS=$( echo $PARTITIONS ) -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
(yes, that wildcard thing was fixed upstream in 1.33, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=394557) -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
* If called without arguments, the script throws a syntax error: This has also been fixed in later versions. This patch removes WAS_ACTIVE and uses ACTIVATE in one case The reason for the WAS_ACTIVE stuff is that the mount settings should be saved only if we are switching to laptop_mode (from not-active to active). Note that the script can be run several times, for instance when pulling the power cord and then closing the lid. If we saved the settings when AC was unplugged, we don't want to save them again (and overwrite the original settings with the new) when lid is closed. But ACTIVATE will be true in both cases. So I don't think your patch handles this correctly. OTOH it's not clear for me why the WAS_ACTIVE detection was ripped out either. -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
(I am using feisty.. forgot to mention this,sorry) Looking deeper into the script the seems to be a pile of open issues... patches will be cumulative... This one fixes the issue: * If called without arguments, the script throws a syntax error: /usr/sbin/laptop_mode: line 597: [: ==: unary operator expected /usr/sbin/laptop_mode: line 600: [: ==: unary operator expected ** Attachment added: LM_01_syntax.diff http://librarian.launchpad.net/7579686/LM_01_syntax.diff -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 113207] Re: laptop-mode remount does not work
* It seems that WAS_ACTIVE is *always* set to 0. And the file mentioned in the comment /var/run/laptop-mode-state is not used or referenced at at all. So mount options will never be reverted This patch removes WAS_ACTIVE and uses ACTIVATE in one case ** Attachment added: LM_02_remount-fix.diff http://librarian.launchpad.net/7579823/LM_02_remount-fix.diff -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
