[Bug 1228250]
*** Bug 616771 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Changed in: firefox Importance: Wishlist => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Bug watch added: KDE Bug Tracking System #378584 https://bugs.kde.org/show_bug.cgi?id=378584 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/4-5/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Pushed by masay...@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/63b547bb4078 Make users can scroll contents horizontally with vertical wheel operation with a modifier r=smaug -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to public from comment #128) > This add-on can be used until Firefox 58 has been released: Shift + Scroll > (Horizontal Scrolling) - > https://addons.mozilla.org/en-US/firefox/addon/shift-scroll/ Firefox 56 and earlier, it can be implemented by XUL addons, but Gecko 58+ has this feature. So, only with Firefox 57, you cannot use this feature. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
By navigating the source code, I believe I have figured out how to resolve bug 1438794 and would like to have a try to work on the "first good" bug for myself. Hope someone would assign bug 1438794 for me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://hg.mozilla.org/mozilla-central/rev/63b547bb4078 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=57d5864711a2a2bd65130644c9da616017184b58 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/3-4/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
*** Bug 1431966 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review195394 > You change the ordering of whether action is first checked for plugin or apz, and delta is adjusted before the plugin chcek. But I guess that makes sense. But please test (manually) some Flash doing scrolling. It's necessary to adjust the wheel deltas before updating wheel transaction which is automatically done in ComputeScrollTarget(). And unfortunately, I don't find Flash contents which have horizontal scroll. As far as I read Action Script documents, Action Script doesn't support horizontal wheel events. Therefore, Flash contents cannot handle horizontal scroll anyway. I don't know about the scrollable contents in Flash. That's what I could find. > We do have this similar code in several places. > Can you think of anyway to have a helper method to do this all? If not, fine. Okay, I did it in new patch. > Vertually? Do you mean Virtually Oops! Nice catch! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
This add-on can be used until Firefox 58 has been released: Shift + Scroll (Horizontal Scrolling) - https://addons.mozilla.org/en- US/firefox/addon/shift-scroll/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
I realized that due to e10s mochitests disabled, we won't test the default actions of wheel events without APZ. I manually ran the test without non-e10s mochitests. Then, I confirmed that it's all green. On the other hand, there is a known bug in the patch. The multiplier pref for X axis is applied to deltaY if the wheel event should be treated as horizontal scroll. So, WheelEvent.deltaY may see odd delta value with it especially when the multiplier X is negative (meaning scroll direction is reversed) but multiplier Y is positive. With more complicated code, I can fix it, but I don't know if it's enough worthwhile... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
1-3 or 2-2 sound reasonable to me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review193228 Still r-, because I was surprised to see "expected: kScrollDown | kScrollLeft" in case there is both vertical and horizontal scrolling with modifier. Please explain or fix. ::: dom/events/test/window_wheel_default_action.html:1830 (Diff revision 2) > + > + const kTests = [ > +// Without modifier key, the default's action should be used. > +// I.e., vertical scroll is expected normally. > +{ defaultActions: { > +default: 1, with_shift: 2, with_control: 3 What these numbers are? 1, 2, 3? Please add some comment ::: dom/events/test/window_wheel_default_action.html:1853 (Diff revision 2) > + deltaX: 0, deltaY: -1.0, > + lineOrPageDeltaX: 0, lineOrPageDeltaY: -1, > + shiftKey: false, ctrlKey: false, altKey: false }, > + expected: kScrollUp > +}, > +// If only the modifier to treat vertical wheel as horizontal scroll, I don't understand this sentence. ::: dom/events/test/window_wheel_default_action.html:1914 (Diff revision 2) > + deltaMultiplierX: 1.0, > + deltaMultiplierY: 1.0, > + event: { deltaMode: WheelEvent.DOM_DELTA_LINE, > + deltaX: 0, deltaY: 1.0, > + lineOrPageDeltaX: 0, lineOrPageDeltaY: 1, > + shiftKey: true, ctrlKey: true, altKey: false }, Oh, modifier in the JS object isn't about the event but about the pref. Could you document that somewhere ::: dom/events/test/window_wheel_default_action.html:1981 (Diff revision 2) > + deltaX: 0, deltaY: -1.0, > + lineOrPageDeltaX: 0, lineOrPageDeltaY: -1, > + shiftKey: true, ctrlKey: true, altKey: false }, > + expected: kScrollUp > +}, > +// If the wheel is operated diagonally, shouldn't treat the deltaY as This sounds wrong. If the pref is set, and modifier is pressed, why should viewport scroll ever horizontally? I don't see such behavior in Chrome on Windows ::: dom/events/test/window_wheel_default_action.html:2184 (Diff revision 2) > ["mousewheel.default.action.override_x", -1], > ["mousewheel.with_shift.action", 2], // history > ["mousewheel.with_shift.action.override_x", -1], > ["mousewheel.with_control.action", 3], // zoom > -["mousewheel.with_control.action.override_x", -1]]}, > +["mousewheel.with_control.action.override_x", -1], > +["mousewheel.modifier_to_treat_vertical_wheel_as_horizontal_scroll", > 0]]}, I don't understand this. Why 0? Doesn't that disable the feature. ::: modules/libpref/init/all.js:2759 (Diff revision 2) > +// to one of 16 (Shift), 17 (Ctrl), 18 (Alt/Option) and 224 (Command), the > +// corresponding modifier key with vertical scroll is treated as horizontal > +// scroll. Note that this setting may override the action set by > +// "mousewheel.with_*.action" and mousewheel.with_*.action.override_x. E.g., > +// when this is set to 16 (Shift) and "mousewheel.with_shift.action" is set > to > +// 2 (History Navigation), try to scrolling vertically with Shift key causes s/try to// ::: widget/MouseEvents.h:597 (Diff revision 2) > mLineOrPageDeltaX : mLineOrPageDeltaY; >} > > + void SwapDeltaXAndDeltaY() > + { > +auto tmpDelta = mDeltaX; I guess you could use std::swap here -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review192674 This is complicated enough, that I think I should re-read this after those small nits are fixed. ::: commit-message-19b32:26 (Diff revision 1) > +restoring. > + > +So, this patch does NOT change any wheel event information on web apps. Only > +changes its default action. This is same behavior as Chromium. > + > +Note that with this patch, users cannot navigate the tab's history with Could you explain this. Currently shift+vertical wheel is back-forward. Does this new behavior override that feature always or only when it is enabled explicitly? How is shift+horizontal supposed to work for back-forward if shift+vertical is for scrolling? One often gets both horizontal and vertical scrolling when using touchpad. ::: dom/events/EventStateManager.h:652 (Diff revision 1) > * If an .override_x value is -1, same as the > * corresponding mActions value. > */ > Action mOverriddenActionsX[COUNT_OF_MULTIPLIERS]; > > +// XXX Modifier is better than Modifiers. However, it's defined in That seems like a silly reason to not use Modifier. If you're really worried about the build time change, why not just move Modifier to its own header? ::: dom/events/EventStateManager.cpp:5691 (Diff revision 1) > + } > + > + Index index = GetIndexFor(aEvent->mModifiers & > + > ~mModifierToTreatVertialWheelAsHorizontalScroll); > + Init(index); > + // We need to cache this result in the widget. Some methods of this class Cache the result in the widget? I don't see anything stored in the widget. ::: dom/events/EventStateManager.cpp:5710 (Diff revision 1) > return INDEX_DEFAULT; >} > + if (!NeedToTreatAsHorizontalScroll(aEvent)) { > +return GetIndexFor(aEvent->mModifiers); > + } > +#if 0 No ifdef 0 code, please ::: dom/events/EventStateManager.cpp:5837 (Diff revision 1) >Index index = GetIndexFor(aEvent); >Init(index); > > + // If the event should be treated as horizontal wheel operation, deltaY > + // should be applied mMultiplierX. Note that deltaX and deltaZ are always > + // 0 in such case. Therefore, we only need to use temporary variable only Why they are 0? ::: dom/events/EventStateManager.cpp:5842 (Diff revision 1) > + // 0 in such case. Therefore, we only need to use temporary variable only > + // for deltaY. Additionally, if the event is being handled by default > + // handler, the deltaX and deltaY may be swapped. Therefore, we need to > + // use mMultiplierX for deltaY only when the event should be treated as > + // horizontal scroll and mDeltaY isn't 0. > + auto multiplierForDeltaY = mMultiplierY[index]; Could you not use auto here. With auto I need to go to the mMultiplierY definition to see what the type of multiplierForDeltaY is. ::: dom/events/EventStateManager.cpp:5886 (Diff revision 1) > aEvent->mOverflowDeltaX /= mMultiplierX[index]; >} > - if (mMultiplierY[index]) { > -aEvent->mOverflowDeltaY /= mMultiplierY[index]; > + > + // If the event should be treated as horizontal wheel operation, deltaY > + // should be applied mMultiplierX. Note that deltaX and deltaZ are always > + // 0 in such case. Therefore, we only need to use temporary variable only Again, why they are 0? ::: dom/events/EventStateManager.cpp:5891 (Diff revision 1) > + // 0 in such case. Therefore, we only need to use temporary variable only > + // for deltaY. Additionally, if the event is being handled by default > + // handler, the deltaX and deltaY may be swapped. Therefore, we need to > + // use mMultiplierX for deltaY only when the event should be treated as > + // horizontal scroll and mDeltaY isn't 0. > + auto multiplierForDeltaY = mMultiplierY[index]; Don't use auto, pretty please. ::: dom/events/WheelHandlingHelper.h:217 (Diff revision 1) > + */ > +class MOZ_STACK_CLASS AutoTemporarilyWheelDeltaSwapper final > +{ > +public: > + /** > + * @param aWheelEvent A wheel event. Must not be nullptr. If so, perhaps make the ctor take WidgetWheelEvent& and store using that type too. That self-documents that it must not ever-never be null -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/2-3/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review193228 Because the tests set default action of both without any modifier and with shift to "scroll": > default: 1, with_shift: 1, with_control: 3 Therefore, even if the new pref overrides "default"'s default action, it should be ignored (i.e., default action of with_shift should be executed) since the wheel operation is not only for vertical-wheel. In other words, if with_shift is 2 as the default settings of non-macOS platforms, the diagonal wheel operation with Shift should cause navigating history. However, it's impossible to test it with this automated test. > What these numbers are? 1, 2, 3? Please add some comment Okay, I'll replace them with constants. > I don't understand this sentence. I meant "If only the modifier to trreat vertical wheel as horizontal scroll is active," > This sounds wrong. If the pref is set, and modifier is pressed, why should viewport scroll ever horizontally? I don't see such behavior in Chrome on Windows On macOS, we may receive diagonal wheel operation events. In such case, we should not respect the new pref because the new pref is for legacy mouse device which only supports vertical wheel operation but the user's device is obviously supports horizontal wheel operation in this case. Do you think that we should enable this hack even in this case? > I don't understand this. Why 0? Doesn't that disable the feature. Yes. Because if we set a modifier key code here, I need to rewrite existing tests. And that needs special handling with this pref. I.e., that causes making the existing tests really complicated. Therefore, I think that we should keep running existing tests with disabling the new pref. But the new feature should be tested by the new tests. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Oops, I used wrong form to reply to the review comments :-( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/1-2/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review195394 ::: browser/app/profile/firefox.js:639 (Diff revision 4) > -pref("mousewheel.with_shift.action", 2); > +// only vertical wheel but want to scroll horizontally. For such users, we > +// should provide horizontal scroll with shift+wheel (same as Chrome). > +// However, shift+wheel was used for navigating history. For users who want > +// to keep using this feature, let's enable it with alt+wheel. This is > better > +// for consistency with macOS users. > +pref("mousewheel.with_shift.action", 4); ok, this is of course a change to the default behavior, but we do have some time to get feedback ::: dom/events/EventStateManager.cpp:3298 (Diff revision 4) > - // When APZ is enabled, the actual scroll animation might be handled by > - // the compositor. > - WheelPrefs::Action action; >if (pluginFrame) { > MOZ_ASSERT(pluginFrame->WantsToHandleWheelEventAsDefaultAction()); > action = WheelPrefs::ACTION_SEND_TO_PLUGIN; You change the ordering of whether action is first checked for plugin or apz, and delta is adjusted before the plugin chcek. But I guess that makes sense. But please test (manually) some Flash doing scrolling. ::: dom/events/EventStateManager.cpp:5915 (Diff revision 4) > > - *aOutMultiplierX = mMultiplierX[index]; > - *aOutMultiplierY = mMultiplierY[index]; > + // If the event should be treated as horizontal wheel operation, deltaY > + // should be multiplied by mMultiplierY, however, it might be moved to > + // deltaX for handling default action. In such case, we need to treat > + // mMultiplierX and mMultiplierY as swapped. > + double multiplierForDeltaX = mMultiplierX[index]; We do have this similar code in several places. Can you think of anyway to have a helper method to do this all? If not, fine. ::: dom/events/WheelHandlingHelper.h:233 (Diff revision 4) > + WidgetWheelEvent& mWheelEvent; > + double mOldDeltaX; > + double mOldDeltaZ; > + double mOldOverflowDeltaX; > + int32_t mOldLineOrPageDeltaX; > + bool mTreatedVertualWheelAsHorizontalScroll; Vertually? Do you mean Virtually -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Created attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier This patch declares a new pref, "mousewheel.modifier_to_treat_vertical_wheel_as_horizontal_scroll", this takes a keycode of modifier keys as its value. The default value is 16 (NS_VK_SHIFT) on Windows, Linux and Android and 0 (meaning disabled) on macOS. The reason why this new feature is disabled on macOS is, if user turns vertical wheel of mice with Shift key, macOS notifies us of horizontal scroll events. So, we don't need to care this feature by ourselves on macOS. If a modifier keycode is specified to the pref as expected, EventStateManager and EventStateManager::WheelPrefs treats vertical wheel operation as horizontal scroll when coming wheel event without the modifier causes scroll. In such case, EventStateManager::WheelPrefs::NeedToTreatAsHorizontalScroll() returns true. Otherwise, false. If this returns true, default action handler of wheel events such as EventStateManager::PostHandleEvent() and IAPZCTreeManager::ReceiveInputEvent() swaps deltaX values and deltaY values of coming wheel event temporarily and restore them. AutoTemporarilyWheelDeltaSwapper in WheelHandlingHelper guarantees this restoring. So, this patch does NOT change any wheel event information on web apps. Only changes its default action. This is same behavior as Chromium. Note that with this patch, users cannot navigate the tab's history with Shift + vertical-wheel in the default settings. However, I guess that the usage of this feature is less than the number of users who wants to scroll contents horizontally with vertical mouse wheel. Of course, Shift + horizontal-wheel is available for navigating tab's history even after this change. Review commit: https://reviewboard.mozilla.org/r/186794/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/186794/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eedf1e99a374ea782be21bb64d707fa014c9b435 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Okay, now, I think that 2-2 is the best here because: 1. if we ban diagonal wheel events with specific modifier key, horizontal scroll might be too slow if the device can cause diagonal scroll easily (even if user expects only vertical scroll). 2. if we also take deltaX as horizontal scroll, horizontal scroll might be too fast if user does diagonal scroll. Then, we can treat the new action as simple default action. I'll rewrite the implementation of ESM::WheelPrefs. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review193228 > Oh, modifier in the JS object isn't about the event but about the pref. Could you document that somewhere I'll rename it instead of documenting it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
hmm, yeah, perhaps that isn't even a bug but a feature. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Ok, if some other browser (happens to be Chrome) doesn't change the delta values, we shouldn't either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #108) > On macOS, we may receive diagonal wheel operation events. In such case, we > should not respect the new pref because the new pref is for legacy mouse > device How so? Isn't it for touchpads too. > which only supports vertical wheel operation but the user's device is > obviously supports horizontal wheel operation in this case. Do you think > that we should enable this hack even in this case? I don't know what hack. How is this supposed to work on Windows + touchpad? On Chrome if shift is pressed, only horizontal scrolling will happen. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Olli Pettay [:smaug] from comment #111) > (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #108) > > > On macOS, we may receive diagonal wheel operation events. In such case, we > > should not respect the new pref because the new pref is for legacy mouse > > device > How so? Isn't it for touchpads too. Oh, really? I remembered as so. Just my memory is wrong or macOS's behavior has been changed (IIRC, starting Sierra, mouse scroll event behavior has been changed, it might be changed at this time). > > which only supports vertical wheel operation but the user's device is > > obviously supports horizontal wheel operation in this case. Do you think > > that we should enable this hack even in this case? > I don't know what hack. I think the new feature is hack for the legacy mice. > How is this supposed to work on Windows + touchpad? On Chrome if shift is > pressed, only > horizontal scrolling will happen. On Windows, native event doesn't support diagonal scroll with an event. So, this case never occurs on Windows actually. (If user tries to scroll content diagonally, both vertical wheel event and horizontal wheel event are fired separately.) Although, it could occur with some touchscreen. However, I don't see wheel events when I scroll content in Gecko with my notebook's touchscreen. (Pan gesture could fire wheel events, but I'm not familiar with this path: https://searchfox.org/mozilla- central/rev/1a4a26905f923458679a59a4be1e455ebc53c333/widget/windows/nsWinGesture.cpp#393,409-410,412-413 ) I'm not sure about GTK. GTK3's event has both delta values in an event. So, it could support diagonal scroll, but I don't have environment that Linux is installed on real machine (not virtual machine). Anyway, I don't think that we should use this feature when the user's device is obviously non-legacy pointing device, i.e., it supports diagonal scroll. What do you think? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8a75e4e55f87b622341651c1ff95e097272cb0f -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
2-3. Handle deltaX as horizontal scroll too (but may cause too fast or slow scroll with diagonal wheel operation). I like 1-1, 1-3 or 2-2. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e15a3bcb3fcc3f8288e6f6ffdc31e28d042542ea -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Requesting ni? for the above reply from MozReview. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Olli Pettay [:smaug] from comment #113) > (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #112) > > Anyway, I don't think that we should use this feature when the user's device > > is obviously non-legacy pointing device, i.e., it supports diagonal scroll. > > What do you think? > But this is enabled on touchpads too, if the pref is set. Could we somehow > enable it on mouse input only, and not touchpad? Unfortunately, on any platforms, we cannot check if mouse scroll event came from what kind of device. There are some options: 1. Take current approach -- treat "pure" vertical wheel operation as horizontal scroll and 1-1. Handle deltaX as is (current approach). 1-2. Handle deltaX as vertical scroll (I don't like this and incompatible with Chrome). 1-3. Ignore deltaX, so, if only deltaX is non-zero, does nothing. 2. Treat any vertical wheel operation as horizontal scroll (even if it's diagonal operation) and/but 2-1. Handle deltaX as vertical scroll (same as 1-2). 2-2. Ignore deltaX (same as 1-3). If user operates wheel diagonally but native events come separately, it might be the best to ignore deltaX. E.g., we can avoid performing 2 default actions (e.g., both horizontal scroll and navigating history), but this means that the default action will always be ignored if it matches with new pref's modifier. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review192730 ::: commit-message-19b32:26 (Diff revision 1) > +restoring. > + > +So, this patch does NOT change any wheel event information on web apps. Only > +changes its default action. This is same behavior as Chromium. > + > +Note that with this patch, users cannot navigate the tab's history with Yes, when the new pref is enabled, the modifier (default value is Shift on non-macOS platforms) with vertical wheel overrides the default action. the modifier with horizontal wheel or diagonal wheel operation works exactly same as current build. See NeedToTreatAsHorizontalScroll() implementation for the detail. ::: dom/events/EventStateManager.h:652 (Diff revision 1) > * If an .override_x value is -1, same as the > * corresponding mActions value. > */ > Action mOverriddenActionsX[COUNT_OF_MULTIPLIERS]; > > +// XXX Modifier is better than Modifiers. However, it's defined in Sure. I'll move it to EventForwards.h. ::: dom/events/EventStateManager.cpp:5691 (Diff revision 1) > + } > + > + Index index = GetIndexFor(aEvent->mModifiers & > + > ~mModifierToTreatVertialWheelAsHorizontalScroll); > + Init(index); > + // We need to cache this result in the widget. Some methods of this class Ah, I meant in WidgetWheelEvent. ::: dom/events/EventStateManager.cpp:5710 (Diff revision 1) > return INDEX_DEFAULT; >} > + if (!NeedToTreatAsHorizontalScroll(aEvent)) { > +return GetIndexFor(aEvent->mModifiers); > + } > +#if 0 Oops, sorry and nice catch! ::: dom/events/EventStateManager.cpp:5837 (Diff revision 1) >Index index = GetIndexFor(aEvent); >Init(index); > > + // If the event should be treated as horizontal wheel operation, deltaY > + // should be applied mMultiplierX. Note that deltaX and deltaZ are always > + // 0 in such case. Therefore, we only need to use temporary variable only Because NeedToTreatAsHorizontalScroll() checks |if (aEvent->mDeltaX || !aEvent->mDeltaY || aEvent-DeltaZ)| and return false if it's true. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review192674 > Could you explain this. Currently shift+vertical wheel is back-forward. Does > this new behavior override that feature always or only when it is enabled > explicitly? > > How is shift+horizontal supposed to work for back-forward if shift+vertical > is for scrolling? One often gets both horizontal and vertical scrolling when > using touchpad. Yes, when the new pref is enabled, the modifier (default value is Shift on non-macOS platforms) with vertical wheel overrides the default action. the modifier with horizontal wheel or diagonal wheel operation works exactly same as current build. See NeedToTreatAsHorizontalScroll() implementation for the detail. > That seems like a silly reason to not use Modifier. > If you're really worried about the build time change, why not just move > Modifier to its own header? Sure. I'll move it to EventForwards.h. > Cache the result in the widget? I don't see anything stored in the widget. Ah, I meant in WidgetWheelEvent. > No ifdef 0 code, please Oops, sorry and nice catch! > Why they are 0? Because NeedToTreatAsHorizontalScroll() checks |if (aEvent->mDeltaX || !aEvent->mDeltaY || aEvent-DeltaZ)| and return false if it's true. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f517c8a2bdf5265c785e60f2b9d125285869c42f -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #112) > (In reply to Olli Pettay [:smaug] from comment #111) > > (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #108) > > > > > On macOS, we may receive diagonal wheel operation events. In such case, we > > > should not respect the new pref because the new pref is for legacy mouse > > > device > > How so? Isn't it for touchpads too. > > Oh, really? I remembered as so. Just my memory is wrong or macOS's behavior > has been changed (IIRC, starting Sierra, mouse scroll event behavior has > been changed, it might be changed at this time). Sorry, I was unclear. I was talking about touchpads on Windows. I have no idea about MacOS > I'm not sure about GTK. GTK3's event has both delta values in an event. So, > it could support diagonal scroll, but I don't have environment that Linux is > installed on real machine (not virtual machine). I see, on linux Chrome has odd behavior where it seems to allow vertical scrolling when diagonal scrolling is done. That behavior is really weird when one uses it. Makes scrolling feel like all broken since viewport is scrolled somewhat randomly. It is hard to control whether to do only up-down or left-right scrolling on a touchpad or a bit both. > Anyway, I don't think that we should use this feature when the user's device > is obviously non-legacy pointing device, i.e., it supports diagonal scroll. > What do you think? But this is enabled on touchpads too, if the pref is set. Could we somehow enable it on mouse input only, and not touchpad? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Olli Pettay [:smaug] from comment #85) > (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #82) > > > That sounds like a minor problem that could be fixed in this bug or a > > > follow-up. > > > > I think that we should decide it in this bug. Smaug, how do you think? I > > believe that if we'd swap deltaX/deltaY for default action, DOM wheel event > > and legacy mouse scroll events should represent it. However, if we do so in > > default settings, there is an issue mentioned in #4 (below). > > Doesn't sound like a minor problem. > Since widgets on web pages tend to emulate native scrollable areas, they > should get events similar to > native viewport or other scrollable areas. > > #4 is tricky, but I think we should favor the more common case, so swap. > How does IE handle this? What does Chrome actually report in delta values? Looks like that IE/Edge doesn't have this feature since Shift+wheel causes navigating history like us. Chrome just swaps default action (i.e., not touching DOM event values). I wonder, wheel related events are cancelable, that means that it does NOT represent default action's behavior. So, perhaps, we can just take the Chrome's behavior? (Even if web apps check their implementation only with Chrome, it won't cause any problem only on Firefox.) That's not ideal behavior from a point of view of DOM events, but low risk approach in the real world. FYI: At bug 1358017 Comment 2, similar issue on vertical writing web pages, dbaron thinks that only changing default action is reasonable. How about you? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Shift+Scroll to scroll horizontally is still missing. This might seem like a small feature to have, but it actually has profound impact. First of all, I belive the majority of mice still only have a vertical scroll wheel. At our university, every mouse falls into that category. However, the major problem is providing a consistent interaction with horizontally scrolling containers across platforms/browsers. If one has to rely on a vertical scroll wheel, the approach would be listening for the `wheel` event and use `event.deltaY` for setting `scrollLeft` when `event.shiftKey === true`. Now this won’t lead to pleasent results right away since these deltas yield vastly different values across devices/browsers. Is it a trackpad? Does it fire the event very often? Is the delta very big or very small? Is the inertial scrolling behavior? In short, re-implementing scrolling behavior is very hard. Turning a scroll wheel once results in roughly the same scrolling distance when comparing Chrome and Firefox. However the events’ delta values are different. What does this have to do with this issue? Since there is no Shift+Scroll for horizontal scrolling, providing users with a way to do so also requires to re-implemented scrolling. Users need a way of interacting with horizontally overflowing elements by scrolling natively. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=554cd7fe7479c2cad7a3e246280eaf611a8c59f1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
At least, there is an add-on that this now: https://addons.mozilla.org /en-US/firefox/addon/shift-scroll/ Works great for me! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
14 years and such a basic feature still isn't working out-of-the box. I don't even have words for this anymore. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Why not merge code from this add-on (https://addons.mozilla.org/en-US/firefox/addon/shift-scroll/) be merged into upstream Firefox? Should be easy to fix such a long standing bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to xyzdragon from comment #88) > 14 years and such a basic feature still isn't working out-of-the box. > I don't even have words for this anymore. Agree 110% !!! Meanwhile they keep on releasing increasingly bug-ridden and bloated new releases. The latest version of Firefox on Mac just has browser tabs that keep on crashing for no reason. Good riddance Mozilla, I should have trashed it a long time ago. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
I know it's not qt, but qt has this notion of QWheelEvent::DefaultDeltasPerStep – maybe gtk has that too? Anyway, I recently implemented a fix for a problem in the linux KDE application gwenview, where, when you used CTRL+Touchpad_scroll to zoom in/out, it was horribly sensitive (see here for bug/patch https://bugs.kde.org/show_bug.cgi?id=378584#c7). For the fix we would always accumulate deltas upon triggered events and only perform the action once the accumulated delta is greater than or equal to QWheelEvent::DefaultDeltasPerStep (at the same time resetting the accumulated delta to 0). Using the scroll wheel, the emitted delta is exactly QWheelEvent::DefaultDeltasPerStep, such that the action is performed at each turn of the wheel. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
Upstream bug showing "RESOLVED FIXED" Tested ok Ubuntu 18.04 and Firefox 61 ** Changed in: firefox (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Changed in: firefox Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Changed in: firefox Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Changed in: firefox Status: In Progress => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Thanks a lot for the encouragements! (especially Anand) I'm very sorry to disappoint, but I don't have time to realistically fight this battle at the moment. If anyone feels like taking this bug, please do. You can even steal ownership of my patch and do comment 81. Open needinfo for smaug's questions in comment 85. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #82) > > That sounds like a minor problem that could be fixed in this bug or a > > follow-up. > > I think that we should decide it in this bug. Smaug, how do you think? I > believe that if we'd swap deltaX/deltaY for default action, DOM wheel event > and legacy mouse scroll events should represent it. However, if we do so in > default settings, there is an issue mentioned in #4 (below). Doesn't sound like a minor problem. Since widgets on web pages tend to emulate native scrollable areas, they should get events similar to native viewport or other scrollable areas. #4 is tricky, but I think we should favor the more common case, so swap. How does IE handle this? What does Chrome actually report in delta values? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: firefox (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
I have never owned a mouse with a horizontal scroll wheel, only ones with a tiltable a scroll wheel. It's horrible having to use those for scrolling horizontally as you have to press them several times rather than rotate a wheel. It feels much more natural to use the up/down wheel with a modifier key pressed. Furthermore, this is standard behavior in quite a number of applications; to the ones already mentioned (Chrome, gimp, evince) I'd like to add Inkscape, Scribus, LibreOffice. For other applications like konqueror, okular, gwenview, qtcreator it's Alt+Scroll Wheel, but still it's possible. I frequently find myself longing for that feature because I (have to) use large zoom levels and having to grab the scroll bar or scroll with Left/Right keys is much less comfortable. So I would be really happy if someone could provide a simple working solution! (o: -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
> How many people still want this feature? In these days, most pointing devices support horizontal scroll with tilt wheel or swipe gesture. Well, since you asked, here's the history of my horizontal scrolling capability. First, my desktop still has a 1-dimensional wheel. After all, mice aren't the kind of gadget that have compelling reasons for people to upgrade them every six months. On the other hand, my laptop is my primary computer, and I've recently upgraded to one with two-finger scrolling (in 2D). In fact, I've even written a Firefox extension (Scrolling Gestures) to take advantage of the horizontal scrolling capability. As a result, I've been untrained from using shift+scrolling and this feature isn't as important to me as it was a year ago (when each of my computers had only 1D scrolling). > scrollable element implemented with JS is scroll normally with this patch Do you mean, it will appear to JavaScript like Shift+Up and down? Bear in mind that there are two separate events for capturing wheel events; one ignores the axis and the other does not. There is at least one webapp (pressdisplay.com) that requires shift+vertical scrolling because of this. Here's a JSfiddle that demonstrates this: http://jsfiddle.net/SXAUx/7/ . Also, for the axis-capable event, shift- scrolling in Chrome reports only horizontal wheel events (even for shift+horizontal). > And I'd like to know if other browsers have this feature? Chrome has this feature. It also works in some other software, at least on Linux, like Evince (the GNOME PDF viewer). I still think this feature is useful, even if I don't need it myself. However, I don't maintain Mozilla's scrolling code, so (speaking only for myself) if it's really too problematic to implement, I'm willing to concede. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
> Additionally, I think that most web developers don't design such pages which > needs to be scrolled > horizontally. Actually, I don't use horizontal scroll in most web pages... Actually if you like to split your screen and use your browser only on one half of it, you're going to realize that most web pages are too large and therefore broken. > And I'd like to know if other browsers have this feature? It's expected standard behaviour in software handling 2D surfaces (e.g. a web page). In my experience, Shift+Scroll scrolls horizontally in Chrome, Gimp, Evince, Photoshop, MSPaint. Some programs use other modifier keys to scroll horizontally, hence the idea to make it configurable in prefs. > 1. Many people still want this in these days? I would guess so. Many people still use 1D scrolling (either with mouse or basic touchpad) and Shift+Scroll is a good standard way to scroll horizontally, even better than tilt wheels or trackpads in my opinion because you get the speed and control of a scrollwheel/touchpad. > 2. If it's not enabled in default settings, how many people would use (realize) this feature? Giving frustrated users no option to enable this is bad. Currently, searching for how to enable this feature in firefox gives a lot of "not possible, use chrome", a few strange addons, and eventually this bug (or one of the 9 other duplicates). > 3. If it doesn't swap DOM wheel event's delta values, users won't scroll > custom scrollable elements > implemented with JS horizontally. That sounds like a minor problem that could be fixed in this bug or a follow-up. > 4. If it's enabled in default settings, web applications NEVER receive raw > delta values with Shift key > or other modifier. It's very bad thing for web application developers. E.g., > game developers. I think you're wrong here, because web applications already do not receive raw delta values / modifier in case of Shift+Scroll: In default Firefox, they see the user back up in his history, and as nandhp said in default Chrome they see a horizontal scroll event. > 5. Swapping delta value may be broken easy at maintaining > nsEventStateManager. For preventing it, we > need a lot of automated tests as far as possible. I'm willing to address your nits to my patch and add reasonable test coverage for it. > Oops, you're not janx. But I still wonder why we need to implement a complex > feature which is not > enabled in default settings. It doesn't look that complex. Changing the default behavior would probably surprise users who are used to navigating their history with Shift+Scroll. But hscroll is a feature that makes sense and needs to be configurable in firefox. > Oh, Shift + Wheel is now navigating history on non-Mac platforms... I find this default behaviour extremely annoying, because coming from Chrome I have the Shift+Scroll reflex, and every time I want to hscroll I find myself back on my homepage! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
And I'd like to know if other browsers have this feature? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key I believe that you want to swap the scroll direction completely. However, your patch just swap the scroll direction of default action of wheel event. E.g., scrollable element implemented with JS is scroll normally with this patch. You need to swap the delta values before handling all of them. I.e., You need to swap them in PreHandleEvent() (after applying delta_multiplier prefs?). And also you need to swap lineOrPageDeltaX and lineOrPageDeltay at same time. Finally, you might need to swap overflowDeltaX and overflowDeltay at the end of PostHandleEvent(). Additionally, you have to test new behavior with automated tests: * Add new function to test if deltaX/deltaY are swapped in DOM event level. http://mxr.mozilla.org/mozilla-central/source/dom/events/test/test_dom_wheel_event.html?force=1 * doTestScroll() should be run again with swapped pref. And also you need to test overflowX/Y are swapped correctly. http://mxr.mozilla.org/mozilla-central/source/dom/events/test/window_wheel_default_action.html?force=1 * Please test it with native scroll event (this is now only available on Windows) http://mxr.mozilla.org/mozilla-central/source/widget/tests/window_mouse_scroll_win.html?force=1 However, I don't think that this is good patch because this may make the code difficult to maintain. Therefore, basically, I don't agree with adding this feature suggested by this bug. How many people still want this feature? In these days, most pointing devices support horizontal scroll with tilt wheel or swipe gesture. Why this isn't enabled in default settings? These fact means that this makes the code complicated only for a few users. I'm not sure if this is worthwhile to fix this bug. I want to suggest this bug marked as WONTFIX. Could you explain why do we need to fix this bug even with such cost and appending risk? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Jan Keromnes [:janx] from comment #80) > > 2. If it's not enabled in default settings, how many people would use > > (realize) this feature? > > Giving frustrated users no option to enable this is bad. Currently, > searching for how to enable this feature in firefox gives a lot of "not > possible, use chrome", a few strange addons, and eventually this bug (or one > of the 9 other duplicates). Hmm, even if so, I still think that the new feature should be enabled in default settings (Alt + Wheel?). > > 3. If it doesn't swap DOM wheel event's delta values, users won't scroll > > custom scrollable elements > > implemented with JS horizontally. > > That sounds like a minor problem that could be fixed in this bug or a > follow-up. I think that we should decide it in this bug. Smaug, how do you think? I believe that if we'd swap deltaX/deltaY for default action, DOM wheel event and legacy mouse scroll events should represent it. However, if we do so in default settings, there is an issue mentioned in #4 (below). > > 4. If it's enabled in default settings, web applications NEVER receive raw > > delta values with Shift key > > or other modifier. It's very bad thing for web application developers. > > E.g., game developers. > > I think you're wrong here, because web applications already do not receive > raw delta values / modifier in case of Shift+Scroll: In default Firefox, > they see the user back up in his history, No, web pages/applications can cancel it with a call of preventDefault(). > and as nandhp said in default > Chrome they see a horizontal scroll event. I feel it's bad behavior... > > Oops, you're not janx. But I still wonder why we need to implement a > > complex feature which is not > > enabled in default settings. > > It doesn't look that complex. Changing the default behavior would probably > surprise users who are used to navigating their history with Shift+Scroll. Indeed. It depends on that we should give priority to compatibility with Chrome or our traditional behavior. We should ask somebody who works on UX of Firefox for default setting change. I don't know who is good person for it, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to nandhp from comment #75) > First, my desktop still has a 1-dimensional wheel. After all, mice aren't > the kind of gadget that have compelling reasons for people to upgrade them > every six months. Well, but horizontal scroll is supported on Vista or later with native message. So, all major platforms now support it in native level. I.e., the problem occurs only on WinXP or with mice or touchpads which don't support horizontal scroll. On such environment, the users really want a way of horizontal scroll by their device's vertical scroll operation? I'm not sure the strong reason why we need to implement this. Additionally, I think that most web developers don't design such pages which needs to be scrolled horizontally. Actually, I don't use horizontal scroll in most web pages... > > scrollable element implemented with JS is scroll normally with this patch > > Do you mean, it will appear to JavaScript like Shift+Up and down? I meant that some web pages have their own scrollbar for sub frames which handle DOM wheel events. I believe that users want to scroll them horizontally with the new setting. However, if it's enabled in default settings of Shift or something, web pages never handle raw deltaX/Y values with the modifier state. Of course, it's bad thing, though... > Bear in > mind that there are two separate events for capturing wheel events; one > ignores the axis and the other does not. There is at least one webapp > (pressdisplay.com) that requires shift+vertical scrolling because of this. > Here's a JSfiddle that demonstrates this: http://jsfiddle.net/SXAUx/7/ . > Also, for the axis-capable event, shift-scrolling in Chrome reports only > horizontal wheel events (even for shift+horizontal). On Mac, we support diagonal wheel event (i.e., both deltaX and deltaY may be not 0 of a wheel event). So, discarding native event's deltaY information does not make sense. So, just swapping deltaX and deltaY does make sense to me. > > And I'd like to know if other browsers have this feature? > > Chrome has this feature. It also works in some other software, at least on > Linux, like Evince (the GNOME PDF viewer). > > I still think this feature is useful, even if I don't need it myself. If so, why don't you change the default settings? I don't think it isn't worthwhile to implement such complicated behavior only for hidden feature. > However, I don't maintain Mozilla's scrolling code, so (speaking only for > myself) if it's really too problematic to implement, I'm willing to concede. I think that swapping delta values may be broken easy by any changes around wheel handling code in nsEventStateManager. If we take your patch, we have to have a lot of tests for preventing regression bugs in the future. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Jan Keromnes [:janx] from comment #80) > > Additionally, I think that most web developers don't design such pages > > which needs to be scrolled > > horizontally. Actually, I don't use horizontal scroll in most web pages... > > Actually if you like to split your screen and use your browser only on one > half of it, you're going to realize that most web pages are too large and > therefore broken. > > > And I'd like to know if other browsers have this feature? > > It's expected standard behaviour in software handling 2D surfaces (e.g. a > web page). In my experience, Shift+Scroll scrolls horizontally in Chrome, > Gimp, Evince, Photoshop, MSPaint. Some programs use other modifier keys to > scroll horizontally, hence the idea to make it configurable in prefs. > > > 1. Many people still want this in these days? > > I would guess so. Many people still use 1D scrolling (either with mouse or > basic touchpad) and Shift+Scroll is a good standard way to scroll > horizontally, even better than tilt wheels or trackpads in my opinion > because you get the speed and control of a scrollwheel/touchpad. > > > 2. If it's not enabled in default settings, how many people would use > > (realize) this feature? > > Giving frustrated users no option to enable this is bad. Currently, > searching for how to enable this feature in firefox gives a lot of "not > possible, use chrome", a few strange addons, and eventually this bug (or one > of the 9 other duplicates). > > > 3. If it doesn't swap DOM wheel event's delta values, users won't scroll > > custom scrollable elements > > implemented with JS horizontally. > > That sounds like a minor problem that could be fixed in this bug or a > follow-up. > > > 4. If it's enabled in default settings, web applications NEVER receive raw > > delta values with Shift key > > or other modifier. It's very bad thing for web application developers. > > E.g., game developers. > > I think you're wrong here, because web applications already do not receive > raw delta values / modifier in case of Shift+Scroll: In default Firefox, > they see the user back up in his history, and as nandhp said in default > Chrome they see a horizontal scroll event. > > > 5. Swapping delta value may be broken easy at maintaining > > nsEventStateManager. For preventing it, we > > need a lot of automated tests as far as possible. > > I'm willing to address your nits to my patch and add reasonable test > coverage for it. > > > Oops, you're not janx. But I still wonder why we need to implement a > > complex feature which is not > > enabled in default settings. > > It doesn't look that complex. Changing the default behavior would probably > surprise users who are used to navigating their history with Shift+Scroll. > But hscroll is a feature that makes sense and needs to be configurable in > firefox. > > > Oh, Shift + Wheel is now navigating history on non-Mac platforms... > > I find this default behaviour extremely annoying, because coming from Chrome > I have the Shift+Scroll reflex, and every time I want to hscroll I find > myself back on my homepage! Just wanna say that EVERYTHING @Jan Keromnes has answered is EXACTLY what I'm feeling. I've been a loyal Firefox user since around 2001. I live the net through it. In the very least, being able to *enable* this behaviour - if only through "about:config" - is very, very important to power users. PS: It's not a good idea to assume that users will have mice with horizontal scroll, nor is it guaranteed that if they have horz-scroll on the mouse, that they'll actually use it that way. I have a Logitech G700 and I've mapped copy/paste to my left/right horz-scroll cause that's what I use practically once every two minutes while working. Thanks for your efforts @everyone! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Sorting out my concern: 1. Many people still want this in these days? 2. If it's not enabled in default settings, how many people would use (realize) this feature? 3. If it doesn't swap DOM wheel event's delta values, users won't scroll custom scrollable elements implemented with JS horizontally. 4. If it's enabled in default settings, web applications NEVER receive raw delta values with Shift key or other modifier. It's very bad thing for web application developers. E.g., game developers. 5. Swapping delta value may be broken easy at maintaining nsEventStateManager. For preventing it, we need a lot of automated tests as far as possible. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #76) > (In reply to nandhp from comment #75) > > I still think this feature is useful, even if I don't need it myself. > > If so, why don't you change the default settings? Oops, you're not janx. But I still wonder why we need to implement a complex feature which is not enabled in default settings. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
I forgot to say thank you for the very helpful and detailed review, Masayuki. I'll follow your suggestions, add tests, and ask for another review when I'm done. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Oh, Shift + Wheel is now navigating history on non-Mac platforms... http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#604 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Changed in: firefox Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
You're very welcome Anand :) I couldn't bear this anymore. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
@Jan Keromnes: Thank you very much for picking up this issue! It's a constant pain point for me!!! :o) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Thanks André! I'll ask Masayuki to review as well. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key Review of attachment 8369358: - Currently, mousewheel pref actions can be set to 0:do nothing, 1:normal scroll, 2:navigate history and 3:zoom. This patch adds option 4 to mousewheel pref actions in order to swap X and Y scroll deltas. Example: Change "mousewheel.with_shift.action" to 4 so that Shift+Scroll scrolls horizontally. André, can you take a look please? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Created attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key (sorry for double posting, no need for two reviews) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key Review of attachment 8369358: - Currently, mousewheel pref actions can be set to 0:do nothing, 1:normal scroll, 2:navigate history and 3:zoom. This patch adds option 4 to mousewheel pref actions in order to swap X and Y scroll deltas. Example: Change "mousewheel.with_shift.action" to 4 so that Shift+Scroll scrolls horizontally. André, can you take a look please? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Comment on attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key Review of attachment 8369358: - It looks good to me. You may want to also ask Masayuki Nakano, he's got more experience than myself on those things. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
oops -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
*** Bug 953136 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250]
Hi! I'm also a Firefox loyalist and have been searching desperately for this functionality. I've seen all sorts of options that *sort of* indicate that it *might* be available but nothing works. Some webpages I've viewed: - https://wiki.mozilla.org/Gecko:Mouse_Wheel_Scrolling#Preferences_for_customizing_delta_values_and_default_action - http://forums.mozillazine.org/viewtopic.php?f=23&t=2072387 - https://wiki.mozilla.org/Gecko:Mouse_Wheel_Scrolling - http://forums.mozillazine.org/viewtopic.php?f=38&p=12546047 These pages are related to this feature request but none of them provide an actual solution. User @Skewer's original comment near the top of this issue says: > Note that the traditional defaults are: > Mouse wheel: Scroll vertically > Ctrl+wheel: Zoom > Shift+wheel: Pan (scroll horizontally) The shift+wheel action (Pan / scroll horizontally) is *exactly* what I'm looking for. Please help! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
If the grease-monkey firefox addon installed, I found this user-script as a work around: http://userscripts.org/scripts/show/168193 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
Launchpad has imported 62 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=143038. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2002-05-08T15:59:25+00:00 Hunters wrote: >From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0rc1) Gecko/20020417 BuildID:2002041711 Under Preferences->Advanced->Mouse Wheel, I'd like to see an option for mouse wheel + modifier key to scroll the current page horizontally instead of vertically (when such scrolling is possible). Reproducible: Always Steps to Reproduce: Not currently a feature. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/0 On 2002-05-08T16:22:33+00:00 Bugzilla-tf wrote: see also bug 58589 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/1 On 2002-05-08T17:14:45+00:00 Jag-mozilla wrote: -> bryner Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/2 On 2002-06-23T16:18:14+00:00 Skewermz wrote: Note that the traditional defaults are: Mouse wheel: Scroll vertically Ctrl+wheel: Zoom Shift+wheel: Pan (scroll horizontally) Most of the programs that don't follow this tradition either pan when the mouse is hovering over the horizontal scrollbar (bug 71464) or shamefully don't pan at all. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/3 On 2002-09-26T22:50:26+00:00 Bugzilla-tf wrote: *** Bug 171049 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/4 On 2003-03-09T07:10:58+00:00 Danielwang wrote: *** Bug 196516 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/5 On 2003-07-24T09:10:19+00:00 Llwang wrote: I think that the OS should be All instead of just Windows 2000. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/6 On 2003-07-24T11:19:55+00:00 Vdvo wrote: Indeed. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/7 On 2004-01-29T09:20:33+00:00 Hachiro75 wrote: Created attachment 140146 patch (only tested with gtk) Hi. This patch adds two options `scroll the document by [N] chars.' and `scroll a page left or a page right.' to mousewheel's pref-panel. Tha range of integer value of mousewheel.with*key.action is extended to 5. 4=scroll horizontally. 5=scroll page horizontally. The result makes mousewheel's pref-panel more verbose but may help single wheel mouse users. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/8 On 2004-01-29T13:30:37+00:00 Hunters wrote: Great! Any chance for a binary patch for Win32? :) Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/comments/9 On 2004-01-31T10:27:07+00:00 Hachiro75 wrote: Created attachment 140298 XUL (workaround) (In reply to comment #9) > Great! Any chance for a binary patch for Win32? :) Thanks. Though the best way is building Mozilla with patch, here is yet another implementation by XUL. This also implements Bug 71464 imperfectly. This will be XPInstalled as add-on by simply opening it in Mozilla. Only works with window, frame and message-pane in Mozilla but none of other widgets like texbox although original patch works with almost every scrollable widget. If you want to change modifier key, amount of scroll or direction, edit mozilla's chrome/whscroll/content/whscrollOverlay.xul manualy. The value of mousewheel.with[your modifier]key.action must be 0 or 1 when using as horizontal scroll trigger. Uninstallation is done manualy delete the directory named `whscroll' and remove descriptions about whscroll in chrome.rdf and those lines in some overlayinfo/*/content/*.rdf files in Mozilla's chrome directory. Reply at: http
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
** Bug watch added: Mozilla Bugzilla #143038 https://bugzilla.mozilla.org/show_bug.cgi?id=143038 ** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=143038 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] [NEW] [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
Public bug reported: In Chromium, I can scroll horizontally using my mouse-wheel by holding down the shift key while scrolling the mouse wheel. Firefox is missing this very convenient page-navigation short-cut. Use Case: As my eyes age, I find myself always scaling up the web pages I read (by holding down crtl and scrolling my mouse wheel). Doing this, often makes the page exceed the width of my monitor (hiding the right-side of the text I want to read) and produces a horizontal scroll bar at the bottom of the page. At this point, since I've already used ctrl-scroll-mouse-wheel to magnify the page, it would be wonderful if I could use shift-scroll- mouse-wheel to horizontally-scroll the magnified page and therefore center the (previously cropped) text that I am wanting to read. ProblemType: Bug DistroRelease: Ubuntu 13.04 Package: firefox 24.0+build1-0ubuntu0.13.04.1 ProcVersionSignature: Ubuntu 3.8.0-30.44-generic 3.8.13.6 Uname: Linux 3.8.0-30-generic x86_64 NonfreeKernelModules: wl AddonCompatCheckDisabled: False ApportVersion: 2.9.2-0ubuntu8.3 Architecture: amd64 AudioDevicesInUse: USERPID ACCESS COMMAND /dev/snd/controlC0: lonnie 2161 F pulseaudio /dev/snd/pcmC0D0p: lonnie 2161 F...m pulseaudio BrokenPermissions: sessionstore.bak (0o600, wrong owner) BuildID: 20130911155223 Channel: Unavailable Date: Fri Sep 20 11:02:07 2013 ForcedLayersAccel: False IfupdownConfig: # interfaces(5) file used by ifup(8) and ifdown(8) auto lo iface lo inet loopback InstallationDate: Installed on 2013-09-06 (14 days ago) InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Release amd64 (20130424) IpRoute: default via 192.168.24.1 dev eth0 proto static 192.168.24.0/24 dev eth0 proto kernel scope link src 192.168.24.198 metric 1 MarkForUpload: True PrefSources: prefs.js [Profile]/extensions/{b9db16a4-6edc-47ec-a1f4-b86292ed211d}/defaults/preferences/prefs-dwhelper.js ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR= LANG=en_US.UTF-8 SHELL=/bin/bash Profiles: Profile0 (Default) - LastVersion=24.0/20130911155223 (In use) RelatedPackageVersions: google-talkplugin 4.5.3.0-1 icedtea-7-plugin 1.3.2-1ubuntu1.1 totem-mozilla 3.6.3-0ubuntu6 rhythmbox-mozilla 2.98-0ubuntu5 RunningIncompatibleAddons: False SourcePackage: firefox UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 04/14/2011 dmi.bios.vendor: Dell Inc. dmi.bios.version: A09 dmi.board.name: 0P792H dmi.board.vendor: Dell Inc. dmi.board.version: A09 dmi.chassis.type: 8 dmi.chassis.vendor: Dell Inc. dmi.chassis.version: A09 dmi.modalias: dmi:bvnDellInc.:bvrA09:bd04/14/2011:svnDellInc.:pnStudio1737:pvrA09:rvnDellInc.:rn0P792H:rvrA09:cvnDellInc.:ct8:cvrA09: dmi.product.name: Studio 1737 dmi.product.version: A09 dmi.sys.vendor: Dell Inc. ** Affects: firefox (Ubuntu) Importance: Undecided Status: New ** Tags: amd64 apport-bug raring -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1228250] Re: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally
Also, most mouse-scroll-wheels (these days) have the ability for you to click your mouse-wheel. If you press down on your scroll wheel, while scrolling, this too should allow you to scroll horizontally in Firefox. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1228250/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs