[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Changed in: freeipmi (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
This bug was fixed in the package freeipmi - 1.1.5-3ubuntu3.1 --- freeipmi (1.1.5-3ubuntu3.1) trusty; urgency=medium [ dann frazier ] * debian/patches/Retry-ssif-reads-as-needed.patch: Retry SSIF reads as needed, LP: #1324992 -- Robie BasakThu, 17 Jul 2014 02:14:05 + ** Changed in: freeipmi (Ubuntu Trusty) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
Node 1 works without any changes required to K60. root@Slaytonc41n1:~# bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id Device ID : 20 Device Revision : 0 Device SDRs : supported Firmware Revision : 1.30 Device Available : yes (normal operation) IPMI Version : 2.0 Sensor Device : supported SDR Repository Device : unsupported SEL Device: supported FRU Inventory Device : supported IPMB Event Receiver : unsupported IPMB Event Generator : supported Bridge: unsupported Chassis Device: supported Manufacturer ID : Hewlett-Packard (11) Product ID: 8449 root@Slaytonc41n1:~# The other nodes work only if I do the changes to K60. Shashi do you know which firmware has the changes? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
With the latest firmware all the nodes should work. I think he did not download the correct freeimpi version. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
pradeep which node? It needs node 2, 3, and 4 need some extra step as per shashi. Can you try it node 1 if it is not node one. Otherwise you need to get the steps from shashi to enabled i2c on those nodes. Thanks and Regards, Narinder Gupta (PMP) narinder.gu...@canonical.com Canonical, Ltd.narindergupta [irc.freenode.net] +1.281.736.5150narindergupta2007[skype] Ubuntu- Linux for human beings | www.ubuntu.com | www.canonical.com On Tue, Aug 5, 2014 at 10:16 PM, Kodamati Pradeep Vinesh Reddy < pradeep.red...@hp.com> wrote: > I am seeing the error like mentioned by manoj above comment #4 > > root@ubuntu:~# bmc-info --no-probing --driver-type=SSIF > --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id --debug > = > Get Device ID Request > = > SSIF Header: > > [ 0h] = lun[ 2b] > [ 6h] = net_fn[ 6b] > IPMI Command Data: > -- > [ 1h] = cmd[ 8b] > ipmi_cmd_get_device_id: internal system error > root@ubuntu:~# > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1324992 > > Title: > freeipmi patch for HP moonshot ARM cartridges with I2c > > Status in “freeipmi” package in Ubuntu: > Fix Released > Status in “freeipmi” source package in Trusty: > Fix Committed > Status in “freeipmi” package in Debian: > New > > Bug description: > [Impact] > freeipmi is unable to reliable communicate with the BMC on ARM HP > Moonshot cartridges > [Test Case] > > [Regression Potential] > Should be minimal, given the new code only runs in a case that would've > previous resulted in a failure. > > To manage notifications about this bug go to: > > https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions > -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
I am seeing the error like mentioned by manoj above comment #4 root@ubuntu:~# bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id --debug = Get Device ID Request = SSIF Header: [ 0h] = lun[ 2b] [ 6h] = net_fn[ 6b] IPMI Command Data: -- [ 1h] = cmd[ 8b] ipmi_cmd_get_device_id: internal system error root@ubuntu:~# -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
I loaded the driver manually, now I see the devices but the command fails with "internal system error. See below root@ubuntu:~# ls /dev/i2c-* /dev/i2c-0 /dev/i2c-1 /dev/i2c-2 root@ubuntu:~# bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id ipmi_cmd_get_device_id: internal system error -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
RE: [Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
You need to manual load the i2c-dev driver Narinder Gupta Kodamati Pradeep Vinesh Reddy wrote: null -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
After installing the freeipmi from the proposed repositories, I see the below error ubuntu@ubuntu:~$ sudo bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id [sudo] password for ubuntu: insufficient permission on driver device '/dev/i2c-2' When I looked into the /dev/ I dont see i2c-2 device. ubuntu@ubuntu:~$ dpkg --list | grep freeipmi ii freeipmi1.1.5-3ubuntu3.1 all GNU implementation of the IPMI protocol ii freeipmi-bmc-watchdog 1.1.5-3ubuntu3.1 armhf GNU implementation of the IPMI protocol - BMC watchdog ii freeipmi-common 1.1.5-3ubuntu3.1 all GNU implementation of the IPMI protocol - common files ii freeipmi-ipmidetect 1.1.5-3ubuntu3.1 armhf GNU IPMI - IPMI node detection tool ii freeipmi-tools 1.1.5-3ubuntu3.1 armhf GNU implementation of the IPMI protocol - tools ii libfreeipmi12 1.1.5-3ubuntu3.1 armhf GNU IPMI - libraries ubuntu@ubuntu:~$ Please let me know if I am missing something. Thanks, Pradeep. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Branch linked: lp:ubuntu/trusty-proposed/freeipmi -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
Hello Narinder, or anyone else affected, Accepted freeipmi into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/freeipmi/1.1.5-3ubuntu3.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: freeipmi (Ubuntu Trusty) Status: Triaged => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
Uploaded to Trusty. Now awaiting SRU team approval. ** Changed in: freeipmi (Ubuntu Trusty) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
This bug was fixed in the package freeipmi - 1.1.5-3ubuntu4 --- freeipmi (1.1.5-3ubuntu4) utopic; urgency=medium * debian/patches/Retry-ssif-reads-as-needed.patch: Retry SSIF reads as needed, LP: #1324992 -- dann frazierFri, 30 May 2014 15:53:06 -0600 ** Changed in: freeipmi (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Branch linked: lp:~ubuntu-branches/ubuntu/utopic/freeipmi/utopic- proposed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
dann's work is perfect, as usual - thank you! I see that the current release (1.4.4) that is not yet packaged contains this patch, so cherry- picking should be no issue. Uploaded to Utopic. ** Changed in: freeipmi (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Changed in: freeipmi (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Bug watch added: Debian Bug tracker #754807 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754807 ** Also affects: freeipmi (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754807 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Changed in: freeipmi (Ubuntu) Status: New => Confirmed ** Changed in: freeipmi (Ubuntu Trusty) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
OK, turns out it was a firmware setting that Manoj was missing in the previous comment. On a system with the correct setting, this is what freeipmi shows w/o my branch: root@ubuntu:/home/ubuntu# bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id ipmi_cmd_get_device_id: internal system error And this is with my branch: root@ubuntu:/home/ubuntu# bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 Device ID : 20 Device Revision : 0 Device SDRs : supported Firmware Revision : 1.30 Device Available : yes (normal operation) IPMI Version : 2.0 Sensor Device : supported SDR Repository Device : unsupported SEL Device: supported FRU Inventory Device : supported IPMB Event Receiver : unsupported IPMB Event Generator : supported Bridge: unsupported Chassis Device: supported Manufacturer ID : Hewlett-Packard (11) Product ID: 8449 System Firmware Version : System Name : ProLiant m800 Server Cartridge Primary Operating System Name : Operating System Name : Channel Information Channel Number : 0 Medium Type : IPMB (I2C) Protocol Type: IPMB-1.0 Active Session Count : 0 Session Support : session-less Vendor ID: Intelligent Platform Management Interface forum (7154) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
Installed the package that dannf provided and ran the exact same command that works for Shashi with his version of freeipmi+patches: ubuntu@c3n3:~$ sudo bmc-info --no-probing --driver-type=SSIF --driver-address=0x10 --driver-device=/dev/i2c-2 --get-device-id --debug = Get Device ID Request = SSIF Header: [ 0h] = lun[ 2b] [ 6h] = net_fn[ 6b] IPMI Command Data: -- [ 1h] = cmd[ 8b] ipmi_cmd_get_device_id: internal system error ubuntu@c3n3:~$ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Also affects: freeipmi (Ubuntu Trusty) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Description changed:
- As per HP for moonshot arm cartridges freeipmi changes are needed. So
- this request is to pull the patch from upstream into current version of
- trusty to support the i2c communication on HP moonshot chassis.
+ [Impact]
+ freeipmi is unable to reliable communicate with the BMC on ARM HP Moonshot
cartridges
+ [Test Case]
- Here are the details.
-
- svn://svn.savannah.gnu.org/freeipmi/trunk
-
- Revision: 10072
- Author: chu11
- Date: Friday, May 30, 2014 10:21:03 AM
- Message:
- Retry ssif reads as needed
-
- Modified : /trunk/ChangeLog
- Modified : /trunk/libfreeipmi/api/ipmi-ssif-driver-api.c
- Modified : /trunk/libfreeipmi/api/ipmi-ssif-driver-api.h
-
- I have attached the ChangeLog and patch file for your reference.
-
- -Original Message-
- From: Al Chu [mailto:ch...@llnl.gov]
- Sent: Friday, May 30, 2014 10:26 AM
- To: Dande, Shashi
- Cc: freeipmi-de...@gnu.org
- Subject: RE: FreeIPMI Patch Submission
-
- Great. It'll be in the next release of FreeIPMI (1.4.4)
-
- Al
-
- On Thu, 2014-05-29 at 23:32 +, Dande, Shashi wrote:
- > Hi Al
- >
- > Here is the updated patch per our conversation today.
- >
- > Thanks
- > Shashi
- >
- > Index: ipmi-ssif-driver-api.c
- > ===
- > --- ipmi-ssif-driver-api.c(revision 10066)
- > +++ ipmi-ssif-driver-api.c(working copy)
- > @@ -319,7 +319,9 @@
- >uint8_t cmd = 0; /* used for debugging */
- >uint8_t group_extension = 0; /* used for debugging */
- >uint64_t val;
- > -
- > + struct timespec request, remain;
- > + uint8_t retry = IPMI_SSIF_RETRY_DEFAULT;
- > +
- >assert (ctx
- > && ctx->magic == IPMI_CTX_MAGIC
- > && ctx->type == IPMI_DEVICE_SSIF
- > @@ -350,9 +352,39 @@
- >if (_ssif_cmd_write (ctx, cmd, group_extension, obj_cmd_rq) < 0)
- > return (-1);
- >
- > +
/**
- > +12.9 SMBus NACKs and Error Recovery:
- > +
- > +The BMC can NACK the SMBus host controller if it is not ready to
accept a new
- > +transaction. Typically, this will be exhibited by the BMC NACK'ing its
slave
- > +address.
- > +
- > +If the BMC NACKs a single part transaction, software can simply retry
it.
- > +If a 'middle' or 'end' transaction is NACK'd, software should not
retry the
- > +particular but should restart the multi-part read or write from the
beginning
- > +Start transaction for the transfer.
- > +
- > +
- > + ***/
- >if (_ssif_cmd_read (ctx, cmd, group_extension, obj_cmd_rs) < 0)
- > -return (-1);
- > +{
- > + while (1)
- > +{
- > + request.tv_sec = 0;
- > + request.tv_nsec = IPMI_SSIF_TIMEOUT_DEFAULT;
- > + if (nanosleep (&request, &remain) < 0 )
- > +return (-1);
- >
- > + if (_ssif_cmd_read (ctx, cmd, group_extension, obj_cmd_rs) < 0)
- > +{
- > + if (retry == 0)
- > +return (-1);
- > +
- > + retry--;
- > +}
- > +else
- > + break;
- > +}
- > +}
- > +
- >return (0);
- > }
- >
- > Index: ipmi-ssif-driver-api.h
- > ===
- > --- ipmi-ssif-driver-api.h(revision 10066)
- > +++ ipmi-ssif-driver-api.h(working copy)
- > @@ -23,6 +23,9 @@
- > #include
- > #include
- >
- > +#define IPMI_SSIF_RETRY_DEFAULT 5
- > +#define IPMI_SSIF_TIMEOUT_DEFAULT 2000 /* 20 ms */
- > +
- > int api_ssif_cmd (ipmi_ctx_t ctx,
- > fiid_obj_t obj_cmd_rq,
- > fiid_obj_t obj_cmd_rs);
+ [Regression Potential]
+ Should be minimal, given the new code only runs in a case that would've
previous resulted in a failure.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1324992
Title:
freeipmi patch for HP moonshot ARM cartridges with I2c
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
I've prepared a potential fix for this issue in ppa:ce-hyperscale/ce- hyperscale-scratch. Please verify and confirm that this backport contains the required functionality. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Branch linked: lp:~dannf/ubuntu/utopic/freeipmi/lp1324992 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
The attachment "this is the patch accepted upstream" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu- reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1324992] Re: freeipmi patch for HP moonshot ARM cartridges with I2c
** Patch added: "this is the patch accepted upstream" https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+attachment/4123021/+files/ipmi-ssif.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1324992 Title: freeipmi patch for HP moonshot ARM cartridges with I2c To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freeipmi/+bug/1324992/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
