[Bug 1330173] Re: bash-completion of Makefile: invalid option name

[Mathew Hodson]

** Changed in: bash-completion (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1330173

Title:
  bash-completion of Makefile: invalid option name

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1330173/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1330173] Re: bash-completion of Makefile: invalid option name

[Peter Cordes]

Good catch, but the right fix is to use command grep, like most of the uses of 
grep in bash-completion do.  --color=never isn't portable to systems where grep 
isn't GNU grep.  So yes, this is a bug, and bash-completion is supposed to not 
break even if you have 
alias grep='cat /dev/random'

 But yes, --color=auto usually works better.  If you ever make one-
liners on the cmdline, you're shooting yourself in the foot unless you
like remembering to type command grep, or \grep.  Like  less $(ls
foo/bar | grep something).

 On the other hand, less -R can handle color escape codes these days,
and even matches searches in coloured text.  Hmm, that's pretty nice
actually.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1330173

Title:
  bash-completion of Makefile: invalid option name

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1330173/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1330173] Re: bash-completion of Makefile: invalid option name

[Peter Cordes]

This is already fixed upstream in git head.


** Changed in: bash-completion (Ubuntu)
   Status: New = In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1330173

Title:
  bash-completion of Makefile: invalid option name

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1330173/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1330173] Re: bash-completion of Makefile: invalid option name

[Aapo Rantalainen]

bash-completion:
  Installed: 1:2.1-4

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1330173

Title:
  bash-completion of Makefile: invalid option name

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1330173/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1330173] Re: bash-completion of Makefile: invalid option name

[Aapo Rantalainen]

I created new user and bug didn't triggered. Then I copied .bashrc and
bug triggered. With bisecting I found one row which destroys bash-
completion for make.

.bashrc
-alias grep='grep --color=always'
+alias grep='grep --color=auto'

--
And after that, proper patch wasn't difficult.

/usr/share/bash-completion/completions/make

--- make_orig  2014-06-24 14:54:46.256847066 +0300
+++ make2014-06-24 14:56:55.240851566 +0300
@@ -141,7 +141,7 @@
 mode=-d # display-only mode
 fi
 
-local reset=$( set +o | grep -F posix ); set +o posix # for (...)
+local reset=$( set +o | grep -F --color=never posix ); set +o posix # 
for (...)
 COMPREPLY=( $( LC_ALL=C \
 make -npq ${makef[@]} ${makef_dir[@]} .DEFAULT 2/dev/null | \
 sed -nrf (_make_target_extract_script $mode $cur) ) )



'grep grep /usr/share/bash-completion/completions/*' gives so many hits that it 
is possible that grep is aliased to 'grep --color=always'  is bad idea.


** Package changed: bash (Ubuntu) = bash-completion (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1330173

Title:
  bash-completion of Makefile: invalid option name

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/1330173/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs