[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
** Tags removed: targetmilestone-inin1510 ** Tags added: targetmilestone-inin1604 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
I recommend opening new bugs against libvirt and docker. Libvirt moves VMS into a cpuset by default. I assume docker does the same. (My xenial laptop runs upstart, so this is not systemd's doing) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
"LXC cases, like docker and KVM" - did you mean non-lxc cases? xenial by default should now be using libpam-cgfs, should not be using cgmanager, and should not be creating cpusets. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
** Changed in: cgmanager (Ubuntu) Status: Confirmed => Fix Released ** Changed in: systemd (Ubuntu) Status: Incomplete => Fix Released ** Changed in: linux (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cgmanager in Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
** Changed in: cgmanager (Ubuntu) Status: Confirmed => Fix Released ** Changed in: systemd (Ubuntu) Status: Incomplete => Fix Released ** Changed in: linux (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
No - this being moot does not apply to wily. Actually the xenial work has been delayed so it does not *yet* apply there either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
@Sqxm - thanks for that input. For what it's worth you should be able to use ppa:serge-hallyn/systemd in xenial to get cpusets not created by default. Unfortunately I need to make some more changes (in particular to use the systemd-created cgroups when they exist) before pushing this to the archive. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Serge, Does the issue being moot apply to wiley or 16.04? Thanks, Ali -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
FYI: My use case for hot plugging my x86 system like a drunken sailor is to evaluate the amount of CPUs required to complete a given task before I schedule it to run on other potentially CPU bound machines. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
> I'm still not convinced that we don't want to make the change only for > powerpc systemx - x86 systems AFAIK don't hotplug like drunken sailors. We do on amd64. We run Ubuntu as virtual machine guests and do allow hot-plugging CPUs. We do not have cgmanager installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Quoting Benjamin Drung (bdr...@posteo.de): > > I'm still not convinced that we don't want to make the change only for > > powerpc systemx - x86 systems AFAIK don't hotplug like drunken sailors. > > We do on amd64. We run Ubuntu as virtual machine guests and do allow > hot-plugging CPUs. We do not have cgmanager installed. The default pam_cgm config line only enables freezer, not cpusets, so I think this is now moot. (Well, will be in the next cycle when we switch from the systemd patch to using libpam-cgm) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
cgmanager (in git, not yet packaged) can now build a pam module which could be used in place of our systemd patch to move tasks into cgroups upon login. This would allow simple configuration of the cgroup controllers to be used. I'm waiting on feedback in private email about whether or not we want to go that route. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
** Tags removed: targetmilestone-inin--- ** Tags added: targetmilestone-inin1510 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Quoting Martin Pitt (martin.p...@ubuntu.com): Setting systemd task to incomplete for now. Please let me know how we want the cgroups set up for user sessions, and I'll change our patch accordingly. Thanks! I'll discuss this with Stéphane next week. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Quoting Martin Pitt (martin.p...@ubuntu.com): Serge Hallyn [2015-04-17 17:49 -]: Cpusets are not *required* for lxc. Perhaps we should in fact default to only providing name=systemd, devices and freezer cgroups for users? We'd want to very widely advertise how to enable other cgroups. Right, I mostly understood it so that we need to create all those controllers in the host that the container workload can *potentially* use all these cgroups as well, not that they are inherently required. Currently lxc would fail this way, but we could teach it to ignore inability to create cgroups which aren't required. (This isn't as simple as it seems, since using the keyword all for controllers would no longer work, but it's doable) all could still try to join all controllers, but ignore the ones it doesn't have permissions for? Maybe also (1) a new weak version of all which implements that behaviour, or (2) a new strong version which will fail if it cannot join any controller. TBH I don't know which way around would break backwards compat less: (1) requires changing all existing container configs on upgrade once we stop putting the user session into all controllers, and (2) might break existing container workloads which actually expect the dropped controllers. My gut feeling is that (2) is the better option. I agree. (the same will be needed for create) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Serge Hallyn [2015-04-17 17:49 -]: Cpusets are not *required* for lxc. Perhaps we should in fact default to only providing name=systemd, devices and freezer cgroups for users? We'd want to very widely advertise how to enable other cgroups. Right, I mostly understood it so that we need to create all those controllers in the host that the container workload can *potentially* use all these cgroups as well, not that they are inherently required. Currently lxc would fail this way, but we could teach it to ignore inability to create cgroups which aren't required. (This isn't as simple as it seems, since using the keyword all for controllers would no longer work, but it's doable) all could still try to join all controllers, but ignore the ones it doesn't have permissions for? Maybe also (1) a new weak version of all which implements that behaviour, or (2) a new strong version which will fail if it cannot join any controller. TBH I don't know which way around would break backwards compat less: (1) requires changing all existing container configs on upgrade once we stop putting the user session into all controllers, and (2) might break existing container workloads which actually expect the dropped controllers. My gut feeling is that (2) is the better option. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Setting systemd task to incomplete for now. Please let me know how we want the cgroups set up for user sessions, and I'll change our patch accordingly. Thanks! ** Changed in: systemd (Ubuntu) Status: New = Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Quoting Martin Pitt (martin.p...@ubuntu.com): Note that when i start up a vivid vm without cgmanager installed, cpuset is still mounted and login sessions get a cpuset cgroup: 2:cpuset:/user.slice/user-1000.slice/session-1.scope Note that this is by request of Stèphane, it's an ubuntu specific patch to make user LXC containers work under systemd. I didn't follow the discussion here in depth and I don't know much about the cgroup internals -- I just wanted to say let me know if the above is unintended and systemd should stop configuring the cpuset controller for user sessions (then user LXC would need to get some adjustments for that too, though) Cpusets are not *required* for lxc. Perhaps we should in fact default to only providing name=systemd, devices and freezer cgroups for users? We'd want to very widely advertise how to enable other cgroups. Currently lxc would fail this way, but we could teach it to ignore inability to create cgroups which aren't required. (This isn't as simple as it seems, since using the keyword all for controllers would no longer work, but it's doable) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Serge, This is the output of what you have request. root@ubuntu1504:/sys/fs/cgroup/cpuset# cat cpuset.cpus ; cat user.slice/cpuset.cpus 0-7 0-6 root@ubuntu1504:/sys/fs/cgroup/cpuset# cgm listcontrollers blkio cpu,cpuacct devices freezer hugetlb memory net_cls,net_prio perf_event name=systemd root@ubuntu1504:/sys/fs/cgroup/cpuset# ps aux | grep cgmanager root 28368 0.0 0.1 5120 4352 ?Ss Apr07 0:00 /sbin/cgmanager -m name=systemd -M cpuset root@ubuntu1504:/sys/fs/cgroup/cpuset# cat /proc/28368/mountinfo 55 88 0:36 / /run/cgmanager/fs rw,relatime - tmpfs cgmfs rw,size=128k,mode=755 73 87 0:4 / /proc rw,nosuid,nodev,noexec,relatime - proc proc rw 74 73 0:31 / /proc/sys/fs/binfmt_misc rw,relatime - autofs systemd-1 rw,fd=21,pgrp=1,timeout=300,minproto=5,maxproto=5,direct 76 55 0:23 / /run/cgmanager/fs/blkio rw,relatime - cgroup blkio rw,blkio 77 55 0:25 / /run/cgmanager/fs/cpu rw,relatime - cgroup cpu rw,cpu,cpuacct 78 55 0:25 / /run/cgmanager/fs/cpuacct rw,relatime - cgroup cpuacct rw,cpu,cpuacct 79 55 0:24 / /run/cgmanager/fs/devices rw,relatime - cgroup devices rw,devices 80 55 0:30 / /run/cgmanager/fs/freezer rw,relatime - cgroup freezer rw,freezer 81 55 0:29 / /run/cgmanager/fs/hugetlb rw,relatime - cgroup hugetlb rw,hugetlb,release_agent=/run/cgmanager/agents/cgm-release-agent.hugetlb 82 55 0:26 / /run/cgmanager/fs/memory rw,relatime - cgroup memory rw,memory 83 55 0:22 / /run/cgmanager/fs/net_cls rw,relatime - cgroup net_cls rw,net_cls,net_prio 84 55 0:22 / /run/cgmanager/fs/net_prio rw,relatime - cgroup net_prio rw,net_cls,net_prio 85 55 0:28 / /run/cgmanager/fs/perf_event rw,relatime - cgroup perf_event rw,perf_event,release_agent=/run/cgmanager/agents/cgm-release-agent.perf_event 86 55 0:20 / /run/cgmanager/fs/none,name=systemd rw,relatime - cgroup none,name=systemd rw,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd 87 45 253:2 / / rw,relatime - ext4 /dev/disk/by-uuid/1ce3e5ed-71cf-4682-91f5-261804741e81 rw,errors=remount-ro,data=ordered 88 87 0:16 / /run rw,nosuid,noexec,relatime - tmpfs tmpfs rw,size=403904k,mode=755 root@ubuntu1504:/sys/fs/cgroup/cpuset# cat /proc/self/mountinfo 16 21 0:15 / /sys rw,nosuid,nodev,noexec,relatime shared:7 - sysfs sysfs rw 17 21 0:4 / /proc rw,nosuid,nodev,noexec,relatime shared:12 - proc proc rw 18 21 0:6 / /dev rw,relatime shared:2 - devtmpfs udev rw,size=1972160k,nr_inodes=30815,mode=755 19 18 0:13 / /dev/pts rw,nosuid,noexec,relatime shared:3 - devpts devpts rw,gid=5,mode=620,ptmxmode=000 20 21 0:16 / /run rw,nosuid,noexec,relatime shared:5 - tmpfs tmpfs rw,size=403904k,mode=755 21 0 253:2 / / rw,relatime shared:1 - ext4 /dev/disk/by-uuid/1ce3e5ed-71cf-4682-91f5-261804741e81 rw,errors=remount-ro,data=ordered 22 16 0:11 / /sys/kernel/security rw,nosuid,nodev,noexec,relatime shared:8 - securityfs securityfs rw 23 18 0:17 / /dev/shm rw,nosuid,nodev shared:4 - tmpfs tmpfs rw 24 20 0:18 / /run/lock rw,nosuid,nodev,noexec,relatime shared:6 - tmpfs tmpfs rw,size=5120k 25 16 0:19 / /sys/fs/cgroup rw shared:9 - tmpfs tmpfs rw,mode=755 26 25 0:20 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime shared:10 - cgroup cgroup rw,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd 27 16 0:21 / /sys/fs/pstore rw,nosuid,nodev,noexec,relatime shared:11 - pstore pstore rw 28 25 0:22 / /sys/fs/cgroup/net_cls,net_prio rw,nosuid,nodev,noexec,relatime shared:13 - cgroup cgroup rw,net_cls,net_prio 29 25 0:23 / /sys/fs/cgroup/blkio rw,nosuid,nodev,noexec,relatime shared:14 - cgroup cgroup rw,blkio 30 25 0:24 / /sys/fs/cgroup/devices rw,nosuid,nodev,noexec,relatime shared:15 - cgroup cgroup rw,devices 31 25 0:25 / /sys/fs/cgroup/cpu,cpuacct rw,nosuid,nodev,noexec,relatime shared:16 - cgroup cgroup rw,cpu,cpuacct 32 25 0:26 / /sys/fs/cgroup/memory rw,nosuid,nodev,noexec,relatime shared:17 - cgroup cgroup rw,memory 33 25 0:27 / /sys/fs/cgroup/cpuset rw,nosuid,nodev,noexec,relatime shared:18 - cgroup cgroup rw,cpuset,clone_children 34 25 0:28 / /sys/fs/cgroup/perf_event rw,nosuid,nodev,noexec,relatime shared:19 - cgroup cgroup rw,perf_event,release_agent=/run/cgmanager/agents/cgm-release-agent.perf_event 35 25 0:29 / /sys/fs/cgroup/hugetlb rw,nosuid,nodev,noexec,relatime shared:20 - cgroup cgroup rw,hugetlb,release_agent=/run/cgmanager/agents/cgm-release-agent.hugetlb 36 25 0:30 / /sys/fs/cgroup/freezer rw,nosuid,nodev,noexec,relatime shared:21 - cgroup cgroup rw,freezer 37 17 0:31 / /proc/sys/fs/binfmt_misc rw,relatime shared:22 - autofs systemd-1 rw,fd=21,pgrp=1,timeout=300,minproto=5,maxproto=5,direct 38 16 0:7 / /sys/kernel/debug rw,relatime shared:23 - debugfs debugfs rw 39 18 0:14 / /dev/mqueue rw,relatime shared:24 - mqueue mqueue rw 40 16 0:32 / /sys/fs/fuse/connections rw,relatime shared:25 - fusectl fusectl rw 41 20 0:33 / /run/cgmanager/fs rw,relatime shared:26 - tmpfs cgmfs rw,size=128k,mode=755 42 41 0:35 / /run/cgmanager/fs rw,relatime shared:28 - tmpfs cgmfs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Yes Nish, take a look at the full example: root@ubuntu1504:/sys/fs/cgroup/cpuset# cat cpuset.cpus ; cat user.slice/cpuset.cpus 0-7 0-7 root@ubuntu1504:/sys/fs/cgroup/cpuset# echo 0 /sys/devices/system/cpu/cpu7/online root@ubuntu1504:/sys/fs/cgroup/cpuset# cat cpuset.cpus ; cat user.slice/cpuset.cpus 0-6 0-6 root@ubuntu1504:/sys/fs/cgroup/cpuset# echo 1 /sys/devices/system/cpu/cpu7/online root@ubuntu1504:/sys/fs/cgroup/cpuset# cat cpuset.cpus ; cat user.slice/cpuset.cpus 0-7 0-6 root@ubuntu1504:/sys/fs/cgroup/cpuset# ps aux | grep cgmanager root 5761 0.0 0.0 5120 3072 pts/1S+ 10:35 0:00 grep --color=auto cgmanager root 28368 0.0 0.0 4288 3392 ?Ss 10:31 0:00 /sbin/cgmanager -m name=systemd -M cpuset -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
(In particular I'm looking to confirm that cgmanager didn't mount cpuset) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
When doing that check, please show the results also of cgm listcontrollers sudo cat /proc/$(pidof cgmanager)/mountinfo cat /proc/self/mountinfo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Breno, Was your test done with a cgmanager with the -M flag passed? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Serge, That should only be true for unified hierarchy. In legacy hierarchy, effective_cpus follows cpus, I think? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
I understand that this problem is still not fixed yet. It should be reopened: # taskset -p $$ pid 2523's current affinity mask: ff # echo 0 /sys/devices/system/cpu/cpu7/online # taskset -p $$ pid 12787's current affinity mask: 7f # echo 1 /sys/devices/system/cpu/cpu7/online # cat /sys/devices/system/cpu/cpu7/online 1 # taskset -p $$ pid 12787's current affinity mask: 7f So, it seems that the mask doesn't get back to ff after the CPU is back online. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Hope had been that the kernel's new support for cpuset.effective_cpus would fix this. Removing a cpu from a parent cgroup or offlining a cpu would remove it from effective_cpus, but not from cpuset.cpus. Apparently that's not the case (kernel 3.19.0-10-generic was used for the test in comment #27) ** Also affects: linux (Ubuntu) Importance: Undecided Status: New ** Changed in: linux (Ubuntu) Importance: Undecided = Medium ** Changed in: linux (Ubuntu) Status: New = Confirmed ** Changed in: cgmanager (Ubuntu) Status: Fix Released = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cgmanager in Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Hope had been that the kernel's new support for cpuset.effective_cpus would fix this. Removing a cpu from a parent cgroup or offlining a cpu would remove it from effective_cpus, but not from cpuset.cpus. Apparently that's not the case (kernel 3.19.0-10-generic was used for the test in comment #27) ** Also affects: linux (Ubuntu) Importance: Undecided Status: New ** Changed in: linux (Ubuntu) Importance: Undecided = Medium ** Changed in: linux (Ubuntu) Status: New = Confirmed ** Changed in: cgmanager (Ubuntu) Status: Fix Released = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
@glaubits, cgmanager is not for managing but for delegating cgroups, which systemd does not yet provide. (I'd like to work toward that with the systemd community) When that is not needed then cgmanager can indeed be removed - however cpusets still end up being mounted by systemd itself. @bharata-rao My reading of kernel/cpusets.c comments is that the new cpuset.effective_cpus is supposed to give you what you want. If you've written 0-64 into cpuset.cpus, and some cpus are removed, then cpuset.cpus won't be changed, only cpuset.effective_cpus. When you plug those cpus back in, then they should show back up in cpuset.effective_cpus. I dont' have any hardware to test on, and couldn't get libvirt setvcpus to do this for me, but could you please test on a ubuntu 15.04 host (which should have a new enough kernel to have cpuset.effective_cpus)? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Looking into cgmager for Ubuntu vivid, Correct me if I'm wrong, but the sole reason why cgmanager was conceived was to have something to manage CGroups when systemd is not running. And, as Ubuntu 15.04 (vivid), is settling on systemd by default, you can just uninstall cgmanager as systemd does all the necessary CGroups management. Unless there is something I am overlooking here? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
It seems this fixed was reverted when cgmanager was upgraded to 0.36. Looking into cgmager for Ubuntu vivid, I don't see the patch 0001-implement-M-to-support-skip-mounting-certain-control.patch anymore, also, cgmanager is not being loaded with -M option, as showed: ubuntu@ubuntu1504:~/source/cgmanager-0.36$ ls debian/patches/ -la total 40 drwxrwxr-x 2 ubuntu ubuntu 4096 Mar 23 22:32 . drwxrwxr-x 5 ubuntu ubuntu 4096 Mar 31 09:42 .. -rw-rw-r-- 1 ubuntu ubuntu 1690 Feb 13 15:32 0001-pivot_root-bind-mount-the-old-rather-than-starting-w.patch -rw-rw-r-- 1 ubuntu ubuntu 1742 Feb 13 15:32 0002-bind-mount-run-from-host-into-cgmanager-s-fs-as-well.patch -rw-rw-r-- 1 ubuntu ubuntu 842 Mar 23 17:20 0004-prune_from_string-handle-a-corner-case.patch -rw-rw-r-- 1 ubuntu ubuntu 863 Mar 23 19:21 0005-Fix-the-last-commit.patch -rw-rw-r-- 1 ubuntu ubuntu 7286 Mar 23 22:29 0006-cgmanager-make-exception-for-proxys-placed-in-system.patch -rw-rw-r-- 1 ubuntu ubuntu 1196 Mar 10 12:20 fix-tests-on-systemd -rw-rw-r-- 1 ubuntu ubuntu 294 Mar 23 22:27 series After the package is installed, I see: $ ps aux | grep cgmanager root 2347 0.0 0.0 4288 3392 ?Ss 09:39 0:00 /sbin/cgmanager -m name=systemd So, I understand that this bug should be reopened -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Quoting Bharata B Rao (1392...@bugs.launchpad.net): Serge, What's the recommended way to start cgmanager with -M cpuset ? I added When running systemd you must edit the file /lib/systemd/system/cgmanager.service so that the ExecStart line reads ExecStart=/sbin/cgmanager -m name=systemd -M cpuset After making that change you may need to do sudo systemctl daemon-reload and then you may need to sudo mount -o remount,rw /sys/fs/cgroup to allow cgmanager to create a new socket for itself. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Quoting Breno Leitão (1392...@bugs.launchpad.net): It seems this fixed was reverted when cgmanager was upgraded to 0.36. No, I've verified that this still works in 15.04. The patch implement -M to support skip mounting certain controllers is a part of the 0.36 release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Any update on comment #19 ? Also any plans to get CPU hotplug work seamlessly ? I see that CPU hotplug is affected by this bug, haven't been able to use -M cpuset option to verify if that helps CPU hotplug case too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Serge, What's the recommended way to start cgmanager with -M cpuset ? I added cgmanager_opts=-M cpuset in /etc/default/cgmanager but it still starts w/o -M option. root@ubuntu1504:~# ps aux | grep cgm root 624 0.0 0.1 4096 3264 ?Ss 04:58 0:00 /sbin/cgmanager -m name=systemd root@ubuntu1504:~# cat /etc/default/cgmanager cgmanager_opts=-M cpuset I stopped the service myself and start it manually root@ubuntu1504:~# service cgmanager stop root@ubuntu1504:~# /sbin/cgmanager -m name=systemd -M cpuset root@ubuntu1504:~# ps aux | grep cgm root 863 0.0 0.1 4096 3328 pts/0S05:00 0:00 /sbin/cgmanager -m name=systemd -M cpuset Now if I offline and online a CPU and try to tasket a process to that CPU, it fails. Expected ? root@ubuntu1504:~# cgmanager --version cgmanager 0.36 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Can you explain what the patch does ? This will help us figure out why its not working. The pach is: implement -M to support skip mounting certain controllers So you need to start cgmanager with -M cpuset to get the behavior you are looking for. The changelog entry said: This doesn't change the default, so may not suffice for powerpc, but at least offers a workaround. (LP: #1392176) So it is a starting point and gives you a workaround. It seesm to me that this is something that should be configurable in the kernel. It also seems worthwhile for cgmanager to watch for cpu hotplug events and do something when it gets those. But exactly what it should do and how this is best implemented is not clear to me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
The patch does not work for us. We tried out the below test: root@ubuntu1504:~# cat /etc/issue Ubuntu Vivid Vervet (development branch) \n \l root@ubuntu1504:~# cgmanager --version cgmanager 0.36 root@ubuntu1504:~# uname -a Linux ubuntu1504 3.18.0-13-generic #14-Ubuntu SMP Fri Feb 6 09:57:41 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux root@ubuntu1504:~# root@ubuntu1504:/sys/devices/system/cpu# ps aux | grep bash root 955 0.2 0.3 8576 7104 hvc0 S01:52 0:00 -bash root 1001 0.0 0.1 4992 3072 hvc0 S+ 01:53 0:00 grep --color=auto bash root@ubuntu1504:/sys/devices/system/cpu# taskset -p 955 pid 955's current affinity mask: root@ubuntu1504:/sys/devices/system/cpu# echo 0 cpu15/online root@ubuntu1504:/sys/devices/system/cpu# taskset -p 955 pid 955's current affinity mask: 7fff root@ubuntu1504:/sys/devices/system/cpu# echo 1 cpu15/online root@ubuntu1504:/sys/devices/system/cpu# taskset -p 955 pid 955's current affinity mask: 7fff You can see that the cpumask of the task does not have the cpu that we got back online and we are using the version of cgmanager that has the fix in. Can you explain what the patch does ? This will help us figure out why its not working. On another note, to make things clearer, there are two requirements to take care of: a. When a cpu goes offline and comes back online, the cpuset of tasks must get updated both times to reflect the online mask b. When a cpu in the possible_mask is brought online anytime after bootup, that too should get updated in the cpuset of the tasks. Regards Preeti U Murthy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
This bug was fixed in the package cgmanager - 0.35-1ubuntu1 --- cgmanager (0.35-1ubuntu1) vivid; urgency=medium * 0001-implement-M-to-support-skip-mounting-certain-control.patch: This doesn't change the default, so may not suffice for powerpc, but at least offers a workaround. (LP: #1392176) -- Serge Hallyn serge.hal...@ubuntu.com Tue, 10 Feb 2015 13:57:03 -0600 ** Changed in: cgmanager (Ubuntu) Status: Triaged = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cgmanager in Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
This bug was fixed in the package cgmanager - 0.35-1ubuntu1 --- cgmanager (0.35-1ubuntu1) vivid; urgency=medium * 0001-implement-M-to-support-skip-mounting-certain-control.patch: This doesn't change the default, so may not suffice for powerpc, but at least offers a workaround. (LP: #1392176) -- Serge Hallyn serge.hal...@ubuntu.com Tue, 10 Feb 2015 13:57:03 -0600 ** Changed in: cgmanager (Ubuntu) Status: Triaged = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Yes, for those tasks which had the offlined cpu in their cpusets before hotplug, the cpu should be added back to their respective cpusets when it comes online. Regards Preeti U Murthy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
** Branch linked: lp:ubuntu/vivid-proposed/cgmanager -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
It seems that what you really want is for, when a cpu is on-lined, for all or some tasks to have that cpu automatically added to their cpuset? Would that suffice? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
The movement of existing tasks to the child cgroups created by cgmanager/systemd must be avoided as far as I can see. If the additional cgroups are for LXC containers, the containers and the tasks spawned within them alone can reside under the children cgroups. Why move the existing tasks into them, when they are not going to benefit from it ? If this can be done there would be no need to avoid having to mount cpuset controllers; they can very well be there. Regards Preeti U Murthy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Hold on, the actual mounting of the fs is not the problem, right? It's the movement of tasks into groups on login? So this should perhaps be fixed in systemd-shim instead? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
@preeti, if it suffices for you to just not run cgmanager at all, then you can just disable it by doing echo manual | sudo tee /etc/init/cgmanager.override Is it specifically only the cpuset cgroup which you do not want mounted on your systems? We could add a '-M' option to cgmanager so that -M cpuset would mean do not mount the cpuset controller. I would not however want that set by default, so the question is where would be the best place to specify it? It sounds like you would nee dit set for all powerpc platforms, or is this only on a specific cloud you control? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Serge Hallyn [2015-02-03 17:01 -]: Hold on, the actual mounting of the fs is not the problem, right? It's the movement of tasks into groups on login? So this should perhaps be fixed in systemd-shim instead? Note that upstream systemd does not touch any cgroups other than systemd. We specifically do that in Ubuntu (with both cgmanager and systemd itself) to support user LXC containers, which will fail if they can't put the containers into all controllers. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
Hi, Is there any update on this front? We are seeing the effect of this bug in several places on IBM PowerPC platforms and would like to see it resolved soon. Can the cgroup mounting be made *only* when the user explicitly asks for it? Regards Preeti U Murthy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
systemd (in the sense of pid 1) doesn't do that. I. e. if you boot with init=/bin/systemd the only cgroup controller it puts tasks into (by default) is the systemd one, for that very reason. But if you boot with upstart (Ubuntu's default still), cgmanager creates cgroups. cgmanager puts tasks into *all* controllers (including cpu); as far as I know, this is so that user LXC containers work. So from cgmanager's POV this might be a design decision which can't otherwise be accomplished with the current kernel, but I'll let the cgmanager maintainers decide about whether this is a wontfix or whether there is a more elegant way to make user containers work. ** Summary changed: - Systemd mounts cgroups unconditionally which causes undesired effects with cpu hotplug + mounts cgroups unconditionally which causes undesired effects with cpu hotplug ** Package changed: systemd (Ubuntu) = cgmanager (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cgmanager in Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
systemd (in the sense of pid 1) doesn't do that. I. e. if you boot with init=/bin/systemd the only cgroup controller it puts tasks into (by default) is the systemd one, for that very reason. But if you boot with upstart (Ubuntu's default still), cgmanager creates cgroups. cgmanager puts tasks into *all* controllers (including cpu); as far as I know, this is so that user LXC containers work. So from cgmanager's POV this might be a design decision which can't otherwise be accomplished with the current kernel, but I'll let the cgmanager maintainers decide about whether this is a wontfix or whether there is a more elegant way to make user containers work. ** Summary changed: - Systemd mounts cgroups unconditionally which causes undesired effects with cpu hotplug + mounts cgroups unconditionally which causes undesired effects with cpu hotplug ** Package changed: systemd (Ubuntu) = cgmanager (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1392176] Re: mounts cgroups unconditionally which causes undesired effects with cpu hotplug
I'm definately open to making this more flexible. The queestion is how best to allow the configuration. We could add a /etc/cgmanager.conf, or we could do it through command line options specified in /etc/default/cgmanager ** Changed in: cgmanager (Ubuntu) Status: New = Triaged ** Changed in: cgmanager (Ubuntu) Importance: Undecided = Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1392176 Title: mounts cgroups unconditionally which causes undesired effects with cpu hotplug To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cgmanager/+bug/1392176/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
