[Bug 1396070] Comment bridged from LTC Bugzilla
--- Comment From vsand...@in.ibm.com 2016-02-11 01:04 EDT--- Closing this bug as the fix has been released. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1396070 Title: Libvirt patches for launching VMs with 'ppc64le' architecture. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1396070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1396070] Comment bridged from LTC Bugzilla
--- Comment From saxena.pre...@in.ibm.com 2015-02-08 11:54 EDT---
(In reply to comment #24)
Hm, seems like that might make this not work on ppc64le. Could someone
with the hardware please test and confirm?
Quoting Stefan Bader (stefan.ba...@canonical.com):
Now too late but I had noticed that the provided patch #3 missed two
changes from the upstream patch. Not sure how important those would be:
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1b8efb1..21309b0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -10043,7 +10043,7 @@ virDomainVideoDefaultType(const virDomainDef *def)
(STREQ(def-os.type, xen) ||
STREQ(def-os.type, linux)))
return VIR_DOMAIN_VIDEO_TYPE_XEN;
-else if (def-os.arch == VIR_ARCH_PPC64)
+else if ARCH_IS_PPC64(def-os.arch)
return VIR_DOMAIN_VIDEO_TYPE_VGA;
else
return VIR_DOMAIN_VIDEO_TYPE_CIRRUS;
diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c
index 67cb9ff..d591c18 100644
--- a/src/cpu/cpu_powerpc.c
+++ b/src/cpu/cpu_powerpc.c
@@ -38,7 +38,7 @@
VIR_LOG_INIT(cpu.cpu_powerpc);
-static const virArch archs[] = { VIR_ARCH_PPC64 };
+static const virArch archs[] = { VIR_ARCH_PPC64, VIR_ARCH_PPC64LE };
struct ppc_vendor {
char *name;
Yes, these two changes are indeed essential. I verified that:
1) These have not been included in the libvirt package shipped with ubuntu
15.04.
2) These are essential to launching guest VMs on ppc64 little endian arch.
In fact, I had uploaded a modified patch too at the time, but it seems that got
missed.
Can these changes be included now ?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1396070
Title:
Libvirt patches for launching VMs with 'ppc64le' architecture.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1396070/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1396070] Comment bridged from LTC Bugzilla
--- Comment From saxena.pre...@in.ibm.com 2014-11-28 10:16 EDT--- I have obsoleted the previous patch for adding LE arch support to libvirt CPU driver (0003-Cpu-Add-support-for-Power-LE-Architecture.patch) In its place, I have uploaded a fresh version of the patch that includes all changes from upstream. I have also added another trivial upstream patch that is required for my updated patch to apply. The series file for libvirt patches now looks like this: 0001-qemu_command-Split-qemuBuildCpuArgStr.patch 0002-qemu-Don-t-compare-CPU-against-host-for-TCG.patch 0003-maint-use-consistent-if-else-braces-in-qemu.patch [Newly added, for 0004 to apply cleanly] 0004-CPU-Add-support-for-Power-LE-Architecture.patch [Updated patch for LE support] 0005-PowerPC-Add-support-for-launching-VM-in-compat-mode.patch 0006-PowerPC-Improve-PVR-handling-to-fall-back-to-cpu-gen.patch 0007-docs-Add-documentation-for-compat-mode.patch 0008-Test-Add-a-testcase-for-PowerPC-compat-mode-cpu-spec.patch All other patches are unchanged. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1396070 Title: Libvirt patches for launching VMs with 'ppc64le' architecture. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1396070/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1396070] Comment bridged from LTC Bugzilla
--- Comment From saxena.pre...@in.ibm.com 2014-11-28 05:29 EDT---
(In reply to comment #14)
Now too late but I had noticed that the provided patch #3 missed two changes
from the upstream patch. Not sure how important those would be:
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1b8efb1..21309b0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -10043,7 +10043,7 @@ virDomainVideoDefaultType(const virDomainDef *def)
(STREQ(def-os.type, xen) ||
STREQ(def-os.type, linux)))
return VIR_DOMAIN_VIDEO_TYPE_XEN;
-else if (def-os.arch == VIR_ARCH_PPC64)
+else if ARCH_IS_PPC64(def-os.arch)
return VIR_DOMAIN_VIDEO_TYPE_VGA;
else
return VIR_DOMAIN_VIDEO_TYPE_CIRRUS;
diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c
index 67cb9ff..d591c18 100644
--- a/src/cpu/cpu_powerpc.c
+++ b/src/cpu/cpu_powerpc.c
@@ -38,7 +38,7 @@
VIR_LOG_INIT(cpu.cpu_powerpc);
-static const virArch archs[] = { VIR_ARCH_PPC64 };
+static const virArch archs[] = { VIR_ARCH_PPC64, VIR_ARCH_PPC64LE };
struct ppc_vendor {
char *name;
This bug was fixed in the package libvirt - 1.2.8-0ubuntu16
---
libvirt (1.2.8-0ubuntu16) vivid; urgency=medium
* debian/patches/add-ppc64le-support.patch: Added patches needed
for ppc64le support. (LP: #1396070)
-- Chuck Short zul...@ubuntu.com Thu, 27 Nov 2014 08:57:35 -0500
Yes, these are needed. Wonder how this didnt get flagged in the build test.
In fact the upstream tree 1.2.10+ has these patches in. Is there a chance the
upcoming 1.2.11 release could be packaged for Ubuntu ?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1396070
Title:
Libvirt patches for launching VMs with 'ppc64le' architecture.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1396070/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
