[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Attachment removed: "The qml file to test"
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+attachment/4318108/+files/main.qml
** Description changed:
The width of an Icon {} depends if the Icon is an SVG coming from
image://theme/ or a JPG.
For the SVG the width grows as the units.gu grow, but for the JPEG it
does not and one has to manually add code to maitain the aspect ratio.
See the attached code and files.
-
- **
-
- Trying to explain the bug a bit better.
-
- The problem is basically that the first image looks "correct" at any
- GRID_UNIT_PX value while the second does not, you need to add extra code
- (i.e. the third) for it to look correct. See in
- http://i.imgur.com/EBb8PEU.png how the first and third images always
- keep the aspect ratio nice while the second gets distorted as we
- increase the GRID_UNIT_PX value
** Attachment added: "QML file to try"
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+attachment/4812571/+files/main.qml
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1421293
Title:
Icon width is inconsistent when height is specified
To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1421293/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Changed in: canonical-devices-system-image Milestone: 12 => backlog ** Changed in: canonical-devices-system-image Assignee: (unassigned) => Zoltan Balogh (bzoltan) ** Changed in: ubuntu-ui-toolkit (Ubuntu) Assignee: (unassigned) => Zsombor Egri (zsombi) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Also affects: canonical-devices-system-image Importance: Undecided Status: New ** Changed in: canonical-devices-system-image Status: New => Fix Committed ** Changed in: canonical-devices-system-image Importance: Undecided => Low ** Changed in: canonical-devices-system-image Milestone: None => 12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Description changed:
The width of an Icon {} depends if the Icon is an SVG coming from
image://theme/ or a JPG.
For the SVG the width grows as the units.gu grow, but for the JPEG it
does not and one has to manually add code to maitain the aspect ratio.
See the attached code and files.
+
+ **
+
+ Trying to explain the bug a bit better.
+
+ The problem is basically that the first image looks "correct" at any
+ GRID_UNIT_PX value while the second does not, you need to add extra code
+ (i.e. the third) for it to look correct. See in
+ http://i.imgur.com/EBb8PEU.png how the first and third images always
+ keep the aspect ratio nice while the second gets distorted as we
+ increase the GRID_UNIT_PX value
** Changed in: ubuntu-ui-toolkit (Ubuntu)
Status: Fix Released => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1421293
Title:
Icon width is inconsistent when height is specified
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Triaged => Fix Committed ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Branch linked: lp:~lukas-kde/ubuntu-ui-toolkit/staging-fix-icon-svg- image-loading -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Branch linked: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk-fix-icon- svg-image-loading -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
Ahm, Albert, I have worst news for you: design said we have to set the implicit width/height to 2grid units... so you will have to do more calculations if we apply that :( Perhaps we expose the image size so you can decide whether you want to bind to that or not. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Changed in: ubuntu-ui-toolkit (Ubuntu) Importance: Undecided = Low ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
No, I haven't just run the file with different pixel per grid unit and see how the error is still there. ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Incomplete = New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
Albert, haven't you provided recently a fix for this? ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New = Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Attachment added: A screenshot depicting the issue at 25 and 50 pixels per grid unit https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+attachment/4318110/+files/icon.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Attachment added: The logo file for the test https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+attachment/4318109/+files/logo.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1421293] Re: Icon width is inconsistent when height is specified
** Attachment added: The qml file to test https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+attachment/4318108/+files/main.qml -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1421293 Title: Icon width is inconsistent when height is specified To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1421293/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
