[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
Fixed in 1.11.2-0ubuntu6 ** Changed in: docker.io (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
Yeah, I agree and want to get there, but I figured just dropping it straight away would be doing our users a disservice (especially since it might not be obvious right away that it's not being used anymore). For example, if a user has "--bip=..." set in DOCKER_OPTS in that file, then dropping the sourcing of it outright wouldn't cause the service to fail to start or anything, and it actually wouldn't change anything for the running system until the next reboot (at which time, Docker would revert back to choosing its own IP range, which will be a nasty surprise for said operator). :( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
Makes sense to me, although I *think* I'd be just as happy with the "just don't source that file" approach ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
https://anonscm.debian.org/cgit/docker/docker.io.git/commit/?id=0bc5ad426c84804c939804e33247140ff2636991 is the compromise I've applied in Debian recently (replacing the file's contents with a long-form note pointing our users to the upstream- recommended alternatives, which should invoke dpkg's configuration file merge and also not break existing users right away). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
Yeah, I think that makes sense. We want to deliver an "upstream" experience with docker, not a Debian/Ubuntu-ized one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
IMO we should just remove the patch we add that makes it apply; systemd drop in files are the way systemd upstream recommends configuring startup parameters like this, which is why upstream doesn't include the EnvironmentFile directive that we've patched in. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
I also like the way /etc/default/docker says that the file does not apply to systemd, except in fact it does, kinda. For the export/sysvinit problem, one approach would be to put set -a / set +a around the sourcing of /etc/default/docker? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
Hi Guido Serra, Which version of docker did you install ? The one from ubuntu wily archive? I just installed docker.io from archive on a wily vm, and I got this systemd unit: docker.io 1.6.2~dfsg1-1ubuntu3amd64 Linux container runtime [Unit] Description=Docker Application Container Engine Documentation=http://docs.docker.com After=network.target docker.socket Requires=docker.socket [Service] EnvironmentFile=-/etc/default/docker ExecStart=/usr/bin/docker -d -H fd:// $DOCKER_OPTS MountFlags=slave LimitNOFILE=1048576 LimitNPROC=1048576 LimitCORE=infinity [Install] WantedBy=multi-user.target -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
not only... the variables that are in /etc/default/systemd are not being used by the docker.system file I had to add the EnvironmentFile key (after having seen this thread/bug report) and also the $DOCKER_OPTS in the ExecStart value [originally it is NOT there] [Unit] Description=Docker Application Container Engine Documentation=https://docs.docker.com After=network.target docker.socket Requires=docker.socket [Service] Type=notify EnvironmentFile=-/etc/default/docker ExecStart=/usr/bin/docker daemon $DOCKER_OPTS -H fd:// MountFlags=slave LimitNOFILE=1048576 LimitNPROC=1048576 LimitCORE=infinity [Install] WantedBy=multi-user.target -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
** Also affects: hundredpapercuts Importance: Undecided Status: New ** Changed in: docker.io (Ubuntu) Importance: Undecided => Low ** Changed in: hundredpapercuts Importance: Undecided => Low ** Changed in: hundredpapercuts Status: New => Triaged ** Changed in: docker.io (Ubuntu) Importance: Low => Medium ** Changed in: hundredpapercuts Importance: Low => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1469204] Re: /etc/default/docker format is wrong for systemd service
Yeah this is valid - I've hit it myself. Should be sent to Debian for appropriate resolution regardless of init system in use. ** Changed in: docker.io (Ubuntu) Status: New => Triaged ** Tags added: needs-upstream-report -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1469204 Title: /etc/default/docker format is wrong for systemd service To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1469204/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
