[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** No longer affects: haproxy (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Tags removed: haproxy ** Tags added: trusty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Changed in: trusty-backports Assignee: Louis Bouchard (louis-bouchard) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** No longer affects: haproxy (Ubuntu Trusty) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Vincent Bernat (vbernat) is the Debian maintainer for haproxy. His PPA assumes a version of dpkg that is newer than 1.17.7. I'll try to open a Debian bug on that. The problem lies in the use of start-stop-daemon's new --pid option that is only available after wily. If 1.6 is backported to any version earlier than wily, this bug will exist and the fix for it will need to be applied. I just got the fix for 1.4 uploaded so I should be able to fix the 1.5 backport in the near future. ..Louis -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Ha, sorry about that - I crossed the wires in my head a bit. (ppa:vbernat/haproxy-1.6, for what it's worth.) Anyway, should this work for 1.6? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Greg, 1.6.2 is not packaged for Trusty. I don't know where it comes from. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Just to throw in on this, I'm running 1.6.2 on 14.04.3 and it's not working here either. Specifically I see it running /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid, but /var/run/haproxy.pid doesn't exist. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Changed in: haproxy (Ubuntu) Importance: Undecided => Medium ** Changed in: haproxy (Ubuntu Trusty) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Chase them with beer. Works faster ^^ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Claudio, it is only partly fixed by Jorge's patch. I have proposed the same fix than for this bug in LP: #1481737. Unfortunately, not being a core dev, it needs to be sponsored to be accepted. Then I can backport the fix here in 1.5 Sorry for the delay, I'll chase a sponsor. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
By the way... this bug was also backported into the official trusty version of HAProxy (1.4).. Jeez! In the meantime its fixed again. haproxy (1.4.24-2ubuntu0.2) trusty; urgency=high * debian/haproxy.init: + Pass the pidfile to the --pidfile argument instead of the PID number. (LP: #1477198). -- Jorge Niedbalski Wed, 22 Jul 2015 11:12:26 -0500 haproxy (1.4.24-2ubuntu0.1) trusty; urgency=medium * debian/haproxy.init: + Backport of utopic start/stop routines, uses start-stop-daemon to reliable terminate all haproxy processes and return the proper exit code. (LP: #1462495). + Backport of utopic check_haproxy_config routine, that test the configuration before start or reload. (LP: #1468879) -- Jorge Niedbalski Thu, 25 Jun 2015 12:51:05 -0700 That's just as an additional note. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
FYI, I will rebase the debdiff on the new version currently in backport & repost. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Good catch Claudio. The bug is present in Trusty and Trusty-backports. Prior to LP: #1477198, the stop script did not stop at all because it relied on the --pid option that is introduced in dpkg version 1.17.6 as outlined in the man page of start-stop-daemon : [--pid] pid Check for a process with the specified pid (since version 1.17.6). The pid must be a number greater than 0. Now with the fix introduced by LP: #1477198, it will work as expected unless nproc > 1. Otherwise, we will see the behavior described in LP: #1481737 whereas processes other than the first PID appearing in the pidfile will remain active. The patch included here solves both situation as it loops through all the PIDs in the pidfile & terminates them using a temporary pidfile. I will carry on this explanation in the other bug so the version in -updates is fixed as well. This bug remains valid as we still see only the first PID being killed with the recent patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
The "new bug" for trusty concerning if nproc > 1 is probably this one: https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1481737 ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Hello, Unfortunately Jorge's patch is incomplete. The reason for the looping on pid is that, if nproc > 1, the pidfile will contain more than one PID and using --pidfile will only kill the first one. The proposed patch here will fix both situation, i.e. the fact that --pid is silently ignored and that if nproc > 1, all processes will be killed. I think we need to create new bug for Trusty as, if nproc > 1, only the first PID will be killed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Oh, I didn't realize that my previous backport upload was already accepted. This still needs a patch. I think we should just apply http://launchpadlibrarian.net/213125772/haproxy_1.4.24-2ubuntu0.1_1.4.24-2ubuntu0.2.diff.gz to backports, could you please test this? I've upload a test package to my PPA ppa:micahg/ppa -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Micah, got the bug number ? Maybe we should make this one a duplicate then ? ..Louis -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
There's another haproxy backport request that should fix this (from utopic version). It was missing the testing of one of the reverse dependencies. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Patch removed: "lp1494141_fix_stop_failure.debdiff" https://bugs.launchpad.net/trusty-backports/+bug/1494141/+attachment/4466700/+files/lp1494141_fix_stop_failure.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Louis, I can't sponsor your debdiff into backports, but be careful of ordering issues in your patch. clean() should be defined before the trap is set, and tmp should be defined before any point that clean() could be called. In general you should quote "$tmp" as well in case it ends up with spaces (eg. if $TMPDIR has a space in it). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Bonjour Claudio, No, I have just submitted the fix for inclusion in the backported package. Once the backport team has taken care of it, it will be indicated as such in the bug. Kind regards, ..Louis -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Patch for the fix to the backport package ** Patch added: "lp1494141_fix_stop_failure.debdiff" https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1494141/+attachment/4466700/+files/lp1494141_fix_stop_failure.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Salut Louis, Thanks for taking care of this bug. Have I understood correctly that the haproxy package in trusty-backports is already updated? Or do I have to wait until the package is released to all mirrors? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Marking task Trusty as invalid, since haproxy 1.4 uses --pidfile and is unaffected. Marking task Wily as fix released as the --pid option is available in Wily so haproxy 1.5 is unaffected ** Also affects: haproxy (Ubuntu) Importance: Undecided Status: New ** Also affects: haproxy (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: haproxy (Ubuntu) Status: New => Fix Released ** Changed in: haproxy (Ubuntu Trusty) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Package changed: haproxy (Ubuntu) => trusty-backports -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/trusty-backports/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
Hi, haproxy 1.5.4 introduces the following change : ret=0 - start-stop-daemon --quiet --oknodo --stop \ - --retry 5 --pidfile $PIDFILE --exec $HAPROXY || ret=$? + for pid in $(cat $PIDFILE); do + start-stop-daemon --quiet --oknodo --stop \ + --retry 5 --pid $pid --exec $HAPROXY || ret=$? + done start-stop-daemon --pidfile is replaced by --pid but this option is only available in dpkg 1.17.6 and onward : $ man start-stop-daemon (on Wily) : [--pid] pid Check for a process with the specified pid (since version 1.17.6). The pid must be a number greater than 0. This is not available on trusty, which explains why the process does not stop. I must admit that silently ignoring a false option is not an appropriate behavior though The reason for that change is that, if nbproc > 1 in the haproxy config file, all the PIDs will be in one single /var/run/haproxy.pid file so in order to kill each process, we must loop through the pid list. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Changed in: haproxy (Ubuntu) Status: New => In Progress ** Changed in: haproxy (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1494141] Re: HAProxy 1.5 init script does not terminate processes
** Changed in: haproxy (Ubuntu) Assignee: (unassigned) => Louis Bouchard (louis-bouchard) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1494141 Title: HAProxy 1.5 init script does not terminate processes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1494141/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
